From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F616C4345F for ; Sun, 5 May 2024 07:02:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3C3F6B0088; Sun, 5 May 2024 03:02:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC52C6B0089; Sun, 5 May 2024 03:02:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B65206B008A; Sun, 5 May 2024 03:02:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 955EF6B0088 for ; Sun, 5 May 2024 03:02:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DB861205EC for ; Sun, 5 May 2024 07:02:51 +0000 (UTC) X-FDA: 82083449742.24.0AC8335 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf27.hostedemail.com (Postfix) with ESMTP id 8CB614000D for ; Sun, 5 May 2024 07:02:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714892569; a=rsa-sha256; cv=none; b=XioqdUzrBgQfxIDeNMQKiN3H83xUJMGCB8RaHP2tEpILM8Z3CDVkizs8XcjWsIfVWgKFSS 6FeGnMlBea6wUa5x95ZyEp4q8QMebyLPsVzodh5jcs8I6Rdpj1pxcgvy2VH9IUaglUabl5 dLCG4beCmexAGIyl4Zy/NV0zP1jbefQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714892569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oxglxnDvF5cg1rIl1SHo5u5eJtzefz/AsaUsbLfmQG4=; b=Tz0ULZogcw3RiR1Gkt+SFsqhRL91Lw6rxWXSqVlzJ8WVhvlzsnh3vH69XGNrFnMl52CPKe v9uZeIX5WcpivwT1zA4pQO0SD59YlL8Oc4FXsmDFo5edlFK6It66Bx06Z2d5lzcvuIZPxi BHp+53Xh7PhSTG+7BV6/w5wx0a/7acs= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4VXFlN49lPz1RBvN; Sun, 5 May 2024 14:59:28 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 453F4140384; Sun, 5 May 2024 15:02:44 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 5 May 2024 15:02:43 +0800 Subject: Re: [PATCH 2/3] mm/madvise: Add MF_ACTION_REQUIRED to madvise(MADV_HWPOISON) To: Jane Chu , , , , References: <20240501232458.3919593-1-jane.chu@oracle.com> <20240501232458.3919593-3-jane.chu@oracle.com> From: Miaohe Lin Message-ID: <0c7dbf7d-dcb6-f9f2-4a2a-9700ea465a47@huawei.com> Date: Sun, 5 May 2024 15:02:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240501232458.3919593-3-jane.chu@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: jj8gsf8ns4j9atp9wgbnsweadbucf14t X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8CB614000D X-HE-Tag: 1714892568-654229 X-HE-Meta: U2FsdGVkX19rSQbeLrQ56Rw1JvQ6LWUjBzxmJ0SZI6xWdTpBaK9f+t9xXSM9aE1aZ7UF3c3e2KVmqWpV3yDDAzUZ+qKOP9jsaG5tTfE09PTTs7QDRSxj7NgN7U006BasXTPhFmHoh4qAu1k7u2VcuWsrtGd5eDFX2kMlMgkxkBSV2a1iuOuoBO8rb1VRe9ubU4vV8Ty5d8VhPNvesJkp8URTdQc4bPgWGQ3o2lHVFno0gPEhAjLSI6CpXras/JzBkQf7+C9dlKqcD+Zn4elTKDw5Pj2NmbdyrQlwWCRyHeGLlARX4SG0Pn+w8IhH4lCws/rIsmLxKDQ21o0tXl0ei7kedZco2RaSIndCUcC2rKmpLq10q48d0W936F2zkwM/klpOodOJyOXb4EQr33pLoO/20eWF/lQbh0PuIrMXYrbtBKpHqB6WwAHw9gq1xk3Kn4uOreP9Eb3dqPRlyLJDFPOOaSO43vcu51KsOx1fkiVv+zN8+qSGM59IB6OdvHgrk7APxXfMPMxhCaL4o7bf3npbgVGrwiVKRqQ0O2214mYYXJCNPECPf6KdVnchLgOG1XWRBoogfjYZsYRCYHCQH47praEKTqdjflgOFZ0b8eBGcQdqewLm/jArvc8Td9lByKbzEtehsPxrx3IlxH/opRg63YDPlJwFU1R3uTDJlnmyLjB1Ue9W5Z5KwuLMqpo3+rNI8H2wJ91Zy6EUihiIOovUtkQ3WPMc92HdiMZEgi0wjyMpg7hD6yjinikpIPdNdl+9pObUUT+vNwX8GBDhj7YxDkFxxG+XgeR4hH5b6fkbrI6PGTx8dKgRiIlaZhfoMeKNn9EgC8RDogVOuU7K7uA6gL99jeDO+v6cFH+1n2RuxrJGeX+HGYwBlYbqhlqT9VuDNf4TY8y08iOepgaEnt3Tp9yrOacvPEn5KtSHvYLJqGBG8lJqKc+YAk0kkz7i10u304csMXMzg7fCzm4 y/HX4Dox 2V4QdSRmy6euxLmomvvxSXYgXBC6buMUMjN/6O7aIlLiAPC9b8L/3N2rMB2GchfYceWbuSNH9gHG6JjGLBEeXv8fWw+MkQJM6zeENRh4yaVXNWMriM86LW/mzkbhB2lKQ402qpoQawlPBhTDhPfr8IVPH8/ygK5xYiVHQKO1J7LbC3EHZjCYPQDjADbHZetqjLbGQxkwWQNY/xikmcVP5QywNxG22z12mIYeWBHCwlXfS/1kiJo7vNCM8OQJh1hlFXrNPh6CoPcBQUWE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/2 7:24, Jane Chu wrote: > The soft hwpoison injector via madvise(MADV_HWPOISON) operates in > a synchrous way in a sense, the injector is also a process under > test, and should it have the poisoned page mapped in its address > space, it should legitimately get killed as much as in a real UE > situation. Will it be better to add a method to set MF_ACTION_REQUIRED explicitly when inject soft hwpoison? Thanks. . > > Signed-off-by: Jane Chu > --- > mm/madvise.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 1a073fcc4c0c..eaeae5252c02 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1127,7 +1127,7 @@ static int madvise_inject_error(int behavior, > } else { > pr_info("Injecting memory failure for pfn %#lx at process virtual address %#lx\n", > pfn, start); > - ret = memory_failure(pfn, MF_COUNT_INCREASED | MF_SW_SIMULATED); > + ret = memory_failure(pfn, MF_ACTION_REQUIRED | MF_COUNT_INCREASED | MF_SW_SIMULATED); > if (ret == -EOPNOTSUPP) > ret = 0; > } >