From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCB0C43334 for ; Mon, 18 Jul 2022 13:03:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 407446B0072; Mon, 18 Jul 2022 09:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B6E56B0073; Mon, 18 Jul 2022 09:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27E026B0074; Mon, 18 Jul 2022 09:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 191DB6B0072 for ; Mon, 18 Jul 2022 09:03:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DFC6A20F6F for ; Mon, 18 Jul 2022 13:03:09 +0000 (UTC) X-FDA: 79700236098.07.0FB33E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 716D64006F for ; Mon, 18 Jul 2022 13:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658149388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TcEMTaB7xAKJTL0h0LjPI2dPleMaM3KdN7Sj0rKKqlU=; b=RTtwgHC0pxsCDjaXR7LqnTtxvfxYk/yQDnPsblWoKnQkqKkldY5f5KnBIh+Ln4SKnekhY1 iG/dNcdEoxlMnpM09GMx+0VyyS10VkGBBVdCPgOrqVzCa//uDGqoeJcHE76oNfiAlX8cvU Y24fVfDEENWvv7ZKsKvBVUpfnYq7BY0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-ER5TXeEGM_ywzZqh8l8pmw-1; Mon, 18 Jul 2022 09:03:07 -0400 X-MC-Unique: ER5TXeEGM_ywzZqh8l8pmw-1 Received: by mail-wr1-f70.google.com with SMTP id e7-20020adfa447000000b0021d669c6a76so1982851wra.19 for ; Mon, 18 Jul 2022 06:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=TcEMTaB7xAKJTL0h0LjPI2dPleMaM3KdN7Sj0rKKqlU=; b=kg6GpYvScP+MLA9Dx6GfS0TWBDCKiUTc5sZX8/UbhV6xIixqm8CWCRHRxbvOUu4Ve3 wbPgFq5z0OqdDycgUg1nE2GOWhwyJCn7nwwqQKEHkbuefzIQROsUJCgyiGbSnVxoOy5S kyZPsBXB/tIwnnw0pOGJXTmPjy0FZmC0gct+INQ+Kx0bxKPrHBua+TW3Str1RGeEgBKt HC3AUGa7ugyZtSVlXU8YHCkf9K31ZYqt3c9Y6diMAN3XxrkhM9KU/OYMF75KShjpqPF8 eBtbfvx5DRXiZagJKsWLWbJQGPe4PkEhh7QsjaTv7923Ur4lJVFIKuFsbQkVigaJLklR M2Vg== X-Gm-Message-State: AJIora9rWIKVqQiDIBoKjYYAhTUvw+omVudnkko3+Mu0FRJNs9Z+3ttD CM2J1w2A53mTwv/QhFcv1FBlVIfnqKwKcJIJ8jVHSqOl9rzP99ltzH+gGhj0v3hsH+WAo4600L7 1cOE4P9BqQ9Y= X-Received: by 2002:a05:600c:1f16:b0:3a3:214c:a85e with SMTP id bd22-20020a05600c1f1600b003a3214ca85emr39477wmb.95.1658149386368; Mon, 18 Jul 2022 06:03:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1upa5txyGo3VOx+mVbSu4SrZBRbL944pvx+WCPaDiEcZcCpcHclrXUGGcrP3tyGHYvxGIrbwQ== X-Received: by 2002:a05:600c:1f16:b0:3a3:214c:a85e with SMTP id bd22-20020a05600c1f1600b003a3214ca85emr39452wmb.95.1658149386109; Mon, 18 Jul 2022 06:03:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7400:6b3a:a74a:bd53:a018? (p200300cbc70574006b3aa74abd53a018.dip0.t-ipconnect.de. [2003:cb:c705:7400:6b3a:a74a:bd53:a018]) by smtp.gmail.com with ESMTPSA id p42-20020a05600c1daa00b003a30f84a9aasm10906417wms.26.2022.07.18.06.03.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 06:03:05 -0700 (PDT) Message-ID: <0c67010a-7d5f-567c-a300-0c75f1c47cb9@redhat.com> Date: Mon, 18 Jul 2022 15:03:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm: remove unneeded PageAnon check in restore_exclusive_pte() To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220716081816.10752-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220716081816.10752-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658149389; a=rsa-sha256; cv=none; b=TFH5s9n2dm1cgeV8Gj0ecvnMuRFN6TSeBJYJAFuJKPZLSaZU+X7vUD/UVDrcCBGbaAzarN W51qNozZlrVOHI92Kqeh2+CefrbT4dT8IajYg6/txZf87ucxQOkFqcywazM3+NvLTBwE6C CA3STV1AwT1qxzheJR3iho1hxaBsot4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RTtwgHC0; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658149389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TcEMTaB7xAKJTL0h0LjPI2dPleMaM3KdN7Sj0rKKqlU=; b=jDkSl+zlxTMRqOvEw6Kfs0JTFXuzZIOizX4DOSc8teCnop39Pj9Z9YcAi9dkMdhjRR3Y7N Ib36BmJVe+5pEQTazpnafjO7qc7WzEkjqCIWV2DIXrVAlggjFHTE9ck2YqvQ7t/F4pcbC0 eOkYWSL32mF8LIr7BOlppQQVQTzmWGM= X-Rspamd-Queue-Id: 716D64006F X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RTtwgHC0; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam08 X-Stat-Signature: b4p8ezojb6zakom7hrd7md7jcepqs1m7 X-HE-Tag: 1658149389-222724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.07.22 10:18, Miaohe Lin wrote: > When code reaches here, the page must be !PageAnon. There's no need to > check PageAnon again. Remove it. > > Signed-off-by: Miaohe Lin > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index f671b2dce1fe..d98f89cee3e9 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -753,7 +753,7 @@ static void restore_exclusive_pte(struct vm_area_struct *vma, > * Currently device exclusive access only supports anonymous > * memory so the entry shouldn't point to a filebacked page. > */ > - WARN_ON_ONCE(!PageAnon(page)); > + WARN_ON_ONCE(1); > > set_pte_at(vma->vm_mm, address, ptep, pte); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb