From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E4AC2BA83 for ; Fri, 7 Feb 2020 22:54:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD28722522 for ; Fri, 7 Feb 2020 22:54:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="qqXHc6wK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD28722522 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C95F6B0007; Fri, 7 Feb 2020 17:54:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37A486B0008; Fri, 7 Feb 2020 17:54:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28F656B000A; Fri, 7 Feb 2020 17:54:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 109536B0007 for ; Fri, 7 Feb 2020 17:54:35 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AD9852C04 for ; Fri, 7 Feb 2020 22:54:34 +0000 (UTC) X-FDA: 76464836868.11.nail01_a81b9efed002 X-HE-Tag: nail01_a81b9efed002 X-Filterd-Recvd-Size: 3881 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Feb 2020 22:54:32 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 07 Feb 2020 14:53:30 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 07 Feb 2020 14:54:30 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 07 Feb 2020 14:54:30 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 7 Feb 2020 22:54:30 +0000 Subject: Re: [PATCH v6 02/11] mm/gup: Use functions to track lockless pgtbl walks on gup_pgd_range To: Leonardo Bras , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Arnd Bergmann , Andrew Morton , Aneesh Kumar K.V , Nicholas Piggin , Christophe Leroy , Steven Price , Robin Murphy , Mahesh Salgaonkar , Balbir Singh , Reza Arbab , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , Mike Rapoport , Michal Suchanek CC: , , , , References: <20200206030900.147032-1-leonardo@linux.ibm.com> <20200206030900.147032-3-leonardo@linux.ibm.com> <760c238043196e0628c8c0eff48a8e938ef539ba.camel@linux.ibm.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: <0c2f5a89-4890-fd84-6a6d-e470ba110399@nvidia.com> Date: Fri, 7 Feb 2020 14:54:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <760c238043196e0628c8c0eff48a8e938ef539ba.camel@linux.ibm.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1581116011; bh=hL0GxG3AZWC0D09Bdwot9dPs+jKalw2embmHLRKcnSQ=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=qqXHc6wKJGDUDF5WUptm+LMkjfedSjWuOu7hMwGWAEkS/3j+Ej1V3oKUpca41Ng0y urYrrpUGJl5PZBrXWCNaNq1r74YQg17xXkIfJEWZ2ETV4sIRQXyC3DDK3t90yWS7il ZXJ/nzwWmzLVsoVKwO280dnaulqiEx3taYp7fGo5yaPYHNGnw7pCZS5Qjxa7jYDPsD BSwO7rSz/qtqmDQuTXDD1olCWd+q6M4eHN1MgscfP2hM2HIwSt7OPQQwDfmfujj3As e0W9hTPErF+Jl0u4dsX/7aGtT+P4HJYVsa+n+JpAOCxoK109dMJE9yLaNhzZA5BrNc GSGJo2lJJ8LpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/5/20 7:25 PM, Leonardo Bras wrote: > On Thu, 2020-02-06 at 00:08 -0300, Leonardo Bras wrote: >> gup_pgd_range(addr, end, gup_flags, pages, &nr); >> - local_irq_enable(); >> + end_lockless_pgtbl_walk(IRQS_ENABLED); >> ret = nr; >> } >> > > Just noticed IRQS_ENABLED is not available on other archs than ppc64. > I will fix this for v7. > What's the fix going to look like, approximately? thanks, -- John Hubbard NVIDIA