From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDC1C36005 for ; Mon, 28 Apr 2025 07:21:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E3536B0007; Mon, 28 Apr 2025 03:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0932C6B000A; Mon, 28 Apr 2025 03:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E581A6B000C; Mon, 28 Apr 2025 03:21:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C37FB6B0007 for ; Mon, 28 Apr 2025 03:21:25 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6C8F980B63 for ; Mon, 28 Apr 2025 07:21:27 +0000 (UTC) X-FDA: 83382607014.21.7B3989E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0E8248000C for ; Mon, 28 Apr 2025 07:21:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VYi7gAMV; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745824885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iEbmqg7PxxL61F93dafb5OmtTZxeAKgQMmNRWlTSj7w=; b=YyzvZFir80Mg23+JqyIFzVSnxkVtm1Na5U/qo7V/EaI/trTnwd3yXBTsNYtXadF3+bLGRs GfKGlF1LOHLR1sr+jpfKqalWUoSMOyEdkBSdmD4hU6yuTxkE3laBiFuHo70PTZBuVQS623 M9A6kPbXN6YBPZwuPpu3rWY09Q+j1vE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VYi7gAMV; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745824885; a=rsa-sha256; cv=none; b=DKav/4r9oJX6TSFEeFWDOx9gA/a2jHUdNGy3e9UyisZE7zwvpjeq+gyo2Wu6rR4ZQwjYhv 4vr2g0GbAh/xvGyo25EIgbJKEqpz8nh802l7B51awjfBg949r1OFanrAY2KExmDkC3F8nX O2rItcmYr8yWLXz1y9bceg85RjJkjZs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745824884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iEbmqg7PxxL61F93dafb5OmtTZxeAKgQMmNRWlTSj7w=; b=VYi7gAMVgxYqsFI3GLWXe/D91WtoOE+eLOB8PU6jW6PlEJzgrawY3snnv1qUd/X5XvkjNI kYgG64ZyaUqbQMWIbru1L465c1hkdQ4ayOlloHV6oGKhykoGjd9y9WAzO0Savnd7yKUlkY N8dyy3Kzuzv6Kx1TuwjvT/nOa2CvxIQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-cHSLMEVsN6GVInbchYYm5Q-1; Mon, 28 Apr 2025 03:21:22 -0400 X-MC-Unique: cHSLMEVsN6GVInbchYYm5Q-1 X-Mimecast-MFC-AGG-ID: cHSLMEVsN6GVInbchYYm5Q_1745824882 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43eed325461so23718585e9.3 for ; Mon, 28 Apr 2025 00:21:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745824881; x=1746429681; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iEbmqg7PxxL61F93dafb5OmtTZxeAKgQMmNRWlTSj7w=; b=EkudOiprKRq9HXVdgdvsnBY/bhNxIMfutAtzSXAZ8G64lPmMBkkPDlN3wmTK7sEwNt Xd9tErXg+hDGkFhu7pILaWfymvUZtcej6VOdKThet72pI1IbELbdyjXwdLzmFXkDKN+o V++Ys1CGsvigz3J7uRbE/MMR5Y1g1qkyXL8iZAy8WB7Stmeh1Iyd0vcpVVo5MfiCazIW 5FcbkYa8YNTRVCkFsKmPk2TYUdcK6YDgizk+c87MKAR40hbXpXfAsVoUSg4I4fCHfF0Y 85rPQAU4LWhQWYcYzNVI83FisxjZYPKAIRA7P7uMJXZTnBh/GjYLai6KrLJKL0svxKc7 n0ig== X-Forwarded-Encrypted: i=1; AJvYcCVxrNcXyfeKIPAEguoEl/usZfhtb/ZCW9WxMk2UTaLYKIm1TzKZGdJzDBZfiFbIFVQjqNQobTjVsQ==@kvack.org X-Gm-Message-State: AOJu0YytZ5m8OmbjU+vCUQEtFtnk9aSQCCuRkhjId8rGbeGiVB4ek3uO cfybXNuZE6gDetOmvoMrsYNDBGPF4tvlohVvy99lRsT5YB7u9qaVNVe+e1A4BmbS/p2Mily3u+Y xI6KTirQLqkSIo1hKtsqx8qQcp72gThR5HmyJ8iC9NR1PYazq X-Gm-Gg: ASbGncuEMbxL+EBQ4RN4HiBU/H/kAHVPBekvx4NkWO7LFGLgHuKTVVL+T7zFfSQxbYO rZT9twqj1XzKs+z+GJKItjFzhkCyu6oNDow/sJEuv8u7A0KHSiPcjOmaHbmjCjfclfiw77jHZ2i pByMykUaHFyc4oUtF5bVmDr294C+n6WeqzXUHlCsvLJZz98Puv/sSN+iHKnEXJ6g2oGENKBzYjW Fxfirre+A1A98/Xn++HKDCFMlIOxmdblsulQIP1gzlsZ0BXBI6aNjjE1lG/4vXlItb4jfVlzLzn HEUCbcegoJ1P8wPY6gle9OWaM2V0DmKkZjURlUtyDnvWzpsxWr1Nl89g5mLdY2MXq84dfcy8Neb AGYmRa3qvJips1WEe+XncmdvY/KmsCXmUYOEF9eg= X-Received: by 2002:a05:600c:4509:b0:43c:f8fc:f69a with SMTP id 5b1f17b1804b1-440ab77d34amr64664115e9.4.1745824881542; Mon, 28 Apr 2025 00:21:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEb+NfnUSeGTbIn7uCSc7PsyDAalTHMS5AOTDwK2EqVc/dsElIS2TcnE7A5EH8HnZ5aPpDkcg== X-Received: by 2002:a05:600c:4509:b0:43c:f8fc:f69a with SMTP id 5b1f17b1804b1-440ab77d34amr64663905e9.4.1745824881232; Mon, 28 Apr 2025 00:21:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a538f4aasm113133215e9.38.2025.04.28.00.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 00:21:20 -0700 (PDT) Message-ID: <0c2a0d93-bde9-48ec-bfb4-0a0747857f7e@redhat.com> Date: Mon, 28 Apr 2025 09:21:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/debug_page_alloc: improve error message for invalid guardpage minorder To: Ye Liu , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-3-ye.liu@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250427100442.958352-3-ye.liu@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MdbIIgAdyjR67B15AwBZ6zUfGQ0J5S_--4RpFlSjYXA_1745824882 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0E8248000C X-Stat-Signature: ph1sumusj9wqcoi4u5n6qqqnarjzak3o X-HE-Tag: 1745824884-780274 X-HE-Meta: U2FsdGVkX1/i/KV/MFsjCYLYJ7r6gOSY3J4VZwANHEGzjFq1zI5yiFU1/xZ6cUeOC47/4iLA+EauXAghi62pmNMRVG7H/tFOeozuSLL0QqnY7I+V2G+zNqbkXWgK0gokAP9hJeWXmenjOFZF6aBDHuShnk55gDPUGGWSsqZLo3ktJd0+XAGsgMemGuZzAAafXpP/O1hXapRXn2MsJmdy2svnRu8s5MFJaApxGyb6Sn+lutIW3y1Mu3qA4vD3n6js6AQhlEcCM2hVZNiABoGoSihVcM9YqUqUhQSx6ZkeCoZqgMMNwdGU28p3MTTCbfLbPx8ZziEvj3s2WquT5XVhiFYnrygOFJOM6JHOBEczzcnehpud0JWN0RoNrIIbaatgUfv0z1UBB8RZPp4tiedV4aiNYSK2Rh8aobquLJZhln0BXUFyMBWpFo7W0K45jFjFQjpdWbBUHf3Y14OS+FKu5LkKhD1uq0Mu370j3RJFSBOSEKpzXFebmUvgI9nddK3QesjgNV9KDKgeNrm7DvZqOorrl8SCdC8kL8D0k5DB6W2SluQggKbfAHNeoAfW6x1CHuyWPT+LSrS+fnAwLR5k1G7pyGeh5qxUFGc6ClkRmzBO/k9O1QXcmRRNTp5/oJPuxADlDTi50+Wxfuv8ZFJlndUrSpj0rk8lrf6AvlA41s7peqT+yzxEPilaPvCHGh5dhvXFIcW9L7nZZnz0DuBaDekWrmQiVu7czlV1N/Tg5c9vPY1Qhygt+CKOq4YC8GPREvipPIxfJ6928slHHUwyMP56xwrze38EXW2P/RODlzWoDm/qDSQQCpnbjL0qhBXbSzxhvZYwLUHq3bXPNK5rJe1AP5Iwu2xQrvhMldn2wNaGGh5pS5N3CzAAP1LNf3fvljZ5nJ+BmBrd6YBmz9Kkb+o2Wnf9+t/753a3yKY2qdD5flPAQSY3a/0Nl6IhG2JAgjQmKUdQOsrEru4TXhY fJ9FfrDr 0GNUViKsJ9EP3EK1OWaOFcBKpXXqJFUE/jRzy9FEOTZHfHwEJLV/OCgIhy/R8h2hqErp+uw8IFz+r3KmOzX2qakW+aexxC7hlGqcJTZ+yEtfxC8i+1hGu+Rv9ztc/7WbamJtxUEXu7AAjB6PPv1nCT7wVa5331Vbj99WwBEOFqwY2SzQTGLEZbLaK+691CSCb177MTZoE+oIL4oR5tK7PHTAATLeDf0ywG+4TpOtAfhG4IgX142pp6cPm4eBYxj9TuhDIarzBTSzmPZqS74k3RtD4fjC481T9h2GaqpFfMOwEk4rU3T0iJhzpZe+ikd6B809bw9n3bMgiRMGRtDjaFFk3UQ4vLKSp/X1VkL1FkzkyfVP0/Uk6fMVlpUxjmUO5ns92Q44c3GBhF/jTLwMuMFNLe4MZazN6FxmZULkSFmh69BOV7/MYxHyHH5rluR4u+4lGjf4iH3Ga6UiFxsKTrXITM8y/eV1X76wF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.04.25 12:04, Ye Liu wrote: > From: Ye Liu > > When an invalid debug_guardpage_minorder value is provided, include the > user input in the error message. This helps users and developers diagnose > configuration issues more easily. > > No functional change. > > Signed-off-by: Ye Liu > --- > mm/debug_page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug_page_alloc.c b/mm/debug_page_alloc.c > index d46acf989dde..6a26eca546c3 100644 > --- a/mm/debug_page_alloc.c > +++ b/mm/debug_page_alloc.c > @@ -23,7 +23,7 @@ static int __init debug_guardpage_minorder_setup(char *buf) > unsigned long res; > > if (kstrtoul(buf, 10, &res) < 0 || res > MAX_PAGE_ORDER / 2) { > - pr_err("Bad debug_guardpage_minorder value\n"); > + pr_err("Bad debug_guardpage_minorder value: %s\n", buf); I would guess everybody setting that should know how to find easily out what they tried to set, but in any case Acked-by: David Hildenbrand -- Cheers, David / dhildenb