From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B6AC433E2 for ; Tue, 1 Sep 2020 03:18:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C36B20719 for ; Tue, 1 Sep 2020 03:18:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C36B20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08F566B0037; Mon, 31 Aug 2020 23:18:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 068116B0055; Mon, 31 Aug 2020 23:18:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBFC76B005A; Mon, 31 Aug 2020 23:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id D4B746B0037 for ; Mon, 31 Aug 2020 23:18:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9FED33636 for ; Tue, 1 Sep 2020 03:18:49 +0000 (UTC) X-FDA: 77213035578.28.skirt56_4e0ee9727095 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 77C506C05 for ; Tue, 1 Sep 2020 03:18:49 +0000 (UTC) X-HE-Tag: skirt56_4e0ee9727095 X-Filterd-Recvd-Size: 4236 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 03:18:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F3DC30E; Mon, 31 Aug 2020 20:18:48 -0700 (PDT) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 792003F68F; Mon, 31 Aug 2020 20:18:43 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH v3 05/13] mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with CONFIG_NUMA_BALANCING To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, Gerald Schaefer , Christophe Leroy , Vineet Gupta , Mike Rapoport , Qian Cai References: <20200827080438.315345-1-aneesh.kumar@linux.ibm.com> <20200827080438.315345-6-aneesh.kumar@linux.ibm.com> Message-ID: <0c1ba151-b5c4-27a4-d500-4f416d0beedc@arm.com> Date: Tue, 1 Sep 2020 08:48:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200827080438.315345-6-aneesh.kumar@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 77C506C05 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/27/2020 01:34 PM, Aneesh Kumar K.V wrote: > Saved write support was added to track the write bit of a pte after marking the > pte protnone. This was done so that AUTONUMA can convert a write pte to protnone > and still track the old write bit. When converting it back we set the pte write > bit correctly thereby avoiding a write fault again. Hence enable the test only > when CONFIG_NUMA_BALANCING is enabled and use protnone protflags. > > Signed-off-by: Aneesh Kumar K.V > --- > mm/debug_vm_pgtable.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 28f9d0558c20..5c0680836fe9 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -119,10 +119,14 @@ static void __init pte_savedwrite_tests(unsigned long pfn, pgprot_t prot) > { > pte_t pte = pfn_pte(pfn, prot); > > + if (!IS_ENABLED(CONFIG_NUMA_BALANCING)) > + return; > + > pr_debug("Validating PTE saved write\n"); > WARN_ON(!pte_savedwrite(pte_mk_savedwrite(pte_clear_savedwrite(pte)))); > WARN_ON(pte_savedwrite(pte_clear_savedwrite(pte_mk_savedwrite(pte)))); > } > + > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) > { > @@ -235,6 +239,9 @@ static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) > { > pmd_t pmd = pfn_pmd(pfn, prot); > > + if (!IS_ENABLED(CONFIG_NUMA_BALANCING)) > + return; > + > pr_debug("Validating PMD saved write\n"); > WARN_ON(!pmd_savedwrite(pmd_mk_savedwrite(pmd_clear_savedwrite(pmd)))); > WARN_ON(pmd_savedwrite(pmd_clear_savedwrite(pmd_mk_savedwrite(pmd)))); > @@ -1020,8 +1027,8 @@ static int __init debug_vm_pgtable(void) > pmd_huge_tests(pmdp, pmd_aligned, prot); > pud_huge_tests(pudp, pud_aligned, prot); > > - pte_savedwrite_tests(pte_aligned, prot); > - pmd_savedwrite_tests(pmd_aligned, prot); > + pte_savedwrite_tests(pte_aligned, protnone); > + pmd_savedwrite_tests(pmd_aligned, protnone); > > pte_unmap_unlock(ptep, ptl); > > There is a checkpatch.pl warning here. WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: Saved write support was added to track the write bit of a pte after marking the total: 0 errors, 1 warnings, 33 lines checked Otherwise this looks good. With the checkpatch.pl warning fixed Reviewed-by: Anshuman Khandual