From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 687FDC47079 for ; Tue, 2 Jan 2024 11:21:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67AA46B0289; Tue, 2 Jan 2024 06:21:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 516C66B028A; Tue, 2 Jan 2024 06:21:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3694A6B028C; Tue, 2 Jan 2024 06:21:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 29F746B0289 for ; Tue, 2 Jan 2024 06:21:09 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E51D012074F for ; Tue, 2 Jan 2024 11:21:08 +0000 (UTC) X-FDA: 81634129416.20.F1BF02D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 6067E4001D for ; Tue, 2 Jan 2024 11:21:06 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QZ36bvoh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="B3/FBW5C"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QZ36bvoh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="B3/FBW5C"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704194466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9CsItAFiMpVmAKhXE6YG6CbtmUEODcCn+gzoAeshrRo=; b=kJAHH4m4F8pAMEA3RJxmpmdXYx5N32bypV3iE0CLrzBDxycA6SQvBg4d9kc8XTvdYJmeDR l4mjSsTvk7AM8gldn8lWu+tRgoy353OuBtWjKJxZFRQxIjPYEIKq+oYla9WYEHUglzGlCA lJv0l6+C1oUoSS3x3S+AkFYfEUJdOLY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QZ36bvoh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="B3/FBW5C"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QZ36bvoh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="B3/FBW5C"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704194466; a=rsa-sha256; cv=none; b=vy9bt8RJGFtugSWVgNmbX4Et1mIBkDVMxkeLYgg+ZM1tiovdbi+trLEa+jT8r5rFTYSA7G urCkr1E+op1jMGRH0jO1JIW/DlKdsqNHRXW5Uz4PntAMRY21ko4BHY4aZVACDZ6ggU3TGW 4enWrYKItwte7F9/jC+lN/zQ+gGip60= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9751C1FD55; Tue, 2 Jan 2024 11:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704194464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CsItAFiMpVmAKhXE6YG6CbtmUEODcCn+gzoAeshrRo=; b=QZ36bvohoOmCO71SRnED+dmpLBs9mBCRosqZKQheJZ6ffEx3DqfoeMC1EI+k9hI02XV7fO SDciXojP6JIGUivm9YGNoD1HPta529xjXeq5M7ufNnFbSibZRp8wCkRSAt23xiUGmHFyxG J8/deOlkNFnNZLMAqtlY9fQhdDe1vhM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704194464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CsItAFiMpVmAKhXE6YG6CbtmUEODcCn+gzoAeshrRo=; b=B3/FBW5Cj6we8phTe8fDDhC0hQc1UrJWIU75fHYaRYOM6v9bJWD9bbSIGR55G02/06273q MXakSNg4go980aAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704194464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CsItAFiMpVmAKhXE6YG6CbtmUEODcCn+gzoAeshrRo=; b=QZ36bvohoOmCO71SRnED+dmpLBs9mBCRosqZKQheJZ6ffEx3DqfoeMC1EI+k9hI02XV7fO SDciXojP6JIGUivm9YGNoD1HPta529xjXeq5M7ufNnFbSibZRp8wCkRSAt23xiUGmHFyxG J8/deOlkNFnNZLMAqtlY9fQhdDe1vhM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704194464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CsItAFiMpVmAKhXE6YG6CbtmUEODcCn+gzoAeshrRo=; b=B3/FBW5Cj6we8phTe8fDDhC0hQc1UrJWIU75fHYaRYOM6v9bJWD9bbSIGR55G02/06273q MXakSNg4go980aAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 81CD713AC6; Tue, 2 Jan 2024 11:21:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id x5mqHqDxk2VsLAAAD6G6ig (envelope-from ); Tue, 02 Jan 2024 11:21:04 +0000 Message-ID: <0c13399e-70c4-4787-9e1e-97ecb2fd368e@suse.cz> Date: Tue, 2 Jan 2024 12:21:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] slub: Use a folio in __kmalloc_large_node Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-5-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20231228085748.1083901-5-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6067E4001D X-Stat-Signature: i3px3bqf6bssisixixwfap6cnyn1s19j X-HE-Tag: 1704194466-801165 X-HE-Meta: U2FsdGVkX18QFLjErlrIsYE+hRuQBHfH8P4ytf3H1MbUzaNjOBi38S4KMLoMexgBovYtbpM8XbQY1OOkKSKH/jHbeBvNYhAH15rEct1iSlJYZqZtIF43kmmqTYYtC3gyFmdMxLQmStFGtRWtne+58lnBHiPiO6clclrp+W9k1P4GT3FH9Zkg0xMRJObxWW+gkxePkCeydBgnhcBk6UyS3UZWpxNYIj5c19ylroZ3Cf8Iw6XAEVXaCzGIt1KKhUb/GA2cmfQwiOBFs7CXW2uUJ12sZbkRS6r99Tys8CrFjTHDZAzRJCNiM9NyvtqbKZEuKz1ABhkSEsrSlCKzNH3hYt4REYWsTtBMgIVK9U2S42qr0KV/9TgoNdqjoa8vhqpYggth48vkgkVDYjO65JnDZxs0Offv5dKPb/TVCxDeBVohMhVCFnG5eq9ioerIO40+HPOQ9ZPPPmXzDmNp5HJuDCT/DLHxlRre7tCZGsJFrgeswPyRqxWde+9DZngRwz6ZU5LboHst9zCgqxMxkOOHYfCJl01Tl0QVSDY7DRPn3x//4KfLDxsRGo/mSNDBXmiNfIieC9xFPFY9xWxqZvrHgK4fZPlPJ4bkdbfsi1VAMd5wqqnBRuHOp4F6qb0rv+PGQgma9ToXcEVnThldZofbCJZFncQ5oZWq2t/uvvqLXtzs5DVfRGvk3VtgXv1kTlJVOuS3dVxs+cqnejRvtO6CvTvdlFbepNjtKxNPrlBu28XeyQTBatgvQCtIgjUVDwEl4UO7LDRYhS/4SgiO4P41bOQ2yIUiuzEoGyOE099WRw5rFSWgst0T+7fssldxZEygV3rpIwMgAi2PAKBSN1+D604YkFK3mdeVzAFFnzBD/ZNc4fuAtwHtV4v56BNFxE3dUtPTp0W9ArmPOKrVDN3a4/RO0818BuvlEbIojQ1L+Z7UwYvglRMDV7tB+0N4PHsrGk1GeZiSq+PaflRc5nJ coOZgdUN R4qJT6M8KGYTFl3354TD8T/gIOBcNXeramocLL6Kr4hh7tPzrZdNl3FL28ePOEbD5rL+feiPiNKcSEXGy5J3x2DO5QQ30aN7wFhRfj/OwlIKEKHmPyp8wTcN6SSeMLVLtGWSdjXhcPmQj6251E/giusceHMkdrF/Z9u89CWPwWQmBlJQj8D7qk4S7jv/QpthabC0wOkmkc/aklK6UNwPz1Y8D6TPG6Tv701MsMFcCCUlQI36Ku0avsQL454qow4ycA6ZaIOsnfPrFBHWZ/CQR3Sw0Lv4K8o1sS7VJcvW3NqcVbV2nyq4Ih/WcXx3SoUr2iMeRnNjMoBoQ12KqVC+l6cMctHdxEz+2ixXk8Aaxp4t0Hk/gGIur/BVvaNSTxo+h70E4ABFjplMgZpN1SVKLotBOV5jT3c7OLpFCIXogyAP91138l75OQD0DRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/28/23 09:57, Matthew Wilcox (Oracle) wrote: > Mirror the code in free_large_kmalloc() and alloc_pages_node() > and use a folio directly. Avoid the use of folio_alloc() as > that will set up an rmappable folio which we do not want here. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 58b4936f2a29..71d5840de65d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3915,7 +3915,7 @@ EXPORT_SYMBOL(kmem_cache_alloc_node); > */ > static void *__kmalloc_large_node(size_t size, gfp_t flags, int node) > { > - struct page *page; > + struct folio *folio; > void *ptr = NULL; > unsigned int order = get_order(size); > > @@ -3923,10 +3923,10 @@ static void *__kmalloc_large_node(size_t size, gfp_t flags, int node) > flags = kmalloc_fix_flags(flags); > > flags |= __GFP_COMP; > - page = alloc_pages_node(node, flags, order); > - if (page) { > - ptr = page_address(page); > - mod_lruvec_page_state(page, NR_SLAB_UNRECLAIMABLE_B, > + folio = (struct folio *)alloc_pages_node(node, flags, order); > + if (folio) { > + ptr = folio_address(folio); > + lruvec_stat_mod_folio(folio, NR_SLAB_UNRECLAIMABLE_B, > PAGE_SIZE << order); > } >