From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5C2C369A2 for ; Mon, 14 Apr 2025 14:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D972D280054; Mon, 14 Apr 2025 10:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1D1A28002A; Mon, 14 Apr 2025 10:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD01280054; Mon, 14 Apr 2025 10:37:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9E22228002A for ; Mon, 14 Apr 2025 10:37:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A95AE140301 for ; Mon, 14 Apr 2025 14:37:34 +0000 (UTC) X-FDA: 83332902828.09.D882EE2 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf25.hostedemail.com (Postfix) with ESMTP id CBF95A000E for ; Mon, 14 Apr 2025 14:37:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of guohanjun@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=guohanjun@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744641451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gr3+DPAAJgRKOhQl0uYXfBAb4KyEAX3U+uPj6KYCU3c=; b=ACocapl6s54CqBAffCNTZZSsAsctubYJbQgUHyGLTOEMVjUjrP0OqQ/IwdV8PkuhLoGvx6 1GL2g+hdW5eynuWKY6QYGi8i2zaWnCWWVjyRKiRgH8lRbZQuKFm7TQHrS7foZUWj/+Q9yD LiMyeNMehUbPeAVPT7VB62jlbA/kbcc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of guohanjun@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=guohanjun@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744641451; a=rsa-sha256; cv=none; b=g5J06EdclJ/Jvn7zGAsA3tOeIK2EgRTmAvI9tMg+sW7VI0jlOYMzfovJbOAuMrYCblCNrD waq8JW3JwcKLVP8R+VXJsp4oK7kCc6vwJgyEJPrMNSn5EtR9gEQtNc4+B3MhaRUpwx0knT ww8mdKg8s0Edmx6mJo1AVoeLd1YDQeg= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4ZbqY14QMGzHrDV; Mon, 14 Apr 2025 22:33:57 +0800 (CST) Received: from dggpemf500002.china.huawei.com (unknown [7.185.36.57]) by mail.maildlp.com (Postfix) with ESMTPS id 53FEC1401F4; Mon, 14 Apr 2025 22:37:23 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemf500002.china.huawei.com (7.185.36.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 14 Apr 2025 22:37:21 +0800 Subject: Re: [RESEND PATCH v18 1/2] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered To: Shuai Xue , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , , , , References: <20250404112050.42040-1-xueshuai@linux.alibaba.com> <20250404112050.42040-2-xueshuai@linux.alibaba.com> From: Hanjun Guo Message-ID: <0c0bc332-0323-4e43-a96b-dd5f5957ecc9@huawei.com> Date: Mon, 14 Apr 2025 22:37:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20250404112050.42040-2-xueshuai@linux.alibaba.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf500002.china.huawei.com (7.185.36.57) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CBF95A000E X-Stat-Signature: u1bigoxw1c7saj1dkgt6qbqcpqx47poe X-HE-Tag: 1744641450-142453 X-HE-Meta: U2FsdGVkX1/b9WnYYSIOHs+bRBG6WDfyZY+mCo6eiKfpBiKRJDIxIvBaK1kNiC6Ch3d9CA+EAq9t7ZvNiSVeA9M2gS34JBMtWbqtvJeSMtMJzkO/a3bFbbZ/B0jmK/SmjgRDlPD0O9d9DgbvUb0YZI6jyY1ZKi2ziPfcEDwZATOji4xxvaaLHk+UxvMUC2TKgmcDwhZJf/3VcjApXfJf3pwdidwGo4zB7gQWrd42dU5ZFMBLUqyLT8KopaOaF8r6XYTE8ggwKpIBaBuPDUw+yjdqEZN8J237dXIdCYmnrPUwTt64nqhAH4xXIUbe+PS0Cic0IvB84V+l4fi8a3jjn6VbHXctySv2p2ZKwZNFH4Jp66mDXwhy1/oQrntvM/YeXU0B4yjm8rYTAzj9phTUTy8xf5UgvAO0OCzGtUJv4GDFQ0WubMBHeHKJhA4KOZPtUlF4++i9TosgdNYqvjRtbD5d2+1OKcpIWtr04rBM6HoJkVCZKnhnGL1l1m4oOuYPKBnQATJCNJmT+Khre2pU10qRkIikPERzSEnyPmWN0sUOgTeJI4cKy3LzYxJLUbjetMRcmq34aIzaHimdVp+mHqkQf1PPYOQl3xQIJAIvSydJLXNGi9hSDiaxcjKLd3+8Sgyg1UZ0TJmqqo7qQ+lnQCq/qx2Et/HNX7oRHasX+leTKtS2XCuLm5ZVuMEAJgxBibq6g+jzaFjTRa4n10W2Lp+1NTOoRghdl4ri4HoBn/WMKoTab3/ho8jRl6QcD/IJj4GG9UsNIaFC7pSqCfKq/TOL9r+G4XfI4xgXACdUefc/0PJomrLiMZLafAqPbe9wayoxNYE/rQ01BeCSIvMiDe/Q8HyTXD1z9j2XyVC6UbOJBU0smIzQaodUmJEnL8wOd7V5BtCyg0AiQQSmyZ0IPKo6orXvb25fmr7QpYp6Vce3JJHDmWFdPeRrsAD+Bdj65ALvqVUDtiACKeosnSj SRcA69nz xDg5m8nIDqrlxN6uHZABIZrLkcdB75YdnsxPsb4L4NkefUCyRInCxH1gQpa2YK1MM8UbFe8UgiagzGxVvUbg8Uka77IlA2fLGXydnvaqAW0mMIlgwOwT+dWfbvG8SJ+AvYhm7lGy7EmdxR68wxUq4UD8QPy2NsQHJxnQkEYrx0BYCp6xiHrdK/IJAEx5Vmt30yxRwVHEhZRkqvGjjMe6Jsue9lYfi/fKRDE14Bew8xvqzoirR/mwxs4F3nxeqZZO0dCtm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/4 19:20, Shuai Xue wrote: > Synchronous error was detected as a result of user-space process accessing > a 2-bit uncorrected error. The CPU will take a synchronous error exception > such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a > memory_failure() work which poisons the related page, unmaps the page, and > then sends a SIGBUS to the process, so that a system wide panic can be > avoided. > > However, no memory_failure() work will be queued when abnormal synchronous > errors occur. These errors can include situations such as invalid PA, > unexpected severity, no memory failure config support, invalid GUID > section, etc. In such case, the user-space process will trigger SEA again. > This loop can potentially exceed the platform firmware threshold or even > trigger a kernel hard lockup, leading to a system reboot. > > Fix it by performing a force kill if no memory_failure() work is queued > for synchronous errors. > > Signed-off-by: Shuai Xue > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Jonathan Cameron > Reviewed-by: Yazen Ghannam > Reviewed-by: Jane Chu > --- > drivers/acpi/apei/ghes.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index b72772494655..50e4d924aa8b 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -799,6 +799,17 @@ static bool ghes_do_proc(struct ghes *ghes, > } > } > > + /* > + * If no memory failure work is queued for abnormal synchronous > + * errors, do a force kill. > + */ > + if (sync && !queued) { > + dev_err(ghes->dev, > + HW_ERR GHES_PFX "%s:%d: synchronous unrecoverable error (SIGBUS)\n", > + current->comm, task_pid_nr(current)); > + force_sig(SIGBUS); > + } I think it's reasonable to send a force kill to the task when the synchronous memory error is not recovered. But I hope this code will not trigger some legacy firmware issues, let's be careful for this, so can we just introduce arch specific callbacks for this? Thanks Hanjun