From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97C5C61DA4 for ; Tue, 14 Feb 2023 09:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C5736B0075; Tue, 14 Feb 2023 04:55:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 075CB6B0078; Tue, 14 Feb 2023 04:55:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80286B007B; Tue, 14 Feb 2023 04:55:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC1736B0075 for ; Tue, 14 Feb 2023 04:55:55 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9BE6FA0E2F for ; Tue, 14 Feb 2023 09:55:55 +0000 (UTC) X-FDA: 80465441070.13.FD4B9BD Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by imf16.hostedemail.com (Postfix) with ESMTP id AA347180007 for ; Tue, 14 Feb 2023 09:55:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of alex@ghiti.fr has no SPF policy when checking 217.70.183.201) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676368554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JQbvTqsQQTH0UJ38ui6Gihe5Kqpl3/fQIbR46YUai/8=; b=79LACuA5ngdLU6WGBX9Y234TSl8D0/wpLDB34wBhj5LlrzWgWW4oOfH44ARuQWQb9mzbu9 1AwC1IvW766hL7rx8daZtZ/uEZQq8SGUmSYtSkdFj65Na5WoPKSJ9vPXf16Jh4HPFHKSmK wI5EDITc6ihqNNIgc6ld6s/A6alqjzQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of alex@ghiti.fr has no SPF policy when checking 217.70.183.201) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676368554; a=rsa-sha256; cv=none; b=yuOzJIef8No6x6LK7Ujq2jbgjHmmOCmuehZmX7f7GqmRAQqgKnsfRiXTxsNaKXLVD4gIQj ams4wRYZESZimCllOJ1tn6WzvVSxO1wffkjJWQ1Qzo4JXfpnouI9o16ea0DyxygU0eGsfz I/5V+7RksfJInPDZCRMWzjumcGFqCh8= Received: (Authenticated sender: alex@ghiti.fr) by mail.gandi.net (Postfix) with ESMTPSA id AB0771BF20A; Tue, 14 Feb 2023 09:55:43 +0000 (UTC) Message-ID: <0bf59207-838b-2a0b-a95e-925a6bbf1913@ghiti.fr> Date: Tue, 14 Feb 2023 10:55:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: API for setting multiple PTEs at once Content-Language: en-US To: Matthew Wilcox , linux-arch@vger.kernel.org Cc: Yin Fengwei , linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, Dinh Nguyen , linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org References: From: Alexandre Ghiti In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 3zcrbnwyhjqqh454pnhwd743akojnn18 X-Rspam-User: X-Rspamd-Queue-Id: AA347180007 X-Rspamd-Server: rspam06 X-HE-Tag: 1676368553-505429 X-HE-Meta: U2FsdGVkX19mtgbBLpiskqqmfS2YqgUW77j2vp+/ukYM37UoMpBeCsydAU4DmFJY+s+zHdIHSoMjWgsCoXClxHgBAtaqzIpGNm1q467fEaG51es5qJkbdPWwbMQU5zNCsoSlOE3NjIrxsbECvplDcg+HxeegdyR9UKbJWGpb8FvnLH4XBzGCi1IqOkBi1JWsN1OnjJMZFmyP3KXayRmXx7sJfe8Swt+NQEhO4aFGm7k+2ZUUFn7jT5jQXF1asU1xOlzyCfDsZeOXn2i7oK6g9uk4S4S0SAcu5KSaFtsRNzjjFNr0OT9oQ9xmqFFR5lwGQTleaeLL8d/NUvsxeM8Ltkrm2TLP1HQ564D0bi2A35/Z4cOiJOPyVwqBY0I4AEbsdkFsYQSYHxyotp4Ymkyxs1D/45ib+QnZa9gmJbBiOYvCQj87MB/LiWjhsBIJ/XrBWG3SsSX4y1vgHAaAHF50yNFro9R1oCzpyBQ114ONb5Twtr5Pi1VX1joZRUF2zKClREIzTcH2JsQGw5TqoUrZJ7VDfqlGRHj3txi7jsgpFCGulOHM8LpDoHnllXL2JHFpldgQxEOD9/Dg/d/XVhD6BZ+elZyHFJcC1gN+lzp3fBO7ow6NZe5xMTptQIVvG6EkqNPdw8gkZtXJqFUy4At9ontPWuAcep663zOOwGuACG8xswukUw5udkZENCViN5JEdM4Ef3A6Za2CB8SKJFlnIaEzfSbptxTdV7HtRTcjKDZzZ4buSIolvLMPQ/p5K+81Ge7aM5yyQtQFrJ67iy3vIU49XHMWuJX6tyzMKtCF/dKuIz3Ak+ZF66ZbBDA/PXV/RQfwdOwDGAbRBIvD59GLN4gB9+eON3MlsllfYc0uoHciTGAgvRyo6a+33+5RwZd+XwqIDPSYhbArZx/lh4eGfM1UYpXv5kiW3OaPUMlgZTAYWtMTR/TkeR0PP9DhjaAl2XiENAJ6Eg5/MwLUQbC SpZJjueS 2RYnYJ4upKPLzaYgBPK1Wtgr//TJtZxflouC3sXKihpkgXVT4S4tm/S/Bu67JlzWGO3e6yMLScIcW7aLz2b2SpgyaAy2jpY6C+2q4U0iqO42wsTtNy20ZVFDEElkmsy2FcyInFRu9DgACtFHzLa5Ua/VpUSEBKQX1ZAeryXlGqkfSUSFzXbVuu13CLa0DoRpIM76AvlvBPOADxXkKOKoWqbMXTpa3yoDWKK/xwQNGy9qvqHM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On 2/7/23 21:27, Matthew Wilcox wrote: > On Thu, Feb 02, 2023 at 09:14:23PM +0000, Matthew Wilcox wrote: >> For those of you not subscribed, linux-mm is currently discussing >> how best to handle page faults on large folios. I simply made it work >> when adding large folio support. Now Yin Fengwei is working on >> making it fast. > OK, here's an actual implementation: > > https://lore.kernel.org/linux-mm/20230207194937.122543-3-willy@infradead.org/ > > It survives a run of xfstests. If your architecture doesn't store its > PFNs at PAGE_SHIFT, you're going to want to implement your own set_ptes(), > or you'll see entirely the wrong pages mapped into userspace. You may > also wish to implement set_ptes() if it can be done more efficiently > than __pte(pteval(pte) + PAGE_SIZE). > > Architectures that implement things like flush_icache_page() and > update_mmu_cache() may want to propose batched versions of those. > That's alpha, csky, m68k, mips, nios2, parisc, sh, > arm, loongarch, openrisc, powerpc, riscv, sparc and xtensa. > Maintainers BCC'd, mailing lists CC'd. > > I'm happy to collect implementations and submit them as part of a v6. Please find below the riscv implementation for set_ptes: diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index ebee56d47003..10bf812776a4 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -463,6 +463,20 @@ static inline void set_pte_at(struct mm_struct *mm,         __set_pte_at(mm, addr, ptep, pteval);  } +#define set_ptes set_ptes +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, +                           pte_t *ptep, pte_t pte, unsigned int nr) +{ +       for (;;) { +               set_pte_at(mm, addr, ptep, pte); +               if (--nr == 0) +                       break; +               ptep++; +               addr += PAGE_SIZE; +               pte = __pte(pte_val(pte) + (1 << _PAGE_PFN_SHIFT)); +       } +} +  static inline void pte_clear(struct mm_struct *mm,         unsigned long addr, pte_t *ptep)  { Thanks, Alex