From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D510C71157 for ; Wed, 18 Jun 2025 17:32:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6C296B00A0; Wed, 18 Jun 2025 13:32:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B444D6B00A1; Wed, 18 Jun 2025 13:32:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A822F6B00A2; Wed, 18 Jun 2025 13:32:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96C456B00A0 for ; Wed, 18 Jun 2025 13:32:34 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 60311C07C4 for ; Wed, 18 Jun 2025 17:32:34 +0000 (UTC) X-FDA: 83569215828.05.1339137 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf28.hostedemail.com (Postfix) with ESMTP id 83977C0017 for ; Wed, 18 Jun 2025 17:32:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zh2i8amc; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf28.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.178 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750267952; a=rsa-sha256; cv=none; b=rKfwmZ7zjKrV0AL9KbuvcWm7nIAniMY9iXXVuYcdR87fwzUxSM0tMBOANjb0WUOa0kV3iH VFN+f36frZxc7465jzdxcJyroTXvuvI+JNQTuz4gXa6Xsobr/W3hDZYqJ+qtGnOrgc6Qf2 3zE7Ow5Ugt2Scfwi5g4IxTP+oPxTL/g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zh2i8amc; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf28.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.178 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750267952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=JPaDHCf4QQfYtlFAEXP1n0ACjJsy8xyFFkSONW+4dVI=; b=cDcxRpyF6NuKnntVS8ZmphVyv2U/1g/yd1MkfuACmutjCORqFBa4+9tPnaZekn71dVMY8w LtY848hebnO0N4TefTkZZnQ7DwCZJh0FWLds2KmBdGk07IpHLkxndDOkLaT5Lmqb6sWizN Gr9qX98Wplk3DTXvWtaKmFy1iHtjJiE= Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-40a6692b75cso5372923b6e.1 for ; Wed, 18 Jun 2025 10:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750267951; x=1750872751; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JPaDHCf4QQfYtlFAEXP1n0ACjJsy8xyFFkSONW+4dVI=; b=zh2i8amc+8cEDFiaX8QA80FS8OND9zI1iZPxSAlVOORuhMuM4qDUESkBgjxpgWUTKG rb8rv6GgdXAIcR33Wse92qWo+pheYl82hr32fCG/KwD63c2qn0PGBbRt7QkpIN6SFFbA ePXqkHLTmeadn6q5tTCq0ng0c6gZAgb59xMZu+eWdMXS04gLcE03r0M4t3eMB5dsdj2T BElTiMEiwI2UNnC4iZmcctm7Jq2jsCuMY62+/V6KUQZtj55lIbax3d1S/Aqgzr2nK5tI DCJ0aW9+aAy2DJzKs9zoSEZV7bTXR+J6Q44s0LtdCmcCfyPs3oQTSVl1AjUVo97uQWr1 pQOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750267951; x=1750872751; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JPaDHCf4QQfYtlFAEXP1n0ACjJsy8xyFFkSONW+4dVI=; b=c7Ur/fdJXuMJbZoSponKacAA4yi1gja8eo9mEbXVBtCA5egDBDUSigp3yE19Jf3uXF l/82Yc5Yjla9zjWnRVBVwxUdDSOkCw9l+9Tq2bIvLxjfQdtItWR1xMeaJnNOO5rbzBjE zabo36pOLwQX2pwNL96DNBiUR1rUtNuxAvCyvpt4kaxEgibNe6czAhfAcF+P6ASIhZCE /nB/Vpxa5euxhKGCuW91F+ktUchFfnbBB/TA4CaZhT/qMHvDKsfwbc0eJJse6hcfLmUk 81LdlBj1Eh+mQHvTbGnLQ3VhQl4EoXE28qXLFtJXe2aHXCGhP0zR17yrcYgIsSntaHw8 AcgQ== X-Forwarded-Encrypted: i=1; AJvYcCXD7I06IxLHtH74F69I6p6FKnvpLb+Hdb1CmJ3f7137MN4PbZs2T+h23m/bxIZHsUeEnLrDr2bqGw==@kvack.org X-Gm-Message-State: AOJu0Yy7TbWI/Ozmd2GS++Cqlw0C/2yShHz5rDtZoreN8Yddg9ttmjjD 6xRilyxr0y5knd4lD5yf9P8u2SV+jmfyaa8qPeuwM8E2kuwWOU3KRlBTGTEtqZFiTac= X-Gm-Gg: ASbGncs7U3IP4yQqMAcF6qb/9GppXBg8ZHeWGi8fzJgEe48ZO2IPzQVf4y663a8bpbl hfF8ml/rK5qXKCiYTIxqMplvnOzkXUj9zKBp5TEd+nkE6d6jC5k77+tJ5ljsC+qiX5n8J12HWkw Jb+eUN3c3oiWRs5y4F930alPCOiiXmkv4BIChrGqowdF191KcQgQEKw5V2CtW+9RW0izx0Zf+Tt LxSraBfW4LDuqf0jg1E7TrFpeUjQlY7v8kYUOby8FQ4no4Clp4ztpknMWM70A09zUDszxY865H0 ggOIUnxxn3eezdVBxq+ir7nHKkliVQ7MC4NG9gSbsvMn7L9mGufbQbmKAa9sHhFIEzPFzA== X-Google-Smtp-Source: AGHT+IEhmsXj/9aFuinmgp9fFM5zxL8AzdLs118MWezycsaLkbKoWiwnYgYHLgU6A9s7/1JQmPa7zA== X-Received: by 2002:a05:6808:1523:b0:403:5150:c348 with SMTP id 5614622812f47-40a7c11902fmr11343414b6e.4.1750267951380; Wed, 18 Jun 2025 10:32:31 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1b3b:c162:aefa:da1b]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a740c2484sm2410989b6e.13.2025.06.18.10.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 10:32:30 -0700 (PDT) Date: Wed, 18 Jun 2025 20:32:28 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Alexander Gordeev , Andrew Morton Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Hugh Dickins , Nicholas Piggin , Guenter Roeck , Juergen Gross , Jeremy Fitzhardinge , Ryan Roberts Subject: Re: [PATCH 2/6] mm: Lock kernel page tables before entering lazy MMU mode Message-ID: <0be7d42e-5898-4b94-829b-59c661c2f07b@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bd3a45dbc375dc2c15cebae09cb2bb972d6039f.1749747752.git.agordeev@linux.ibm.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 83977C0017 X-Stat-Signature: def4yrxc7ui8n4xum1id74k7ysdwxsai X-Rspam-User: X-HE-Tag: 1750267952-474395 X-HE-Meta: U2FsdGVkX18fskwD5tK79+TRzWU00Tz1F81luvtz2nkE7QwSKkyoprPYWwiWAmNSr+4Hct/3WflweN8KSvaA/u/ZufcfzAUdEU8d4WvAIZkdUoY7k0PL4QfrtWPQWL8t0ICkmtvC6j68xHZ6CWmKbQmdxGVDpMfkYnYq7EIonucdHVgdixd2YIpG86JSBMXAyxr3jObMvmmA8LcjMJ5qR0vRdFxWh8FJw8AV3Mmopj4sGWJ4YqwO7fu/tYnS7vnYuf9wPCKV3/AT9q3j/oqEpW5e3jXAeL05HyjgDEwvf8q/orSZOhcdaQIWY5eT7wKRIRLnS7a3wTIdiEzS8Vwv2dQr3ju4x49riZbKROrigp5OBjr3Ad79j+CcySY8CmPzbLdyixsloHoBbIW9WLo+1AQ3FJ6iPd2KeC3a2h9ErxW3kLwDWPelp7cfRZMYp0V4tcJmPx5GePclFFbXMaFaZqqRFQpa5lsG/jik2iUqNxxbPk+ZFHgYg3ffxL+43W+Q4fjM+GgqN8hoTHe+WGtq/KKt6swI47i7xdKwVQwEhy4kPQMGKq06tqnjQcLVkEuJaaT8T21ETJGWkzp9b1Vx9InprGWtnLv9jaJLjDQub+XIxaBMnDdnLGRfmsA2EUqlyQCAPzTPGnrXAFxhQ3ME8uC8qPldMWYfXRjG/k2NOEBXB/bzYT4ImEmojV7c8oYm2adeFYTKUKiJtyiRwNIXYwCyPDRc1pZQL+jOwj+UbpKld6UROZp7S23AtBUOcY1eDLWIXE/+f/4do9+SATG49JoxoSRx0fBcho/BOS+ckK2CKOkc8DYkIB7/pVzRwCxGz4+up+k5jgiEfpClBl3B6BqHHkmwL3abPJDyBMzj7+jG0waygj3OoyNObRWUyXTxZlrPicZ4PNYp7dzQnxPSMMaMAyjEOS5eice4u6FBn84q1mjRhGcHsHzECbYDWbZEj48PuXVQc8wlOdf40UZ detMFeAG lhlUSst3x0+8DXSZX+FQ1OM4as+qxPevDSexCatFM6g1eug8BLhN82rYj7XPopENiyxNxYxa9g8PtToX8e63iLusQ0AQy/IgiNI3vgUhMcJLi4fQMYmDTTPzCoV1T2tIDos4qy9QPbfLiLJOiiAjzw/Gw9eXcZuAZtGwQiYLGMUC/vqn8dBpb8F9Xhyb8Cf+QrNGBsm8rVxwqYkeIBB6jRau65b9/tSv5e/tmkMdxkAsSQntqC0GjFgUJY5ecHOoO/B/qz90YJFsjz/3hwl7JD70DRyHxd8nPsmFPU0qRNq2F34gwk9TA9WtgBizl4D3b50AmI8IUpRPQl93WceWfHAEvLbV+o6aIGw1bqKKVWHz0P4y5NiCtLuevQAnLHOajR0P5NYGTlNMkJJffBFV8AckN5zH9msi+F1kAQksk7tEzbeX6LXmdztZz7pogVR/q5aYF4jeQUdua4gIk/x5DEVZGDTBH3YilsfO9EfsXbcXDIM7N7ytxs5YDFJbqNBAgb/Ga0GmLQqlDtLodPc7fgeabMCYsytmKKI9P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alexander, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Gordeev/mm-Cleanup-apply_to_pte_range-routine/20250613-013835 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/7bd3a45dbc375dc2c15cebae09cb2bb972d6039f.1749747752.git.agordeev%40linux.ibm.com patch subject: [PATCH 2/6] mm: Lock kernel page tables before entering lazy MMU mode config: x86_64-randconfig-161-20250613 (https://download.01.org/0day-ci/archive/20250613/202506132017.T1l1l6ME-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202506132017.T1l1l6ME-lkp@intel.com/ smatch warnings: mm/vmalloc.c:552 vmap_pages_pte_range() warn: inconsistent returns 'global &init_mm.page_table_lock'. vim +552 mm/vmalloc.c 0a264884046f1ab Nicholas Piggin 2021-04-29 517 static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, 2ba3e6947aed9bb Joerg Roedel 2020-06-01 518 unsigned long end, pgprot_t prot, struct page **pages, int *nr, 2ba3e6947aed9bb Joerg Roedel 2020-06-01 519 pgtbl_mod_mask *mask) ^1da177e4c3f415 Linus Torvalds 2005-04-16 520 { ^1da177e4c3f415 Linus Torvalds 2005-04-16 521 pte_t *pte; ^1da177e4c3f415 Linus Torvalds 2005-04-16 522 db64fe02258f150 Nicholas Piggin 2008-10-18 523 /* db64fe02258f150 Nicholas Piggin 2008-10-18 524 * nr is a running index into the array which helps higher level db64fe02258f150 Nicholas Piggin 2008-10-18 525 * callers keep track of where we're up to. db64fe02258f150 Nicholas Piggin 2008-10-18 526 */ db64fe02258f150 Nicholas Piggin 2008-10-18 527 2ba3e6947aed9bb Joerg Roedel 2020-06-01 528 pte = pte_alloc_kernel_track(pmd, addr, mask); ^1da177e4c3f415 Linus Torvalds 2005-04-16 529 if (!pte) ^1da177e4c3f415 Linus Torvalds 2005-04-16 530 return -ENOMEM; 44562c71e2cfc9e Ryan Roberts 2025-04-22 531 dac0cc793368851 Alexander Gordeev 2025-06-12 532 spin_lock(&init_mm.page_table_lock); 44562c71e2cfc9e Ryan Roberts 2025-04-22 533 arch_enter_lazy_mmu_mode(); 44562c71e2cfc9e Ryan Roberts 2025-04-22 534 ^1da177e4c3f415 Linus Torvalds 2005-04-16 535 do { db64fe02258f150 Nicholas Piggin 2008-10-18 536 struct page *page = pages[*nr]; db64fe02258f150 Nicholas Piggin 2008-10-18 537 c33c794828f2121 Ryan Roberts 2023-06-12 538 if (WARN_ON(!pte_none(ptep_get(pte)))) db64fe02258f150 Nicholas Piggin 2008-10-18 539 return -EBUSY; db64fe02258f150 Nicholas Piggin 2008-10-18 540 if (WARN_ON(!page)) ^1da177e4c3f415 Linus Torvalds 2005-04-16 541 return -ENOMEM; 4fcdcc12915c707 Yury Norov 2022-04-28 542 if (WARN_ON(!pfn_valid(page_to_pfn(page)))) 4fcdcc12915c707 Yury Norov 2022-04-28 543 return -EINVAL; These error paths don't unlock &init_mm.page_table_lock? 4fcdcc12915c707 Yury Norov 2022-04-28 544 ^1da177e4c3f415 Linus Torvalds 2005-04-16 545 set_pte_at(&init_mm, addr, pte, mk_pte(page, prot)); db64fe02258f150 Nicholas Piggin 2008-10-18 546 (*nr)++; ^1da177e4c3f415 Linus Torvalds 2005-04-16 547 } while (pte++, addr += PAGE_SIZE, addr != end); 44562c71e2cfc9e Ryan Roberts 2025-04-22 548 44562c71e2cfc9e Ryan Roberts 2025-04-22 549 arch_leave_lazy_mmu_mode(); dac0cc793368851 Alexander Gordeev 2025-06-12 550 spin_unlock(&init_mm.page_table_lock); 2ba3e6947aed9bb Joerg Roedel 2020-06-01 551 *mask |= PGTBL_PTE_MODIFIED; ^1da177e4c3f415 Linus Torvalds 2005-04-16 @552 return 0; ^1da177e4c3f415 Linus Torvalds 2005-04-16 553 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki