From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFDCCC54E41 for ; Mon, 4 Mar 2024 09:50:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26BB66B0085; Mon, 4 Mar 2024 04:50:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21B436B0088; Mon, 4 Mar 2024 04:50:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E3D26B009E; Mon, 4 Mar 2024 04:50:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF4006B0085 for ; Mon, 4 Mar 2024 04:50:37 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B37BAA0C68 for ; Mon, 4 Mar 2024 09:50:37 +0000 (UTC) X-FDA: 81858886914.23.BDFA02E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id DE50B40018 for ; Mon, 4 Mar 2024 09:50:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of aishwarya.tcv@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=aishwarya.tcv@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709545836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B21QuwH/dfSqqp1XUmhhAdWrFXja2i9kPdy8vRcWLkU=; b=4PQtm3b+C64nwvsRFu0CW/3z6AlzoQlloqGjnK6liDEYGfGDZOoFXw/HOqkdfjv+avi6rb +3v4OkYu3F84RgPIMyv05cOqcpgKluF5vqh6qUzl+a2iREgWUVBkqiJ2DPNEBC7WBWthk9 ac7wTfZUjSgZwUroii87HtvVNK9CgMs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of aishwarya.tcv@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=aishwarya.tcv@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709545836; a=rsa-sha256; cv=none; b=lgyvTK2Yp2eLXnWsNVBmMVwe1x/C7sXsiiRUL0amASw1NkF1OrQJPrys4YdKSC/vqh2Ak3 XGAbv/lHfJTEHYxW4rO8Glgj6UAf4kaQeuNetJdAG/dlZ27ex+MNi68Jl0faUdw3D4Jx+U kZNwexeYn2wlk7WxFw/Uz+n+NMNEB68= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 704111FB; Mon, 4 Mar 2024 01:51:11 -0800 (PST) Received: from [10.57.10.152] (unknown [10.57.10.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B11203F738; Mon, 4 Mar 2024 01:50:31 -0800 (PST) Message-ID: <0be630f0-ce8e-4a80-b42f-697ea603cfc6@arm.com> Date: Mon, 4 Mar 2024 09:50:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order. Content-Language: en-US To: Zi Yan Cc: "Pankaj Raghav (Samsung)" , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Ryan Roberts , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Roman Gushchin , Zach O'Keefe , Hugh Dickins , Luis Chamberlain , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mark Brown References: <20240226205534.1603748-1-zi.yan@sent.com> <20240226205534.1603748-9-zi.yan@sent.com> <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com> <7E498B77-6CC9-4FC6-B980-D79EEC548CD0@nvidia.com> <0685EC19-CDB8-4CD3-BC39-82DE59B5D10C@nvidia.com> From: Aishwarya TCV In-Reply-To: <0685EC19-CDB8-4CD3-BC39-82DE59B5D10C@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: edk8zngedw3nc8hydz878d5ywu5oydkm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DE50B40018 X-HE-Tag: 1709545835-423830 X-HE-Meta: U2FsdGVkX18NPY/WA73VO8SlyQbRwfxLC8eyyMleEt81uirfJ9LSU+uk0t9U3fwh4aeVvVg7o/3ZNqmtsguz9zJRLNSqoRoZNqSSI8EvnVTKPoN3xjXkmL6RF2md8maMc+3aa0wKyVodXWuC9zgk1SDmsyUSKadXlG6GTpxglWz25r4z6owUtIptgNRFPLcF7nJPztpZyw9kZeQg6lSlUnoiVwOsPqomlsWfaz5Llc8bvd6X2IsBM4hN4aY27677sxakrOX1cFiJSi0dfFlkCJrpLFau+mn/UxqiyLopOQmZ+DqM0aMrCDVzydqTJyZqm1wm/rLPKD9PyP5VvECAElO5+FP5FKtDqICncO9XYHT1YgxOA3xPeaNgUZ0O8/oq/qUQ4zNV94wfZw4fd5JT0/e/DJdYRDNXS78UB1WLM/mYuGohItwjY9/4Bp1xnDG3p8IcupKCZAixdWCh8d44omp0CX2pMpIQssWU6agFne3j8rv1YTTAlFWpqeB7G3227Zs8BdS9KNg5e4m0YUrw2/kP4WeSHjV+vKlG6jqrHRIQZtgABhzMqqOwELYMtiobir/Z+GKf8u1fRYbPKgcIVN0f1EDH0uclCIPH1vzWMCzI3zB9V4wQGYZ2FK8Ob6eRYbHJmj/hcib39PrroXArmdjJB3pfalg2Zh6uiYRWtqxIL71neTporrmjrk0JxpMMTDNUBkSKO/NHufxZPOvosWUpDRccs2usD74n2W4NxB9UToWQQUB3v81/IJC+wYRuNZLaN19qewUCNYR3dfF36xd3GRMQgxYBWu0h8ju9VuyC7ZoOScx6yzJS79fPXmEtcbsDF5lVU9plCb92hRRj2XFsrRCHe322+X/rbO97L0x690+jWnqHDl6YatAxeMW0o7x+ya88qOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/03/2024 21:10, Zi Yan wrote: > On 1 Mar 2024, at 15:02, Zi Yan wrote: > >> On 1 Mar 2024, at 14:37, Zi Yan wrote: >> >>> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: >>> >>>> On 26/02/2024 20:55, Zi Yan wrote: >>>>> From: Zi Yan >>>>> >>>>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>>>> Also add test cases for split_huge_page_to_list_to_order via both >>>>> debugfs. >>>>> >>>>> Signed-off-by: Zi Yan >>>>> --- >>>>> mm/huge_memory.c | 34 ++++-- >>>>> .../selftests/mm/split_huge_page_test.c | 115 +++++++++++++++++- >>>>> 2 files changed, 131 insertions(+), 18 deletions(-) >>>>> >>>> >>>> Hi Zi, >>>> >>>> When booting the kernel against next-master(20240228)with Arm64 on >>>> Marvell Thunder X2 (TX2), the kselftest-mm test 'split_huge_page_test' >>>> is failing in our CI (with rootfs over NFS). I can send the full logs if >>>> required. >>>> >>>> A bisect (full log below) identified this patch as introducing the >>>> failure. Bisected it on the tag "next-20240228" at repo >>>> "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git". >>>> >>>> This works fine on Linux version 6.8.0-rc6 >>> >>> Hi Aishwarya, >>> >>> Can you try the attached patch and see if it fixes the failure? I changed >>> the test to accept XFS dev as input, mount XFS on a temp folder under /tmp, >>> and skip if no XFS is mounted. >> >> Please try this updated one. It allows you to specify a XFS device path >> in SPLIT_HUGE_PAGE_TEST_XFS_PATH env variable, which is passed to >> split_huge_page_test in run_vmtests.sh. It at least allow CI/CD to run >> the test without too much change. > > OK. This hopefully will be my last churn. Now split_huge_page_test accepts > a path that is backed by XFS and run_vmtest.sh creates a XFS image in /tmp, > mounts it in /tmp, and gives the path to split_huge_page_test. I tested > it locally and it works. Let me know if you have any issue. Thanks. > > -- > Best Regards, > Yan, Zi Hi Zi, Tested the patch by applying it on next-20240304. Logs from our CI with rootfs over nfs is attached below. "Bail out! cannot remove tmp dir: Directory not empty" is still observed. Test run log: # # ------------------------------ # # running ./split_huge_page_test # # ------------------------------ # # TAP version 13 # # 1..12 # # ok 1 Split huge pages successful # # ok 2 Split PTE-mapped huge pages successful # # # Please enable pr_debug in split_huge_pages_in_file() for more info. # # # Please check dmesg for more information # # ok 3 File-backed THP split test done <6>[ 639.821657] split_huge_page (111099): drop_caches: 3 <6>[ 639.821657] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 4 # SKIP Pagecache folio split skipped <6>[ 645.392184] split_huge_page (111099): drop_caches: 3 <6>[ 645.392184] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 5 # SKIP Pagecache folio split skipped <6>[ 650.938248] split_huge_page (111099): drop_caches: 3 <6>[ 650.938248] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 6 # SKIP Pagecache folio split skipped <6>[ 656.500149] split_huge_page (111099): drop_caches: 3 <6>[ 656.500149] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 7 # SKIP Pagecache folio split skipped <6>[ 662.044085] split_huge_page (111099): drop_caches: 3 <6>[ 662.044085] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 8 # SKIP Pagecache folio split skipped <6>[ 667.591841] split_huge_page (111099): drop_caches: 3 <6>[ 667.591841] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 9 # SKIP Pagecache folio split skipped <6>[ 673.172441] split_huge_page (111099): drop_caches: 3 <6>[ 673.172441] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 10 # SKIP Pagecache folio split skipped <6>[ 678.726263] split_huge_page (111099): drop_caches: 3 <6>[ 678.726263] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 11 # SKIP Pagecache folio split skipped <6>[ 684.272851] split_huge_page (111099): drop_caches: 3 <6>[ 684.272851] split_huge_page (111099): drop_caches: 3 # # # No large pagecache folio generated, please provide a filesystem supporting large folio # # ok 12 # SKIP Pagecache folio split skipped # # Bail out! cannot remove tmp dir: Directory not empty # # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:9 error:0 # # [FAIL] # not ok 51 split_huge_page_test # exit=1 # # ------------------ Thanks, Aishwarya