From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D325CDD1B8 for ; Fri, 27 Sep 2024 14:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6CD26B00F6; Fri, 27 Sep 2024 10:58:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1CD36B00F7; Fri, 27 Sep 2024 10:58:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBC7E6B00F8; Fri, 27 Sep 2024 10:58:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D15F6B00F6 for ; Fri, 27 Sep 2024 10:58:29 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 57EF2140FFD for ; Fri, 27 Sep 2024 14:58:29 +0000 (UTC) X-FDA: 82610824338.12.005BB6E Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 15E6216001F for ; Fri, 27 Sep 2024 14:58:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=3AtcRm7M; dmarc=none; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.173 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727449070; a=rsa-sha256; cv=none; b=1PVGOJitspWzAtkab9orW7INRDW0w1WCM5A6Px7yy6myEJfSn9MS94dJDGiEkISZgM0iPE javvPm0NbCMPw4cdh3YL6/mdDLVuNQsmHIUl1WTZJlG/hXKPiDkUvdrnqGL6QsPz3HW9o5 t7CuLXDKIBQGLZo+rt+B/kGJGPQZX8E= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=3AtcRm7M; dmarc=none; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.173 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727449070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ozhasy6P2Xb1oYh5TEGfoMTGpcm94OU26cK0RFvw/pA=; b=sOqsrpTGrwYba2gAbm8jfuHESRIVpdF2qW4MHihr7gmcwIp06OFeYliwmUy+WPkmIcLlSm gScS/RMy/BoSZlOp5FvTQkY0WkgXqV+QvNT3t+e2zAJ69GbmF6MVySS7xOe8KswVZkR4s7 mnegktNz0/cbXdKfk5bm6nn9jrTlMrs= Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3a09c977dfbso8178535ab.2 for ; Fri, 27 Sep 2024 07:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1727449106; x=1728053906; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ozhasy6P2Xb1oYh5TEGfoMTGpcm94OU26cK0RFvw/pA=; b=3AtcRm7MTO/6NVIg5rRWAHKOl0Cj+NypE8a/tvwiTBAjqU3qtpMbg5gTxJDToRFtU5 Br08wZhVK0GMHPtfGcNpEZM7wbppZ+CWsyiJPR8UUU17L0t7reb7ZfB9fMwHXcJQ/GOE viB+5vpLXfsJKv0G4WSIDSOb82REXe7EEk/FEPnFt9TnM2kR1saPUgtMMCpAlWIH43cB iXwn8ta97wlnK8T2xd3mnzvUE9XwM2RMDO1U/C+SRRXiM7y4WuYhPLywGnlCxHlVKfw0 9GKpq3UNj4iqA8kufiHa2nKy5BwcS49FCdBBpD/rtKH3g1veHbHEtKQ3QY9e4a+PljJO 6fKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727449106; x=1728053906; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ozhasy6P2Xb1oYh5TEGfoMTGpcm94OU26cK0RFvw/pA=; b=oL3qMza74maje8et9yrtx8vZg1jUHKgnP29+bPxXUzni6Q6h/6CABDmD086NR1Vd0Y x8cOadCi0aIU/xOFva1MKwddJA7iRvb0qMXwO5O2LPO+cy6wc6oBclVO6tpG6+xxKU+C /2c1X3sSYhQccTaXF5btAzkq5fyyPqfS62OIswzDYUdDhirEUjM2Us3ghgvU3/iK7VBL P+uRJJHKY9A82esO2zv8JBPwzV8I1Ysy3xbS1f1EI3DqXzNDG6NIL1jyvq7kK/AQOxju XLuW8o4dBMBufQftSvSexmexue7VTJxQTdZqSFnBUC+s4KHbe8UCvP8T08OfE//VopEj nmfQ== X-Forwarded-Encrypted: i=1; AJvYcCW3II5f4O7XjvMN2u5lQDlHM2wHeyrwxymtUalaL8kAtGVwblMK8bES/jGcRxCuuIS/i3EwUmuUGA==@kvack.org X-Gm-Message-State: AOJu0YyU5EuOTqKnGsePxm7Eo+KQLIh/Ipr77cnes63SFoRN/Zawupko SX1T0qT5MQRtk2UpGdhzfxmYIn1UfdQig43ePO54ucqiYnIhG22rU6X03umspZw= X-Google-Smtp-Source: AGHT+IH8vraAyss5dfiMI4UgXMfkbfey2C1HTqAO3BTHkbK/0W8GSVWuzGv0+TFXbW2pP7mY0lBEFA== X-Received: by 2002:a05:6e02:1fe7:b0:3a2:e9ff:255a with SMTP id e9e14a558f8ab-3a3451b4b6emr32273115ab.22.1727449105798; Fri, 27 Sep 2024 07:58:25 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a344d81fa4sm6237075ab.20.2024.09.27.07.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 07:58:25 -0700 (PDT) Message-ID: <0bdce668-5711-4315-ab05-1a3492cb8bf6@kernel.dk> Date: Fri, 27 Sep 2024 08:58:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Known and unfixed active data loss bug in MM + XFS with large folios since Dec 2021 (any kernel from 6.1 upwards) To: Sam James , Kairui Song , Greg KH Cc: stable@kernel.org, clm@meta.com, Matthew Wilcox , ct@flyingcircus.io, david@fromorbit.com, dqminh@cloudflare.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, regressions@leemhuis.info, regressions@lists.linux.dev, torvalds@linux-foundation.org References: <0a3b09db-23e8-4a06-85f8-a0d7bbc3228b@meta.com> <87plotvuo1.fsf@gentoo.org> <87y13dtaih.fsf@gentoo.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <87y13dtaih.fsf@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 15E6216001F X-Rspamd-Server: rspam01 X-Stat-Signature: cgnbzxdz7pfue3g58mzjnqswkr9o6a5e X-HE-Tag: 1727449106-887525 X-HE-Meta: U2FsdGVkX1/ivwJRP+GjUL2PVDPPRnA4tim9HisxZP3S+rh/Dg/0c77qrXjNnNY9MbU++6L/Ew/RvcIxZBh7z/V1XREA7mqCuK3HtK0o2iLA/p5TmKnvBdE08j8MIO5JiTi2DbYnRT6CDcxHmnFcnjeYCLUSj9o7czdNAbK4qykBad9ZRXQuugrUjEKq2pt/JFAdrX1IVUtyyh0pGaXD1IkPzhkT73Q989hlXD8rgKRSr9VZcO0+mNo+gnrDLdL4qrnb4wfeenHIyUvhraEbbNWvuz2vRqkBFVn7kybShmq2Dg6BHimztdkx8O9WCgtV7pPQ1wcCJ4tN1/4NyEyxvdddoLhTH9YBh73Xtz544mu6meISyg7lGu2BAwE+JyMwyrWrp+YGZpTTtoEUyGe5Tp8sXNH3H2LagdjzEP358u3NlscrPuwLqkfJjgpXgzFkHQTFjb88xDYVnAz8d52F0hBS0kupi8eCffXpaTn92EMdv5e51LoKKs7KFj0BKsj3f+QJ9ifJl2ZavXtc2rrdLkp+vFEde1Dx1UWjT7UVXfax/phcHGdCsqxgsbzkk+Wc9fFqr924jZt7GfIAlix5DyxprbY0Litp94leoNeBhrL9zQQIBoHDJ5vac1FpKSZuMXubOwWlU83pNarB559OG3DPp1a1mVagT86YyfTRfn/6oDGYO6nvlB8qxh9cOQTUP6f0VXxBOx0PQl18qLnt0p366drFTv3reuB4fcN8WW1uCUpppjtwL0sP/1B2KUNmefxIDn/2/Q9qhBP86ayCNPFbjnYcl2+lR/xltOyUDjBGp4rQpNGbdc5B1FTkD8CmnyNPNyk6bdgu4t1Dg8v0FDzJ6xJYYAHtSGnQzj1lr0mvENpo5R8GAj23pPNWEARY58BAYq58TS0mBd0QqC0sqpxuwcjkEq32Nw0+xHd6DDB3w3Mpr8UFbIlaBQjgyWFgeU+khOqaA3TdPmjt7nY jSG3iSVW qWPBb8YMEoTtqczt+g8NVWro8hW9sqatRIXxHZGz3Jkvdd2vjI1jr9Jp98SB34ORz4I0kIJ9ZS5Ip4cjV8EPhzbjmNkTjEI06bl9khjpt9F96d5Kul4C+CL5DKQXSeMIFlY6RZJ34dwv5SuJQncGCwU9AzN86KTQsltnN8L5mTiBPdwHI7s4hYgj0hwir4OkA5+/gEVScUBnxA+vu9vx6LmPwL3AEJWI16FVk14m6MLFxmJY2OU+/pe1BNoeDRnWEbjNFHTdssn9DRHVpnJ1Sq7qxAjaXqIaRs5snRq+h1aKBagSdx5ZdbUzwTbdc9Czz8POXUMCl2FrqClB71k2PFC75NYE70H9dzlmt9eU6hmptj5mbZUIjP4I+8q0uuc6sfdWen3svBsxrFe7YjCQt/DTWr1IMbV/T4X0ZFuB6sVb39I4v/FA34hk9u6EWYj+HLeR3DtoAZzVNMGwfXarGQ2IQ9ed42I6acnIMgC9R79tG60VC++1wws2nr1eb9qB2j5h2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/27/24 8:51 AM, Sam James wrote: > Kairui Song writes: > >> On Wed, Sep 25, 2024 at 1:16?AM Sam James wrote: >>> >>> Kairui, could you send them to the stable ML to be queued if Willy is >>> fine with it? >>> >> >> Hi Sam, > > Hi Kairui, > >> >> Thanks for adding me to the discussion. >> >> Yes I'd like to, just not sure if people are still testing and >> checking the commits. >> >> And I haven't sent seperate fix just for stable fix before, so can >> anyone teach me, should I send only two patches for a minimal change, >> or send a whole series (with some minor clean up patch as dependency) >> for minimal conflicts? Or the stable team can just pick these up? > > Please see https://www.kernel.org/doc/html/v6.11/process/stable-kernel-rules.html. > > If Option 2 can't work (because of conflicts), please follow Option 3 > (https://www.kernel.org/doc/html/v6.11/process/stable-kernel-rules.html#option-3). > > Just explain the background and link to this thread in a cover letter > and mention it's your first time. Greg didn't bite me when I fumbled my > way around it :) > > (greg, please correct me if I'm talking rubbish) It needs two cherry picks, one of them won't pick cleanly. So I suggest whoever submits this to stable does: 1) Cherry pick the two commits, fixup the simple issue with one of them. I forget what it was since it's been a week and a half since I did it, but it's trivial to fixup. Don't forget to add the "commit XXX upstream" to the commit message. 2) Test that it compiles and boots and send an email to stable@vger.kernel.org with the patches attached and CC the folks in this thread, to help spot if there are mistakes. and that should be it. Worst case, we'll need a few different patches since this affects anything back to 5.19, and each currently maintained stable kernel version will need it. -- Jens Axboe