From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19607C021B2 for ; Mon, 24 Feb 2025 01:27:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2DE16B0085; Sun, 23 Feb 2025 20:27:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDC26B0088; Sun, 23 Feb 2025 20:27:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A52D6B0089; Sun, 23 Feb 2025 20:27:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6BD2D6B0085 for ; Sun, 23 Feb 2025 20:27:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ECBEA1405E6 for ; Mon, 24 Feb 2025 01:26:59 +0000 (UTC) X-FDA: 83153099358.08.0678EBB Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf18.hostedemail.com (Postfix) with ESMTP id 4B4151C000B for ; Mon, 24 Feb 2025 01:26:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740360418; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjai5cWeX6pZYG1rCJTwsLHGKRcbgXuPJ+E4fwroHKA=; b=dAVYasZDJO8N17tQJsYXVzwlxf+g/9p/HbdRZA30sfpd5xl8usTKv8xD0NqoyX4fdVyjme kPRuJ6iXBvHAUrrMvfzE8NgsuO9KYXSUk2MoE3x6Q3nlN2437Yj/srVyTuvUU3jc3XZW5E byqI01I2Na2dc7OwetgYbcS+XSVCBE8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740360418; a=rsa-sha256; cv=none; b=KnvHkgZ3dFwhul0EhKzk5SjZQkIof66/wZke2CKZ05LvzhMzOW5rHX080qaQE1WybcP7jP pO0AXvvm82F+nfZXaxQIWIMhMIihSw4dNOAWP1FqjkJjynqkgjXVrHlhl/yIvzDOetHlRo c/qEbbrPJxzn4GZsEt31NDjQ2yGw7gU= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tmNEf-0000000020f-2b9H; Sun, 23 Feb 2025 20:26:17 -0500 Message-ID: <0bb6a374a02995e78db49beb69e0f369480520a4.camel@surriel.com> Subject: Re: [PATCH v13 08/14] x86/mm: global ASID context switch & TLB flush handling From: Rik van Riel To: kernel test robot , x86@kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Date: Sun, 23 Feb 2025 20:26:17 -0500 In-Reply-To: <202502240650.kzshiji7-lkp@intel.com> References: <20250223194943.3518952-9-riel@surriel.com> <202502240650.kzshiji7-lkp@intel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4B4151C000B X-Stat-Signature: rzg8pxerkiworjxoea5umyoo9goagprd X-HE-Tag: 1740360418-21467 X-HE-Meta: U2FsdGVkX1/nSCGjKkYzseNcUlKzBR5ZYe3dnYJ96M8rcTZmiqpqXsaZ/ILv/yXRpPQ2P4IdlquAgl7l4chYt5cdybTl5NrOZjdZThDRQILbTGDUG4uiI/rGkevlArJA8wDTRGrItSBlPPo08Ucg2rvrJwc+OTLuY+1R6eqqma/x7HUsDlL+PmIFqI8dFlpbmBuHT8r1ZCfPuB4YhOLzB5jbE8DnkzSzmetgXLkoiOa2gM+ZWhNeA0wl3DLCFYqaqc0Wbi5R5DoA645+IgZGMcEgS8TIZl7O9fqZ78oe4Z7WeL1C1VBSanWxNze9M/XnKVG5UUfyPkXRy5LWwb+/sw42whYqyxOObG+od4WaRjROv1NptBk5xIc1Cknnm0iDp2Dd8uPVSZHQWBkgB0wGrLp1n0R+6BaBbCVyNjOg4BhLGi+G7Y/RxqZ4ytLD4Tily5g5SFB8GgO/LxWBDXv/Csusvavf4OEwMweadswD1w2WkDCOsYswy3rdk77IMlWDW9/N2aYIIlcR2Y3pAmKVDELztOjLrasAG42p6XHKRqNA4+c0lwblcDcocBNqp0zkIDjNKcABIVuqK835UeFhRlUyZt4msaJQkymTZOmj4/EL+o3oL6s2pwZUD0F2WYqWZ0R/R33M6XcqdpX9b8g0ntyrp8x2q/pOd33viLfG2WKmN6tuehrqYieC9Nlh5c8QFbzhtJPiB/r5KsJRUe2EbuMwrRT7srXP8eoPt39QBkJKt/T+ualJf8ZFvUg6pgwpJiB8iHDhj1nCG6Zto/lTLI7TxQIvi+qckwYCDyrTPc/t8SsaenpLIxkoiGq6hSmBpbJP3YKlS94p5W93d30B2i1FNWdcc7aaRZC3GZ/rcfhzJ98ETVBR+Mjvlj1io76uMd2309wIkQoYT0tDLQHRTmcZUgsuUOFqhYMhWJpXEWNznFEZndJqGJjjRcP5mdm+xgIAvKQuobEpjXfDr/B pkC9vpkj a9lTa41b/FxiUs4yFo8R2a0osIs2nUB1kFPH1wDrPvwRbnM3UWFEEhrc0qvseR3CWWpMN4nBTacN8FBNnqiSqQr25N090JpJ2nX/OTJrcL/S1pXEwK2xKxnjNWC9F3afSOj7nAajYbQ6DYkZIFHcpZSJM0HZ2uxQ/L9hILtOmDu5rDg//RidBnFohSXarSJ0FEZh/yUCPj6YcYxlEBOjwut+plPB+ZJ4U9i32AaMvmLNl+dxnn3IWKGfwvGqCyoF/y6NSBq/9m2nyGA1VtRXXRlgzYbjtkCCwQ7UODsuaJEBNIs4BgitZyFTnas9ixyI0VliwghuHNYXn1GM8QdEJcp2zrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2025-02-24 at 07:08 +0800, kernel test robot wrote: >=20 > All errors (new ones prefixed by >>): >=20 > =C2=A0=C2=A0 In file included from : > =C2=A0=C2=A0 arch/x86/include/asm/tlbflush.h: In function 'in_asid_transi= tion': > > > arch/x86/include/asm/tlbflush.h:253:43: error: 'mm_context_t' has > > > no member named 'asid_transition' > =C2=A0=C2=A0=C2=A0=C2=A0 253 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 return mm && READ_ONCE(mm- > >context.asid_transition); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 ^ Looks like this one needs to be moved under the #ifdef, too. Short-circuiting the build by hard-disabling X86_FEATURE_INVLPGB, or even adding an explicit if(!IS_ENABLED(CONFIG_X86_BROADCAST_TLB_FLUSH)) is not enough to get the compiler to short-circuit the rest of the code in that function. We might need an #ifdef inside destroy_context_free_global_asid as well, no good way to move that one into a .h file without making the global asid data structures in tlb.c visible to the entire kernel instead of keeping them static in tlb.c --=20 All Rights Reversed.