From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08F3C369C2 for ; Tue, 22 Apr 2025 08:52:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA60D6B0012; Tue, 22 Apr 2025 04:52:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A54116B0022; Tue, 22 Apr 2025 04:52:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CD026B0023; Tue, 22 Apr 2025 04:52:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6E82A6B0012 for ; Tue, 22 Apr 2025 04:52:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADE5AC6CCE for ; Tue, 22 Apr 2025 08:52:45 +0000 (UTC) X-FDA: 83361064290.04.ECC0F19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 5A3B380008 for ; Tue, 22 Apr 2025 08:52:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A0GX1uah; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745311963; a=rsa-sha256; cv=none; b=kxco/uWK3IwISvIK9GWl+HW7p2ZICNaARrYluglcEbKNYm+3P0UQbcDFi50pkEiLWBqWUk RdxQ6zDhefSRmaaG6lHNpK4VJGBdE2bS2iUogMDTmVWwBvM83AIGEbiRdpu6ZLK1jrWc7P CL+8n04obGmqH/+gGh95TH52LAXLa/A= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A0GX1uah; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745311963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6D+NIEZj5Y7xPhCQODKU2HLjfcx1SC407jYITEkyw1E=; b=GhfNPrHXrffaUY4JnPxCWukHz/3qm3l+vjbcgEgN/jEYjXDDFqPbcuvHXlj1gVp2mtRBmB V9+btASimFJ8A9y1c0ot184gjWrpT1xBNuaVT5UAqW2cngRksGSL/0Nl/hTLs/K+aSQbqS T/668vww8I8GSVwpBDzB/5km/qCmX6w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745311962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6D+NIEZj5Y7xPhCQODKU2HLjfcx1SC407jYITEkyw1E=; b=A0GX1uahE9PytZb818Z02yzw5msbSJEUn+WJt+Q//WQyWMq+5IUipXpwFDNUXpXKdMeb9k KLmk7jqFN2X9kUS3bmdYzC5gst6IyN9+deNndhGUnrBI6URhM2FSn66f3b0toWPe8BUAxe ACdd0+ko855Oh/hFTA1anAntMv5Nl8U= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-bz-rQUWWMgeP3Js1YjTlJg-1; Tue, 22 Apr 2025 04:52:39 -0400 X-MC-Unique: bz-rQUWWMgeP3Js1YjTlJg-1 X-Mimecast-MFC-AGG-ID: bz-rQUWWMgeP3Js1YjTlJg_1745311958 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3912e4e2033so1451988f8f.0 for ; Tue, 22 Apr 2025 01:52:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745311958; x=1745916758; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6D+NIEZj5Y7xPhCQODKU2HLjfcx1SC407jYITEkyw1E=; b=eLC3G/p6K+8uF2CggihS/t/lbogGkCvCpcZstw3vLSg7gD80bs+DuVht3eygoZ8R+b PB9sWI95urpXtKBnjRV/CesgdRk4j9pUEtgDGX892bpTOOZg/h4vO146qSAmeiQFxYlH xwKugzTr2FPQjfyqC5upDG7gKyl4CQufwCHBxhXs3jeSnDIU4KVLVogtewaz4mw4lW6T /qW4hRdwrh+kpbgNGxo1Hyv2Zmoh9NO2/MX+D9T+OddNwPGt8Z50nrWbENaVJsIrX2uv vg+/f2iU2Hd6IEUEpdlnODcojOizN9qY5gPCpgV7UrKVF44btGox5+sC5MXHE4w5VJPe pDOg== X-Forwarded-Encrypted: i=1; AJvYcCVN/LruZ5MqfASHLHY/LgvQOpvrIxTOTaZFRPTuE4HynEbff3R4dlGAx9xZgABmaj31e9RsN9PH2g==@kvack.org X-Gm-Message-State: AOJu0YzQ33Bsv/2hQBWsLXjNlYz52NYNgifRL4N18yg3CD5dXvg3rdzD DuHp0NDO98oR4v6wcAJki6zXyklNYatmCLsi/mOAmOp5oQq0gR8R1YAAvUqqso0MzAHsFCZ3LI5 exuHm+x7uZbPcR05HbVZTcwA3NRs65mGScBo7yNIrHQ0SQwO3 X-Gm-Gg: ASbGnct3RFsBxCJdc2w1bOYxYbl6DOK3fzEaAS1tG2RX+64pg/vEEEiWHMpj6VCBMPT ZSI82OK/i1m2wVf5EwC0TNzyiStOFlV9EepsMYWs4d7vOVaHs5EC542K+25XlJZ4l1HhSDzvIUj bQKtERRrHKlXfv0qivDFsm+EX8JQE4q6fn2G4muBaRLeG9qd4dyh+N8yGnFULa+ngBUIYvrs2jF 9nBn3RV9M/eePX5gfNuHesvZFCFb4KaSXsty3n0pR5RdafPAV+Io7XDN0cO8jDpqbAdieTNv+ni ED/oqFEnF5XMwrz2wZB31MbhWapAAhqePOqrdnV7B+I7H/khm6d2qzPM7tEJfzvLIxvjSozAmQC TleeE1akmDEz4fKIQu2GhYmA5mpLlbiBhP81/ X-Received: by 2002:a05:6000:1449:b0:38f:4f60:e669 with SMTP id ffacd0b85a97d-39efba6ae57mr11302116f8f.29.1745311958289; Tue, 22 Apr 2025 01:52:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/UI2uRZTHgPFSuSaAg/KQzTDzHZh4wPKLeRC71LvW1VKaLDpD/BYdDtU9xqkVe9XTUyRq2g== X-Received: by 2002:a05:6000:1449:b0:38f:4f60:e669 with SMTP id ffacd0b85a97d-39efba6ae57mr11302099f8f.29.1745311957953; Tue, 22 Apr 2025 01:52:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:8700:3969:7786:322:9641? (p200300cbc73187003969778603229641.dip0.t-ipconnect.de. [2003:cb:c731:8700:3969:7786:322:9641]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4206fasm14260104f8f.2.2025.04.22.01.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 01:52:37 -0700 (PDT) Message-ID: <0ba5c4ab-1580-4286-b9df-5d4da4e9324e@redhat.com> Date: Tue, 22 Apr 2025 10:52:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page To: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni , Sidhartha Kumar References: <20250418170834.248318-2-nifan.cxl@gmail.com> <20250418170834.248318-3-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250418170834.248318-3-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 726EEKP_nSSNYmwqsaIcinQ9C0EqFE43smbkqsSP1M8_1745311958 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5A3B380008 X-Rspamd-Server: rspam04 X-Stat-Signature: ytahxeqcnwpdaruam8bbr53wyqg4rqkk X-HE-Tag: 1745311963-75092 X-HE-Meta: U2FsdGVkX19CZixV9GHsbrqv1V4e9c1beT9NBx7iXSQkU4fKeA/ft/my2raPDr3OpU4LBKJEkleJExu6RvHOlUtUgBDbYGOOIcapwsNfXkHDwED1Ae8PrO8LM4z1TSzTGSq1465WJqBOcqR/4M6C9l0CJWjSi76ERMWPBJbE2fq1xWK2/fZ6V8T4LkCMfYLSiZbJJbSe0pbToR86BID175GI1WIKpBEyMrARgnVT0AwtYgFV/7gdHS55FkgrVW5O8o34s3/cgn9a8w72+47ZdMr8UazGJK0UmXAMFj8Zi9iatmhWydkps39QpOXCbsIgPWzjz+zxd2ijsgxUv8cr2s1y07NV9frxa3/14K/cVJAkplsRgPusQabetnxAOHwzFsBNpa8y+WonvHjUiqZB79qRIYe5/8xNNqTjLR2HxHbk1wS0aaPZTR/DRRwuU83ZJ0Lgd5+Ot0qSDlrjxGbYGRGZh/V1j0eqTPK73HDH57SinAK3JkUKbZNpmGFUVTnsgkefJwPyV9S0UlgURBc5KXQxANbOS1NbbRhI50igLyAfQ3hFN653oD8qHcFIFojBbZ1nuwu1/pT46XNsiFeMTkQYl9qQPV1teQLVaJ2e9ZJOnOROPW9ZNVeK8EJdk6tB9HXUK0HaT09MuNdYEr44QIFJLbx6xoHRO5wYGxwN67LhXzRlXXFw0ZPKoy9eIeD3UUsFMhSvB658W6maXLaK5R40HkPbusCGUoHpgyTnmdBqFzRCpPWZ4es8JhiqNHRBiZVARph7yYC+syFhA9ZxWGeNCpESem1+mg0Qd3l1ajrHWg/u2Ut8F30JSVtfJAxaMTqzmLbICE+f7ZReuHEENuyTzhk1f+1eNf1NjelBcDbwSkJ4cKwNHpUv1/gJ83fUzVCnmE//0MD/x/SGMg/aRneRkAMx/zmHMO8VizAdPkUEt51fY/3RNBaqKrHnyJ/diSqWZFX/E8n+cPoCxW1 IQ/5zqh3 ayEbmVYYabnjqm3zBPwL6ozZZKyA2c8nuWdHsibS3ffEB3aIGp+KX8IzDEqtRGRh+UR30Hk+ta5lYUoVVhQuEDF6ufzbRevr0zGlMOei2DjjWjFLza9t1JpOJW7GlxnwNqEj4XScpU6Fc06UABqV8ZegTFA/GH+qpzHmC1QUZTI1NoImdAy7o9sLpIpJfTskAQE4L8wzOHCPX8ezDSqlWtaCgpWTZyHVrgGwEvjMevmH0/UYZjCkM9xbWamQiJtywCtcupym+vhOPpoUZLFGvnbsD10qxzjUnE8Veiq5DiMWyF+SlgR3wQoklnmq5lFlJInifisqY2VYQrIZ3FCDze6lIxl9HCbeP8OWRbwWc/Vy3OGwI/txk63ICj+WP1JxOC+ZxkK28BKKXpWqCJW+vUT7dE9Z+o9Z8BzkDUUKI8y0niR3wxBzYaowgl3lu5ClMtm7FCUww7FMBVmYbf1csvXaJGEB/yc0UxicmRHTUH51zRI2Qy0nRYhj5xMnnAY6ythcL4zNgEh0E5Gy1h47Va9C84Phwk7BerK9n2A+gCGq0arMKpB0LjIftcWIO83/8syIyy91Gv1IBcnUJbTyQVxXzsugh3WsyuEfV3iRfMzPO9+7JvzxdUlaaUuN4nYmhTx+C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.25 18:57, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function unmap_hugepage_range() has two kinds of users: > 1) unmap_ref_private(), which passes in the head page of a folio. Since > unmap_ref_private() already takes folio and there are no other uses > of the folio struct in the function, it is natural for > unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni > Reviewed-by: Muchun Song > Reviewed-by: Sidhartha Kumar > --- > v2: > Picked up Reviewed-by tags; > > v1: > https://lore.kernel.org/linux-mm/aAHUluy7T32ZlYg7@debian/T/#m7ba630d783e08ae708453279579093d481c6e721 > --- > include/linux/hugetlb.h | 2 +- > mm/hugetlb.c | 7 ++++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index a57bed83c657..b7699f35c87f 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -128,7 +128,7 @@ int move_hugetlb_page_tables(struct vm_area_struct *vma, > int copy_hugetlb_page_range(struct mm_struct *, struct mm_struct *, > struct vm_area_struct *, struct vm_area_struct *); > void unmap_hugepage_range(struct vm_area_struct *, > - unsigned long, unsigned long, struct page *, > + unsigned long, unsigned long, struct folio *folio, > zap_flags_t); Note that no parameters are using names. While I am not a big fan of that in general, we should keep it consistent. Either name all or none. Acked-by: David Hildenbrand -- Cheers, David / dhildenb