From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CBEC2D0CD for ; Mon, 19 May 2025 19:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C22466B0089; Mon, 19 May 2025 15:29:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BABA76B008A; Mon, 19 May 2025 15:29:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FFB86B008C; Mon, 19 May 2025 15:29:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7E5B36B0089 for ; Mon, 19 May 2025 15:29:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F33381A0E76 for ; Mon, 19 May 2025 19:29:12 +0000 (UTC) X-FDA: 83460645744.12.DB73B7C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 9290E40009 for ; Mon, 19 May 2025 19:29:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpqzgYJ4; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747682950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n/A5udE0xFsUfjluCthGJRT0KVJ/nbPqupKt9mvOjwI=; b=BjfsT3I64d7L3YluvSId7ApjyWEM2/KZlhj7eRkuo5BwSrnYJpp3Vu75fZrfpb0XnGoCWM pU5Aeivpg9DUxEGzVCWr6v712xfYqwyV4kskTbfmu1gWzXGFQzOrFzCBwjyiT6ovHI+lph oR/SSjQBzq3nAfsJ3jEsPo3fQlaLjr0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpqzgYJ4; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747682950; a=rsa-sha256; cv=none; b=qpnqNp/TatLDG9/nf3x8l4W2E3MLZGVp1E2rsHWFtP/8xupGcmcn2d0iwMZyPdzX0RCINq 1aPyuL7AauvY0iPzjRIO/xeqjLyYbv1kmS4n8M3yIopql34dzQrhXDbndcK498f6XQv9qh jplcf8cK0dn5OqmjsYm1msYShZUTCUg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747682949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=n/A5udE0xFsUfjluCthGJRT0KVJ/nbPqupKt9mvOjwI=; b=EpqzgYJ4fSJ7Qjjj0hupcsTEaUV7e2TZxWHQYOHq1SUnIyoTGtOQnfO2l3VWDjCe12v4p/ DebWeIPUVBJLyE0I6NXdvAcBaNy7zt7vNPNw2Fk1h/i/eZcFuJXrKcEO21bW/cCRsB+wXu 9rc1ntsS/GLZipMAUS1GceaMciikkEQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-HQmglLi7M4axfTsBgDa9SA-1; Mon, 19 May 2025 15:29:08 -0400 X-MC-Unique: HQmglLi7M4axfTsBgDa9SA-1 X-Mimecast-MFC-AGG-ID: HQmglLi7M4axfTsBgDa9SA_1747682947 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-44059976a1fso20912485e9.1 for ; Mon, 19 May 2025 12:29:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747682947; x=1748287747; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=n/A5udE0xFsUfjluCthGJRT0KVJ/nbPqupKt9mvOjwI=; b=w+w5i5NYIwFaWyGk8R9YbFrXv3CwaddtorQPOj+CSHsyiUoslDJ2t+iXAuK+f9cEJ3 nkUM28lrJM/jt4X4FI/torEPOtOHz0o0CDb06CGKP5P/deBZYihuhP1MdY0Xq7sQVFxl neVMj2Zdmq7UhLwvTQzTQXFRUlkeKUQ5sO0UwiWFtUkR6lD73Asgj4AytCVt+dOSS36z P6IkOE3yiIIwwd6mHc2/kYLsNzlvtTJkGkYSTSB7CHzi3CTQZP+Jejdg/kEECplcPvwW 1PssBy5PlwtvyBuvBSMGtF0uNz3sL5aIfsWILNxyBigXn6i8ifKKiMyLuazUt+kSY5O4 FhOg== X-Forwarded-Encrypted: i=1; AJvYcCV/USJesVJNysnx8LVNWlxp5KIsOIS9k7sdQfOUEpKIqENpfQl7NBT8XCEn02hFtvxAt7g8cqq5og==@kvack.org X-Gm-Message-State: AOJu0YxvM5b6oluf51gU+LBkucruIcyTe8WzgAkBmLa3UwcfR6zCfOsh YadrX85ptvzrwRMYE2LJyIxq+urUV+bakRgOnPMsBZM3l/IM+WEEjvxjepi+ETF6vILuhKL02pQ gLaxKTtPqmNerV2wCjwkngDIo0tHbOg0OqIh5g9SEQsL8VGDqP4Jx X-Gm-Gg: ASbGncsBxGW1ocPQeBfL9utSS1QmKxoOs/DjX5Rx8YEXGG9y+VqYkDG09jjXl951pim vgUZ3n4OK9BJGx/kv3EmEi7L/+BxR7OulDQFy/WF6Xv86dQFQsBRqXRXGLj7fe7+RnuyejFjTUX EnLyYx7MAIBMfEyLDrdR0M1owJgXIJhbkjg0zJ81A6w5LCjIfEIjzp86dTbRQel8/rx3cf3Es4C 5kCRJYP5fPmCX6d9cjUEpg0T8uCee7ZLyWo6zFhcYQf5kBx/8RVd2tUir/cBwdtjlf2uGyzo/a8 7925On49NzzyMQ832uOANgOcdE8xpyXREkwQy/X+XPFhyPm4qeFF6TkkmbRdKv6mjDCnHIbXO3x l1cREsHKvPK6+yHupVk2OCG603CTL6CJShi8UNEw= X-Received: by 2002:a05:600c:3e0a:b0:43c:e478:889 with SMTP id 5b1f17b1804b1-442fd5a2c09mr163645315e9.0.1747682947184; Mon, 19 May 2025 12:29:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElwndSxsvYGiPSfmwEdluQQgF5em0NgqI0FO0EfTofaeJHmVDskBJCeT6akaFpuN6ZVrpCIA== X-Received: by 2002:a05:600c:3e0a:b0:43c:e478:889 with SMTP id 5b1f17b1804b1-442fd5a2c09mr163645205e9.0.1747682946811; Mon, 19 May 2025 12:29:06 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f7d975cfsm730805e9.38.2025.05.19.12.29.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 12:29:06 -0700 (PDT) Message-ID: <0ba29e21-22f1-446f-a9fd-863c99904ce2@redhat.com> Date: Mon, 19 May 2025 21:29:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: prevent KSM from completely breaking VMA merging To: Lorenzo Stoakes Cc: Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <418d3edbec3a718a7023f1beed5478f5952fc3df.1747431920.git.lorenzo.stoakes@oracle.com> <3e2d3bbb-8610-41d3-9aee-5a7bba3f2ce8@redhat.com> <36ea1ee7-bb6c-47ff-a6cf-18f43fb23493@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <36ea1ee7-bb6c-47ff-a6cf-18f43fb23493@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ENjksWkGxPFDkupFFxVtLSPusoB4Bbr9EqJaAlN4Ro0_1747682947 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9290E40009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ophq7yssceqc8xz9xwtsya6oejfu5cgu X-HE-Tag: 1747682950-301828 X-HE-Meta: U2FsdGVkX1+UbSA3b1qpMvAdnGY1MRrGPA7ckSV1UK0VhFdTk0wLx8B6dWwOo2IzIx1tYe3QFrtA0DAsqZyL+/iH86VB+JdAuHjqIDZY5I9oEVUO/CHYLVOtKEvl9EIgY8XDNg8rBJW4U4MKoTQ+qYsPkE8uoLqmaQSrA4hUg3mg8q/zuHmYw0UuFYxidcHWz3bhbK1MAJvTnP1qhy4zskjSlRWxcymYEi6h4+TSDeMAdRzLk6nZ/QTShnN9W3B5iuKWoSq71LdtPL8NdfkY2TtNqio6qm9P68sSbPP2n7x6CCl6U+6kvQDqF/sWzZ9O0kR4sSMYjY5Lk9xQKhiOiYCqesGgYTdF23JfokUAEZJ9jGc/KYI4147wT4SrUcoJEfSc0SssL76QxUJP8aSFlib86d9CwbhLfh/fsAyMYXDwDs5EgWVIKV3yEpc4Rl2isOi2kSOGVo5hbCDI2LH0yr6HNjVvDrlBVAR7Ep7bflBL9Y46piCkPngjzW68Nyi8K0tfY8uHNSpgKIqWZCoX+/HNfv9f4RkIQqBKMU15qfLu1jntZi0vTzH5kvB9kA/cGXoHuUPt5zR9gGroRZIIrnvuHsiS3SOh+8owuvu7r6kp/afw40QFWQatzYKI1/HvISu1cOaBFX/Dx6BZasvxjIWZNUe2O2XzkWtxho3D02Hdoay07KvpL0B3nKc3WUacKMlAN1PQwnNSJRWL+jA6m9NrEdLD5y6M81Y+HRYEscd/JEiEMX13AE5jNlhTl2C6LcVwVjAyeo5RGfMTBI8gLXYgF/DWxKtqcS5AFHcpSk6wneP0Z316AFstMzcyGMe0ARz/qbI/2v7QwyYNw7dWCCu4L/K2zLn1jisv7xQHy77qIhyzJx6/napHrQv7IJ4RAg+sAmC+gx4V/lEYLTLW/7hQB0uNNbLkjH8/qYyhnnet9Wg5QNdAi5gF1XbsCpXosloGpsuJd/dI15+je8r JklQGvAQ +v3/wnIf3unyLZetVMpPT8iGcgtIU609zOvxiHRK+wbs6gzn+JXHgREa7Vvrodc7Zdu/Q0b/KygRuJAEN51fOL7CMmaIXt38ic8TM59qJTWQ+uztOrak6j78mQTLpfplYW4zZd7PhB2p+/HpFEhI9crZOTA0JYUS/lOdW0nPmNPzjMggnQ19+T41jPAqoidKxyGBclzZoaQQbhdr8zR+HMvRPbA2I9qCCzQyowZNv4T9wHpN5HzChNAtLoidyl+bcLz72tww+iRacEEUoe3h6Cyk9a60T/+lSHj3+/JSHpRfdlWf2t552F+J3xWlazc/3QT1asxayrjG84GvSLzr0vt+7kDqZAA4EUX+MsvFcOUrFmFyIk81NCWae1hUetPeqt9rhFkMqA5VF2lFYjpHLl+8t4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.05.25 21:26, Lorenzo Stoakes wrote: > On Mon, May 19, 2025 at 09:11:10PM +0200, David Hildenbrand wrote: >> On 19.05.25 21:02, Lorenzo Stoakes wrote: >>> On Mon, May 19, 2025 at 08:04:22PM +0200, David Hildenbrand wrote: >>>> >>>>>> +/* >>>>>> + * Are we guaranteed no driver can change state such as to preclude KSM merging? >>>>>> + * If so, let's set the KSM mergeable flag early so we don't break VMA merging. >>>>>> + * >>>>>> + * This is applicable when PR_SET_MEMORY_MERGE has been set on the mm_struct via >>>>>> + * prctl() causing newly mapped VMAs to have the KSM mergeable VMA flag set. >>>>>> + * >>>>>> + * If this is not the case, then we set the flag after considering mergeability, >>>>>> + * which will prevent mergeability as, when PR_SET_MEMORY_MERGE is set, a new >>>>>> + * VMA will not have the KSM mergeability VMA flag set, but all other VMAs will, >>>>>> + * preventing any merge. >>>>> >>>>> Hmmm, so an ordinary MAP_PRIVATE of any file (executable etc.) will get >>>>> VM_MERGEABLE set but not be able to merge? >>>>> >>>>> Probably these are not often expected to be merged ... >>>>> >>>>> Preventing merging should really only happen because of VMA flags that >>>>> are getting set: VM_PFNMAP, VM_MIXEDMAP, VM_DONTEXPAND, VM_IO. >>>>> >>>>> >>>>> I am not 100% sure why we bail out on special mappings: all we have to >>>>> do is reliably identify anon pages, and we should be able to do that. >>>>> >>>>> GUP does currently refuses any VM_PFNMAP | VM_IO, and KSM uses GUP, >>>>> which might need a tweak then (maybe the solution could be to ... not >>>>> use GUP but a folio_walk). >>>> >>>> Oh, someone called "David" already did that. Nice :) >>>> >>>> So we *should* be able to drop >>>> >>>> * VM_PFNMAP: we correctly identify CoWed pages >>>> * VM_MIXEDMAP: we correctly identify CoWed pages >>>> * VM_IO: should not affect CoWed pages >>>> * VM_DONTEXPAND: no idea why that should even matter here >>> >>> I objected in the other thread but now realise I forgot we're talking about >>> MAP_PRIVATE... So we can do the CoW etc. Right. >>> >>> Then we just need to be able to copy the thing on CoW... but what about >>> write-through etc. cache settings? I suppose we don't care once CoW'd... >> >> Yes. It's ordinary kernel-managed memory. > > Yeah, it's the CoW'd bit right? So it's fine. > >> >>> >>> But is this common enough of a use case to be worth the hassle of checking this >>> is all ok? >> >> The reason I bring it up is because >> >> 1) Just because some drivers do weird mmap() things, we cannot merge any >> MAP_PRIVATE file mappings (except shmem ;) and mmap_prepare). >> >> 2) The whole "early_ksm" checks/handling would go away, making this patch >> significantly simpler :) > > OK you're starting to convince me... > > Maybe this isn't such a big deal if the KSM code handles it already anwyay. > > If you're sure GUP isn't relying on this... it could be an additional patch > like: > > 'remove VM_SPECIAL limitation, KSM can already handle this' > > And probably we _should_ let any insane driver blow up if they change stupid > things they must not change. That is exactly my thinking. But I'm also fine with doing that later, if you want to be careful. -- Cheers, David / dhildenb