From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A46CC61DA4 for ; Mon, 6 Feb 2023 06:46:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFAED6B0072; Mon, 6 Feb 2023 01:46:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA96F6B0073; Mon, 6 Feb 2023 01:46:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B716D6B0074; Mon, 6 Feb 2023 01:46:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A8E946B0072 for ; Mon, 6 Feb 2023 01:46:17 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73791160B8A for ; Mon, 6 Feb 2023 06:46:17 +0000 (UTC) X-FDA: 80435932794.01.EE3BC19 Received: from mail3.bemta32.messagelabs.com (mail3.bemta32.messagelabs.com [195.245.230.18]) by imf29.hostedemail.com (Postfix) with ESMTP id 51D2E12000A for ; Mon, 6 Feb 2023 06:46:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b="x/XU+I3v"; spf=pass (imf29.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 195.245.230.18 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675665975; a=rsa-sha256; cv=none; b=RLMzOyBXTc/fH9gg3Ayph0N93poarTL+0ASNlk5hWVlhAS9xf0bZjp/MgVMMC8qTbLG/bT VAvpq2XwXGD6Nlrg/rTz1Z5puz5VZOEdqUEOij/VQtX0J4FEf1JMYW70B73g24RRU+HvWR BNRWqC9Jhcd7Lkyn4Vw60l4uO0RIxKU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b="x/XU+I3v"; spf=pass (imf29.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 195.245.230.18 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675665975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8tDYHNWMpUBfn2W8rtNUEQrr/Lx/KtmFpqOm7bf5zQI=; b=PPZQ52RwYdtlBi+6j/3vNe8Ms6TEBGg2baXfFFBFdEiHATB/6KFg+d33H9ZI962U8F7PDE nHrJDlsjmHgpSViySzSUv5q6O+DpzHrckj2aupdYnpeUm5aIS23K+2dWznm25GMVKurnfd /SojYVfjf7WQLqtMxtotlUJqqgf8NVM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com; s=170520fj; t=1675665972; i=@fujitsu.com; bh=8tDYHNWMpUBfn2W8rtNUEQrr/Lx/KtmFpqOm7bf5zQI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=x/XU+I3vkY/snNMoCAM/Q/te6FSxTJEf60Xnb/zrFJUUov70ue0p8e8wke8j4UX/s I6AT7V8sLv+JvrsjvpmMjJ895YeTQH1WjKo13SltqC/C4oY2+HqJsDVjZiZiuNUVEi 5Tmrk/9cWpNqCZ5Zc8XfeuMeaizZwi4kh54eoQEkU759+tqQ04D+yaItl+JMdgHfSG WqoyWHzlLgCmdn0OIhhRVYZ4NJLTL9pnwWdm9KLG9NHjiJUKA8pEMYBfdDAaD/Z/Ao 4iTpnSnDMaMZUCsPfJ+DBXYcrFL/2efiwCAJpqfhIxVItcNut4/dirdG69CiOdVd1v Lji+JGr0wwiUQ== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRWlGSWpSXmKPExsViZ8ORqKuz6EG ywemHFhbTp15gtNhy7B6jxeUnfBanJyxistj9+iabxZ69J1ksLu+aw2Zxb81/Votdf3awW6z8 8YfV4vePOWwO3B6nFkl4bF6h5bF4z0smj02rOtk8Nn2axO7xYvNMRo+PT2+xeHzeJBfAEcWam ZeUX5HAmvHywxrmgg1sFa09v5gaGC+xdDFycQgJbGGUeHnqOzuEs4JJYt6/g1DONkaJi19+sH YxcnLwCthJ/Jr1hA3EZhFQkehq6WWEiAtKnJz5hAXEFhVIljh2vhWsRljATaJh5x0gm4NDREB D4s0WI5CZzAIdTBJ712xkhFiwnFGiY/ZLZpAGNgEdiQsL/oIt4xQwkfi49wU7iM0sYCGx+M1B KFteonnrbGaQoRICShIzu+NBwhIClRKtH36xQNhqElfPbWKewCg0C8l5s5BMmoVk0gJG5lWMZ sWpRWWpRbqGZnpJRZnpGSW5iZk5eolVuol6qaW65anFJbqGeonlxXqpxcV6xZW5yTkpenmpJZ sYgRGZUsz8cgfjib6/eocYJTmYlER5+/3vJgvxJeWnVGYkFmfEF5XmpBYfYpTh4FCS4A2Y8yB ZSLAoNT21Ii0zB5gcYNISHDxKIryXpwOleYsLEnOLM9MhUqcYFaXEeYMXAiUEQBIZpXlwbbCE dIlRVkqYl5GBgUGIpyC1KDezBFX+FaM4B6OSMK/oPKApPJl5JXDTXwEtZgJa3G1wF2RxSSJCS qqBSXCR5j0pid67FqWLbqzXV/yWLZOa47+8+Lvp5YhWqwkHGOf7NZ+f9+HP5Ou75VdP4Vtiln jIQX3alssRHoyyzu92mayYsKLx89Ok5y8FdIXM98yZvsCBXy9RYEKbhlzx7qtKv5enHDSbnCO yeHFAUc7LEE/dV/fKbi86XjXDp+TysUrZC88OFFZ/2Nm2rn+G59W26lt398WrqWwoDTpfVetq 127/gV3z0/HEA3+23DSvyjI26rGtc6rcvNw+ZbNF9U+pFpO1J4L3eq94f917SdKEVfWWpa4lf q+SGxke2xp5nX37e11s3KmDz9lbC9/O+bWH8QtzrqmmfdsfeebHUWUn+TjDtji9PuPocUEtUY mlOCPRUIu5qDgRAPjkbkDDAwAA X-Env-Sender: ruansy.fnst@fujitsu.com X-Msg-Ref: server-23.tower-585.messagelabs.com!1675665964!299649!1 X-Originating-IP: [62.60.8.97] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.102.2; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2381 invoked from network); 6 Feb 2023 06:46:04 -0000 Received: from unknown (HELO n03ukasimr01.n03.fujitsu.local) (62.60.8.97) by server-23.tower-585.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 6 Feb 2023 06:46:04 -0000 Received: from n03ukasimr01.n03.fujitsu.local (localhost [127.0.0.1]) by n03ukasimr01.n03.fujitsu.local (Postfix) with ESMTP id 77186100188; Mon, 6 Feb 2023 06:46:04 +0000 (GMT) Received: from R01UKEXCASM223.r01.fujitsu.local (R01UKEXCASM223 [10.182.185.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by n03ukasimr01.n03.fujitsu.local (Postfix) with ESMTPS id 6A116100182; Mon, 6 Feb 2023 06:46:04 +0000 (GMT) Received: from [192.168.50.5] (10.167.225.141) by R01UKEXCASM223.r01.fujitsu.local (10.182.185.121) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 6 Feb 2023 06:46:00 +0000 Message-ID: <0b8551a2-1d46-8ac8-5073-5b094507975a@fujitsu.com> Date: Mon, 6 Feb 2023 14:45:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v9 1/3] xfs: fix the calculation of length and end To: Matthew Wilcox CC: , , , , , , , , , References: <1675522718-88-1-git-send-email-ruansy.fnst@fujitsu.com> <1675522718-88-2-git-send-email-ruansy.fnst@fujitsu.com> From: Shiyang Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.167.225.141] X-ClientProxiedBy: G08CNEXCHPEKD07.g08.fujitsu.local (10.167.33.80) To R01UKEXCASM223.r01.fujitsu.local (10.182.185.121) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspam-User: X-Rspamd-Queue-Id: 51D2E12000A X-Rspamd-Server: rspam01 X-Stat-Signature: 9jo3gbuq1wyuubnrc59rgq9b8n387o6t X-HE-Tag: 1675665974-279826 X-HE-Meta: U2FsdGVkX1++Z46utvpqxh3Hp0IoAhVLX+HxlMBFEw9CQenkzkLzB7wlWusOXH4kBs56WdQF1Dz4XhoNZidL7D+If172ctQN2Eon7XjHghF2ChvfeSpO4H162FUJJbHgWeHvDXzb+0FaAvwE1BJBklpaIUhPru5KLiY7/Znd2FGLcuBOO6jHLqjzIus/kQk9biY2KWbIdSUPR/9KujCbR6wczmPUizfa4IULXv7A6kOCfp7deInBw+sqt9roGhz65oAMQqZs7bEdiu8pocu8qUAls0C0OEq65Tpz1+0qkHPc4HRBJG4ijIKuRxl5aChwBXohON8mdtZU7GFuDs3fs6N+2+e+3jcZWtVn/90NPGvIOzuvemqxzMHqA70AeCqX4LGTEAwPtLQzPCPb4rVaRvrRyYKm3QjxLA7/rD+NnL1AoGV+iuH2zkutQO31FH9i/Qoilb4Z+xH9rpIxSEnKEukkN1bWGWEXpbYHtapTduXCWiuUrNtLfLDRnAHwuPBvgbN+SCYEGwGfuJCBvRvRLcMJAyKEjVJTlFXmvaXVVzxsfu1gYaNk/R82EMSHy8v8kwU82v3wrZu49YghZjnl3FwYWGv3wqwZUqd2ptfge0Kgr9CsncY0wlaUKokte76I5F2Bf2L6RE3r38IdGY8XNpyB9y9sCLPSjLs25zN63yYVLssqagOUFb5353k9dDDPRsZg8FhOBWvgZrWUNKXumPgusKWrtb+SPFCngLqw+B8O8dWhWnyztlkxaK+uMoB6m/TdpjDdRS8Fu3aScw2fjYaxsJnO5rWDGjDeM6g9VIDOf4zInhJ7bC0FPzUN99Xj8XSfusdoZWV91glCCgXxY496XZdL6U4rjXeR3HnA0pZbKsfymFuqvqS7jCWIvbqoIn//bps1Us3fl9nUvTH9R7Ex/EagKP4ZrXfA2DEVh8X6Je4otf2xgo0sxP2SpKIOlnQzjZoxcFw/maES7Sz aysqXWqr VnKYbO84Jy7O15rYHLcbLrTSNId+ptIMBFznB4sL7+oyxuHUGKzybFt/Q0TMJKmlSWL6QS8FOzb/kHd6JVEVN9B1fl3VZC9NsnX1fRlfVsLnQniWVQwGgx9wU3vxDFya2ZBTo5BZTiTW2y/2T3koXY+yQ/DHlHoKG1X0ClpvF8q/2o+i7mpD7coZgZ6Rsl/0LRWYqu30j72meFzg8ALdWKdiwZzrumWigRXjV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000172, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/2/5 19:42, Matthew Wilcox 写道: > On Sat, Feb 04, 2023 at 02:58:36PM +0000, Shiyang Ruan wrote: >> @@ -222,8 +222,8 @@ xfs_dax_notify_failure( >> len -= ddev_start - offset; >> offset = 0; >> } >> - if (offset + len > ddev_end) >> - len -= ddev_end - offset; >> + if (offset + len - 1 > ddev_end) >> + len -= offset + len - 1 - ddev_end; > > This _looks_ wrong. Are you sure it shouldn't be: > > len = ddev_end - offset + 1; > It is to make sure the range won't beyond the end of device. But actually, both of us are rgiht. Mine: len -= offset + len - 1 - ddev_end; => len = len - (offset + len - 1 - ddev_end); => len = len - offset - len + 1 + ddev_end; => len = ddev_end - offset + 1; --> Yours I forgot to simplify it. Will fix. -- Thanks, Ruan.