From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35C3CAC5BE for ; Wed, 18 Sep 2024 05:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5608F6B0085; Wed, 18 Sep 2024 01:46:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 510426B0088; Wed, 18 Sep 2024 01:46:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D7B66B0089; Wed, 18 Sep 2024 01:46:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1AC6B6B0085 for ; Wed, 18 Sep 2024 01:46:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C1BCCA0326 for ; Wed, 18 Sep 2024 05:46:34 +0000 (UTC) X-FDA: 82576774308.25.D8D0B58 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf08.hostedemail.com (Postfix) with ESMTP id 76A3E160004 for ; Wed, 18 Sep 2024 05:46:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=NLbIB6CO; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf08.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726638280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+T7DsFUS0IX9KOF0oXx+kzfEg5O8+v17rnwkmfflrAg=; b=THKZpTfnBhCwmzy1uZnQ7KfQjCdRXFRjkyiYTf/jiCT+jNgPRSawcdBARYheRGBZsQ9m1Z BVFOR2v6OXalEpxJ/fc9gaSevOPnr1OaE5NUPbOOf1D0bbZudkKKvPo67nBMrITSFvGYCe fkA7RTtHzSVn1jr0kwy1BSJLkXV8gK0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726638280; a=rsa-sha256; cv=pass; b=cO0dgZ14Qr28nGK+E93tWPRMMqgMzCte1S7TdQ7PWfxgCffseptjJYYp/RnD/Z6BVBPFS1 Mr2tuiFjkQKb5PamJl42xpt/GrFmCUBBcozUzDybipgRbEKfsKwvoZPdI5PRuF1LPsljN4 xwZjHvs2TD+kbCud1aMHvQkWYMu+puI= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=NLbIB6CO; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf08.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; a=rsa-sha256; t=1726638375; cv=none; d=zohomail.com; s=zohoarc; b=SMU5Ji6YY7IaC0jHm0l+cFblMXz4OkLyQ2t+4lB/zQFRqKtv5xHq+h+fpVDWn1mXD5wyZpzQ6U2byH2lNiFT6Gd4RD//4/X5b5CRQc1XJj5IgG8fDoQX7WnYxMjamhPEA+y2Qso6WV4CgZbdron84fic1xLCBOXcjshzb0apBbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726638375; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=+T7DsFUS0IX9KOF0oXx+kzfEg5O8+v17rnwkmfflrAg=; b=Y4Pfl8dbAkBgk3OqWIXcgIcaTYPS+0kGU1XZHrxqPbEM16Iyy5xBIW+MTAw383cPJq6JD1EldOS3uehQyoh+8TBn7iFfOQ6gi677nkVjC1HTsqB7w2Qm31jMGSfUPd8Rl99nnUoPriSt5XEBJnYDS2ofgDrUZJMcTcyUqyvWc7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1726638375; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=+T7DsFUS0IX9KOF0oXx+kzfEg5O8+v17rnwkmfflrAg=; b=NLbIB6COo8X+/MWgt8//wCwYehdzZE9WHG+LpQFJCKeJGq14GlAIUePFepJulTlG bO+2WV6ofbUYXNvG0EuVQF5jYCKfTuD4WGojbkAfBf2UWpJaGxvW5Flm9AlMS9U6SC3 uprPEXzLldZD+gcnM+i89ubVM+OHmlcm6bGEvnnI= Received: by mx.zohomail.com with SMTPS id 1726638372856538.8419138041938; Tue, 17 Sep 2024 22:46:12 -0700 (PDT) Message-ID: <0b847784-a95f-4ed5-a0fb-1b7b4023df13@collabora.com> Date: Wed, 18 Sep 2024 10:46:05 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, John Hubbard Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Shuah Khan , Andrew Morton , Shuah Khan , David Hildenbrand , Peter Xu References: <20240912103151.1520254-1-usama.anjum@collabora.com> <3cb9d266-4d4b-4031-8603-da7fd9e3ad47@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Stat-Signature: 9esydmaq9fxzjz4oj99b11cccwgrb6xp X-Rspamd-Queue-Id: 76A3E160004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726638392-308766 X-HE-Meta: U2FsdGVkX1//lziKcdVN5NJ7CKLAFRPm3SQ/UsCB3lF9MS/9Yq4sdi13Kfd6+vDdM+wASLym3hsGgcjCXeeArF2ngIsJJkj6iBWS6hqyS0YjkGbptOvU/jmgeQJdGWOgQafGYi1vOpZp2V+zEpqhIZyGg2q2DT4/1cpUHK11Y4IWgz8/13FBUhnVvjWW8dn6howe6EEnhCeZ85AWAJHwKx7HFlo07IR0lmrstDiGC5YQlfxA6VJgXdhNz1rpJJ9pCvPulDgLrkBFEaK0P9JHZUL1fxcKsbkM4kqXP3n5rLvp7UsiA5zP7btlHPFUCXvvQMs1DLrpcLPjX1fpyycVOymBZx/owFeZ4yyejlCmnDdtCEJ+tyJ4tfe4ijU5bmfkE2pqGVKcrRbyJqCE9MuqQYNzh4NCuGtIp3lIhb2rJXJyHterjE7WOX8O1wbpYK8JtlH8PRC3K8GebRDOTbEJyNucs1ccY5zkJ5lwFgCpwYOc9Mft36KMaswe9GxFfpcORoRhqCt5b4m3P0edRsXbGmGnVvFblcmtl+AU66G9/ulYmDgX/mZmrImEf1WhecgXKdrzf9M7IPjsbum1KOpQvww2X7+UjtOXKQ+IwnwdgeCLl34nU9rUYLnBdoX2b5djP96wiKptYIUfemBjgS1EA9zGO8cSIHCJPcZX09hGV6apFgaVcw4Zn7hw2UHYGuMh34S8314BEvtbZhXUeVyYTKMdLpHSnPwqyA+nhJckimi2x7dsbvF2Z+4iL5ajPdoYFN3FYw3NfAeSO+KXO8AwYmQhSWU4Orw6W9Nb2or87bDXdQ+y1iMLdTXQFVYCXIGzOAYX6dOO/2Pz9NJND3OLwcKmlihdjNOL3DUrc6pfugXOjlhSR3fkYZtNg6qGQC7PMhN0wMa8X7oD2czxlCrKpmAFUkoBw7toOSjohiFw98wEZxBOc5w1gF7/ICiA1VFMpGOJfJjjN/0gB/Wta6M UXGjqoS7 FOjO9Go/q7HJSq0GvMY/Lcg61pESx/w9mdDkhnU5oS7gtHYEXcvCB1Aio5QF6fbKf0Ir3kyYCsI0Ecp8NIIuaFYqQ5vo3DIRJG753HPhPW+Hj/KdiEQDpZ/IZ+wTFRrxSTdHzfGRkIRI0nGcIfXDQgnVEQeN6DZfJVbELAtbFD0JixZ+nV8su4/qBq1DPem5MvLC/QBtnwE6MwkbwukENFBPQw0XnrYClLL8ffJ3+zYwrm9M8IRJsM1VHLeDkiys78gadxAT+0F0AfD1XZv9/xW4jPi5s72t756QX6+keKH5vyK1c5+k96FGYGOVE5niQ+9GhQhi6cg41ySVadRtZi8KbyA3ZnOyBP8kX9suPY76Qxbk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/17/24 6:56 AM, Shuah Khan wrote: > On 9/16/24 00:32, Muhammad Usama Anjum wrote: >> On 9/12/24 8:44 PM, Shuah Khan wrote: >>> On 9/12/24 04:31, Muhammad Usama Anjum wrote: >>>> The value of __NR_userfaultfd was changed to 282 when >>>> asm-generic/unistd.h was included. It makes the test to fail every time >>>> as the correct number of this syscall on x86_64 is 323. Fix the header >>>> to asm/unistd.h. >>>> >>> >>> "please elaborate every time" - I just built on my x86_64 and built >>> just fine. >> The build isn't broken. >> >>> I am not saying this isn't a problem, it is good to >>> understand why and how it is failing before making the change. >> I mean to say that the test is failing at run time because the correct >> userfaultfd syscall isn't being found with __NR_userfaultfd = 282. >> _NR_userfaultfd's value depends on the header. When asm-generic/unistd.h >> is included, its value (282) is wrong. I've tested on x86_64. >> > > Okay - how do you know this is wrong? can you provide more details. > > git grep _NR_userfaultfd > include/uapi/asm-generic/unistd.h:#define __NR_userfaultfd 282 > include/uapi/asm-generic/unistd.h:__SYSCALL(__NR_userfaultfd, > sys_userfaultfd) > tools/include/uapi/asm-generic/unistd.h:#define __NR_userfaultfd 282 > >> The fix is simple. Add the correct header which has _NR_userfaultfd = >> 323. grep -rnIF "#define __NR_userfaultfd" tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 arch/x86/include/generated/uapi/asm/unistd_32.h:374:#define __NR_userfaultfd 374 arch/x86/include/generated/uapi/asm/unistd_64.h:327:#define __NR_userfaultfd 323 arch/x86/include/generated/uapi/asm/unistd_x32.h:282:#define __NR_userfaultfd (__X32_SYSCALL_BIT + 323) arch/arm/include/generated/uapi/asm/unistd-eabi.h:347:#define __NR_userfaultfd (__NR_SYSCALL_BASE + 388) arch/arm/include/generated/uapi/asm/unistd-oabi.h:359:#define __NR_userfaultfd (__NR_SYSCALL_BASE + 388) include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 The number is dependent on the architecture. The above data shows that: x86 374 x86_64 323 I'm unable to find the history of why it is set to 282 in unistd.h and when this problem happened. > > I need more details on this number. > > thanks, > -- Shuah -- BR, Muhammad Usama Anjum