From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E060DC28B2F for ; Wed, 12 Mar 2025 14:59:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55D58280003; Wed, 12 Mar 2025 10:59:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50C9E280001; Wed, 12 Mar 2025 10:59:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D4D2280003; Wed, 12 Mar 2025 10:59:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1CE15280001 for ; Wed, 12 Mar 2025 10:59:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E3041CA0A9 for ; Wed, 12 Mar 2025 14:59:10 +0000 (UTC) X-FDA: 83213206860.09.D9C088E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 5D3461C001E for ; Wed, 12 Mar 2025 14:59:08 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qF8Q3tmZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PkVWaqgd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qF8Q3tmZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PkVWaqgd; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741791548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9ZvV4vKA5vYd6vr6nTnELCHn+UXS+fNwMlNQ1aAYmss=; b=2WVXY0Zz/vHyzPvpMDzoh+T2lFv/XgdZOvdojf39AUu/xekrB1AMus0/4akV2euwrnxrP6 L7r7d/MEGYpCKuwrw0UgIYNxU39PMk6MMCVRFQlz1sKULNc3D4E4czoQlLc8PpZ5TdlCT6 TpyCWiIcKlgloA9PdGsdQPcAJiu1+PQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741791548; a=rsa-sha256; cv=none; b=CfSCvhOX2BC1kT5kKIRL4YMTbUWM/8ttZ9r6258sFnZMNR9bRk9qsw4+9muyL8Fg1Gop1W 04DygX2Te6Hnl5a/ZT+T1nitirAxbn7nmC3aM9pNXBeJ7gDFMiekct8PsTGtFEentJbizk +R/JbzHjQIT1qz9G3ZqnOsDnF79zhVs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qF8Q3tmZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PkVWaqgd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qF8Q3tmZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PkVWaqgd; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CBE6721162; Wed, 12 Mar 2025 14:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741791546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ZvV4vKA5vYd6vr6nTnELCHn+UXS+fNwMlNQ1aAYmss=; b=qF8Q3tmZQZrDdBv4pMmY45d2A+kaMugGTS20tq10V6NpXXsG6Km8+BTnSEcHpI/jzsZe5T frhJhBD/4qkEdojAGoANn+ppAJeN/zgJENg2FNpn0OQO/BQKM2EMlQ/aXNEAfM+8t1w7/m i6xRGcon6sUO3kBPv8zaklEQF0PxTWc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741791546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ZvV4vKA5vYd6vr6nTnELCHn+UXS+fNwMlNQ1aAYmss=; b=PkVWaqgd1GFjeCjYjEMsjlUU9kjZtzbA5tLgTp4SLL1PuAVyMsUNyXix5t2dPn4UiSf714 z3kbGe3sC8MNdfCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741791546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ZvV4vKA5vYd6vr6nTnELCHn+UXS+fNwMlNQ1aAYmss=; b=qF8Q3tmZQZrDdBv4pMmY45d2A+kaMugGTS20tq10V6NpXXsG6Km8+BTnSEcHpI/jzsZe5T frhJhBD/4qkEdojAGoANn+ppAJeN/zgJENg2FNpn0OQO/BQKM2EMlQ/aXNEAfM+8t1w7/m i6xRGcon6sUO3kBPv8zaklEQF0PxTWc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741791546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ZvV4vKA5vYd6vr6nTnELCHn+UXS+fNwMlNQ1aAYmss=; b=PkVWaqgd1GFjeCjYjEMsjlUU9kjZtzbA5tLgTp4SLL1PuAVyMsUNyXix5t2dPn4UiSf714 z3kbGe3sC8MNdfCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A6960132CB; Wed, 12 Mar 2025 14:59:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0HkqKDqh0WfTAgAAD6G6ig (envelope-from ); Wed, 12 Mar 2025 14:59:06 +0000 Message-ID: <0b843e18-1e1e-427f-832e-f49c156ee99d@suse.cz> Date: Wed, 12 Mar 2025 15:59:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 01/10] slab: add opt-in caching layer of percpu sheaves Content-Language: en-US To: Harry Yoo Cc: Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org References: <20250214-slub-percpu-caches-v2-0-88592ee0966a@suse.cz> <20250214-slub-percpu-caches-v2-1-88592ee0966a@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5D3461C001E X-Stat-Signature: cpxbcqmmbtmdohk7s4mz3ayupnujrw9x X-HE-Tag: 1741791548-141274 X-HE-Meta: U2FsdGVkX19ZmCD/+HbnKMILKabAv0l0Mmm8h1L3QVxRxmox/4SE+WqXCvQp/5aSBpGxg0IVbYCpZLXmU0T2Nt/MXfHmGzH1D0lMBosZErnR65OgCDVlfnD1QPtOhhkUMdPKitrSGNVg96F8sLtVbF5p4uf381A9CKp2s1LWykn9Ylv4zPPZpCoHufd5q5Jn8+sWH1QHqcDp3ZY2mwzhYT7HeB6CSspo+M/P+o6f55vDASVVCWpyA6fV5JEIwrDsbEHS6i94h9W6nirK+SOw6VEyPTY8+7zpNO/00ku4l+dnGhueluJi2brLgcrsTfg14N3Q0vbdOCyPUsZknJyH51ZuySgZZkZfbUrl1gapFxL2eJoIbkCOX41L/pia00RJHoYxHXRs/QXLRKSnBcLqwzMxzb+oMal6cickBh8TNdTPWmN/D2JRQ5yAok1sCHnGpmqMChUd1JO0Wn8p9LT3vhMSNMTRFwpV1AWVNtt3tj7kYbHLIuTz3Y3/yQIUXYBLQQKqEyayqOoUWkqC4mSZxTJWBR7NNkkdK4OLL/LchpZYnQ7Ds95zpOB2CagLldKqASsZASsAOavNW13pCdCg4aT8CaIAvrKCuFI3TGQZ309Pc7zy/b9zCRQfTaKe55dN2//+chlI0qWK47P3uX0Vi2VB+HJ88OFwRNch9448nyTBGEZlmmbkDVtoybHgTHWWxFDcIG4KOz0s/cmkvuSDXYBQE7kjc6txDz5FWn7ay08L9Pdie67k8nTPUj8eTPwo/m3pOFkobbYwX+cFY9+FTxuixmIJAyhcQDZMRYq0H3Fkjxcon0uumVGrUqgkt8zJIEuVUbSpnatP59NHEngrIk6sxwMe0OKq3kcPvpJ21Vbdy1sVakVMybAt7DpIuJa8J1jJfth4NbdYaKaWoxmm6yRB3GsHJD+H38+gK6EZo4YkfHwcvyvLbW88+yFky4JgSSiMAsRqIBtk+YvnZG3 XBRAANLv 52ndP7RKKpjDnDC4y7wpUSsF1NaydIK/ytHc3GH7LsGCMUgdaYjoOxGgHg9U3VnPZCZC8elPJKq/mR2cfkm1qmdTT/aOdiQSA863+WktSvzGURodJQ+AYJIXorS9Z/NQglkpiRAa0cE+x0WmV8PdmYDtxtmEe/RXb9lWwxtPejsDAiJ+/D4ys1yZhRJWKZdAt4OfdkQQT1XpY/6Aagngk6XwBux+fkLzQVjeGxbZ1yA+ZtBLrzynx/yefbtQow4dEUy3yiDMpOEu8jhs7hSRsMpkyzelHjMIb99xIIXnrGZ7NzezLuWMcOpSPLy1ZSIUajs1IkhLQhRsclLvL5kkWXpqa+xnC6GZE4yhl/VtN7KkT8vE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/25 09:04, Harry Yoo wrote: >> +static void barn_shrink(struct kmem_cache *s, struct node_barn *barn) >> +{ >> + struct list_head empty_list; >> + struct list_head full_list; >> + struct slab_sheaf *sheaf, *sheaf2; >> + unsigned long flags; >> + >> + INIT_LIST_HEAD(&empty_list); >> + INIT_LIST_HEAD(&full_list); >> + >> + spin_lock_irqsave(&barn->lock, flags); >> + >> + list_splice_init(&barn->sheaves_full, &full_list); >> + barn->nr_full = 0; >> + list_splice_init(&barn->sheaves_empty, &empty_list); >> + barn->nr_empty = 0; >> + >> + spin_unlock_irqrestore(&barn->lock, flags); >> + >> + list_for_each_entry_safe(sheaf, sheaf2, &full_list, barn_list) { >> + sheaf_flush(s, sheaf); >> + list_move(&sheaf->barn_list, &empty_list); >> + } > > nit: is this list_move() necessary? You mean I can just do free_empty_sheaf(s, sheaf); ? Yeah why not. >> + >> + list_for_each_entry_safe(sheaf, sheaf2, &empty_list, barn_list) >> + free_empty_sheaf(s, sheaf); >> +} > > Otherwise looks good to me. Thanks.