From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAEFC43334 for ; Fri, 24 Jun 2022 02:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D84088E01A1; Thu, 23 Jun 2022 22:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0BEE6B026B; Thu, 23 Jun 2022 22:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BABA88E01A1; Thu, 23 Jun 2022 22:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A45A96B026A for ; Thu, 23 Jun 2022 22:26:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 747AC3590A for ; Fri, 24 Jun 2022 02:26:29 +0000 (UTC) X-FDA: 79611540498.01.6F56EBB Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf11.hostedemail.com (Postfix) with ESMTP id 5A62A40026 for ; Fri, 24 Jun 2022 02:26:28 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LTgtc3q82zkWW8; Fri, 24 Jun 2022 10:24:40 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 24 Jun 2022 10:25:49 +0800 Subject: Re: [PATCH v2 1/9] mm/hugetlb: remove checking hstate_is_gigantic() in return_unused_surplus_pages() To: Naoya Horiguchi CC: Andrew Morton , David Hildenbrand , Mike Kravetz , Liu Shixin , Yang Shi , Oscar Salvador , Muchun Song , Naoya Horiguchi , , Linux-MM References: <20220623235153.2623702-1-naoya.horiguchi@linux.dev> <20220623235153.2623702-2-naoya.horiguchi@linux.dev> From: Miaohe Lin Message-ID: <0b69e3ef-0123-4575-b68d-4d9b2067aa0e@huawei.com> Date: Fri, 24 Jun 2022 10:25:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220623235153.2623702-2-naoya.horiguchi@linux.dev> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656037589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUqCln7Pqx4aoXalK+UcByuwLgil+brmtQ6olyjT/Zc=; b=C39G3t88hrneETKCQYYQ3euNIiY2pOCR37ttDkDmcr1Pla0WeemNl4f/lQehCuW4jrnlEw a9FFC+fpBOvl8A98UqtTDrnUVNjMcFO/JkbAYdSUmyO0Fa2jaQHXTqb64hYkEG7uOnfuoV jVR3W9gP3x2Rc0NZLj2TLaskL0Uc7xY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656037589; a=rsa-sha256; cv=none; b=gTN0hbwWXiVf4yRvol419ZrMGBGu6+pzY/C/WWkv66jmM7DcWYOmhthFSPci+6VkP9y5Gp yUf/d7dSwjwnlJK7ucmredECOawrL2zTgML2ijXFNW3O0FgmshJ5EUGjLJ5D0tVfAKrFFM j/ZfKv/hlJ6R4nLxAT6E7a9hExT77Lc= Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: ikssyfgzjzsg5i93p9b36tngyjq5h63x X-Rspamd-Queue-Id: 5A62A40026 X-HE-Tag: 1656037588-991679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/24 7:51, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > I found a weird state of 1GB hugepage pool, caused by the following > procedure: > > - run a process reserving all free 1GB hugepages, > - shrink free 1GB hugepage pool to zero (i.e. writing 0 to > /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages), then > - kill the reserving process. > > , then all the hugepages are free *and* surplus at the same time. > > $ cat /sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages > 3 > $ cat /sys/kernel/mm/hugepages/hugepages-1048576kB/free_hugepages > 3 > $ cat /sys/kernel/mm/hugepages/hugepages-1048576kB/resv_hugepages > 0 > $ cat /sys/kernel/mm/hugepages/hugepages-1048576kB/surplus_hugepages > 3 > > This state is resolved by reserving and allocating the pages then > freeing them again, so this seems not to result in serious problem. > But it's a little surprizing (shrinking pool suddenly fails). > > This behavior is caused by hstate_is_gigantic() check in > return_unused_surplus_pages(). This was introduced so long ago in 2008 > by commit aa888a74977a ("hugetlb: support larger than MAX_ORDER"), and > it seems to me that this check is no longer unnecessary. Let's remove it. s/unnecessary/necessary/ > > Signed-off-by: Naoya Horiguchi > --- > mm/hugetlb.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index a57e1be41401..c538278170a2 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2432,10 +2432,6 @@ static void return_unused_surplus_pages(struct hstate *h, > /* Uncommit the reservation */ > h->resv_huge_pages -= unused_resv_pages; > > - /* Cannot return gigantic pages currently */ > - if (hstate_is_gigantic(h)) > - goto out; > - IIUC it might be better to do the below check: /* * Cannot return gigantic pages currently if runtime gigantic page * allocation is not supported. */ if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported()) goto out; But I might be miss something. Thanks. > /* > * Part (or even all) of the reservation could have been backed > * by pre-allocated pages. Only free surplus pages. >