From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18110D5B154 for ; Mon, 28 Oct 2024 21:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DC176B00A9; Mon, 28 Oct 2024 17:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88C5D6B00AA; Mon, 28 Oct 2024 17:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DF096B00AB; Mon, 28 Oct 2024 17:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E9796B00A9 for ; Mon, 28 Oct 2024 17:00:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E8A17C0268 for ; Mon, 28 Oct 2024 21:00:10 +0000 (UTC) X-FDA: 82724227950.12.794AB71 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 077A34001C for ; Mon, 28 Oct 2024 20:59:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FQrsIqMB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MPB0AEQh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WkTgtwGx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="o/eeHX7Y"; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730148998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MIu8nbphfr0kRpJXu0L3XhSe06h41uBB4XXp8vIsjxU=; b=50s4gRo2+eWjB0jJTPHCTYOoottq/mVC8Ecjdmtkmo4384gpTwwLi5CC7aMSclnwXTl4C9 +lQWZkJk9U4WnTeM0Yt0wxTF48zFHVnlBTOmn2fj21Mkh8sdO+KDmfznGj4G2i9J/+hQkt LLYLhoes3ohlGL8Mm/gnomVBQtOVPo8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FQrsIqMB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MPB0AEQh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WkTgtwGx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="o/eeHX7Y"; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730148998; a=rsa-sha256; cv=none; b=kZ9wRDP/QqYU65SmDtWa+sMcn95Y0m87eCD/otk8K81MwTHSsoawoZ2pGIR3V1Io8PTaFZ r24PeQiPEiY5BqFuE8ahelOzPTFh4WJLvL4iCs2S4YBI6hjQbEeGIXC7HGVM8DwnPuuvF5 98CJ7knq/ihyFvOsDU4pYPzclhkzn8c= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 94D911FDB4; Mon, 28 Oct 2024 21:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730149206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MIu8nbphfr0kRpJXu0L3XhSe06h41uBB4XXp8vIsjxU=; b=FQrsIqMBVP10UOIMfQvrX+aobJcjBh7NVYsyW41hVX9BmQ+//g5HdDepr0L2CwIac1AH2s 4BEaojhyk2KZ4p9im60xvzurEd9dyD5W8hldNl/V9e6VcwDwxdwPsGMOlQgmpdSTFDlZw6 5JNIuKMMGkY2vgjRR6+5JWDxmk2/wkU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730149206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MIu8nbphfr0kRpJXu0L3XhSe06h41uBB4XXp8vIsjxU=; b=MPB0AEQhutVquFsbMPAPyr4KT05AUMlM06orXwlKpxm7r5ftfbhFTIpCZBwWxYi8bh4eFl rRPqTg19sGNodGCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730149205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MIu8nbphfr0kRpJXu0L3XhSe06h41uBB4XXp8vIsjxU=; b=WkTgtwGxafHo3jqf8s0DkgSAtYnyWxW9Po1ya/Q+HPeSMaSryT7B0l55Czayr1A7sKfZbD NsAXUMCFKJcMm4N2hnqxCwwis/eTTxBgJfTJvs6VAsSFQwKCu6p11wZ2FqcdUDk5ii+wmH dWZA13rE+weuIwA7gVr4VSfAZnne9QE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730149205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MIu8nbphfr0kRpJXu0L3XhSe06h41uBB4XXp8vIsjxU=; b=o/eeHX7YK1XUT6/NSl54j2oHJBm1I27JN02FaM2tXuEjtXKo21efrTp4andrnl5/3p181s srA3iv17R1Z/1CCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76F1D136DC; Mon, 28 Oct 2024 21:00:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2ImzHFX7H2c+agAAD6G6ig (envelope-from ); Mon, 28 Oct 2024 21:00:05 +0000 Message-ID: <0b64edb9-491e-4dcd-8dc1-d3c8a336a49b@suse.cz> Date: Mon, 28 Oct 2024 22:00:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Content-Language: en-US To: Linus Torvalds , Lorenzo Stoakes Cc: "Liam R. Howlett" , Mark Brown , Andrew Morton , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV References: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> <438f50c5-8b8c-444f-ae85-10e5151f3f24@lucifer.local> <57mgmdx7wgfwci3yo3ggkmcnm3ujamgkwcccm77ypvmer5tegn@opiq3ceh2uvy> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 077A34001C X-Stat-Signature: 6czia681yjg9n48aiuqrtw9coh3rapuy X-Rspam-User: X-HE-Tag: 1730149177-879033 X-HE-Meta: U2FsdGVkX1/HR7GKbsDDyF+RDYbreRSICDximuAbcRLtO2DqWpRaKC1jlUw9vZa/xUNsQ/hGX+BxFAwSOUgzClXxRkHE0c4cWimdT3oIAZn+TYcUSsaqO1MwaAC/mZ+RBTp6mX8RW7ZVD6G/uYuqoavwxktcWTec/YYsT64UN/pIOj0cubfk+8ktwoPpM4NXtmhfuBQArAOObf7A0dNsE/IPDlWJ1CTTJX4C1A5d+BpvOYpB1EmIfkmN9wO7mCAD5bZIKWK3WBqCxCxr1mJgxlSBs+LKJhIUzP0S5O4L64Yn+6iPEaa32yXqTl8BOgOekZ99W6zZhqgd8khzyoihKMkJwBI+a+rHNflErLTsEHn5vbzO77mjmyBVBb0glc7VdcgvhtCBOcTVvNWyLTCmsStilNkF+5McSMGcghDZV40PrshpwWFu8dMIFT4j1K+iMJpo9xUvlj88QzjwuMJSnuHEqg9PBPPfKbCqx+C1ofSfIcCpDPnBj1M7C9beJMVbNY1OTl38aPutSiuQRNEPFPGhh5O9XZ+hqs/UHx3WffJ9abaz82JrS2ZcqbJp2PEJb2Z0G3fo1K0mU5ATPiC+Zx7b/t1zcSR3X89GCCJ6Nyu/zWGP/pQZSJciRhgjdHIjeKtTmxf2yZtYg1K+l5FhFdCc8ktBxWCfRpMosukiTs0JWeVpaO9+5vV0pFzmOTdv1exPSjAfMby+3AfWb2fZ5A/cop90+nGQA5s+YsT9XLUQ3Jp4wlALYtzVe1T9DeB8JpXYv6sKqS0sOUfwrTkHM3sY9vwuvVv/tQ/LeqjAs4ldkx4N2DocGlYh5YnYlc4FmZD2KoYKFXv9dDf7ZDTyyUrdOaA3qvHn+ZgLDLk0gy4dbN+bECYyaiDEqSSKGvvMvXFHF64/eGBqSKlJwM59c9E5QfPX8vKBBHbS28rEC9O/AyTlY/iD4dJ6BsjwnYec9RU20jUzymLpCAM6SWE ORX1jTER XDq1KVesMcb7bT+I1KhsPzVS4vLqWD5F5Rj7Lc6eWxhDs9m1YBaevhVwbE+JIaWfxs+FKcfkj3Ay9Og8nqoXseXdatOY++hwhbvQH3eCWey7cLw0UxxvvYE2sht3tr+Sjcj0Ox+VbBRRztiL4IAVY1v0RemN51uz3/1r9FXFz2oaA86+kqiZFbmDGxPKV6VNMV8XABQ7mDopFE8iYciHo6Aj0PYhdSFtcPt3nE+0Hnjy84pL9IBjIavd8LokBus4YG1H1bjuba3RKN2Ad7mFL9Zaw4l45lfJVjoM0dkEYfmnVFA08WykGyVtT1IHkhViQ2i5X9zUgoYlDwVEkh4/gWteC0/jm5A+8IRzflIstPrLQc4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/28/24 21:22, Linus Torvalds wrote: > On Mon, 28 Oct 2024 at 10:18, Lorenzo Stoakes > wrote: >> >> I'm genuinely not opposed to a horrible, awful: >> >> #ifdef CONFIG_ARM64 >> if (file && file->f_ops == shmem_file_operations) >> vm_flags |= VM_MTE_ALLOWED; >> #endif >> >> Early in the operation prior to the arch_validate_flags() check. > > I would just put it inside the arm64 code itself. > > IOW, get rid of the VM_MTE_ALLOWED flag entirely, and just make the > arm64 arch_validate_flags() code do something like > > if (flags & VM_MTE) { > if (file->f_ops != shmem_file_operations) > return false; > } > > and be done with it. VM_MTE_ALLOWED is also set by arm64's arch_calc_vm_flag_bits(): if (system_supports_mte() && (flags & MAP_ANONYMOUS)) return VM_MTE_ALLOWED; And there's also this in arch/arm64/include/asm/page.h #define VM_DATA_DEFAULT_FLAGS (VM_DATA_FLAGS_TSK_EXEC | VM_MTE_ALLOWED) So it would need to all be considered in the validation if we wanted to replace VM_MTE_ALLOWED completely? > Considering that we only have that horrendous arch_validate_flags() > for two architectures, and that they both just have magical special > cases for MTE-like behavior, I do think that just making it be a hack > inside those functions is the way to go. > > Linus