From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D20BCE79AD for ; Wed, 20 Sep 2023 10:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A25336B0141; Wed, 20 Sep 2023 06:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AE736B0142; Wed, 20 Sep 2023 06:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84FB96B0143; Wed, 20 Sep 2023 06:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 72EBD6B0141 for ; Wed, 20 Sep 2023 06:00:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 289E2140EC3 for ; Wed, 20 Sep 2023 10:00:52 +0000 (UTC) X-FDA: 81256531944.25.1A13318 Received: from sender-of-o49.zoho.eu (sender-of-o49.zoho.eu [136.143.169.49]) by imf19.hostedemail.com (Postfix) with ESMTP id DF8AF1A0032 for ; Wed, 20 Sep 2023 10:00:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of carl@uvos.xyz designates 136.143.169.49 as permitted sender) smtp.mailfrom=carl@uvos.xyz; arc=pass ("zohomail.eu:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695204049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivU1Q3Lm3SRkvOu8dDzPYKK2MzEusFDp8L1yK82VhDE=; b=co8PlD6F7pyxkRYRX0ggEE2UVRmKZyOrirbL36KgNYJAUSINa2GcQ8KSH09hs/oJ9zdgx+ oDRVx0PO2wQpJCvsJ7SQkABEzucFbqxQL25P65mUOYGTXanq5zAEppRscA4U3sviUlDshU WNDZkFKe4gBBjzq3mSkrDddh/HnMD9Y= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of carl@uvos.xyz designates 136.143.169.49 as permitted sender) smtp.mailfrom=carl@uvos.xyz; arc=pass ("zohomail.eu:s=zohoarc:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1695204049; a=rsa-sha256; cv=pass; b=AyrVU6XiHTu6PuYyqTxVz+6pF/HyqeAQU24pWnMr6aFKCG30zbPMxK4FQ2ADjyMxky97W3 sOAITMZuT1yBO/ZqAmFIywStgN2FEo7/Oabk+ZMB54ajns/f2G/7lOYrg5Gr/3NZfa/Xpc /TmJr8uaFsugH9RmEx27ak5wq5mmJtM= ARC-Seal: i=1; a=rsa-sha256; t=1695204020; cv=none; d=zohomail.eu; s=zohoarc; b=aPF06cmUj0A63kCGcCQK8JxxdOlZLE4g5au+qDUpIxUYZv3MQV3Rnxx05dJc2LFMkm2t72132GKI4HSIGkcc84mE53luY3rSEuD80U/3mAR+pPGXAhBReXVb5lu/1zJbguJlb8QRtIN9rBPhcen/DXx1Swpw8c25NPnQVVH7Zxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1695204020; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ivU1Q3Lm3SRkvOu8dDzPYKK2MzEusFDp8L1yK82VhDE=; b=bjXroVLQkynczCeCxqxd0fYRDsxpMhvCMoSkuJY20f4Taree1+gNPDeE4wHXMzYBF1fyInZUlAQm1NHHxfwdUY24svMl7t920LaCl2RCkqMuEdWBYCA47e28tQ5WTiTA+yLCokTIShglDhg6rxAhRBB9rkPtjB0NMBuccoHuN9Q= ARC-Authentication-Results: i=1; mx.zohomail.eu; spf=pass smtp.mailfrom=carl@uvos.xyz; dmarc=pass header.from= Received: from [10.0.0.2] (ip-037-201-240-033.um10.pools.vodafone-ip.de [37.201.240.33]) by mx.zoho.eu with SMTPS id 1695204018039776.6738542916296; Wed, 20 Sep 2023 12:00:18 +0200 (CEST) Message-ID: <0b5c436a9772b3dac647a5981e50881f5c22c137.camel@uvos.xyz> Subject: Re: [PATCH v1 1/2] mm/ksm: support fork/exec for prctl From: Carl Klemm To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, david@redhat.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Wed, 20 Sep 2023 12:00:16 +0200 In-Reply-To: <20230919205158.1897353-2-shr@devkernel.io> References: <20230919205158.1897353-1-shr@devkernel.io> <20230919205158.1897353-2-shr@devkernel.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-ZohoMailClient: External X-Rspamd-Queue-Id: DF8AF1A0032 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1pi95sa36jxqf1jgeuq4nwa5yy3ubg4z X-HE-Tag: 1695204048-690991 X-HE-Meta: U2FsdGVkX1+ZQ/CSguCv4wTKin7yGibbOfy+veljRKp9BFqyJsSVaWehc8mTcupJdhZInD2D9cHcKn1V6pu354zPKjIantxjYhDrv57K0m085Vj2Cu+IUlGZMmQ2JKEoDAhpDFviUw9ABgotbg6HmN0Y51fERsLh+bWcOCGEG47UGKyDl4Rl5Y3WZ+zC1y+0f82Z2g5BxsrDhgOxW8NlV+AtpeZzsIdWlaYM4CJtqw7x074fXL2NT//kuNAHsptuRLn4ch4OEewpTw05ELWcXfWIwQcAfVnSLYvigiCQleu9cIq3wHiB8+YGWOPWh3yGZ+ku738V4I42xUQKmCBHFNVODPIHHUJJn8w/DIDF/VhZxDtRD46Ut/6auKEXZfp8Ob/Y/huBiAYx3Y0WRoNO5pbkBnf2QOk6zviIJ2EQHwTXMXgQeJpYnJ9OwpNChkYjo1Q697+bit1FAIL6rOju2QUmEiaY/Pi1TXSqW3332DYI1u3osjVN3Q6njaH9lsWaujm9sREQ5dIO/hyDw2umnDBqp66x4ypLd5VxC93ItdGpkbiPWzzlCwFjtISpGJT9WvMjknR37kzF3Lr1ExqS4ow0f6XtlO539SSq37K+iUbSJF+d5Pmv41QxfMN3eZezC2ZOyAeuapqMUS/0yzypdJ8vxW87d62HjHb8vpsy4q0JpuvaLheuS1VHXGhUPPYSuCVTaaLZZhumRcHPflKOvSmjiqkyYlzCzZQk5cmqHQKMw6y/PlJihbnLkRythFIWk3NYMEsQDOXkprqL8XX9wQO1EG5D07f3L04Zd5Ioja90dUbk7vvyJjMQWew7Oc1IHZER/TzWMm6g5MPpKWuhmcQTw6yDuEbHj4OTCRmFsBP1jIXt5RSbxGKFa4bqpW3NznArJaztmdp5Kkboz+oaCsctXEI77OEZjvZRKsAq/q5J4P9dXrxGczuA8oIhQKTu8Gs3usNV7u8Kk1+Kps9 hSQN3ld8 SJtXEc52Hh6Ep3vQxziR0JnJcRBeiPxpITYXPwRpCRMc6r19jzAFfzpdRSfsT4Zb2pmdiIHtImaa1n+wfQi7mL8MvtNsOkynVP6PhrVptxCUw6Z7Q/pPNDYt25II39nMBo3MMePwP7dVCbJ7avFNjGuMtHqrCOX4H41EMmfLSkKoDnfSFTMDNYOVYAfL922XjUrmKNrhufs774RKPIgd/nDxaJ5FlYcYfQ8fsQ007pTndxftzVBV/YCmKyJ/+JRAT9h2v2dfSWP4VY8ETIT1uyu8pqWB+A2FORLmoSbUSCGL2B27dxImx7vZSHwyZ/uKJIdmEoozIP2d5OGJlQdDAcImV2F8dRodMcFtaiYxK6cZq9r2vHwzg3haEMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2023-09-19 at 13:51 -0700, Stefan Roesch wrote: > A process can enable KSM with the prctl system call. When the process > is > forked the KSM flag is inherited by the child process. However if the > process is executing an exec system call directly after the fork, the > KSM setting is cleared. This patch addresses this problem. >=20 > Signed-off-by: Stefan Roesch > Reported-by: Carl Klemm > --- > =C2=A0include/linux/sched/coredump.h | 7 +++++-- > =C2=A01 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/include/linux/sched/coredump.h > b/include/linux/sched/coredump.h > index 0ee96ea7a0e9..205aa9917394 100644 > --- a/include/linux/sched/coredump.h > +++ b/include/linux/sched/coredump.h > @@ -87,8 +87,11 @@ static inline int get_dumpable(struct mm_struct > *mm) > =C2=A0 > =C2=A0#define MMF_DISABLE_THP_MASK=C2=A0=C2=A0=C2=A0(1 << MMF_DISABLE_THP= ) > =C2=A0 > +#define MMF_VM_MERGE_ANY=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A029 > +#define MMF_VM_MERGE_ANY_MASK=C2=A0=C2=A0(1 << MMF_VM_MERGE_ANY) > + > =C2=A0#define MMF_INIT_MASK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0(MMF_DUMPABLE_MASK | > MMF_DUMP_FILTER_MASK |\ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MMF_DISABLE_THP_MASK | > MMF_HAS_MDWE_MASK) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MMF_DISABLE_THP_MASK | > MMF_HAS_MDWE_MASK |\ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MMF_VM_MERGE_ANY_MASK) > =C2=A0 > -#define MMF_VM_MERGE_ANY=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A029 > =C2=A0#endif /* _LINUX_SCHED_COREDUMP_H */ I can confirm that this patch works as intended for my usecase, you can have my: Tested-by: Carl Klemm