From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FB9C369B2 for ; Thu, 17 Apr 2025 13:52:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2D3A6B029F; Thu, 17 Apr 2025 09:52:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDD4C6B02A0; Thu, 17 Apr 2025 09:52:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D55216B02A1; Thu, 17 Apr 2025 09:52:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B748F6B029F for ; Thu, 17 Apr 2025 09:52:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A720014186A for ; Thu, 17 Apr 2025 13:52:28 +0000 (UTC) X-FDA: 83343675576.14.542B269 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 3F8A14000C for ; Thu, 17 Apr 2025 13:52:26 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gwYQplTv; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744897946; a=rsa-sha256; cv=none; b=8if+JDHFOuRxpXFtqFDyyxG8ZeP6QYG9wrQqrCTHcKepP5Ay1jZlAAIoaYs5q4uqJykjfH 37V8TOyLJbuedOoSaE8TuSJuaVJSvLv7pMX3mSa/BX3xx0szgnnpYXqYQgkF4OC2+BZCgT WmzBDCK1DpTZ42vN3xooYHsKnlA16nw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gwYQplTv; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744897946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IN8nSRs5svRcamG3V9dzV9RhjQYdAen0A2gX4ysaldw=; b=Repem1l1O/XKh3mdoIkuXDzV6daJAQ1plLJY9ZrN3ofiyAkZCkHLiMPxmXeASzojGULiWH bXHEIY3Ybp/V6xUUlBaP4jBE8CaJ14HCjgAnLFuF9kQQanbhgo8JuUQ1EW7+n3iirklovk Rsg2XU7Xl6CSlK0x2mon310advdp4Gw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744897945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IN8nSRs5svRcamG3V9dzV9RhjQYdAen0A2gX4ysaldw=; b=gwYQplTvGtscg5FgmoVRGlqJmJWMAf5uLScQxOgGhWNahqZtBIuJhibqwMWE18saSsYaHg fSq+GSNStgDqnDNG9cf+5ZqofWXUbliwQpwVdRXrOvn1EwMII7qbWix2GmAhEFXJZ+J0nn fApUSU3orfqB8Zc6UuFRva85NPtNilg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-SjtjoDJlNCekL6ljCqxOmA-1; Thu, 17 Apr 2025 09:52:24 -0400 X-MC-Unique: SjtjoDJlNCekL6ljCqxOmA-1 X-Mimecast-MFC-AGG-ID: SjtjoDJlNCekL6ljCqxOmA_1744897943 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ea256f039so6714205e9.0 for ; Thu, 17 Apr 2025 06:52:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744897943; x=1745502743; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:to:from:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IN8nSRs5svRcamG3V9dzV9RhjQYdAen0A2gX4ysaldw=; b=VHxA8hWctDTwnCFqLE/c95yuEuoTZYJPHukQAxOHNlDwHuHfKarB/8h4yIyENKYhKW OFygasHH1k+AEas0duqFjiUkx+u03OYCdJFoxO8CIfozRhyZCTJyEubVRx9rWOMmpwtZ j7dnlKqVnxf4tobZuk9s3V+M5pJuL+dlWZXU0ZUD2IIy+Drr7Oa3Hz3lcwtFZXuNSs5n sfishy+1x1jlIY9P5Z3+od4N+GFg4u11kvbwPEkUCsFvsD7iY2eap1x0qsmhlX/cz9wv sZJT25gX0HDcsubYZNX1sR0MLE0WQpHaKALQ4RbDUzyma6l79IPonDbyHvhShjN23+uP d8YA== X-Forwarded-Encrypted: i=1; AJvYcCXg4q2cM80fToScboBhJ5lL3CPimX2Ow2fAD1bNlxY03Bd0QZ4v4yjCnecBf/yvuRcOP+bUv7SVaw==@kvack.org X-Gm-Message-State: AOJu0YzDInQ6+f9PuAyyOUwVwIyF4A1JI+Ny8NBRYICSMPPd8njjHb9T rpaLwGuwLp0mOF6pDs90ckF8wKksBTXpu4Swfa+XKh1UxNq0J/Dbs1WEC8LpXk1pVFc1goPJpUV O0AQc47V2I/Qw1TU+LS0Bjh3h+OwHW3ctZtQy1RqEx0zkokRz X-Gm-Gg: ASbGncsKsU4yJMmbXaxp06rkRMoYtzxh7acV3RFjatgDrtgkWEQro1tBPNgxO3ogrwN keMUdRVNnp41CGmm0GHLOm6YQZlX3GbqD3Ztn3wjTCplIE11BXEaKqKJ3NLuZ41azVBL2+kxTH5 F3zBoiWsn64wwwVD26E7NnzIP8tlNqWTUESTKhJPOIZ1hK5D62Fk46tl2LoISa8jzXo8ickE5Op tlSAGF4Sz5NRVwc87x9jvtSE3DzDSEC50m9X4hbVHACdHYUlqG+vSftNxuXrYTjYANOKU0qQDG1 orrLC3rRKCjou/lOHD8mOOusyLLYAs8MTYNvD+4l0b7LZ+q6Y7YCc7dyCdRHyOa+vrWIqwRp3dy jj0kOM5ax8VE6GIrujxAX+OwoOgPQDxF2wKNGgAM= X-Received: by 2002:a05:600c:3d9b:b0:43c:fa0e:471a with SMTP id 5b1f17b1804b1-4405d5fda13mr59396415e9.5.1744897943086; Thu, 17 Apr 2025 06:52:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6Z4b5I5yEI1TXgi12OaFGUxCYPV4I7oEVR/lkHT9nbZK5yLlU6S5NIYAx5ZCDvtrRX1njBQ== X-Received: by 2002:a05:600c:3d9b:b0:43c:fa0e:471a with SMTP id 5b1f17b1804b1-4405d5fda13mr59396175e9.5.1744897942768; Thu, 17 Apr 2025 06:52:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2700:abf9:4eac:588c:adab? (p200300cbc7062700abf94eac588cadab.dip0.t-ipconnect.de. [2003:cb:c706:2700:abf9:4eac:588c:adab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4405b4f3bbbsm54836395e9.23.2025.04.17.06.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 06:52:22 -0700 (PDT) Message-ID: <0b502748-3f37-4fbf-9709-afc47db17dce@redhat.com> Date: Thu, 17 Apr 2025 15:52:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/3] mm: Create snapshot_page() From: David Hildenbrand To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20250210212142.4002210-1-willy@infradead.org> <20250210212142.4002210-3-willy@infradead.org> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aNz1hZDDZWx38rldOC7sXGxMDn-aOuTJcmvmDcnCktk_1744897943 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3F8A14000C X-Rspamd-Server: rspam04 X-Stat-Signature: fyobf9fr6qxmfo8xo1xk84wuhi4h8n9p X-HE-Tag: 1744897946-958104 X-HE-Meta: U2FsdGVkX19/kAzpoNLlD/5lF5mtJxP33WQgLTSqnKrH235I7kyReFeXPBlyF91rAu7y3vCzuzr7MXwemxmyv5y1nk1deCziYLk+3ToUnaZOVJgMx7wzzClxRyhgdipry4U39GKTBcv4rStdktSgoapQk2qwcVXY87W3cXibeTK+sW1OTUWkyLZMvTsmJugHrZHmzWIl+cYdjipaMLwfyQNXoN+Dhnu4dEimwXMmThbIas5q5U72yy98TbDZiFCAmK3SaeLdYpchlmmexi0JbWO/fa3EwLtws/65rz8d1WHyGzHuP+r1IJ5IILPotgH6MiiY3l1qEIzxZPFPc1yPirlKs7u1X5W33gYNvmiqU33NsSVhgnvF5WqZbwXl2Fpn2Zy83MojVWK2hgFmNmfgkDFQYccLogJvezAZh+BsGQDdgM8N34vrsu5P8C0IkWAHdZ1duFNaq6RljJW/lHP1tVDCZGUyqIhaQ2NRPAFLrPbBy9yn0Gjv/o9HAIco6Z/vRcxre45Y9c3leMFoCkmAVdf6yZQPhbvqM6TRFyVGopdNZnbLE3fm3zjNRCg7gMJc9c5tXdxW9oajmPqoDd8iNyy/+zH2YCPX14vwGiQErZN0P27G29jsvOuE6ZstN1FGY7duvzzd1H78uQ/DfBs7v42phIfSLVWX4HTUsrKb4eWD6LW33GYHPFJLzu0gcMVARdtuYTT92EiqskUSKX01yjtNEpHZ13m+fQUbkhZtjbIJs5kbnHfXsK27bnJQX91peDjOHP+2l6xEBCr69XoNYAcgDR2/fHV7c/egSZGp+x4F1kT5Fz9cxWF/zL18m+VTFhmsfWZGSjUi7IGEo04KF6+VSNU34HTPvmgLBh5QAlRyZZk4kNCLL8fT9p9Qg0ygB88adpwQnomDDFF+pGD1hTFfluQkk7KTsEGteH//NECGcoJpIOsSEUlnqqo/6VCLPgpU8GJ0a77Zh0+8c3L nRuvTZ3K KJobjQLV1iCV/gOSouceKLS0fG2wKPtI0Q9BPd2Lls/o1efkONxkQjp930nfbDzDbwwHBiZEtnOaexue19lvIFw621JDhi73pgbAYburphd/1EpoZkm6NsA+EFLPHScWtXHZwtcVhf6RWiIFVFMNdiEM0OCXEHu6dB9d68VS3j+LzKye+0fGccuPssOu/en+hbpGZPdhZH1GRV3VlOJg+X3h5e3ogwdyrTlEjhT5WrKqECgnkbdyAvvAwRR20WgPWAj/YP3J774Seb9tWZWbG/wHp6KSzril3IS36f1DcMv4sEke6Mdw7jktzzp560G9vG/sx8Kco+Xy29tJ21tIwuhpxNO8KB9eUvSlNza1lUr1PuV6K7a0BEU7xcRGGGK8WW5Z515zPOI7PRftiEJ11863mwC+yzZ+zqFjwn5cKmRwOCdpYPh9+Qd/G7eoFXMyWBQr7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > A better interface might be something like: > > struct page_snapshot { > struct folio folio_snapshot; > struct page page_snapshot; > /* page_to_pfn(page_snapshot) etc. don't work. */ > unsigned long pfn; > /* folio_page_idx(folio_snapshot, ...) etc. don't work. */ > unsigned long idx; > }; > > void snapshot_page(struct page_snapshot *ps, struct page *page); > > Or even (likely performance is less relevant) > > struct page_snapshot snapshot_page(struct page *page); > > > __dump_folio() would then only accept that structure. > > > In the future, we could indicate what kind of memdesc the page was a > part of, and have "struct folio folio_snapshot;" be in a union with > other types we support to snapshot etc.. Hi Willy, either I or somebody from our team might have time to look into that. Are you planning on following up on this here soon, or would it help you if we take care of this? -- Cheers, David / dhildenb