Re: [RFC PATCH 2/3] mm: Create snapshot_page()

[David Hildenbrand <david@redhat.com>]

> A better interface might be something like:
> 
> struct page_snapshot {
> 	struct folio folio_snapshot;
> 	struct page page_snapshot;
> 	/* page_to_pfn(page_snapshot) etc. don't work. */
> 	unsigned long pfn;
> 	/* folio_page_idx(folio_snapshot, ...) etc. don't work. */
> 	unsigned long idx;
> };
> 
> void snapshot_page(struct page_snapshot *ps, struct page *page);
> 
> Or even (likely performance is less relevant)
> 
> struct page_snapshot snapshot_page(struct page *page);
> 
> 
> __dump_folio() would then only accept that structure.
> 
> 
> In the future, we could indicate what kind of memdesc the page was a
> part of, and have "struct folio folio_snapshot;" be in a union with
> other types we support to snapshot etc..

Hi Willy,

either I or somebody from our team might have time to look into that.

Are you planning on following up on this here soon, or would it help you 
if we take care of this?

-- 
Cheers,

David / dhildenb