From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F42FD68BDA for ; Sat, 16 Nov 2024 00:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B3696B007B; Fri, 15 Nov 2024 19:13:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1424E6B00AF; Fri, 15 Nov 2024 19:13:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED1186B00D0; Fri, 15 Nov 2024 19:13:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CCAAA6B007B for ; Fri, 15 Nov 2024 19:13:21 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4D9EE140A71 for ; Sat, 16 Nov 2024 00:13:21 +0000 (UTC) X-FDA: 82790032500.12.4448323 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf01.hostedemail.com (Postfix) with ESMTP id BD80640005 for ; Sat, 16 Nov 2024 00:12:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=juHtZTV0; spf=pass (imf01.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731715802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8aWsE6KsHqgZAR/UTPX2BOaIFAyMPoSLG9xpC4Hm8PA=; b=7vzV1zTWl0S71h4BplaRLbDVOSjiR/RXE38neWhWAKzegNMZZCTflPzn7JedojGlaC9NKL VkxrQ43/xYIdZMXtHpzqG1mmRAqNIXC7zm7okIUyp/5U8ug9wDakYDrtJ6GEtItaGyE+ZS qR2q6LQ3lxNCgC/NuDu/Lvlg0DC2c9o= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=juHtZTV0; spf=pass (imf01.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731715802; a=rsa-sha256; cv=none; b=cVOA7yrCUAuRdtagGahPPIuBQQ+xzFTzWKsQnPpqDNpTo+hpf+5CwUpmNHzjB2m6Hf4bB3 4VRqoP39tdQWvtSta0AKc4spZwPlVwBllK5iAQDx+O+PBboGWWRZDh1VSYKxprMdKR1aOS d5Op3k7rt/1zVwvkSczkN7tAEZEkiUY= Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 95E342064AF0; Fri, 15 Nov 2024 16:13:13 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95E342064AF0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731715997; bh=8aWsE6KsHqgZAR/UTPX2BOaIFAyMPoSLG9xpC4Hm8PA=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=juHtZTV0RDh+wTFwjvF/I5Cbue56gEXjd0kD3znUPuWXx2wtRwF3SiJZ6HWwI5inJ TBVBD9vnbAv41iOqcNYfHcjXy0Jo4vpPQnYC829Cp+vZARPfhAL4M9phLDROf5akb8 KGqyHrYITaajwfOdtt56+uCdzgps3Ezs57MjrN0w= Message-ID: <0b4bbd38-f6aa-4091-b7db-8b87572ad83a@linux.microsoft.com> Date: Fri, 15 Nov 2024 16:13:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions To: Stephen Rothwell References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-1-911fb7595e79@linux.microsoft.com> <20241116093458.4aa19a0e@canb.auug.org.au> Content-Language: en-US From: Easwar Hariharan In-Reply-To: <20241116093458.4aa19a0e@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BD80640005 X-Stat-Signature: z1ezknfanjaau3b3edej7xw6euenwj5h X-Rspam-User: X-HE-Tag: 1731715963-22164 X-HE-Meta: U2FsdGVkX18iigQbmPT6ibckB5xnymxoqEZEOhqNF+5ulhU9mWayeaQSW3aOSfD+ueEvglcskpS+rvJbFe1KHHX+9YH/9wTDkRxkeKwR6e1mbDaJ+i9FIQwG2By8eruVFM1oD36dAROC3vQflDa7XoCztDQ5S718V4Y13xR5TxZpAH0+B4BwqEy3J6EiDcAvcIREZosaXCbCbQPq6LACZ1yceGTX6aOJSkNgYpGVcvdHz5/EW9Po2/dzMwIonSRj9v0AR87f+L4XywhiwEha9JCpPt8O89n58Vw0XoZIbCN8KDI21y4OXXHHcBsjCX5HqsJoo8fwoy/noSugoMsXxeZeaD14KBSV2UaACAIne9xUK+oAdsaQP1YizsTGCGYpnjESEiQ+L5edkcy07Rw0lhcB3yuLZ2bL6+QR7stp3CuwTJNj8FJPgSdYgzGiw/KR5anwKd6OSCH2HnWLlCOE3JCwm21jVVxJ5hw4lfRuG09Pqb+SS5ez4NowAwqfKext/+YHzDFPzhk+tg3VYJBUGBz46qOT0EwxghfGaPh4vu24xqk5gF6P7eY7WYlF0+HX4iCdah1rgPKfeMOjpZHcTouLYaifDf117RaEHCv9L70M9hlcaa8bEer6F0+PNnBPig8M5oF5YCqVJvdqTVeAvFQUxlge6ZIr2MR520RH0SG8D6nlGnlScP2g6nnl5eFh4AEFggwtI3ycgvurSyjYyKdGVkp/KS5ZdiWzoxwX0/p1ek1E/BGLGe4QbHfHb3kyW808cEuXNNQ1WW026bpKmoFfqzHISMvSIL3ZR1fz0e7gA5TcuZUUCkiBJAF2/Jk9FSKl6dHuzqL7N8P/reyo3SYnmsslIeWB1cen9zsKt6esY3q9VpZ/2r/Pd1jwojiJLLX9Xb+lUCl62bteidhEHcWFNBKomxgtx72fxKkR5N4rDAEJQbwemMhI1+L2ZgNggt5WBGSTNdadZqcx8RD hnCyArEN Cx6A5bX8p1jYxkVvEnajD9YxrSegJYB2jJNuyNaE0LgtLxc3d2tgDzde6yQf5yPZF6qNH/LoL+QnZTVhGoqfbiK1+vyJ6V+w5huPGRxujvUizEIBdycjqeCnYKiXAGdKbYGzfmWB8sS1AsJ6T7TPl4rG40xzXV4+n2KCQFY7eqHN4RfnQCE+FUYOq8e8vlUUBmBKZBB1eT6WXBaV4YbRRZs4BDfZoa6HFdYxzBB83tgQi5DvC1PwfbAQsdoZ50T9h5ksl9jIoggwjwwrA/dF3ZsLvDTkxMc4fiTaW2iX4ONzRYBXAh54yZ5qVc8tP1DjQuAK9yNS0k/W7xCYEyU45L5MbXXFg/6psdG4WRH6F9d8rHQmqxCrmv1TSEj8iiIC+WMgCjaobrSqLHdmigswnLooaRznIQ8BrPTeC9OCme+VX0GE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/2024 2:34 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan wrote: >> >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> - [SCTP_CONNTRACK_CLOSED] = 10 SECS, >> - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, >> - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, >> - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, >> + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), >> + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), >> + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), > > You have changed this last timeout from 30 seconds to 3 (presumably > just a copy and paste error). > Will fix in v3.