From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C54C3ABC5 for ; Sun, 11 May 2025 08:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C098F6B0083; Sun, 11 May 2025 04:04:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B92896B0085; Sun, 11 May 2025 04:04:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E7616B0088; Sun, 11 May 2025 04:04:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 754826B0083 for ; Sun, 11 May 2025 04:04:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6956BE1199 for ; Sun, 11 May 2025 08:04:24 +0000 (UTC) X-FDA: 83429889648.13.355CFBE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 0B611C0012 for ; Sun, 11 May 2025 08:04:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CeJvM2C0; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746950662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UEl9h2DxU6sOnGYIOsqwQ0KLbpVncdPRN/pptzxwTl0=; b=xsuRfJLrb9iD4/vk7rCPcGkRaMLfDhOSZOCF1F1onm3Ih/G4iJj6Nucu+4SqLSSD+WbGqe gucojaiVfVeScpzH4Rc9tjUGLgu9ckw8A/buHzTmhr6kfu/OUGwpxZCcSKd2qYC3R+7Syb 9n3x4GKiz+37rtNTZdD8/fpPgSGz/3M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CeJvM2C0; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746950662; a=rsa-sha256; cv=none; b=WWejlUa/fcEHLOD6pUst9QXWgO5d0NrTKeVIg5XCUH6Hl0aQewVmnLtfaCc+cLwuSlpHjF V2w6ZO6G2hbRtu5pVtuRUM2bw5yyPEDrG/0ri/8tQHSMm3Tkcu8O9OLEpqNQ9qtUpefHXI KGbJ1cqxu/hWTKdbCqyoLHxlvfStO/s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746950661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UEl9h2DxU6sOnGYIOsqwQ0KLbpVncdPRN/pptzxwTl0=; b=CeJvM2C0plrc3cZRQ96MoO5e30yX99JUqnc+x16/P6HIVqgwTQqoj5cBKafcSgcv6nWBfj xgsTIu4nPMMQkL0r78REMKguVh1NZHGXNuvmy4nhACrqygL89kpUCF1ekNgXgsQfSjdRl/ 6sWy8TY/0z+0Ub3DjI41CaNle/5fy5I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-1yfhJQEDOTOK83fD0AYZAQ-1; Sun, 11 May 2025 04:04:20 -0400 X-MC-Unique: 1yfhJQEDOTOK83fD0AYZAQ-1 X-Mimecast-MFC-AGG-ID: 1yfhJQEDOTOK83fD0AYZAQ_1746950659 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a0b7c8b3e2so2153887f8f.1 for ; Sun, 11 May 2025 01:04:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746950659; x=1747555459; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UEl9h2DxU6sOnGYIOsqwQ0KLbpVncdPRN/pptzxwTl0=; b=uE83yImXfdfO2cO+E/bguNMpXTV70uy8zyb7AIZVJzao2GE63QKxi0XE3QfieWyj+g rcJfJwRGCvVu2r6Zj0sxwrUPIgNEv88dKFLJ/uxZidMJeHtBHbjNRiP3lh+RIR88S+lf YZSWYxKW3m2N2AQx028cxz8tIjXx54Kp0kVul/wdmGX67Uo3o0Ag7b+IBsKSyFPNqt87 SJQuQzfUUX3P96rudUw6Omj1ADFrChn0dteA0dEHnayaJQph32A8F0kmLGb6P7IZA5hD 4eRyJH79dDmlZkmZL3OHOG4yxULUGuU7um91B+5Ytcla78678vNOoTpDdhSO6BRxxVj/ fWMQ== X-Forwarded-Encrypted: i=1; AJvYcCXDTSkl0LHHInaZljf/Kds+m3rUflV2rAGjIHroROOtQwtnpNYAVUpbYWuRS7znvsRbX/mX9Mr6Mw==@kvack.org X-Gm-Message-State: AOJu0YzNtBaWjQLJdaGaECcrHdu3SFcGcE1QQNDBKoZnTEMg0t830yxT 1NuWFXYFZ2Ya9OZkMYZV5EuPDfso4ZSNF8LkmzVLxDIffdf0CygdtODJ0RXTv2j3mk24V1VPEH/ zqW0StmVtqg0UgI8pdh5nTBXxQPxxFaby/RpTGBkxu9iTi5Tp X-Gm-Gg: ASbGncvzqnuEnAfqC41w5eJnK5IcaHUo8gtxaRNH6Zh6XuM/hyPdK/+HZOzZ0y0MUy6 5oA7HEvYdwNQ2TZ4X4WNrvZux1ikL50vpfxjWdMu6lUos4Ud/AEVxz3vc9CbZZwM9zVcNoIZNV0 QY1QMqMEeoXer1PvJ5gwcp+LqEP2rd+tH85WQhOR+hZAi7q/PQsK9i11TAq2U0fVi8uMtTpNOQA Z8WJJpWZ17F8Zo0EPQzCR7SNnyRpn2suL5BO2stNiat0AGLtGxfeGuUfh3R2UKH8PW8NFTcmS7v teP2nLzmKbXnjjKK+tqOmR6hSyxSDkx5FsH3jr6sZo0ZWVKBGH7iFkwnTpR10OoiRD1BsxNXImB wt6gDGG8tXI2HiofxWMl0+nftTvVg5iPNfzT3UaI= X-Received: by 2002:a05:6000:2485:b0:3a0:bdeb:c489 with SMTP id ffacd0b85a97d-3a1f644852emr8032217f8f.33.1746950658760; Sun, 11 May 2025 01:04:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwQTZ8XHquHzrFGsAKjcaJ6vnw1Efqboxz/mY9Wng8J2VTBq88DFtARuidB7IrurCQ00j9jg== X-Received: by 2002:a05:6000:2485:b0:3a0:bdeb:c489 with SMTP id ffacd0b85a97d-3a1f644852emr8032202f8f.33.1746950658364; Sun, 11 May 2025 01:04:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1e:c400:a7bb:d0cb:2506:c714? (p200300d82f1ec400a7bbd0cb2506c714.dip0.t-ipconnect.de. [2003:d8:2f1e:c400:a7bb:d0cb:2506:c714]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58f2a07sm8720827f8f.50.2025.05.11.01.04.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 May 2025 01:04:17 -0700 (PDT) Message-ID: <0b4308e5-97ed-4a82-ac8c-a9061cb4d5f0@redhat.com> Date: Sun, 11 May 2025 10:04:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/contig_alloc: fix alloc_contig_range when __GFP_COMP and order < MAX_ORDER To: Zi Yan Cc: Jinjiang Tu , akpm@linux-foundation.org, yuzhao@google.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250421013620.459740-1-tujinjiang@huawei.com> <0a6fa00f-0e48-4101-b2ad-23c9a964b740@redhat.com> <5CD028AA-64B7-4A93-8679-AAC5869B8C15@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5CD028AA-64B7-4A93-8679-AAC5869B8C15@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OEgPhzpbcazc1B1Jsq-wna28k1bOzhGN27XR5ir8mQk_1746950659 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0B611C0012 X-Rspamd-Server: rspam09 X-Stat-Signature: tamyrpqwyypwps8kpwc5zm5az74rcndo X-HE-Tag: 1746950661-472321 X-HE-Meta: U2FsdGVkX19xFKIVR7sDq7rlpkmq2ELRPRaP5gtiN1YzCuhGKV0dId32ghbsxomIhMuxxNGGB8zHm/uVCC7Xf1obroDciZ4FgDxLGSXafZCGqE0JJq/vicWOtpSuizyTpMCMV5VVMajOI6niyLCbpda3qjvQ8bJTue1dMCpdfCPA7x/vBmpqW/HJ0yT7jvUWkGYTtEtUbUA5l2reD0cQCtpugdjl6C0P/GjcYXGZDK1/e009/o2oCZ3+2XdOUMo35gZC6jwOIQEK+I9DGQm0VOF5sHLfEvS/CvuYXb6OzhqOEW+nKU0EQgcpgxIhhBWDIAM92fISUODj7yajG7GX3LrceJ3QP8PxISFDX3XTf7pUlCzCRxxogWechgvhxa19STbxYuOkCHAOh+yWBYcpApURGu/Zel8ihH+poXUEq2nyvFtqB+9UXArFOWGhsEwOkmLTJjgKo2ayfTCTpaNJUtkYLNr/sCoHPY7IlWVSnJntRIqVlP2O0R3kR2dlvjajSH/1pPVqUzMADhE0V6Rs6MJtJZK1WnHTOqm0lG3RejdVAQveFqaiK/tRorJDO0ybBrDr7IMRhfXEcy4bF8nI8UDniSroCf8dt1r6YMUF8x7WDXsBBuwgfmBX+WIEdgN1Be8SacUxokazgOraPh0zRS22RAJmp++lm2hMBUijdjxk7LBOSx005KCwcku4HDGrd93vSIkd1u4r9xVKDRC7o4GRNZIa1sA1F+tb61ZdpsQQDSurGJhuDgSOJ67vH67osSnLBxvdCfDi4RQyYkWz4IrQi9BfIMLsemTtmMHhnGiU2Ff4GeXQVrjXLVWssgosm7Ha8TD0zCWO9dLASMqIAANdQ3hFwFotupQfKVXb6avaGsEdJaUey9qjmOwQhDbvseCZSq4YeQ2/JbuWKLkfJ0+QSPuJA8cbI23bz7H6qvn9SdoiMzvSlhM4PNBEPil8xL4ShNU7NNEHEDYJc1/ 1HaSRsop +E8+mV9BXrDRDOvMGgQe8sYvN+i2wuLmt7AtJuwnRnh6ygKBK9WqLCqcEhdU5B5O3OsXzCgLL6b9H9xf/C7b8bVByRoyssiL2/aBYCJEKFU2XaSeRZ0mTVV/C3KxPcfyesmFJ46garXWB3R84Jgli83hKgXlVpbR04DCJPpm5f7SHVhSuPyGOj8aKB7/xQC34eB2km6E0FJIFPzugIgMtFbG1x10/kWkouRgSBxZoVgEdhg0/Qu+dlIfqgt2WQMuIxH5VYvZpdkQBQFQq6gK1h8AEEUxYju28Qyqf5JXUhqbfbKfJUfJpi62cBZh5/X6acgcYBmDjU8V4aHIg30qOMOzjgQt6yFVgQT+BZDBl8/CdbrO0ZrXJ2SuW0vP6ckL0S3/EUhM9sm+zb1Ctnje42u4HSkm9nEvNaPp2110z6dIU7NsIjxa8yCJMZA9Z7XWJfO2A+ASqtGw5PzdESCC7rD9FIpsFHnOoAgRt+itUgc99SOIxqlHgOrhmEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.04.25 13:04, Zi Yan wrote: > On 25 Apr 2025, at 6:33, David Hildenbrand wrote: > >> On 21.04.25 03:36, Jinjiang Tu wrote: >>> When calling alloc_contig_range() with __GFP_COMP and the order of >>> requested pfn range is pageblock_order, less than MAX_ORDER, I triggered >>> WARNING as follows: >>> >>> PFN range: requested [2150105088, 2150105600), allocated [2150105088, 2150106112) >>> WARNING: CPU: 3 PID: 580 at mm/page_alloc.c:6877 alloc_contig_range+0x280/0x340 >>> >> >> Just to verify: there is no such in-tree user, right? >> >>> alloc_contig_range() marks pageblocks of the requested pfn range to be >>> isolated, migrate these pages if they are in use and will be freed to >>> MIGRATE_ISOLATED freelist. >>> >>> Suppose two alloc_contig_range() calls at the same time and the requested >>> pfn range are [0x80280000, 0x80280200) and [0x80280200, 0x80280400) >>> respectively. Suppose the two memory range are in use, then >>> alloc_contig_range() will migrate and free these pages to MIGRATE_ISOLATED >>> freelist. __free_one_page() will merge MIGRATE_ISOLATE buddy to larger >>> buddy, resulting in a MAX_ORDER buddy. Finally, find_large_buddy() in >>> alloc_contig_range() returns a MAX_ORDER buddy and results in WARNING. >>> >>> To fix it, call free_contig_range() to free the excess pfn range. >>> >>> Fixes: e98337d11bbd ("mm/contig_alloc: support __GFP_COMP") >>> Signed-off-by: Jinjiang Tu >>> --- >>> Changelog since v1: >>> * Add comment and remove redundant code, suggested by Zi Yan >>> >>> mm/page_alloc.c | 20 ++++++++++++++++++-- >>> 1 file changed, 18 insertions(+), 2 deletions(-) >>> >>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>> index 579789600a3c..f0162ab991ad 100644 >>> --- a/mm/page_alloc.c >>> +++ b/mm/page_alloc.c >>> @@ -6440,6 +6440,7 @@ int alloc_contig_range_noprof(unsigned long start, unsigned long end, >>> .alloc_contig = true, >>> }; >>> INIT_LIST_HEAD(&cc.migratepages); >>> + bool is_range_aligned; >> >> is "aligned" the right word? Aligned to what? >> >> I do wonder if we could do the following on top, checking that the range is suitable for __GFP_COMP earlier. >> > > The change below makes the code cleaner. Acked-by: Zi Yan Jinjiang, can you integrate that into your patch and resend? Thanks! -- Cheers, David / dhildenb