From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C82C02190 for ; Thu, 30 Jan 2025 15:52:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A4302802A8; Thu, 30 Jan 2025 10:52:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 954322802A7; Thu, 30 Jan 2025 10:52:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A7AE2802A8; Thu, 30 Jan 2025 10:52:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B5112802A7 for ; Thu, 30 Jan 2025 10:52:38 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D966E12012D for ; Thu, 30 Jan 2025 15:52:37 +0000 (UTC) X-FDA: 83064560754.20.0F21631 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6639A80009 for ; Thu, 30 Jan 2025 15:52:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=isC9cjOn; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738252355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TsPelXXasc7TSuPc4lSN7EB9eFx6gV0MKgk7ChJm0z4=; b=D5gUkNgwZg71bQmeqkL6S5bnqP21Vr2FuWuoosJgLdOcq06PjKs4XnB3RAMVgukgFxWmca vuRKIduvFlpl+icjUrixqXnvv6ExxlidAQtAk27ACENR7pFrsAEBwFgAkLNb3G/51LgB40 dRV4dLnh7D8pJmjenA1ZokdSitzn44U= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=isC9cjOn; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738252355; a=rsa-sha256; cv=none; b=Gtj2TktuoyHrLkYjNZhuubvoq9YHYFV8/acz5L3olPmDf7AR5DuA2/MQ4z3zVa1ibA67dt NpaZyIYO7mktyHzBK5FR8f1/LVf41mQW9EOkHleim41AzxG714bN8k3CrFNm3ujNYmlohl GLk5ieeQ5RL9GrSJinYbcLwDwp9Rbrc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738252354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TsPelXXasc7TSuPc4lSN7EB9eFx6gV0MKgk7ChJm0z4=; b=isC9cjOnZS7JlyrXv0NeQJ2/l8q2LVcWp8BGmfGPB978NUoSaJ4jXpjHJGnx4xjvGPwEby 8llxhBbSUKQzs3H7pz1jPqVRxAOa4DOdWlaxdte8burtnk/FwA14D7gPKS+V3E4Zhg1Tp/ trGmAAxjA95M1NVRWg+3T3YbR+07FrY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-Ha6obMjwPUOpvINjc9ZnVA-1; Thu, 30 Jan 2025 10:52:32 -0500 X-MC-Unique: Ha6obMjwPUOpvINjc9ZnVA-1 X-Mimecast-MFC-AGG-ID: Ha6obMjwPUOpvINjc9ZnVA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-438da39bb69so6158235e9.0 for ; Thu, 30 Jan 2025 07:52:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738252351; x=1738857151; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TsPelXXasc7TSuPc4lSN7EB9eFx6gV0MKgk7ChJm0z4=; b=RyTzBeNJLoPE+uAaLQP3JcW8SGSZspLpBo5Hd35DosjQuu/SqPiArWLxglevtm3ocQ buIuYb9I4bXiCWlqUXCSTTaqGT/o6ee/xbOa9q17Pj+m6DtFvVXefsAGX53uD5m9LwRg ospEp2jlo3NbYW0YE59vaLEU8DJ0h1X4LSFCuxdSTtVk17ID9cFRfytqxM/F0DLCVELG ARTQwzOxoBx6Ui9IXILxuL26dZXQs3I9PAXr/caJYeK69911OPjX0nci6THig2uFIWhh psrCzQLRyDWNKEwcySJqzRRDAMHeu3aHrQ+0B+FWRx3IHoFCe4CcLF1iQc/dbihNczaA y2FA== X-Forwarded-Encrypted: i=1; AJvYcCVVbRzk+qU2NFq/WluxumTNYg9jDwahZuyCH+XyhUzq9C1XgIsMZsimIQtnHf5ZYyDz7TcMYXm5EQ==@kvack.org X-Gm-Message-State: AOJu0YyrC7VRGcuAnFHAChYVb06zdm2FbOQIqStRiCebzYohsRalk+iX oVZhGxBxKxYTGS16Itwq4WpPePt5gZQfNpabMQ4iZURCqxhukBfCc7YsCxWuXcGlLzcnbZwkRCS +JnFl34VH2Ynuq/HEmPA9xdi1/JrJMKviyHIHGbSZxpWLlIh0 X-Gm-Gg: ASbGnctmbeE3S+VzyGs5OS1q7k4L6089kh1Mjse2oTfhBhK/JQsmDdKmlvC2BPq7RGs sBs9hBm532BrKoCAHM/G7fPUzO+NeWWgNe8YWiz/0EWcFExHDNz4uP5N74GJYv6N7Wc5GF8+ptN WHUfWUcFOgmPMsRCVJXM9NJItxOr8NMNP0b7q69weRfnnR87bTTrX3mbX3a9A7//cpbGu1QutgZ AvFCnsz7YllC3LyXKBr6krFPPmUSONHr/z8mmVtx7zIJcHMtCjrEQagAALwzbHPZXvXoIFuH5j9 tC5GmPId0k9hqYl9oEXDcsyipt6DVfEME/fbq97E3tXfh7Bf4xT+UiUigTQoPfhZOthanbVNll7 d5KS1oy1QUqxnIUAKFbrU/PdOqjO0iVi8 X-Received: by 2002:a05:600c:19d2:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438dc34b37bmr77183635e9.0.1738252351149; Thu, 30 Jan 2025 07:52:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLc0GSKvGNrlFwZzVzr9jAXl07EKtr7grPLdJmtHhU8CpAS0lhJAYux5tQ0FGwaQWq8rUmUA== X-Received: by 2002:a05:600c:19d2:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438dc34b37bmr77183245e9.0.1738252350748; Thu, 30 Jan 2025 07:52:30 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3b00:16ce:8f1c:dd50:90fb? (p200300cbc7133b0016ce8f1cdd5090fb.dip0.t-ipconnect.de. [2003:cb:c713:3b00:16ce:8f1c:dd50:90fb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438d755375bsm63310815e9.0.2025.01.30.07.52.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 07:52:29 -0800 (PST) Message-ID: <0b3a38cc-b956-4db4-8b13-c8180926d2a3@redhat.com> Date: Thu, 30 Jan 2025 16:52:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 08/12] mm/rmap: handle device-exclusive entries correctly in try_to_unmap_one() To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe References: <20250129115411.2077152-1-david@redhat.com> <20250129115411.2077152-9-david@redhat.com> <59feb709-dadc-4d19-857e-49320cca3d98@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RdawwYcjZtnpYIPpUsSEMHRnCWbWCTRSylje9ITpNhI_1738252351 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6639A80009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: s6oegkg4hh34ub9wydtfnnup63mudzf6 X-HE-Tag: 1738252355-873252 X-HE-Meta: U2FsdGVkX1+VXYlLHE8qzz59XdtDeDtojFzkL/cbPvLvTLJZvAmrWUDLuQ7iOk6XVq4Pq9CjLwy+QOfbM5c6K5O5e+cd13RHvA7N+C6rjvLPNn4WDU7TA3ICqjc8uyFhkPbfYa9DCMo77C3W9ZoXAtPUfFlH+giuFlMBUnVn0CrldBwjBjXf+gO2pvfWdFPd3ldzMZXEJ3PDw80kd71YndTaL+Bi7E8nwxJP4RB65dMUlpjgsRPfQJ6HIV+LN3ufs4xVehqrUAkc5vTbtmvGog7bhwsR4Fk3ZRn9W7f0zw81UfhgV+1HYLj+G3KkoIGEFhR4HFyE8L4qTXofE9+Th3Sun26f6NESiIdnxPgxs/r61Zpl5gOx9YfxpOrJANslNF6S1yehemvck5RyW3J02VmSdn4KuIUC2nFzJM6VtIvIzoQgzrwGFm6P/y9MUSvrE+ElU0F0I0buFzPOPKWrshfovCcPFH0gVYR9AcQvbR5WTuBVfXVkHzr/ZuAULJNKwSAl19gC9m1W4yUKTSFncR+Q4N8pK4Epy2Dd9QXF+BUGoXD1B7N/wjJWuO743U3GUQUd5B6wzv1YZr/QmEp+wOJ+p/WyLuww0z38Oe9/tALXn+3hBExNmcjUueUa0H0TrGZGpTufPvp8wuaoHV1nzG2Nhd52jQkl6OiT9dKk5MRCdRlLApaW9jH+qfks79aL1Lwuikbgmul2QlQ9MUQB7yb+KamX3Di19Rrh5bIvcSE35rC4lgPCN8TlRwronTZEs5ikPGHYSSmQUkyxpvMItNaVNbe/g6gwU3Az97yad5cRRFltGXN/xjQRUhPqlokBZikBH18fJ5swWyvO08VNy97kk5yJ8splGICsk/MtwaRaFfEZQf8kf9vXJOpcWGb7WZMuZ5yPUbz0VmyYuCTuWuilFkZuh/4CWqeoMTZAeRVlHBRMcb8XmUgQwWZ1vWPgwl7XhtdmQxXoeXoqEXK AKvlWaGB cvDsJ0cpTa2J0TvqxTq534gkmwisP1x3hsoj7zK/aYhp5dLu9xKK0jhe8YJV8pkGSSjjB9frF2dqLHR80b2bLYtJhQylclz0STpGUX9xvr2HDUGm2R5NYsKu7ySwpbM9T0vavm9euQw6Na+WuaEkKMoEK7ZfqPxhPdJT1tOLL/yH0jona63PAL8mSSHtvPKt8n6KtZfszOQ3j0sX7adti2XEXLTQXSdQujwNlqB2bAi78LDANop8HuvwQhV1ms3IkgkMnon/u09Y5bYU+H3vrbaeYJfIlsMktgxh6eMVDKsXaheIhcEe7qJ182GAxe0er+/hdXR9BwUE9KpYs7hDSj/YT3XqqhHreefcdPgfNBtlKqdatCBnuTmjK6oJn3lQxv7FyTyk5ivmF32GRr5YDTqKsnwNDzavWw93Hczwl6vbSH/dkecU+6uHPrPcbikgWbHFn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.01.25 14:06, Simona Vetter wrote: > On Thu, Jan 30, 2025 at 12:08:42PM +0100, David Hildenbrand wrote: >> On 30.01.25 11:10, Simona Vetter wrote: >>> On Wed, Jan 29, 2025 at 12:54:06PM +0100, David Hildenbrand wrote: >>>> Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") >>>> we can return with a device-exclusive entry from page_vma_mapped_walk(). >>>> >>>> try_to_unmap_one() is not prepared for that, so teach it about these >>>> non-present nonswap PTEs. >>>> >>>> Before that, could we also have triggered this case with device-private >>>> entries? Unlikely. >>> >>> Just quick comment on this, I'm still pondering all the other aspects. >>> >>> device-private memory is entirely owned by the driver, the core mm isn't >>> supposed to touch these beyond migrating it back to system memory in >>> do_swap_page. Plus using rmap when the driver asks for invalidating >>> mappings as needed. >>> >>> So no lru, thp, migration or anything initiated by core mm should ever >>> happen on these device private pages. If it does, it'd be a bug. >> >> I was not 100% sure about HWPoison handling, that's why I added that >> comment. In other regards I agree: reclaim etc. does not apply. > > So maybe I'm just entirely lost, but unless you have a coherent > interconnect I don't think hwpoisin should get involved with device > private memory? And for a coherent interconnect it's just device memory, > which isn't treated very special. I would have thought that in a scenario Jason describes, that you would still want to zap the page from the page table (try_to_unmap()) and install a hwpoison entry instead. But yes, right now this should never ever happen: memory_failure() does some ZONE_DEVICE specific things, but likely doesn't call try_to_unmap() on these folios. > > Also to clarify, I meant this as a general comment for all subsequent > patches that have the same paragraph. Yeah, I'll rephrase that to "We'll never hit that case for special device-private pages." -- Cheers, David / dhildenb