From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D43B1C4345F for ; Mon, 29 Apr 2024 08:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5756B0083; Mon, 29 Apr 2024 04:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A6DD6B0085; Mon, 29 Apr 2024 04:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31F2D6B0088; Mon, 29 Apr 2024 04:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 14C326B0083 for ; Mon, 29 Apr 2024 04:32:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 950F740833 for ; Mon, 29 Apr 2024 08:32:10 +0000 (UTC) X-FDA: 82061902020.18.EC369CA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id 1554A16001D for ; Mon, 29 Apr 2024 08:32:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKVaUyyG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=y0XMxxJp; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKVaUyyG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=y0XMxxJp; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714379528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0AvLdLa85eH0nrOtIRvo+E0XiJSOvFaO0gBqFvexFL4=; b=jW5IqjDrbVM1lT5fdjbyP/TGWG0gsMhD3hu6UhbXN3VSvyQtdddyq1rL4hqKGi/3CLaVD0 al9f+uqKgcQgEcucTKdkBLEQjUVkZsye5ThwsYcDhohi9Q03f+6X84RyHkFH6MAuYOLS8Q Ese6MoBxhprglZkCevklLVo/QCCBzus= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714379528; a=rsa-sha256; cv=none; b=HSfxz1PZwMwdeoz2LNyXiNhSt2kwM715onjRBho4XigisiwqDffNIWVfbkPUw3PC/LmIgz 3K0fb8IIB/R6MAqMJUSQTQCAqiT7gt/uD1tJXYMtTnNtK+HQ6hUAzIw8eHlBrGxmcAj2gv 67IxlgKXx/HYz4jGMTOPefSY984pojU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKVaUyyG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=y0XMxxJp; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKVaUyyG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=y0XMxxJp; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4FC66203A0; Mon, 29 Apr 2024 08:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714379526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0AvLdLa85eH0nrOtIRvo+E0XiJSOvFaO0gBqFvexFL4=; b=tKVaUyyGHoiAKsY2qxc8bDi7AEiNLcfyAXkkxnqYNJlIbJhL89YxdkJ8w0Elr9Qr+HzZbb aKUFk4ueZRQo43OD84UC8U5yP/0EXEB/aTVUS15CmmYhd0NKjjaY5LeMK4AseXC+Cv1yNw IzfpoPQmDalcCiCvvEqTI36BrsoAclA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714379526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0AvLdLa85eH0nrOtIRvo+E0XiJSOvFaO0gBqFvexFL4=; b=y0XMxxJp8zVMzeO3e1UMsC6fEz96XhxT+PkbuUUcEse+adwEUHKJUu7csAIN2IBnn+1Bah QJ0HzCvon9GC3rAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714379526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0AvLdLa85eH0nrOtIRvo+E0XiJSOvFaO0gBqFvexFL4=; b=tKVaUyyGHoiAKsY2qxc8bDi7AEiNLcfyAXkkxnqYNJlIbJhL89YxdkJ8w0Elr9Qr+HzZbb aKUFk4ueZRQo43OD84UC8U5yP/0EXEB/aTVUS15CmmYhd0NKjjaY5LeMK4AseXC+Cv1yNw IzfpoPQmDalcCiCvvEqTI36BrsoAclA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714379526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0AvLdLa85eH0nrOtIRvo+E0XiJSOvFaO0gBqFvexFL4=; b=y0XMxxJp8zVMzeO3e1UMsC6fEz96XhxT+PkbuUUcEse+adwEUHKJUu7csAIN2IBnn+1Bah QJ0HzCvon9GC3rAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3D2C2139DE; Mon, 29 Apr 2024 08:32:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oQClDgZbL2YgDAAAD6G6ig (envelope-from ); Mon, 29 Apr 2024 08:32:06 +0000 Message-ID: <0b353d34-54e1-4a07-9e44-a2be00800a1a@suse.cz> Date: Mon, 29 Apr 2024 10:32:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm,page_owner: don't remove __GFP_NOLOCKDEP in add_stack_record_to_list Content-Language: en-US To: Christoph Hellwig , akpm@linux-foundation.org, osalvador@suse.de Cc: elver@google.com, andreyknvl@gmail.com, linux-mm@kvack.org, djwong@kernel.org, david@fromorbit.com, linux-xfs@vger.kernel.org References: <20240429082828.1615986-1-hch@lst.de> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240429082828.1615986-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 1554A16001D X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1cpaut18g8k99dnzqzxsyudz3ti35f3e X-HE-Tag: 1714379527-395015 X-HE-Meta: U2FsdGVkX18Wgg188PKl/XDL685ICKmtVTIIgFmruff3AjCT7KyzMU8rPYWN1ky3K2jl0dETqH94rQggkzc2tIbVZhnWE0TI6seXr+SO3p5bCHQh3+d8mwl0ZuMtXyAhxueDvvadnLr+ioOgCappMG8hrOV2owxNbV0QTdw6dS9RjFVs/mNvgBKGAX3JSHUh50ZqHctYC6CnOcCGEJnNaVOzu8fILHNz2Eei4M7GW8N8DS415ZIxgWBWQvZCx/ZHZ1+/gIdDGnfzzLf2l0YFF8xfIkx8JU5wakHRQ9ju75OlCLBHAu+wndX7mPZy+RSRNhoyJsQpQDnoqLBq4lxEM6GCNUW+YIo26i/HWuZpNvN+aDl0Uo4qXY4lfD+zqOcDU/KH0v4bYfifRtAX3yPn5YplIb1ecuXBBruc+d2tIGcafUNzd0Hj2CS7b5bZ6dm8bb0ANtgcY9l3HElAc5K5ZB2X11IWkRBQfidM3TceCcCF7u8CCnw+Yp8i2kqqe1SI6XKaw3ZaKz3noxMbjH527zyMy7U8KF2e8JDcT5zFO93X5974dVYuWFqNeYe2SkxOLYgoDTDdtFySTF+SDOie3mGTaHLzyBXpSanqtxcdiDDUsyF8K7E5hOyVQFkhfp7nmXTCUY/XOysVf2aYAxGw6D8kaYrGkpa5klvSVlEwHzEwIoBMsLJMvwkS7oC5BNgijTgqL0HNZGUUkZGigpkWRGIHKJKhCgpg0FA5ukvA3VhRrDNRM+cbYoM4FMAGVq/bolxNAJ19UIhx7+h8E82qVvPyT/Z7vWF9c1ldmYfxiaM4UPb+TObjwQZdwI39ZvQ/u+q3BuxlHaxBy4g1TLkoSeI/px8zhI1sUHAYVGlMae/tO+yy9nmqTiH5oMqd6Es/C0flDx19fGM4W+jc1gXwrWMXMsHxHWo+JJWJ/XXV9IjQMlXbfEHgrSA9X01VL2DTxRGr//eHeW8nmBPaRLc X0AeRf9y PmFBXN+TDd7N6v/51oEC6YlRCDN0l3dF8iQUssKPDm93GRx2+Ax94vRVdWpF3AE7ICzepKRnBzL3fTJHrp2BROjxyez2WJs/vJHW+todFVHy8PZ6os2dYpn5QR0tdWW/kRAWrJtIjTBCLk889eUAgq/iI5GPeyKbqczHZNAclUrT6goUg4snZwfPstyNy+4mt2a8KMHF06cSJxHp2C4Dj/ozRaM9JrAeHKqTTUBISx+c/l+xdJ18U0E3+aI/VohU2lmQrfxpj+wRn1Rv4ntd6q6tY6WudnXxTxlYB3yXGEyVbA7xzGawWkm2yfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/29/24 10:28 AM, Christoph Hellwig wrote: > Otherwise we'll generate false lockdep positives. > > Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count") > Signed-off-by: Christoph Hellwig Reviewed-by: Vlastimil Babka > --- > > Changes since v1: > - only pass on __GFP_NOLOCKDEP and leave the other masking in place > > mm/page_owner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index d17d1351ec84af..428c1ea8b4579e 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -170,7 +170,7 @@ static void add_stack_record_to_list(struct stack_record *stack_record, > > /* Filter gfp_mask the same way stackdepot does, for consistency */ > gfp_mask &= ~GFP_ZONEMASK; > - gfp_mask &= (GFP_ATOMIC | GFP_KERNEL); > + gfp_mask &= (GFP_ATOMIC | GFP_KERNEL | __GFP_NOLOCKDEP); > gfp_mask |= __GFP_NOWARN; > > set_current_in_page_owner();