From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8179C41535 for ; Wed, 13 Dec 2023 12:52:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30E316B02C9; Wed, 13 Dec 2023 07:52:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FAC86B02C3; Wed, 13 Dec 2023 07:52:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 025E16B02BB; Wed, 13 Dec 2023 07:52:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E134B6B02B7 for ; Wed, 13 Dec 2023 07:52:07 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B721140610 for ; Wed, 13 Dec 2023 12:52:07 +0000 (UTC) X-FDA: 81561782694.28.F34E281 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 5CBC3C0007 for ; Wed, 13 Dec 2023 12:52:05 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Bo7/GC8+"; spf=pass (imf10.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702471925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q9EqIwf08LmEIH+cEN/dULDXznjNTZrCAOaSTuIwhOA=; b=LiWWGi71eiG69oK+v67zIztCONi/bHPm3IIsFDLyDIOPHP6lOaWse/W6/bjbMoKPrMPvaK MPiEKFF5dWyOkirDQQWJbD5/P2bYXkUcYGitrWpMEACWHXa3oeEgnQAax67BaTX3+n3Q3q 4cbP5Ws5TURClQs3bgY6OiDe1tDB1BU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702471925; a=rsa-sha256; cv=none; b=Jg3M2bfCKE2PcUOcF0OheL5Rk+hEtMN7Frmqq7P0cPyG5+o3zh9S7Satl72dn+HvE977Cv C2y/sRDRYAU6ffyR1uNy7pQDHvnFYma186mqsO9PRhuqY196/UpLgtebEDzxooB3G4FUA8 BHHOwVY/ehbeBeAfODVbuFZzoTfv9HY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Bo7/GC8+"; spf=pass (imf10.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702471924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=q9EqIwf08LmEIH+cEN/dULDXznjNTZrCAOaSTuIwhOA=; b=Bo7/GC8+1FoKU5ZcOlKjxScKJEDHPoF6vC9rlmxFWye4/ZwVBzIswa74+yQKdfo1YKiujJ 8V1EkiNoDPrNz//bOMVVXw/+8z9b0sfbehjAQEgzQqt/Kf8O0ECyx7uUB9jiPhY/P7FuaV 2AVjYRj06Mi3OK7yOTpQkC1gdOsDwEs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-DU10fMb_PH-4G-1E9jiTvQ-1; Wed, 13 Dec 2023 07:52:03 -0500 X-MC-Unique: DU10fMb_PH-4G-1E9jiTvQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33349915d3cso5216924f8f.3 for ; Wed, 13 Dec 2023 04:52:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702471922; x=1703076722; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q9EqIwf08LmEIH+cEN/dULDXznjNTZrCAOaSTuIwhOA=; b=XA5tvheLpt81+Hb1s2AMQafbtOkoXl6JrBHYY05Sg6pu+MKtxGYRY8OXfHZkKd/5E3 ieDoA+kLvAZ2hOpqkwU34ck0frVXwk5vxHFDu7wVjvIIq0xRzwJezuJ/luEkSidCLEje nty/N0KAh2s0umwM0jCE2NBPNbLbc3RDeeRnPWn0gL3GdndFD7j8McC9UVozdQApCHzo R6Y3q5lVsBl6qeSlXJHcFkTdvS+2rzBITl5xIPEKjY9LraVY2EpVfqqw/26fo6rofyWq hx7zXasubd38YpBEvv0ydKCQOlqG81o56A41kNxgCxFWxsExf73CXeeh5cJNegkPhHKU IrGw== X-Gm-Message-State: AOJu0YzjEZG1yyrKEhc84ZghwmpXSFpguVSGUq5Ps67cUhTw4TiqHx/H /+g84FUIn2qESdBI9kHvvFQ1eWUIlq8ixzbIHak7ck/WGq/cnVQpvyEARpIwxzcMJbYIfwwiCHM h1ZyFG+AGlZ4= X-Received: by 2002:adf:f5c3:0:b0:336:42b3:e6fc with SMTP id k3-20020adff5c3000000b0033642b3e6fcmr221045wrp.139.1702471921736; Wed, 13 Dec 2023 04:52:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGS9kEb5NuIiXVIRCHPgHr8JyshyCNd1dXxmiolZKU6PUXqbebhVxtgWC/2E00NW6AGSO/0RQ== X-Received: by 2002:adf:f5c3:0:b0:336:42b3:e6fc with SMTP id k3-20020adff5c3000000b0033642b3e6fcmr221030wrp.139.1702471921394; Wed, 13 Dec 2023 04:52:01 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id h3-20020a5d4303000000b0033629538fa2sm4664964wrq.18.2023.12.13.04.51.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 04:52:00 -0800 (PST) Message-ID: <0b2eb374-356c-46c6-9c4a-9512fbfece7a@redhat.com> Date: Wed, 13 Dec 2023 13:51:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 04/50] x86/cpufeatures: Add SEV-SNP CPU feature To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh , Jarkko Sakkinen References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-5-michael.roth@amd.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231016132819.1002933-5-michael.roth@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5CBC3C0007 X-Rspam-User: X-Stat-Signature: nxdsh9pbt358gkby1eksfeiepfy1849p X-Rspamd-Server: rspam03 X-HE-Tag: 1702471925-476918 X-HE-Meta: U2FsdGVkX1/uSRs5YRso3A3fMvPo5YXrrA74JyJxbNlbguhSfCxYQ7w0nbvQaDisyYgcjD26+fJwKntWBhHxUbextPUFhFI4Wvt0mTJMErzMp7MwyGcy+sG8ZFjpFUbQAKZgxxv9DSxq3M2Krd4Dw/e1u9jfM318fUSWKYs8JCIJhxnAQ1Omf/pDwVdqm/xtieZMIJFYsQVj0SysI06FteS0AvsSgCtQGUZw5Vso6jj31Lv2HkGpwvaY42RVJUQJFwXI2LKfwSJ+6VkstrMDT0j683mmu+so5zawkMMfa9CSGYdYuD+HUSolEfInH4gbXO7Hcvp1Pvvrs/lcFuXXmJbYTyd9h6MTQQN6cJuqs59QXsKtZqNFrUre3iXLRTJmsF93QskMwmFM75bTtS+UqFuHZbco+MPyqQo/iDA8AnFl2zw265ZJzezCi91sHODZANehC5ySjmK8DwIjFTG29/sbZzihiWUEvrRICUpXR3SMwuVEIg2NpDbX3st3WC7EqwGnc637NIh2w32wuZwZubJDloFY6yqbk7Gt/jHVuJuy5zh18bNDYdzr+YUOQA7FMPVdd8s3chuS9Zte2dF6SITEIzB/efk0cvyvK9So1aUSlm8s5UFnQ/GGQvGaCDB5tyjhIUZJz4Pw+AdWN9coUVABIAkkM5XI2J1+fblDfmMqlLLkyp4TNZDT+34ZnhNoeLLUrOz/+gvK0WZxULgAQW8DZ8fZTG0DFpLPH6UHUb9UmRRdwmDEdAIFU/Orja/ldhoUlkllHbCyS2I2OMTL2j6e1h5aN7RMKN7Ejp4pDWGc9gm93q2ZOr0FvEaUp7sLssE64EiR/97snBj/UwtOFIQ9jVoqf3TqIl7e+pK4bg0wayHxgoo1NW9Kdis/uoKoYmdx9M51Ssw23sTXK+WbD8DHu2d3nNhloAbBf1P5d2JRGzVjBlHVI1d5JYQ8c3nBhkXh1MxZYbIU0RYsFdZ 2iawhPrK WmmxZ9euw29ENBWs0N20TiFdXAVcvjBo3t7Pu0u22VudVjs5kAOvjIE4EuP8pnv8crn8YBa1DEvBbJ3+pB4RpMsmZ/TkmUwHRktReXDIQkYqya+ot9Ym/JMq0fTiNt7hqbZBCaOtOoAJBf8iA8Jk8e/BnFkl0+RrnJRNoSQ4ked36j4vCZp2vRvrBo+CFROFD0NrXxJuwo2Dp8Ve+ySdqhJp/wgwPCujOWflRUdP87l3zV4211kLy59m9M9qgnjXeLS7xYol/oP6QI9Xn5Zw0HSNyS28LdowgWoK+qVEM45um2sRo72KDF+2CvUd+Yzr9S6OLbBFPMRpyN+lzJ2zCQVZDtGTn/tYc1FJ84zy8AEdxZoIIzhua4txgAMrwMu31ze9hxXrUs7C9b4ew7kLhyWt0HWK/hoDLELJXtKBv3PlfGo3O2GDc6iSo3aJ63JHhw6GorTziFQIOvPo7JV7K9HSDew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/23 15:27, Michael Roth wrote: > From: Brijesh Singh > > Add CPU feature detection for Secure Encrypted Virtualization with > Secure Nested Paging. This feature adds a strong memory integrity > protection to help prevent malicious hypervisor-based attacks like > data replay, memory re-mapping, and more. > > Signed-off-by: Brijesh Singh > Signed-off-by: Jarkko Sakkinen > Signed-off-by: Ashish Kalra > Signed-off-by: Michael Roth Queued, thanks. Paolo > --- > arch/x86/include/asm/cpufeatures.h | 1 + > arch/x86/kernel/cpu/amd.c | 5 +++-- > tools/arch/x86/include/asm/cpufeatures.h | 1 + > 3 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 58cb9495e40f..1640cedd77f1 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -437,6 +437,7 @@ > #define X86_FEATURE_SEV (19*32+ 1) /* AMD Secure Encrypted Virtualization */ > #define X86_FEATURE_VM_PAGE_FLUSH (19*32+ 2) /* "" VM Page Flush MSR is supported */ > #define X86_FEATURE_SEV_ES (19*32+ 3) /* AMD Secure Encrypted Virtualization - Encrypted State */ > +#define X86_FEATURE_SEV_SNP (19*32+ 4) /* AMD Secure Encrypted Virtualization - Secure Nested Paging */ > #define X86_FEATURE_V_TSC_AUX (19*32+ 9) /* "" Virtual TSC_AUX */ > #define X86_FEATURE_SME_COHERENT (19*32+10) /* "" AMD hardware-enforced cache coherency */ > #define X86_FEATURE_DEBUG_SWAP (19*32+14) /* AMD SEV-ES full debug state swap support */ > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index dd8379d84445..14ee7f750cc7 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -630,8 +630,8 @@ static void early_detect_mem_encrypt(struct cpuinfo_x86 *c) > * SME feature (set in scattered.c). > * If the kernel has not enabled SME via any means then > * don't advertise the SME feature. > - * For SEV: If BIOS has not enabled SEV then don't advertise the > - * SEV and SEV_ES feature (set in scattered.c). > + * For SEV: If BIOS has not enabled SEV then don't advertise SEV and > + * any additional functionality based on it. > * > * In all cases, since support for SME and SEV requires long mode, > * don't advertise the feature under CONFIG_X86_32. > @@ -666,6 +666,7 @@ static void early_detect_mem_encrypt(struct cpuinfo_x86 *c) > clear_sev: > setup_clear_cpu_cap(X86_FEATURE_SEV); > setup_clear_cpu_cap(X86_FEATURE_SEV_ES); > + setup_clear_cpu_cap(X86_FEATURE_SEV_SNP); > } > } > > diff --git a/tools/arch/x86/include/asm/cpufeatures.h b/tools/arch/x86/include/asm/cpufeatures.h > index 798e60b5454b..669f45eefa0c 100644 > --- a/tools/arch/x86/include/asm/cpufeatures.h > +++ b/tools/arch/x86/include/asm/cpufeatures.h > @@ -432,6 +432,7 @@ > #define X86_FEATURE_SEV (19*32+ 1) /* AMD Secure Encrypted Virtualization */ > #define X86_FEATURE_VM_PAGE_FLUSH (19*32+ 2) /* "" VM Page Flush MSR is supported */ > #define X86_FEATURE_SEV_ES (19*32+ 3) /* AMD Secure Encrypted Virtualization - Encrypted State */ > +#define X86_FEATURE_SEV_SNP (19*32+ 4) /* AMD Secure Encrypted Virtualization - Secure Nested Paging */ > #define X86_FEATURE_V_TSC_AUX (19*32+ 9) /* "" Virtual TSC_AUX */ > #define X86_FEATURE_SME_COHERENT (19*32+10) /* "" AMD hardware-enforced cache coherency */ > #define X86_FEATURE_DEBUG_SWAP (19*32+14) /* AMD SEV-ES full debug state swap support */