From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D27C3DA61 for ; Wed, 24 Jul 2024 09:40:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371F06B0088; Wed, 24 Jul 2024 05:40:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FAB26B0089; Wed, 24 Jul 2024 05:40:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1753A6B008C; Wed, 24 Jul 2024 05:40:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC2926B0088 for ; Wed, 24 Jul 2024 05:40:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3FBC14072F for ; Wed, 24 Jul 2024 09:40:13 +0000 (UTC) X-FDA: 82374150306.16.1656C03 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 066751C0021 for ; Wed, 24 Jul 2024 09:40:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fBGblOjm; spf=pass (imf18.hostedemail.com: domain of jgross@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jgross@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721813963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VbMbEnfMM83BKeL5xF8DO0bNfwt+gSUUC0MQPNjUR6o=; b=eOBhSi8uA6z/0x+vJBtSKQnjmzmoerx9jk/cV3qJoBJxtkFvQ/2aD20DCoQuBDk/rxH8vy hm9K65sClPRcmGJwpGmHLV/WAdV16qv/vnyvbn5DACGY+zfHc4L0TT/bCt2qn32wBFGba+ pIVT3TPb43AMNA8mIxlRdFqhKKi4OQc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721813963; a=rsa-sha256; cv=none; b=7BpPzq9bMtVJMfwUY47sBZwzjLac+cwOmo5JiyciGinXxlg5nXVmb1IaJfjsD5lYTvVaK0 Suvu3LoYqgF/8wrZSg9ZzDiKnsnYq2jPWPE6PnkflQSphbAUFuR05CUWh9a5JdirrY6PS8 VpUcCQzYW1uZo+HALSi+yPWNPwWBukM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fBGblOjm; spf=pass (imf18.hostedemail.com: domain of jgross@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jgross@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4266dc7591fso47587255e9.0 for ; Wed, 24 Jul 2024 02:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721814009; x=1722418809; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VbMbEnfMM83BKeL5xF8DO0bNfwt+gSUUC0MQPNjUR6o=; b=fBGblOjmsKwQhDWEgJypK2wTT8zIDp6ZsOPTF+uEJj3jX0S7OPt+VQmgcWawnciobQ 4I8q0GIUGNb4tri+adHKY4OFW/1+9+jR8SVPuF6iML6PHn6IfArrbF5+QXMSxzpESuiV q9+8YMONqvkBDFNsyUwHLJ9zltVxT662fPqjImj8+3gIaEyxKBIM9/a92qOe5QwRMw10 lb+jGDwtMHFAbwap/5ixQlpPasJpLrVtON2j9l5lUUW+4PF93/eQJ5xV4Qq08wmBDLjb Fa5mhjL0zMKWPfo9wR8g75NlaNgKskhNoAx7N6kseXciEdHTZaaWTY8euIXH1wItDnJ7 HcOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721814009; x=1722418809; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VbMbEnfMM83BKeL5xF8DO0bNfwt+gSUUC0MQPNjUR6o=; b=nyKOq+BhE1qsrFum1FkFHyTytEAt8/0LEsz3gwF51Oz9Uri2UEIH92SYWRZgdIQ/qU QzQg1kRbuSt0U1f7daP3reGoa1mRuXxJTBdf0m9kAy4YdDMmloasL5ttFQGsLT3NVDSn Bax0ukWGT7vUVdZSGsD47UQNrBGLhv4Rqed6qGqDgla6KWpvBYW7XVlnd+SDy7gwyFhL d1cT/iJrmGfVQgdDP9WFFQoI/R9X/ozU1+ys5tZ2bk2ndtYF9caHOnxnfTAqSmqiaJrp YlzoK9DuEfSYKdlVVJpvYCp5JuIu26Wej0EWJ2V8mJFMpnTV2+CnPF5A7hPL/GjP7jaV r37g== X-Forwarded-Encrypted: i=1; AJvYcCUaSrJePp1bi8eN/L4CEKhY4lv/HRnOCdVVdLI9DXCQhQcZ2SG9+inskDP/2+LrephwMJY3CTu8px2hjcn5zw6Hwhk= X-Gm-Message-State: AOJu0YwNcJeMNjWuX+0q8rszr01TdYMq2WlEGytY6j6PIP5dHZFu4ZSo +A73OYiWU61TzMgo3ZL5NC2CSTJmyHzPYiwF/t8v9Ns3Yl56APgbWYN/gZJV2+A= X-Google-Smtp-Source: AGHT+IF+zj06oSZDaSBVWEWlQOWmVhFMHkEpldn6/IeeJVJnQbwGCnuo/2GWaKic8DPKuGM/8nw+Dw== X-Received: by 2002:adf:f484:0:b0:35f:e0f:69a6 with SMTP id ffacd0b85a97d-369dec0cf92mr4139925f8f.27.1721814009111; Wed, 24 Jul 2024 02:40:09 -0700 (PDT) Received: from ?IPV6:2003:e5:8729:4000:29eb:6d9d:3214:39d2? (p200300e58729400029eb6d9d321439d2.dip0.t-ipconnect.de. [2003:e5:8729:4000:29eb:6d9d:3214:39d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3687868477fsm13813827f8f.12.2024.07.24.02.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jul 2024 02:40:08 -0700 (PDT) Message-ID: <0b11e6c8-170d-4b95-ad14-76685d657643@suse.com> Date: Wed, 24 Jul 2024 11:40:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Build performance regressions originating from min()/max() macros To: Lorenzo Stoakes Cc: Andrew Morton , david.laight@aculab.com, Arnd Bergmann , willy@infradead.org, torvalds@linux-foundation.org, Jason@zx2c4.com, hch@infradead.org, andriy.shevchenko@linux.intel.com, pedro.falcato@gmail.com, Mateusz Guzik , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <16f51077-f525-4d3c-92ad-8a1ccc02e4ff@suse.com> <9d62cd2d-a00b-4260-8ffb-0e0e4574f222@lucifer.local> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= In-Reply-To: <9d62cd2d-a00b-4260-8ffb-0e0e4574f222@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 066751C0021 X-Stat-Signature: d4ehsmuyw4mcsscawym9n3a5yhnahu4f X-HE-Tag: 1721814010-909570 X-HE-Meta: U2FsdGVkX1+Ol7QxaATBlM+W91HRBYt7c7/v2YhY3QdcRacdsmedK6oUNFbiDf33zpoyN90DEmWdZohwnLc+bFfhGl7CPnH4f/LQ11OU5sSCBBsD1z7xngk916IBl6EqBDiGaqz6bYoysxfTnpYa9yaonmx0rJxB9BWNPRHeYFYclMxSWGWbJGqveCjsbfkf9HN11vRF1iJwh+mMsg7EcXomdQz4uCLozSTXmY3xXHRvdx4lO8/+O1IheCWL8+i9xXuSq6n9bZMju6JxewEq/wD4eyYrRm+SmHESX8Bsh4+6KbHmxSNJj+iyymGunjEVbZelBI4JwWEw99+h2QPh5MVtkokdGngirBUlB5f7gfUxcWjz1K9GTtl2RCA2zbW8XfEkqIksKb9SrPArfCzhczUqHmlvfPWwnMHT0/iEiZt/lbDU1MVJmxefW/84XFB0pty82jcBL8K5vuj71W6Gkd8WcCBTcDgFAZLOeu1u0UmtYlJIlIJCfaTtfm3hwUgV8Qoh3a0n+7mvI9i1TU06RZ9Tk5z6Ky0z5TpOpifuPwCuLKRGIJlEZEWte2NOsnRhc2V6fZDhVbL7vtR5QTtkdj7Hp6rkQbM/PPv/rXaNp6L+7+Q3SWT6y+DGrgln61ntsk9dz9L1zlO3dBU5560I/vr1VJTy5bMqaU8uiS5UPlOxD0YSUrqmKnOYPM0VXdmIQptMs2djO20PH6V4k6eiA8P4qraqL1Vebwy97jF2L5IDyVaQjJrRkybcF/Hr5DxOpVBZfTEkSG8zctAxY7i2LU2d1udX498q/YKqGy8F/WNXa+VIlw+H3hDoJ4Z07X/Rvvml5Ikvu/PUVSZ0lnVFdtrnWS3mqZ77Kpb2nwpGK7ochcGmS+Pq/6NV572XXItpf2eBqQHCsJcqcOzbQAuL+CUPNsJie5uZpm8B5CIC3lGY5rA3WfZeYvGh1iCqLkRVdB3TQ8H9Nr57L79NAPg MQpm2yL9 awUUQMKid7/kQB0DCrdAIEWFkBfbvmml3rg8zpna+e2Noge9dh8xl/6cPo8jhhEXxNpl8sOunQQYXYpctrV/TH60LoUjiIuwEdqauCS1Fsjqztbb/HFbBa02N37SWP0/o/3+CjRfNSt5uB6vXFRHZOR4DgNZyQ2WQmWooAxLfTuycPTerZOEyVsxIFIyMEtJleHj2/GVkEheouhleTMxmrp8OsvJ9B/bzjZohEpzALMdJqW3bYjrgQifWxjio8OgnAOH/LCjjn6vkOqSOUzbHsvE4k0GscyFKpzsAlPxWCZoPRzdYE24KN39XvtGvQ5f2WnDcyFzj6ZIGRiFZabntj0NzU+7COFlD1TSwT75vpSGfnCMy2FqriscTiUQBNezw2+BXB13mnK9DdqMYos9LzB1NvCNnwB63KlsILOhIIIoCz+U6HRBXJmV/wduOOZyOJb1R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.07.24 10:31, Lorenzo Stoakes wrote: > On Wed, Jul 24, 2024 at 10:14:12AM GMT, Jürgen Groß wrote: >> On 23.07.24 23:59, Lorenzo Stoakes wrote: >>> Arnd reported a significant build slowdown [0], which was bisected to the >>> series spanning commit 80fcac55385c ("minmax: relax check to allow >>> comparison between unsigned arguments and signed constants") to commit >>> 867046cc70277 ("minmax: relax check to allow comparison between unsigned >>> arguments and signed constants"), originating from the series "minmax: >>> Relax type checks in min() and max()." [1]. > > [snip] > >> I can send a patch to simplify the problematic construct, but OTOH this >> will avoid only one particularly bad example. > > Thanks, appreciated but I am a little concerned that we might get stuck in > whack-a-mole here a bit. I'm pretty sure we've had previous patches that > have addressed invocation points, but obviously the underlying issue are > these macros which will keep cropping up again and again. The xen example seems to be one of the worst due to nesting of min3() and min(), so being de facto a min4(). I think drivers/firmware/sysfb_simplefb.c has a similar problem, as it is nesting max() with max3(). Same applies to arch/x86/kernel/cpu/cacheinfo.c and multiple times to fs/xfs/libxfs/xfs_trans_resv.c. There are probably more such extreme cases. Juergen