From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E3FC6FA8E for ; Sun, 5 Mar 2023 20:44:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C757B6B0071; Sun, 5 Mar 2023 15:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C264E6B0073; Sun, 5 Mar 2023 15:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC78E6B0074; Sun, 5 Mar 2023 15:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9CB5D6B0071 for ; Sun, 5 Mar 2023 15:44:26 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 76E821A04CB for ; Sun, 5 Mar 2023 20:44:26 +0000 (UTC) X-FDA: 80536022532.23.8D15845 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 8819440017 for ; Sun, 5 Mar 2023 20:44:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XsgLdLib; spf=pass (imf12.hostedemail.com: domain of schmitzmic@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=schmitzmic@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678049064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qQEhAEnCoSqPNLqIdWFb7wfcuPxRiAiR2KEKFk8XhXg=; b=KZTPnNjAszrworKuJ2BynGwXhAjQxPzuHXWoumDjGY8px9pe0hJn8YTRK25tc2aOGxAxjW pvCKWWdA9qAnsryv4Nkmtx80WSnLBS+U4LH7RGh0SEzXwAxRp9Q9HUl7aAC3VBBxO3jhcJ OUMqNAVlF77o8R9lZb5VAmWyLT2N474= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XsgLdLib; spf=pass (imf12.hostedemail.com: domain of schmitzmic@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=schmitzmic@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678049064; a=rsa-sha256; cv=none; b=a2o2A+Rwg1p21njZf5PG5V7Gp4BN6+l1l7WvSLcG76dxj8XIkPcdp3mhG8xMZIMw9JG3o8 xAzAJikt1X8FgX72wPPf1Yca0mY3aToTguRF3mIS0OlO325+TxPgGQ1VP36t0b4ofMb0id dgOvSw4ET+esPQPx9t9Y5aWVq6aLTKE= Received: by mail-pl1-f169.google.com with SMTP id p6so8229232plf.0 for ; Sun, 05 Mar 2023 12:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678049063; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qQEhAEnCoSqPNLqIdWFb7wfcuPxRiAiR2KEKFk8XhXg=; b=XsgLdLib5YxD3UoqpUHhBtiMXrRSCSRmpOEeXQH70qS3WFbdWPt1QYhHdkVRA9Gj21 mEDZTI0L9f5gUoHNGUz8dYsJKIca+pLBKlsRCwlYQKvVTuWV6OlYHhFz17PFlGmk2qai w48jZGK8k3O71v2p3Ca68xusJCiIKgpGuvqnOrH57yLfgW4OTASVw0mgHUaeGODiWwxk x10bxn2cw3B9cZ28kNFwxInwQIFf7GHfVfivx+Mb0UN+PaMJzNLbgbuQI61l0y63Tqnq f43J6fG1L58LZBfsbeLd8oQiz0acVMwoTIHqcI0gtuJJD7VWsi/T2hq99QSLOBlqWZNa wg0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678049063; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qQEhAEnCoSqPNLqIdWFb7wfcuPxRiAiR2KEKFk8XhXg=; b=Jhr7PUFPk1jIySSv1AaA90+vaegGjDwz7zOWKbaG1EKBozQza21iMoyhoHwzI3UdHU 9t7wsSh4eru145mVEAt0tA2hI8Ljbw3sM4uJOq6HiEXVxX5eRJMLYR7dx5dEgLTM8wxs QCYyX+qTktljHl71Y2uZSHX9CRIB2X/fkt37D7wf5r612lhluXPXs9OLeL2MBgjbMRnr jNBm1xrv4uAfyjoN9E97GijcYGwUurqfS7GSKXFw5lGAmsZDDfdr7th691O3JX2h47kA HYudQPPwyF7DCbsI11N6LJe8D2B5T3Sd98MoWEH2bgiZ1VWYMTmVK7PU2gG1la2c2jSO 7ZZQ== X-Gm-Message-State: AO0yUKW7+V1IgfJ81iGKsxoGQwkwwF0iLr6B5mM1FZjksTFEx++RnVA8 LvzhE4wVqmiuxa6e87ZHus4= X-Google-Smtp-Source: AK7set/RbEx9jtFCpRX+pR8Y+f6oCnVFm4mqzGAENK55LPzQH1+61UY9MM+V+7mTev/dOMa3U25bEQ== X-Received: by 2002:a17:903:41ca:b0:19c:be63:a9ce with SMTP id u10-20020a17090341ca00b0019cbe63a9cemr9066698ple.4.1678049063223; Sun, 05 Mar 2023 12:44:23 -0800 (PST) Received: from ?IPV6:2001:df0:0:200c:c02f:c6b5:6aff:ae1d? ([2001:df0:0:200c:c02f:c6b5:6aff:ae1d]) by smtp.gmail.com with ESMTPSA id j7-20020a170902690700b001991942dde7sm5106140plk.125.2023.03.05.12.44.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 12:44:22 -0800 (PST) Message-ID: <0b00a30e-cb7f-d42b-7d16-0ae8d50ed916@gmail.com> Date: Mon, 6 Mar 2023 09:44:17 +1300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 13/34] m68k: Implement the new page table range API Content-Language: en-US To: Matthew Wilcox , Geert Uytterhoeven Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-14-willy@infradead.org> From: Michael Schmitz In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8819440017 X-Rspam-User: X-Stat-Signature: fqu9c13owp18kqr1zeayjofx8n4bqg63 X-HE-Tag: 1678049064-698827 X-HE-Meta: U2FsdGVkX1+qWno5Iv4gYa5b4r9ZeylIBR3cwjU48YIU58PWs1se0Y/PdJElzQvixmbc2Mq8GavBh+YI7a9X+0cmrrmgSkLRTAUtMDEVz18T/Cc7LC+sgYMXpMnUUnfIaJAfZrfNpPqWZYazNOnex9Ws9RUwP5/TtdwZFL9hCk4Ryh0J6j1fxV9ty4gM7exwGI0az7K8MGLLARgkfJU+bJ01L64SvPbXH0BB/4GLdssMj9hA1ERUJmJOcm+IXsfTRdWxifU2Qr2aZMRt03ObLOx5YjCqEfqO/HZ4gVQiRuPXH4Wwr29RJcNVKx9UA1FcqaHzxp8ycN4NpFL/3hqSVk4+xWzqwjHOctT+ZIfDvWVM48PNteO2YLAA/122XxjIdubF9Cq1JADRln0PGFgZNHx/tLsbrukv7rJyeuAWUuUQQeSoVqiVA2Arobp4gAmBuzETdVBiYCqylflZ5Lx1q/zPps1wCr7Ama/RtO5anPRCIn7iTahxHP+cJEy5R4tOWyuAzLgeveOy/XFt69C9lFpmS8tptcJPw0Xowi9qD3yziDq14wAh2J+JLha1VrRwagQcBaJF3jnGdMBTfOICamfj0wApe6WPps3uLVI7h5qp7cMtb4skfz4gxsqIaRjKVK5v+VeOVJk/6hREEiJ4U3aJhe/IPM/D1nMyVSs7ULnSLChlu6k/3p+3NHrQJ3nOnicoqPDN+aVCm1Fb7rD6FdVcTGWC8XhFQsTonl/kTQhNNe5COyACACuh4cg70FhofJMz1MhkpOBH5bp5rPjcacOoxwwFU5ed3hlppeoF2w2+Uw+a8/K6Cp2v1G+3jTdEZBzcawI9yV8feKdpB0ip4OL1HisTapwnkB9AK4/Ent/M4oh1t3f+ThDS6SEAhqanbxtpj0RXqAQsYtt6JdZqAfYIDlqyJItuSwfpy4C8cQx6wG851tyk+eT4PGTblHht39CB+ZDOsy+9Ia0xfE1 dyiO/SWF CiuCbUa2ZC2iJKQ3gYaWxZzmrSBzYpvAZ4u+g7gOWfxDFCEJTuekLQiGN2Jj9AcrZvJXLE5Rw+4XN0NkBzVo7UTGMN/ApK98wAozq6XceZ4TPCRQn09mKPdZoMzEhHldPCNBUgveDnTVus7cWmG/z6oBZOm2FyDyXRycB9xJnX2klDlhtynNieDYjSLp00xO0m9oZIfXOuG5n8h6pL6QWm6KIvqcCt8tQMslvw0Csge3H7Q0xPjchTexRusBYRjw/J+aIYp2bfuxjWDhuvU6DSFSlMFyYLi83ZPv5pVFcKDkM51wIZcVbCSAwXcdv0aC/u2AOGskbzbeGNSS8xXU3+nwvM/Nrzr729fZuR5lJNSfwEHyFDnSgcgQVd7xMpErkoCbIGYzirhz5jAyOnHlrepp+PNfVaaDN1+yoF+LGc5Fg0FG93xSNh3/gjAD27vxU8E/eFEHdEo2rOvM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, Geert, sorry, I missed that one when it got posted ... On 6/03/23 04:28, Matthew Wilcox wrote: > On Sun, Mar 05, 2023 at 11:16:13AM +0100, Geert Uytterhoeven wrote: >>> + while (nr--) { >>> + __asm__ __volatile__("nop\n\t" >>> + ".chip 68040\n\t" >>> + "cpushp %%bc,(%0)\n\t" >>> + ".chip 68k" >>> + : : "a" (paddr + nr * PAGE_SIZE)); >> As gcc (9.5.0) keeps on calculating "paddr + nr * PAGE_SIZE" >> inside the loop (albeit using a shift instead of a multiplication), >> please use "paddr" here, followed by "paddr += PAGE_SIZE;". Are we certain that contiguous vaddr always maps to contiguous paddr? If not, I'd suggest we increment vaddr inside the loop, and use __pa() each time: > +++ b/arch/m68k/include/asm/cacheflush_mm.h > @@ -235,13 +235,14 @@ static inline void __flush_pages_to_ram(void *vaddr, unsigned int nr) > } else if (CPU_IS_040_OR_060) { > > - while (nr--) { > + do { > __asm__ __volatile__("nop\n\t" > ".chip 68040\n\t" > "cpushp %%bc,(%0)\n\t" > ".chip 68k" > - : : "a" (paddr + nr * PAGE_SIZE)); > - } > + : : "a" __pa(vaddr)); > + vaddr += PAGE_SIZE; > + } while (--nr); > } else { > unsigned long _tmp; > __asm__ __volatile__("movec %%cacr,%0\n\t" > (just edited Matthew's patch in the mail editor, untested, may not apply cleanly ...) Cheers,     Michael