From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733ECC10F1B for ; Wed, 28 Dec 2022 01:18:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C1A78E0002; Tue, 27 Dec 2022 20:18:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 672638E0001; Tue, 27 Dec 2022 20:18:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5398E8E0002; Tue, 27 Dec 2022 20:18:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 40D698E0001 for ; Tue, 27 Dec 2022 20:18:34 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1052C803E4 for ; Wed, 28 Dec 2022 01:18:34 +0000 (UTC) X-FDA: 80289954948.14.A84940F Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf28.hostedemail.com (Postfix) with ESMTP id A0276C0012 for ; Wed, 28 Dec 2022 01:18:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672190312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m50WeuLooXswUzo8fvCxRfuWsIcDrLk83KvzUJEqJdE=; b=72Hnrx6cHtescc8XqLJD5/LPag+pxb5e+VuL9o+ROgu4008XIAhol6Cc0H57WpjaVlFTSy YkV1fJlQuAIvsbCtVBVMFrrtIqDdYDye8gwIqWapogwRUC9YI8QHWrLutyvfy92GwQ8QUP 6j2YgDlKCVa2NhbvkCAXXIQyD4W8r0A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672190312; a=rsa-sha256; cv=none; b=WfeYSLwBvsq4xRXXsTsNlqo/i5jHvkDL0DvjZdkaZTSzO8zXT6al22LxXzAqsQ5CVcDw1E kfUTAgU+rTzrznQYyKqKfbZhDH+cXFDnDDkPe8D19a4R6nJQiMSRwVUWrakJYw/uvctVtt oiTs9T/XsMoyxzriJxdeivzbr5UuCsE= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NhYXZ6bbtzJqkC; Wed, 28 Dec 2022 09:17:18 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 28 Dec 2022 09:18:24 +0800 Message-ID: <0afd9944-d30a-c3e0-0fa3-4f609c49af84@huawei.com> Date: Wed, 28 Dec 2022 09:18:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next v2 1/7] mm: page_idle: Convert page idle to use folios Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , SeongJae Park , , , , References: <20221227122714.161224-1-wangkefeng.wang@huawei.com> <20221227122714.161224-2-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A0276C0012 X-Stat-Signature: siykhi1oxt9ngggq4shrqpfzscto6buh X-HE-Tag: 1672190310-978094 X-HE-Meta: U2FsdGVkX19V+lPMJmenwBxbtvG4RHKicu5ppGWZyvWs9kw08DaKSgYCMyzZoz5TK+ou+vdp212lRX2zsV06APZyecuC9bsJCazu/aetXitKSTC7+Nu05TP5/Rgf+VWtUOmsnb88kWnLq7K03fo9bOIBh4ZDtlyYKkWND03raYfTLaCrSXq7tFJXuwOaXzpKTYGJpO6o4taKJgj9CT/HrMZ2eF6Lzar5l5p1eDhDGsYgwx6/DIeopTjTt0z7KgukuZdfFqbFgaqXjJKmx/9su7PB3AQ9C4ZT9bBmhSf3NRfxh+Zv+L6TaUG+bR2T3Raeqsgcd2udumZN1xBT4NOHMfaQpeTzBqRroBDaraB9mGe8SQdakIdGTFEC7vQEdcajIAN1XXn0NpA5OhhEBN8AR0LIYV7o1X4Wb6mZMYJPjb0QWu+Fnjf0Ldjmdu6s0kOUdQeMO8ogG2r1KfE+YijMC8YYaLkrkBrZTlQSBoLkUCOiex6W0TyS7FFujiFTpAUp5b8Wcbk0awrTUhumCjOsBhXksiO2YeGBvRLBdIRegTpLx64JaCqzX05450v+E5Y48Xr9+InwFGcOFjOnt6DF0FkD0WJqvlWgrt7qymAmC151YM1wF12Zf2dC9zmZUGQvxBvi+jU2pVlSB3Svp7YQTSlvl5zEZ1z3RznJZItnNHQprGohyfP55c4Q82VWIym1EJwtsAcyEOI+gyS3mtIxasjawv3tbaFw1RN4G1BSNRBWERCVOdaxoVJSRGPDZwHdGX+CCaEXll8MGPMnMCtDwgBXW6WovZw7x3gJQea+n/Sk4ZlzWa4rxaYZU2LeZBu+uruHcZ1CbdpLKYZmdl3N5M6HaLoOkoSuYOh+XI2OjAfmA8QXWplvo6Dlta74xLRx7c8IdZZODrjBk8b529s3iV9NjoNVDAc3LCEP6OQsl8dSfPhW9DVvxe6Pw8JSV4w2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/28 2:14, Matthew Wilcox wrote: > On Tue, Dec 27, 2022 at 08:27:08PM +0800, Kefeng Wang wrote: >> -static struct page *page_idle_get_page(unsigned long pfn) >> +static struct folio *page_idle_get_folio(unsigned long pfn) >> { >> struct page *page = pfn_to_online_page(pfn); >> + struct folio *folio; >> >> - if (!page || !PageLRU(page) || >> - !get_page_unless_zero(page)) >> + if (!page || !PageLRU(page) || !get_page_unless_zero(page)) >> return NULL; > > Mmmm, no. PageLRU hides a compound_head() call. Try doing this instead: > > if (!page || PageTail(page)) > return NULL; > folio = page_folio(page); > if (!folio_test_lru(folio) || !folio_try_get(folio)) > return NULL; > if (page_folio(page) != folio || !folio_test_lru(folio)) { > folio_put(folio); > folio = NULL; > } > Thanks Matthew, this is more complete, will update. > return NULL; > >