From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCADCC4345F for ; Fri, 3 May 2024 08:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F5986B008A; Fri, 3 May 2024 04:30:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6DD6B008C; Fri, 3 May 2024 04:30:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26E626B0092; Fri, 3 May 2024 04:30:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 065336B008A for ; Fri, 3 May 2024 04:30:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7ED7E40B19 for ; Fri, 3 May 2024 08:30:31 +0000 (UTC) X-FDA: 82076413062.23.DD744C4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 4CD5A20007 for ; Fri, 3 May 2024 08:30:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714725029; a=rsa-sha256; cv=none; b=KDXdOEimOX0XGHPbCaZSDVbzAfbr9Lq4LMg4BLb38BjNfZXVu0REsF0m8K6FTw+XfefBuJ aPEFLNFiRYVp5OjebklxyVeuDCvoobxJDtpS0XZ0VN8/OZw0JONPWQUjvQGxI/6fgHOnFj hwAJ/iPtNAxiaDtaXCQv7MwdwhAsDXw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714725029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w/YjqP7VmB/l3GFTwIbZ3tS317MDLIQE3BFwOgM0Onw=; b=J+LV8IMB8VhRGhVHTCKnsQcuBjaNpRQfXuLS3maHODPKH6l7jyLyy3nbK02V9vAARVued9 16RcwnuEZZdEnRjMLwv7xJKNzLDiagS7ow+n2YPkryeP11c7zA8+xmGZQyoLD6YZA+DwpJ ylbQ9/TpqqrCU87TGffHSePuGFQ1mDQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8118A2F4; Fri, 3 May 2024 01:30:53 -0700 (PDT) Received: from [10.57.67.51] (unknown [10.57.67.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 047DF3F73F; Fri, 3 May 2024 01:30:24 -0700 (PDT) Message-ID: <0afb3887-f72b-42d3-8809-e97353fae031@arm.com> Date: Fri, 3 May 2024 09:30:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/5] selftest mm/mseal memory sealing Content-Language: en-GB To: Jeff Xu Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, corbet@lwn.net, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org References: <20240415163527.626541-1-jeffxu@chromium.org> <20240415163527.626541-4-jeffxu@chromium.org> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 78ctck8jpef8o8g63q1ddfcohmuudnup X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4CD5A20007 X-HE-Tag: 1714725029-580715 X-HE-Meta: U2FsdGVkX186gERvQEMGzgwsH2ZgLF9MiVZqhb1UL3hbtQO53eXBkJPv+eGWltEAJxNnzLzmTqLitpbtOWX+Z0p0pjL0M1HK60mctKS18Fq+b+3rFzSnF11Ha7vuEXvxdxQ7cqt2YFkydfa5/k9UXjQCPNZID8x/3PXm79TABnfML4+HVinaW3GfrpTHr6iOyaoQ2/kwDmr0C2yQNo4ZJnKRsv23d+grIYFSJzlUsvuX7501I8iDeO+fhKln+/QYCuAfdigvaHnyYA4cl14FNLvhhA4x08U4Mdr1QWQEnNWmYvPnaocJfm9JhyQMdgwvHNAcYEkSOO7xsv/GVhrmSo7/0/sJaiqnJaPjYzNf3zqtRs1Jo/CQmpy+m9ItAuFtaF9RpItnvmDC1VTI+1439Oht3zJQmXDTOwqc91kgFqW+RjgporuATgyHgBogpokGRCkKo2mXkvDh5ouaVz62LokL9HbF435UhcbYLYA8AY1OoL853ywptUZK9Zn65HayxyhseW4C7/Uro9knQQTZjEt+ArkK6skKY0jg31SexkzmdOY/j1tga4aWtfrAirF8KxiONle49BIHXQjdRnwM9xnEgg9csJ3Hlx267wBIr6CKOHQEmuCsUcssbnLyRsNfHjgjOh/2LFlAF3Rol84ET7YfWelu2xFCFcGPjuXsuSlxVFYGo/y42L7i+gElKDCY5UbSH7P78q8oLgsa/xBK/k/oOa9t4Y5EYBSK3V08YLIC/7oovtK4wNL44T/Ac9E8DWw6f9G+R9aVHs49Up1/R+tvFJE0+iBU9bDUHE/wZ+v1CtwrNa2KrMNIhE9dH+Aw44hSJJ4Wgw1c7z1VUX4GRBJwn0fANNUpXCiKQHo3zksMEyKn2MST9PviXpzSLe+UvEYwB7s3uGeWk53l2xCpGmIpwxU3zhp8mkpvfkIlZ2GBXWoBDsXZhR7slEJuppqWNMtvIgUuQfb4qvXBBIM FYrzt7h0 G7tZpOdVysfNMAqfmWzZC0ONRm4bPQfQ6UYcU5hnL/tVlmeqx9D0oY9AVQRH67iargJsjIylHFBh8RdwbOjmvQk62mjalQCOUM8fzmxx5UfZ930i4InPafLuaUJVRk0y9GH0/fV4VAOV4gNCJyVAzJyxf0v5HUfXdGrP22c8xq3SGAW4g/b6/uoLjobYKBEOnLD1kVxk+dezKVG9HfrfqWUUJbVjnRZgIuBubgpcCYPAO/y5rrgPV8MoeqB7ucWw37B1pUzmAbqw0ljweFP6ZTkClc8g5vWUFP8D7MJsUsON9+MzQwIQSLVK28QC6Kh8z6HJbQw6S7M60zXqLVlrl7S5gGI7sB6IdmQbd1iHP3ZfPppI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/05/2024 23:39, Jeff Xu wrote: > On Thu, May 2, 2024 at 4:24 AM Ryan Roberts wrote: >> >> On 15/04/2024 17:35, jeffxu@chromium.org wrote: >>> From: Jeff Xu >>> >>> selftest for memory sealing change in mmap() and mseal(). >>> >>> Signed-off-by: Jeff Xu >>> --- >>> tools/testing/selftests/mm/.gitignore | 1 + >>> tools/testing/selftests/mm/Makefile | 1 + >>> tools/testing/selftests/mm/mseal_test.c | 1836 +++++++++++++++++++++++ >>> 3 files changed, 1838 insertions(+) >>> create mode 100644 tools/testing/selftests/mm/mseal_test.c >>> >>> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore >>> index d26e962f2ac4..98eaa4590f11 100644 >>> --- a/tools/testing/selftests/mm/.gitignore >>> +++ b/tools/testing/selftests/mm/.gitignore >>> @@ -47,3 +47,4 @@ mkdirty >>> va_high_addr_switch >>> hugetlb_fault_after_madv >>> hugetlb_madv_vs_map >>> +mseal_test >>> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile >>> index eb5f39a2668b..95d10fe1b3c1 100644 >>> --- a/tools/testing/selftests/mm/Makefile >>> +++ b/tools/testing/selftests/mm/Makefile >>> @@ -59,6 +59,7 @@ TEST_GEN_FILES += mlock2-tests >>> TEST_GEN_FILES += mrelease_test >>> TEST_GEN_FILES += mremap_dontunmap >>> TEST_GEN_FILES += mremap_test >>> +TEST_GEN_FILES += mseal_test >>> TEST_GEN_FILES += on-fault-limit >>> TEST_GEN_FILES += pagemap_ioctl >>> TEST_GEN_FILES += thuge-gen >>> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c >>> new file mode 100644 >>> index 000000000000..06c780d1d8e5 >>> --- /dev/null >>> +++ b/tools/testing/selftests/mm/mseal_test.c >>> @@ -0,0 +1,1836 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +#define _GNU_SOURCE >>> +#include >> >> I'm afraid this is causing a build error on our CI, and as a result we are not >> running any mm selftests currently. >> >> The error is here: >> >> CC mseal_test >> mseal_test.c: In function ‘test_seal_mremap_move_dontunmap’: >> mseal_test.c:1469:50: error: ‘MREMAP_DONTUNMAP’ undeclared (first use in this >> function) >> 1469 | ret2 = mremap(ptr, size, size, MREMAP_MAYMOVE | MREMAP_DONTUNMAP, 0); >> | ^~~~~~~~~~~~~~~~ >> mseal_test.c:1469:50: note: each undeclared identifier is reported only once for >> each function it appears in >> mseal_test.c: In function ‘test_seal_mremap_move_dontunmap_anyaddr’: >> mseal_test.c:1501:50: error: ‘MREMAP_DONTUNMAP’ undeclared (first use in this >> function) >> 1501 | ret2 = mremap(ptr, size, size, MREMAP_MAYMOVE | MREMAP_DONTUNMAP, >> | ^~~~~~~~~~~~~~~~ >> >> >> And I think the reason is due to our CI's toolchain's sys/mman.h not including >> linux/mman.h where MREMAP_DONTUNMAP is defined. >> >> I think the fix is to explicitly #include , as a number of other >> mm selftests do. >> > When I tried to build with aarch64-linux-gnu-gcc, this passed. > > aarch64-linux-gnu-gcc -I ../../../../usr/include -DDEBUG -O3 > -DDEBUG -O3 mseal_test.c -o mseal_test -lm -Wall Its the same on my local system; I'm told our CI is using GCC 10, which I suspect makes the difference. > > I don't have the exact environment to repro the issue and verify the fix. > I will send a patch with the linux/mman.h. > > I will probably need some help to verify the fix on arm build, Ryan, > could you help with this ? I'll pass this on to our CI folks, and hopefully get confirmation shortly. > > Thanks > -Jeff