From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502D2E77197 for ; Tue, 7 Jan 2025 17:30:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCE2C6B00A8; Tue, 7 Jan 2025 12:30:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C57906B00AD; Tue, 7 Jan 2025 12:30:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA9B16B00B3; Tue, 7 Jan 2025 12:30:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8CA126B00A8 for ; Tue, 7 Jan 2025 12:30:55 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 44A8344288 for ; Tue, 7 Jan 2025 17:30:55 +0000 (UTC) X-FDA: 82981346070.24.CF7712C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id C30AD20018 for ; Tue, 7 Jan 2025 17:30:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n+xlwlbU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1P15LYb8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n+xlwlbU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1P15LYb8; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736271053; a=rsa-sha256; cv=none; b=PwDUECZNJg2NwB6u9tOy1nUEicNwhYZvo9Kk7smctz4QQu+iVKa+PDEgUm5O01unuNoC9k oPK1319/kJwjX49Y+lUKbYLJada5VP67W91jL039gNSMyqfVgQtHyt/jgOMdP6Zr7JeD/0 EY9zX23BaaM31iQ/iBcO+qx6RxXs6HM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n+xlwlbU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1P15LYb8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n+xlwlbU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1P15LYb8; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736271053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PgfYbuJmBDD+vkev9+2bzquJaCnvxw07wW76Zl3uXAc=; b=glXbCZvdi147XRAYzSOBrHfeVQ2fNW2g//q09BLoJy3oRsJh/IeIqF+mPeGbW5/eq7fLFg VL/Gb477aqW7//TbSoJiqD3K8tHcGR2J3tvsm67VKUGe3cGstp0I9DFdn6oac7EFmkQxrj J+9sJ3q7SbVMCud0Z7F2dLt4ShtmWVg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2C6B01F390; Tue, 7 Jan 2025 17:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736271051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgfYbuJmBDD+vkev9+2bzquJaCnvxw07wW76Zl3uXAc=; b=n+xlwlbU1sn934I4Um8DkFZ4gJdXGkrGKF/9oFh4ODcjLsRY+9P0id1rDYjpGpK4Duhh0T B4WbmTWwk63DeQBWOw8CUGopMiUzs/SDOnb3UzU60XGfzFRg00kO8oEz7ObSOcZexa8HIx OxiQalKi2aEuQ6hzcFkZLPNeYxfSbu8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736271051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgfYbuJmBDD+vkev9+2bzquJaCnvxw07wW76Zl3uXAc=; b=1P15LYb8WpnLom2jWAm6UZYJNyzcjgO3dYBK3pxSMTvzatkF0JLah+qbwqBtHJNvxnaz4C dbxnYlY+u+rQ/ACQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736271051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgfYbuJmBDD+vkev9+2bzquJaCnvxw07wW76Zl3uXAc=; b=n+xlwlbU1sn934I4Um8DkFZ4gJdXGkrGKF/9oFh4ODcjLsRY+9P0id1rDYjpGpK4Duhh0T B4WbmTWwk63DeQBWOw8CUGopMiUzs/SDOnb3UzU60XGfzFRg00kO8oEz7ObSOcZexa8HIx OxiQalKi2aEuQ6hzcFkZLPNeYxfSbu8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736271051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgfYbuJmBDD+vkev9+2bzquJaCnvxw07wW76Zl3uXAc=; b=1P15LYb8WpnLom2jWAm6UZYJNyzcjgO3dYBK3pxSMTvzatkF0JLah+qbwqBtHJNvxnaz4C dbxnYlY+u+rQ/ACQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E138E13A6A; Tue, 7 Jan 2025 17:30:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8QeFNspkfWchcQAAD6G6ig (envelope-from ); Tue, 07 Jan 2025 17:30:50 +0000 Message-ID: <0af55d1f-aa63-49cb-a334-f8c0e00a856c@suse.cz> Date: Tue, 7 Jan 2025 18:30:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 09/17] mm: move mmap_init_lock() out of the header file Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-10-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241226170710.1159679-10-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C30AD20018 X-Stat-Signature: 4rdc1f9oox7kdwnapiccdotp979ucuzq X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736271052-288080 X-HE-Meta: U2FsdGVkX18jRz8/1JeieVr/bjrOr4bU8iphaVgqFMpx6P22iWKqqZLrJl/DBsgOLbSGFChnJAqsN9TlCEZP8ZSb0J47JP4T72XIvktv3rKYE+JtWPdTlUrWGaXCH77gUeMSoeYYgJftS/YdCmosT9SyF7BWG0eF1Et2Cmfgqb9wYLXlCHOejK8I4LC5aqwE0nYhLS4iyvTPbGKg8kOFuVutI3Ob7nO6JVRAsuQOSCCPyEmgp1iHT+RXGx3kltvJd60GLd1z0kidQ5ED/qGLSUv575Si5bH5STOYi718yq7e1J0+07EaejKLeSKp7K+BZGiXRPH//4quv4aHRElfWbN41ifj+HUQyF9Eau+E/OcW94gdG8gtnTwa/mAJwwd5SGAIWuI1tJ2kj56Usynn/jYkOkHGzG7Br07p3WOgihLzjfqibO+F2UrIl8m3UkRJiiJBScOQO+eXAPibmn5yuq+UODPudDlvpl+ClwqLJDQc6VhECFGSbOUyD/3GmRj+L35Mn9CVz6cauuAUH+AFZxRk6PGJN53+Cmxk8QGyc7v8Z9mj7BK6vd0sFKdIIHz5iP3z7SVHErUgdP3c+8H4kkCI8/BU2E//zfy+LbFa1u66uBrOC2B/9RaldcvWG77thZoC0VIs6uAeV1gDRQ63Pl6xChg9DR7k1xXkR9a2urEH1vOw9nJhALhUeEQZyvFv+Zpo/U1p4+fiBeEe2l/Ulg4NuOnt61Clwe/8Dg6qLl+caZvsHNN1Bnm5udZoM00OWGJldhG8GuU8WEXaQ0DzHOd2MwBdveju5X2KUvsSficEz5wwf/9q1NkElG865C5ZzXJcgZ3G+AOQYH5ldK313xySKSkEl8xKdOFhvT2i7NV+NsFs7U8VchwyGLVDWnYT9OwjAKwogDwBhrw6eiHKtBN5kngknudcfPNudRU8LGwRH1zxdYC/BS0JPemkoYVLyIG4EetQacimECd/BzE Q6DtZ1ve P2AwOaJadrAQiwjFhpOxxQVjEtOwPAxaqL/gqsONf5KVkNpZ5ewPZq4kxi9gsCLtpF7H1rnN+sLsTzxxXbJ7AjJGSKyxHg/VqG+znB1Z3vvGLjIwtosxux5Klfhv5GQRdJyEDqRrK0KboaRtlhfKP4Lb7Z1TFol4n2cFKG4CmGruPLIvtE8WO1DMigFA404NOUslJB14U1iHkCDXUowEOx8iJeFWllXIsys9JolIKV8pWy8jvr0fyBzZTRRTufil/cRAvJhX8Q+4cay0IhMnSjJFHEp9fayNGpa2U03NHrEULevSiDmp4wQZ0tslAjJcqcB12ojjjQ5h7UKa2dF+TSIAl35lyHriylumVCQvyEF+qiH8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/26/24 18:07, Suren Baghdasaryan wrote: > mmap_init_lock() is used only from mm_init() in fork.c, therefore it does > not have to reside in the header file. This move lets us avoid including > additional headers in mmap_lock.h later, when mmap_init_lock() needs to > initialize rcuwait object. > > Signed-off-by: Suren Baghdasaryan Ideally a file named kernel/fork.c wouldn't contain so much mm specific code, but that could be perhaps addressed separately later. The reasons here sound pragmatic. Reviewed-by: Vlastimil Babka > --- > include/linux/mmap_lock.h | 6 ------ > kernel/fork.c | 6 ++++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > index 45a21faa3ff6..4706c6769902 100644 > --- a/include/linux/mmap_lock.h > +++ b/include/linux/mmap_lock.h > @@ -122,12 +122,6 @@ static inline bool mmap_lock_speculate_retry(struct mm_struct *mm, unsigned int > > #endif /* CONFIG_PER_VMA_LOCK */ > > -static inline void mmap_init_lock(struct mm_struct *mm) > -{ > - init_rwsem(&mm->mmap_lock); > - mm_lock_seqcount_init(mm); > -} > - > static inline void mmap_write_lock(struct mm_struct *mm) > { > __mmap_lock_trace_start_locking(mm, true); > diff --git a/kernel/fork.c b/kernel/fork.c > index f2f9e7b427ad..d4c75428ccaf 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1219,6 +1219,12 @@ static void mm_init_uprobes_state(struct mm_struct *mm) > #endif > } > > +static inline void mmap_init_lock(struct mm_struct *mm) > +{ > + init_rwsem(&mm->mmap_lock); > + mm_lock_seqcount_init(mm); > +} > + > static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p, > struct user_namespace *user_ns) > {