From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DACC433C1 for ; Wed, 24 Mar 2021 22:01:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A286361A13 for ; Wed, 24 Mar 2021 22:01:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A286361A13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 37DC36B0325; Wed, 24 Mar 2021 18:01:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32D6C6B0327; Wed, 24 Mar 2021 18:01:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181CC6B0328; Wed, 24 Mar 2021 18:01:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F01576B0325 for ; Wed, 24 Mar 2021 18:01:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AA3D498BF for ; Wed, 24 Mar 2021 22:01:34 +0000 (UTC) X-FDA: 77956140108.16.9751999 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2051.outbound.protection.outlook.com [40.107.236.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 3E55BA000395 for ; Wed, 24 Mar 2021 22:01:33 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GzckYmxxujtsPhdI5cyZp99+He9xIi0Tk52tJB2a6NhEEZYcf0FxqzjMm4he5LdmdL0eUwPMdjAF5Nd8XCViXjA1tQCw0SIDYY9f43MfHx2T6w8nRkn1NcEFP+CLSHwtKie9ILZNfHt+vlNfdo5+Th1jaEUYKx/AG293dw6ayiw8Gpc5FINqTUJefVdrG09Ff/YSJvp3s3KoC+k0PtKOOrQw30BYKdm8F6VUX3oT5uOu7V/IZ5YrQDF2kBYD8b69L9eqiEC7nvl+yFMIxVf7k3cBdPH5Ka/KNWIdRmoSOw3IluYzfatYVkgleWgJYsVywcYn+egg/3UvnwXSPeGxiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3wf/C+nkQnxo/jTJYLNsGMaEAmecW1/CfReKCA06t8=; b=XYbiSRyJwUFQUkkoyzZwHvMgvtILTHCVqE00s9bXvYAyYTOCLQahaPYDXrikb3A+NOtSM21ube1m9XN+QhAp+CDVrXr9YsvhOV5ExGa0f8A58nNWjyRezb9WB7+1MsHnEAYh8u8FKIojbLN609WXjD/2kDIzanFel4p//uSu/0twCS/i0Ug2C+xC96CWC2KtxjapjBCHHiv3pQcJFb9iPW0t0hctIsxULuaLo6EmYoumHU7MMxF4OSKSoxTU8uOg99OwpdexuT+W7UMMU351Na6s8Gto8Y6rjhLWr2x0NqLg0X0cT/2D3K1I+OJxRmNgmp5F+bTiWk8Su7jzYN5t5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=kvack.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P3wf/C+nkQnxo/jTJYLNsGMaEAmecW1/CfReKCA06t8=; b=tPiFtCDc5aT8+RCX5EqRbAZ8Kn8NwLGjAOwFJHF8wMyRQ5lGr+X3OFGn2s6rL4uON2La/FOPMUv8tLR0VvOxLo360NBphZ24hxKDQTV+xYIQXyRD6DN89XXq1DWQkkXJWdR7UVLSit628AQN+fqcFdHd9lfsBl+DkCTbbmN4ThlD+b844eCoug1xK83Ejt09jmUimuDzZiZV85Z0HivhjbpgC9ZqfkdygYoV2nu5gg5VNf60Agq6/rVPCkB0Bni5OJP2/87mwMtii7W3/i22wF+/cLYBJW8bFxRZckmfjobgy1JjJSkQmz6sEBsebgIFfOYgL72e0w0QP8WN4XNZYg== Received: from DM6PR04CA0005.namprd04.prod.outlook.com (2603:10b6:5:334::10) by DM6PR12MB3324.namprd12.prod.outlook.com (2603:10b6:5:11e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Wed, 24 Mar 2021 22:01:32 +0000 Received: from DM6NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:5:334:cafe::84) by DM6PR04CA0005.outlook.office365.com (2603:10b6:5:334::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Wed, 24 Mar 2021 22:01:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; kvack.org; dkim=none (message not signed) header.d=none;kvack.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT004.mail.protection.outlook.com (10.13.172.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 24 Mar 2021 22:01:32 +0000 Received: from dhcp-10-2-49-164.owa-p4-only.scl-ca.nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 24 Mar 2021 22:01:28 +0000 Subject: Re: [PATCH v7] mm: cma: support sysfs To: Dmitry Osipenko , Minchan Kim , Andrew Morton CC: linux-mm , LKML , , , , , Colin Ian King References: <20210324205503.2132082-1-minchan@kernel.org> <65840bfd-4471-7c8d-ce71-c4705baf3bfe@gmail.com> From: John Hubbard Message-ID: <0ac4d495-eece-fb71-d334-a46e069b0c35@nvidia.com> Date: Wed, 24 Mar 2021 15:01:28 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <65840bfd-4471-7c8d-ce71-c4705baf3bfe@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f9360be-a2bc-46cf-58e6-08d8ef10627a X-MS-TrafficTypeDiagnostic: DM6PR12MB3324: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OwiYx1s7UZTkqqmXlmSrPvUas5JDBRTrt5tv3vi6SYn+WT/KJQ6eBI3MWwuoYU+dFV7+66dyM73LoC07QJersA7oJUuS/KSBrMQZj6tWLRbR4qBGE7YQNMj4ZFAfc83gtg2JvYW2oifmCiPtM1h6H5Q96XWhjFDgu+sHMjQzEcHNcICQONpX7AFsFHpzzLFM88W7/dExRJpM5TWt3kn9oPmrQ8UGkgv5xKTvE3Mwx7JPFswrJRMrD5sLDjgUMSlALGBrPzCSKeSaaSt4ySWxnDg+UrCK7XR8ijsD4+clr3D6QaifAbUXN0ksyZJjQ6InkTHlTNpcUVwLk1Ts4OTENqLilSkBC+H0UVO/6cDfo5tcYQ1KBV61ohjfsPnZ3OhNy/fEdllqUtTYfNaPTsFId79ispxajNbzFKxqzB+1/JW/QRjiy5yWtANTcRSExZXvg2wDI+F/3lJDjEl09nxDPjafnSCeqzau7QhXi1XfKbjy0G5Mx9rFP+isubhOmxkJXcewQzjuHZ3h7dAIyRxSzAY/fHBR/v+/+RKK8gGhZpXgRmNLFMe63VzFl1X0K8Gctb0vqjYe9LiZ8Z/iB60Py5hNv3EaPrEmEjk6wPBqkPGc2iMAiLH3KFui6+EvW+7Jlhde+EPdUjByFHoidB7C5iQL7BsWrapFR63aYDFy+XybXKKmb0PWtZ7hHLBqPoyT X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(46966006)(36840700001)(356005)(31686004)(2616005)(426003)(4326008)(4744005)(7636003)(186003)(47076005)(26005)(2906002)(7696005)(8676002)(36756003)(336012)(8936002)(82740400003)(16526019)(54906003)(110136005)(36906005)(70586007)(53546011)(316002)(7416002)(5660300002)(82310400003)(478600001)(31696002)(83380400001)(36860700001)(70206006)(86362001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 22:01:32.2446 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9360be-a2bc-46cf-58e6-08d8ef10627a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3324 X-Stat-Signature: 61gbop3jkdg8ueosu778mkxxnhfincmy X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3E55BA000395 Received-SPF: none (nvidia.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=NAM11-BN8-obe.outbound.protection.outlook.com; client-ip=40.107.236.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616623293-387644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/24/21 2:31 PM, Dmitry Osipenko wrote: > ... >> +#include >> + >> +struct cma_kobject { >> + struct cma *cma; >> + struct kobject kobj; > > If you'll place the kobj as the first member of the struct, then > container_of will be a no-op. > However, *this does not matter*. Let's not get carried away. If container_of() ends up as a compile-time addition of +8, instead of +0, there is not going to be a visible effect in the world. Or do you have some perf data to the contrary? Sometimes these kinds of things matter. But other times, they are just pointless to fret about, and this is once such case. thanks, -- John Hubbard NVIDIA