From: David Hildenbrand <david@redhat.com>
To: "Maíra Canal" <mcanal@igalia.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Hugh Dickins" <hughd@google.com>,
"Barry Song" <baohua@kernel.org>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Lance Yang" <ioworker0@gmail.com>
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-dev@igalia.com
Subject: Re: [PATCH 1/3] mm: fix the format of the kernel parameter ``thp_anon=``
Date: Mon, 28 Oct 2024 13:22:56 +0100 [thread overview]
Message-ID: <0abc2d1f-279c-48a1-be0b-bc7e249d0554@redhat.com> (raw)
In-Reply-To: <20241027175743.1056710-2-mcanal@igalia.com>
On 27.10.24 18:36, Maíra Canal wrote:
> If we add ``thp_anon=32,64KB:always`` to the kernel command line, we
> will see the following error:
^ did you mean "64K" instead of "64KB" ?
>
> [ 0.000000] huge_memory: thp_anon=32,64K:always: error parsing string, ignoring setting
>
> This happens because the correct format isn't ``thp_anon=<size>,<size>[KMG]:<state>```,
> as [KMG] must follow each number to especify its unit. So, the correct
> format is ``thp_anon=<size>[KMG],<size>[KMG]:<state>```.
>
> Therefore, adjust the documentation to reflect the correct format of the
> parameter ``thp_anon=``.
>
> Fixes: dd4d30d1cdbe ("mm: override mTHP "enabled" defaults at kernel cmdline")
As Barry says, this is a doc fix and we should make that clearer in the
subject. With that:
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-10-28 12:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 17:36 [PATCH 0/3] mm: add more kernel parameters to control mTHP Maíra Canal
2024-10-27 17:36 ` [PATCH 1/3] mm: fix the format of the kernel parameter ``thp_anon=`` Maíra Canal
2024-10-27 19:52 ` Barry Song
2024-10-27 20:36 ` Maíra Canal
2024-10-27 21:46 ` Barry Song
2024-10-28 12:22 ` David Hildenbrand [this message]
2024-10-27 17:36 ` [PATCH 2/3] mm: shmem: control THP support through the kernel command line Maíra Canal
2024-10-28 3:31 ` Baolin Wang
2024-10-27 17:36 ` [PATCH 3/3] mm: shmem: override mTHP shmem default with a kernel parameter Maíra Canal
2024-10-27 21:54 ` Barry Song
2024-10-28 1:21 ` Lance Yang
2024-10-28 10:09 ` Maíra Canal
2024-10-28 11:09 ` Barry Song
2024-10-28 11:34 ` Maíra Canal
2024-10-28 22:35 ` Barry Song
2024-10-29 0:31 ` Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0abc2d1f-279c-48a1-be0b-bc7e249d0554@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcanal@igalia.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox