From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06570ECAAD1 for ; Wed, 31 Aug 2022 19:25:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73C5C6B0072; Wed, 31 Aug 2022 15:25:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EBCD8D0002; Wed, 31 Aug 2022 15:25:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D9FF8D0001; Wed, 31 Aug 2022 15:25:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4FB5A6B0072 for ; Wed, 31 Aug 2022 15:25:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E6AA980D77 for ; Wed, 31 Aug 2022 19:25:27 +0000 (UTC) X-FDA: 79860866694.15.BBF72B6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 86EDE18004B for ; Wed, 31 Aug 2022 19:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661973927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y3ggwS2nrH2KekbfZ8v1RY68Sf9S2v0ryOgRAbqObHY=; b=MbvWZrPydzf+A6bjyFPrEKpBK8zEt+GxAabdDbdCy/mrV84tACXoblEwXB4cArEVkv5reU NNPUHdCSs2MRPnUqOJVY7DRDJXEkEJXuJSL3YdPdu2hJGBdnN0BqKUQEz8YbDsB4t/SE+r LcRdRLkRTtT8YEu8wimjVxdUloquSpE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-654-TV_I66x7PkCOyv5ldXCRbw-1; Wed, 31 Aug 2022 15:25:25 -0400 X-MC-Unique: TV_I66x7PkCOyv5ldXCRbw-1 Received: by mail-wm1-f72.google.com with SMTP id b16-20020a05600c4e1000b003a5a47762c3so8675871wmq.9 for ; Wed, 31 Aug 2022 12:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=y3ggwS2nrH2KekbfZ8v1RY68Sf9S2v0ryOgRAbqObHY=; b=srEPNyZmMhUD4ghnvaCy9PDdIeuKPe+1WnWHgcq1AZchVXk7a3UTf/cZXRhhldzouO 78Px5gdoo1ZU2K8Ytiy1rMK/vlrKt5JJEuk0l/l8MzS7UPWKuJJ/k51IO8b9SZrJ3QVg UdxXGHMep9DWzufIM2b6ZhX7BeSPnZAuOyRb43cPFRmk4Sc2f2nL6Q4rvKLzvHcKQ2by evVdjDrKQ5+7sJaULvlER/InA339dmczyLXJlZpqH17eqyT2XzkdQBjRWf0bvgMLPaSa hz+LRo6XnD23EUonKWL66IQ3NqeGNwSThFr2nGXMHa0+nItD8zTqP3puBEAwn7RFW7XM 6WqQ== X-Gm-Message-State: ACgBeo1cYsTfQiptHMcU+QIHjdn5TTpOKRBcfRzFBlWzYrGr6eWBYync iEjmcD76+/3kZvjzf7Q/kJQDQz0KLLR9ZNMBgd7P/Tdb+373A6zvfUhB/yyWbhj9Z2O/i5Fo7h5 zXMTwXgsGOFk= X-Received: by 2002:a05:6000:795:b0:226:e8d9:828c with SMTP id bu21-20020a056000079500b00226e8d9828cmr3618485wrb.464.1661973924584; Wed, 31 Aug 2022 12:25:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR4fs8by6IoJFQ787oFgJNHbEqCREzybMcTnbSuDfwQnhjlpKfAOJG3sm+OqTQ8QlSY6Go1zUQ== X-Received: by 2002:a05:6000:795:b0:226:e8d9:828c with SMTP id bu21-20020a056000079500b00226e8d9828cmr3618473wrb.464.1661973924345; Wed, 31 Aug 2022 12:25:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2900:1613:4308:aca3:2786? (p200300cbc706290016134308aca32786.dip0.t-ipconnect.de. [2003:cb:c706:2900:1613:4308:aca3:2786]) by smtp.gmail.com with ESMTPSA id n42-20020a05600c502a00b003a83ac538a1sm3030022wmr.29.2022.08.31.12.25.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 12:25:23 -0700 (PDT) Message-ID: <0aba2bfc-9f10-2fb1-1858-d8eb04b5d52e@redhat.com> Date: Wed, 31 Aug 2022 21:25:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 2/3] mm/gup: use gup_can_follow_protnone() also in GUP-fast To: Peter Xu Cc: John Hubbard , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mel Gorman , "Matthew Wilcox (Oracle)" , Andrea Arcangeli , Hugh Dickins , Alistair Popple References: <20220825164659.89824-1-david@redhat.com> <20220825164659.89824-3-david@redhat.com> <1892f6de-fd22-0e8b-3ff6-4c8641e1c68e@redhat.com> <2e20c90d-4d1f-dd83-aa63-9d8d17021263@redhat.com> <9ce3aaaa-71a6-5a81-16a3-36e6763feb91@redhat.com> <9a4fe603-950e-785b-6281-2e309256463f@nvidia.com> <68b38ac4-c680-b694-21a9-1971396d63b9@redhat.com> <4d067a99-1112-3b3d-bedf-35c1124904fd@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661973927; a=rsa-sha256; cv=none; b=VN1osmryDQI8bWcVpwGEiLd+uF6zs9y4Hqayg8ng2AnK+8TJ7OeU1q1x3yRY4sMMWzoU+A 9MVr2nGitIRkXK+iPNnrkxQ5zYhfjL8WwSHEGVCLuPMnyn/rYq8KJz/T6jpROmQGQ7Bn31 AXCTL1B909hoJAuWqICdo6nbKMwEAnM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MbvWZrPy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661973927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y3ggwS2nrH2KekbfZ8v1RY68Sf9S2v0ryOgRAbqObHY=; b=o4vLR3B+YoDrtdOCtC1W1wHyTIdoQNcyviMPq0fdzi1+zvbolRfL/DQ1i5xn7N6HbEowsO FHACK6sEq8dUv9Fsx8p6K7gPbb9oGiS8eohd5TArTeqqZ0lns4ZC0gUhGbC4MYsj2wtz3f mvDPCiOBB1UbvGgPuOpvGjOCuyAcxwI= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MbvWZrPy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: j614au4a1pj9yymxhpgjdmougajturcw X-Rspamd-Queue-Id: 86EDE18004B X-HE-Tag: 1661973927-646105 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>>> diff --git a/mm/ksm.c b/mm/ksm.c >>>> index d7526c705081..971cf923c0eb 100644 >>>> --- a/mm/ksm.c >>>> +++ b/mm/ksm.c >>>> @@ -1091,6 +1091,7 @@ static int write_protect_page(struct vm_area_struct *vma, struct page *page, >>>> goto out_unlock; >>>> } >>>> >>>> + /* See page_try_share_anon_rmap(): clear PTE first. */ >>>> if (anon_exclusive && page_try_share_anon_rmap(page)) { >>>> set_pte_at(mm, pvmw.address, pvmw.pte, entry); >>>> goto out_unlock; >>>> diff --git a/mm/migrate_device.c b/mm/migrate_device.c >>>> index 27fb37d65476..47e955212f15 100644 >>>> --- a/mm/migrate_device.c >>>> +++ b/mm/migrate_device.c >>>> @@ -193,20 +193,16 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, >>>> bool anon_exclusive; >>>> pte_t swp_pte; >>>> >>> >>> flush_cache_page() missing here? >> >> Hmm, wouldn't that already be missing on the !anon path right now? > > Yes, I think Alistair plans to fix it too in the other patchset. So either > this will rebase to that or it should fix it too. Thanks, > I'll include it in this patch for now, because by dropping it I would make the situation "worse". But most probably we want a separate fix upfront that we can properly backport to older kernels. Thanks! -- Thanks, David / dhildenb