From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1E8C4332F for ; Wed, 16 Nov 2022 18:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBE9C6B0074; Wed, 16 Nov 2022 13:32:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6EEB6B0075; Wed, 16 Nov 2022 13:32:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C364B6B0078; Wed, 16 Nov 2022 13:32:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B32786B0074 for ; Wed, 16 Nov 2022 13:32:10 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5CA4DA3723 for ; Wed, 16 Nov 2022 18:32:10 +0000 (UTC) X-FDA: 80140150020.30.BEB0710 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf18.hostedemail.com (Postfix) with ESMTP id 940B61C0010 for ; Wed, 16 Nov 2022 18:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668623529; x=1700159529; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=9R89P7Fn5UnS6fXNsmjWkdjOCqGyO+Ikj7R423cX13o=; b=czL0kcrka53tfgoKq6AjnbN0j9mT8ftDyixnuZFf96J0taWpK5+KPd4U xPshFE6JnOYICQPZqSLyBneHCemykZRuZ5btbQHOlZNh45rwZ9HelxiLG 87ENQK8oxh5cgKX2va2cVabOYl0w6q6hJ3q5x7KzOr30rEf4kUxptzWfK HsfcstJFnqLF6gl5YsBE/WfuBA6D+39z2KVKbdp3BVgNwWTReiphPKOzW gXtP4L3UsXezOuFGW/wzkJxix7USyZR0UMzCsqAEGdX1eKEM05b89WbOH ij+nULSbVXISiVFWLWW8SIu6ipzcyw9ukca7wcfVxYbJ7LqfhADE9egv8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="292333587" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="292333587" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 10:32:08 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="670601611" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="670601611" Received: from aagbadea-mobl.amr.corp.intel.com (HELO [10.252.138.56]) ([10.252.138.56]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 10:32:06 -0800 Message-ID: <0ab63cf5-7587-0347-22bf-0987704a5153@intel.com> Date: Wed, 16 Nov 2022 10:32:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH Part2 v6 14/49] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled Content-Language: en-US To: Vlastimil Babka , "Kalra, Ashish" , Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, michael.roth@amd.com, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, "Kaplan, David" , Naoya Horiguchi , Miaohe Lin , Oscar Salvador References: <3a51840f6a80c87b39632dc728dbd9b5dd444cd7.1655761627.git.ashish.kalra@amd.com> <380c9748-1c86-4763-ea18-b884280a3b60@amd.com> <6511c122-d5cc-3f8d-9651-7c2cd67dc5af@amd.com> <7882353e-2b13-d35a-b462-cef35ee56f51@suse.cz> <5b27a05e-09ad-9139-67b1-77b90731419f@amd.com> <9d9f1afe-c981-4df9-f012-89c4cb783cc3@amd.com> <973c6f79-38ad-aa30-bfec-c2a1c7db5d70@suse.cz> <8692e736-7518-d6d2-ae83-720e42e7a059@amd.com> <41b8c83e-2a1a-1dda-945e-99329ca8e7e9@suse.cz> From: Dave Hansen In-Reply-To: <41b8c83e-2a1a-1dda-945e-99329ca8e7e9@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668623530; a=rsa-sha256; cv=none; b=fJihKFsflH7q9/CtN5nNdveR78sPqQH7aQGrOUruUaVcoa//r4IN05aTarlxK/k6vQ+ETw 7iYPNXF2YjAn3wLGqnWQ/pGgoffkLlN2d08VMR3FksE+AfSs3zPtAUSpwJegh4c8/q5ts/ NdrvBTlEOZnTQNkyeLVpmk7cZpZJc1Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=czL0kcrk; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668623530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SKs/cQ9tW7DBi0YB79F3rhg/wFGe5BV+AZfeB8CLM8Y=; b=S1IxzqYtkIhutI46k0nHvO+v6H/3BMVLsWaBHwtW5j+Ioe6fnyaiUVHdD3XyyR1/WOapOd Hk2xwnnT6+oTRjyL2/ryGd7Ue3BUl/M2KWwWP213L5KUJaV+QC7aN9ue0WSN1x92Zc49Zl ECxiPvfXxQTqJj8duNTSxCrAl0/G2xY= X-Rspam-User: X-Stat-Signature: iqghz3bdc5z4ipb9u1i5tdkogkkdydyk X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 940B61C0010 Authentication-Results: imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=czL0kcrk; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1668623529-864724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/16/22 02:25, Vlastimil Babka wrote: >> Referring back to your thoughts about putting these pages on some leaked >> pages list, do any such leaked pages list exist currently ? > Not AFAIK, you could just create a list_head somewhere appropriate (some snp > state structure?) and put the pages there, maybe with a counter exposed in > debugs. The point would be mostly that if something goes so wrong it would > be leaking substantial amounts of memory, we can at least recognize the > cause (but I suppose the dmesg will be also full of messages) and e.g. find > the pages in a crash dump. It might also be worth looking through the places that check PageHWPoison() and making sure that none of them are poking into the page contents. It's also the kind of thing that adding some CONFIG_DEBUG_VM checks might help with. For instance, nobody should ever be kmap*()'ing a private page. The same might even go for pin_user_pages().