From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC592EDEC50 for ; Wed, 13 Sep 2023 13:34:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63DC36B012E; Wed, 13 Sep 2023 09:34:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE066B015D; Wed, 13 Sep 2023 09:34:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48F2C6B0199; Wed, 13 Sep 2023 09:34:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 32DB56B012E for ; Wed, 13 Sep 2023 09:34:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 01713403F3 for ; Wed, 13 Sep 2023 13:34:45 +0000 (UTC) X-FDA: 81231669372.02.7D34A24 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 961361C003D for ; Wed, 13 Sep 2023 13:34:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aCFCxXd6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l4wqlyRC; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694612084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4+RU0KIou9w9utdTOlx7DUMD1ZLCYn2PIUlTEIwiPpQ=; b=1L+UBdlZUJcdYuSifc41F3qWGHbX1YOiMyI5UCZ5uo5bCzCRRRQ7UAuAyjseDUjIMCOkqf HyDzrPO5IVhhKKSCzut1U0nBYVAJFOg9i9Wzz3uUpaQavZ9pHdcaOZ2CK0FmXKbXOFmXu8 H3tgLyUOAt+flZXEgc2Xw/LrJnp7SRU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694612084; a=rsa-sha256; cv=none; b=NN/vO3t7gO0zNi3e+JIt938R9tc/wDcWxR2ZT/+JY9vWnci5eZhp9UN0dMJd++f/qsOgkR XBZ892rZzZ0yopVXsm3cpsbrTW65NETCLsYRHbJI8+H7uOAqODB8+zu61OAOD39nybKJo8 7trZLbGff4IAL+TukFh2aswODBJpG24= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aCFCxXd6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l4wqlyRC; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6F3341F385; Wed, 13 Sep 2023 13:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1694612081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4+RU0KIou9w9utdTOlx7DUMD1ZLCYn2PIUlTEIwiPpQ=; b=aCFCxXd6M2W+F3UzYQaNY77FvUcYJ8khNloHjjQtvOvMWDWoOut6dh0nHef5yWXRhWn1wD Wf21nb56OtPECrnLRO+jLxC2Lz/oDags+po3ayu+WQW/Je43EMNMpr2bvSm9xY0oM86Yfu uLq/vyzRMBh03DbYk2YRcGGHgCw10CE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1694612081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4+RU0KIou9w9utdTOlx7DUMD1ZLCYn2PIUlTEIwiPpQ=; b=l4wqlyRCrqZWIrDDXO1m6/Gv1kjwqx0BpcdarYxHEY5KwbWpK5OeZ6ThGY1Nu8OPyOTBI4 1TwptIIoeGmSlLBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 539EA13582; Wed, 13 Sep 2023 13:34:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KYO6E3G6AWXLSAAAMHmgww (envelope-from ); Wed, 13 Sep 2023 13:34:41 +0000 Message-ID: <0ab2495b-c110-c1b6-bd37-dbd163412a48@suse.cz> Date: Wed, 13 Sep 2023 15:34:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/6] mm: page_alloc: remove pcppage migratetype caching Content-Language: en-US To: Johannes Weiner Cc: Andrew Morton , Mel Gorman , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-2-hannes@cmpxchg.org> <20230912145028.GA3228@cmpxchg.org> <320c16a7-96b7-65ec-3d80-2eace0ddb290@suse.cz> <20230913132412.GA45543@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20230913132412.GA45543@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 961361C003D X-Rspam-User: X-Stat-Signature: 8yi48h9ndq5rdon7mmf5cds4xu4ud9ze X-Rspamd-Server: rspam03 X-HE-Tag: 1694612083-918138 X-HE-Meta: U2FsdGVkX1/UIheRChV/rMpc9QbxyhxghkX7lPKm/HqFKwHDBy9Zg0HBYYbSRGGYo4sFo8s2qz7LqDKnwyfTir6C/JjfkMNmo4xkZFQo+F63Qefwpm/8ZrKSZ7MA3AkeNW6IVJwKa23BrM2xmyVLi7z9dkEynqJAWJt+Z/5rjBRHpkWouZCGBdplVscfOG69TRk66uCLCkdbTA2kV+cxHoQ3R22x/EfM8Cdx6xLK3gNU/SaJx31hx6OfaxzmID/nQyyDNEaqzVe8ZI7azayrVP2eFuodHVHwhgrgxYtIUlaRGJ+07yuSxHqFTUWWJOTDb2MVwyyMfJ503u6kvbT0eDaG5XgKAo1WFGwiqUn2UtH3slN0uPC8CEK2YQpS1TaZuIx9oD6r8pyb213/rOuoGO8tlpYr6Eor5YhwVo+JpiRFwaQtI0QESjsdPlWx5f0nGduocb6Pem+eV8W6e4eQv3TLMMakv85rj6VHImP/GtWryms40qs1zv1NJMaVqoIBXxktf/W/x4y4x41kv/Aj8+gBTFc0hFPG2u+xhGFqMpISFsnhAKGdVUZ7lxA/fVR04MzooZ4gvZ6OHe7LESvgUUFQesOIJevhYB8GVX5bygfDkrTBbjLsgFslfyctdJ/3cOhSUh1mP3IcCLohI3DbrrSNdHtqyEgiXRXqWCslIYF4bpxZ5HqoJqElXfhIqKoa+bL+Lm5S5fvNofmLT/2RXXuoaxjlTXjGHyqS6vs+pQmSegPVzlqbk58oJJs6d6i5p8lEaHnkJzmqE+x3RTg+ezLJpgaTKsMzYEue403/jSOUEucbHuuD9prg3DUjkMKBi21zuEvwkpQQzV22cE6edC5ZuhjjCzM/Z+ku8LFrt1te6aIFmidpIDXBrruY04cZs2QkpwDsffXOIZ111TZrIMAXMDCAoIUGkVCQ+P4GrJ5sdmDmUwJpl9CsxrKbIkyjfbq8wikdMYYEKeuQesp pKqm7VP1 7NT+0o7dxMw+PUYDyqXnqMtooOcNcO63QHOOg87IsxdfKGqkzI2kTLJ5RXxuYxF4geBetQ1vrPwdTehXDzE1NAexLunzhj9jRlxdt/2hlLlYeqUA7PXAPx2bBqf7dkZPjqfzDDV6uwnUl0AwpuRyfPP8Kx3K6iGkvpnhRKxpCpzGyNfxNI3W2wZLCKl9Eh1nt/HIWii8E0t0hIF8Xy+5Choc2Tpm1RR4iU99a+JveK/0vgz4sMI9GE/KgDHCc385sAD0FMRjf8uYG/jNtiieZpBQhUW4BI1iC+Y9j7TojMD7/bx8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/13/23 15:24, Johannes Weiner wrote: > Hello Vlastimil, > > On Wed, Sep 13, 2023 at 11:33:52AM +0200, Vlastimil Babka wrote: >> On 9/12/23 16:50, Johannes Weiner wrote: >> > From 429d13322819ab38b3ba2fad6d1495997819ccc2 Mon Sep 17 00:00:00 2001 >> > From: Johannes Weiner >> > Date: Tue, 12 Sep 2023 10:16:10 -0400 >> > Subject: [PATCH] mm: page_alloc: optimize free_unref_page_list() >> > >> > Move direct freeing of isolated pages to the lock-breaking block in >> > the second loop. This saves an unnecessary migratetype reassessment. >> > >> > Minor comment and local variable scoping cleanups. >> >> Looks like batch_count and locked_zone could be moved to the loop scope as well. > > Hm they both maintain values over multiple iterations, so I don't > think that's possible. Am I missing something? True, disregard :D >> > Suggested-by: Vlastimil Babka >> > Signed-off-by: Johannes Weiner >> >> Reviewed-by: Vlastimil Babka > > Thanks! I'll send this out properly with your tag. np!