From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFE4C433F5 for ; Tue, 17 May 2022 03:32:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5347A8D0008; Mon, 16 May 2022 23:32:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BC1F8D0003; Mon, 16 May 2022 23:32:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35CE48D0008; Mon, 16 May 2022 23:32:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 23BAD8D0003 for ; Mon, 16 May 2022 23:32:33 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E6333608ED for ; Tue, 17 May 2022 03:32:32 +0000 (UTC) X-FDA: 79473812544.27.D882EED Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf19.hostedemail.com (Postfix) with ESMTP id 01B071A0088 for ; Tue, 17 May 2022 03:32:21 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id b18so29037462lfv.9 for ; Mon, 16 May 2022 20:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ER2JX2zn+fukFDj6cClopw15+MZZU+3In4sQBn9YEFk=; b=NGkGnmfB5hvf424RmyFYy0K3036u5k8OG3f+rE/p8W6RGg8LrqLjoJxzhtgxQyotps 5iy548Kd43P0+luHulBEo7p59aoSKmB5FhinQ1LWqfQQ8/ynOgjgb1/+Uep1XAuI5cxR HgcmxcXE1cGRyXj36GkUFF++kXN+XchmJqgFSu940B8AqNajhzliO237KUje42Yp6z8N 578LoRGdb6BrtYVYr8vLUjUXkA5a17N90mV6LZdi/V8tsxEeHjPBySZrhykMpctrnUoF 88Gy9aMJYmgqpy3RyNWQ3Xz/1JG2DpE1J81w/ZL6w9PDRjaOeT4tQIl4HwFIiyQQIU6c KXPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ER2JX2zn+fukFDj6cClopw15+MZZU+3In4sQBn9YEFk=; b=giwJns+z38JPqm2ygbpARQnfok98AkBnnYYE4+TDPPCKXMNZI6DBxwWEC2PyibNQUe k7GtNZzZD9sQ2r08upF09Ppvb8hptPYb58AwqYQ5VuJeWC9nPgTmHFREHkonyH0/AVCH eCoW7JJ/hJHOzh+OiuomwTPcsvkwqlZGr2uXvgOrGRfN8eDU436kCwk2/T+P4C/suFm6 1TdcWA+nijaRl8wWuSs4lVq60TCaGXCWsvH6JeB3d0nk1dqLbWX3TUEtjIUSmB0rrICG dHz84+Q4j2JyWQkM3DJfvaD7plPRLtOap5gYpxacu+qcbXySkcb+e4E02DjcRPV5DlpX QW1w== X-Gm-Message-State: AOAM5315aGRqwsrl5MiFNx4+nb5JhcOLfE2R2zE34051FCslT4tdvNZ4 WdbNYiaurbblZ//oUe5UgKAx6w== X-Google-Smtp-Source: ABdhPJx1INatyM5mlT8qQoY5ZCm2wYSuDesHOSmXNYRGYANspxQpW5ceCyQ+Pj0YWrDX9n1p5BqKdw== X-Received: by 2002:a05:6512:ba9:b0:477:9e15:a6ec with SMTP id b41-20020a0565120ba900b004779e15a6ecmr1639004lfv.315.1652758350166; Mon, 16 May 2022 20:32:30 -0700 (PDT) Received: from [192.168.1.72] (46-138-221-128.dynamic.spd-mgts.ru. [46.138.221.128]) by smtp.gmail.com with ESMTPSA id x4-20020a2e9c84000000b0024f3d1dae8esm1746972lji.22.2022.05.16.20.32.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 20:32:29 -0700 (PDT) Message-ID: <0aaf7b6d-6ed7-45ca-873e-394718f73c9a@openvz.org> Date: Tue, 17 May 2022 06:32:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] tracing: add ACCOUNT flag for allocations from marked slab caches Content-Language: en-US To: Shakeel Butt Cc: Roman Gushchin , Vlastimil Babka , Andrew Morton , Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , kernel@openvz.org, Linux MM , LKML , Michal Hocko References: <1fd21e25-b095-e055-fc2e-abda640a0575@openvz.org> From: Vasily Averin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: cxi6s8si5h7jqjs3nkb6r9p8gjpfn4pd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 01B071A0088 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=NGkGnmfB; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf19.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.52 as permitted sender) smtp.mailfrom=vvs@openvz.org X-HE-Tag: 1652758341-687937 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/16/22 22:10, Shakeel Butt wrote: > On Mon, May 16, 2022 at 11:53 AM Vasily Averin wrote: >> +++ b/mm/slab.c >> @@ -3492,6 +3492,9 @@ void *__kmem_cache_alloc_lru(struct kmem_cache *cachep, struct list_lru *lru, > > What about kmem_cache_alloc_node()? Thank you for the hint, I was inaccurate and missed *_node. >> { >> void *ret = slab_alloc(cachep, lru, flags, cachep->object_size, _RET_IP_); >> >> + if (cachep->flags & SLAB_ACCOUNT) > > Should this 'if' be unlikely() or should we trace cachep->flags > explicitly to avoid this branch altogether? In general output of cachep->flags can be useful, but at the moment I am only interested in SLAB_ACCOUNT flag and in any case I would prefer to translate it to GFP_ACCOUNT. So I'm going to use unlikely() in v2 patch version. >> + flags |= __GFP_ACCOUNT; >> + >> trace_kmem_cache_alloc(_RET_IP_, ret, >> cachep->object_size, cachep->size, flags); >> Thank you, Vasily Averin