From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09C3C5AD49 for ; Fri, 30 May 2025 22:49:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4197E6B0172; Fri, 30 May 2025 18:49:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F0E56B0178; Fri, 30 May 2025 18:49:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3099A6B0179; Fri, 30 May 2025 18:49:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 12FFC6B0172 for ; Fri, 30 May 2025 18:49:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B91551403F8 for ; Fri, 30 May 2025 22:49:10 +0000 (UTC) X-FDA: 83501066460.13.CDE193C Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf18.hostedemail.com (Postfix) with ESMTP id E17461C0008 for ; Fri, 30 May 2025 22:49:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748645348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bi4AOBUbKUwjOuEL2jSTsWSVNmI8uaAnzFkdjk5x+8=; b=KWwqfDxMUFE7lZ76fXATCbHpiP8OO7gPGTAh6h2bbpSI//k2067lgyS6Wk1zAbtKCZmH7D rM0lxldcBRri751GEZ+LxVT1yADi8nHgNlTr+Y69Jt7NJCozJsj/iA0rAELCHD7MUNpd3V NSjxil2LY07ExrKJs//WyrK35VPkROA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748645348; a=rsa-sha256; cv=none; b=EBA2FMoli4fHRGXOuPmsX5A4JEyQxxJAxw4X+VSTgDb1zUTuqkZtCKuqo+Vx80Dnes0Him coQwf+m0eMx1XkbdJabZBMJv7gzXVfUcOOPkNmBjpEcdfcM/4W656i1cJS1WvRHUNgIAs8 Egw3aqbVLiNMDfPAB2nOL8WgXxnKcOQ= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4b8JM12Jy4zYQvBy for ; Sat, 31 May 2025 06:49:01 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 6914D1A018C for ; Sat, 31 May 2025 06:49:00 +0800 (CST) Received: from [10.82.57.70] (unknown [10.82.57.70]) by APP2 (Coremail) with SMTP id Syh0CgCnsWTYNTpoIKGjNw--.13722S2; Sat, 31 May 2025 06:48:58 +0800 (CST) Message-ID: <0a91d1bd-eaa1-4ae3-9212-e63d456f7754@huaweicloud.com> Date: Sat, 31 May 2025 06:48:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: David Hildenbrand Cc: Oleg Nesterov , lorenzo.stoakes@oracle.com, mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> <57533126-eb30-4b56-bc4d-2f27514ae5ad@huaweicloud.com> <956124be-c73c-4023-9edd-25372f3f865a@huaweicloud.com> <20250530180920.GC25160@redhat.com> <0dcec9f4-eef8-499d-a96a-dc6ab3433039@redhat.com> Content-Language: en-US From: Pu Lehui In-Reply-To: <0dcec9f4-eef8-499d-a96a-dc6ab3433039@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:Syh0CgCnsWTYNTpoIKGjNw--.13722S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cr1rGF4fWFWfWr1fJr4UCFg_yoW8Xw18pa yFvayYgr4rKr18Ar4Ika109F4Yv3yfG3yUCr15Jw13CFWjgF1akrWI9r4Y9Fnruwsa9F10 ywsFgFy0y34jvaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvjb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AF wI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43 MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUF1 v3UUUUU X-CM-SenderInfo: psxovxtxl6x35dzhxuhorxvhhfrp/ X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E17461C0008 X-Stat-Signature: ig1rexqb1wypemjxuice9jz1f9bmozyw X-Rspam-User: X-HE-Tag: 1748645344-780509 X-HE-Meta: U2FsdGVkX1/oEyH4MLGHkb8xfkS6XauSbuPuuwbzQ8CONdsu8APfcUcgoM4J+iZB9YjsD3JuvNWef7oQ84KMFdhI5ejJtu60VHMiau1fXDGF3ISRjsjT4xXEaUarDeGaXw2bGDAzB5E54Pjj/1PTwvrC8eaGItbYR67LQ5XlsbjE0hyS8XfMfrCzdEqZeYh46p8Lr14B19x+28gi+7V8j73W45SqraVVIrt+jI0Zy8Cad+JqukP3voaCiGNVlJsJts5ChgIUQ6Qxrjx79XtaF8GZ59pI5RghvRFUYBEVJNahtnEi+iF5eKfT7rOyvw5LY/05IZCT49C9IT3SuEJdpGqLSSOV1FZlFKuta1YwCUCo5D3bVbjvj7sX396n0jXWOq7NpqWH89Qm9wgTGM+nUm+gHbIMQ0sdBbk+r7luspzCcMa0MjuMKtznehVEIWUaeg0Zqd0x3dCfMt0fOIJ1ooWz43Z1KvUMjWSUGjoXOEwkPQj/qY8i05WP3EhcIW2TZrntN7vQjtqCdmL7JFxAA+CwKmULhSq7brmUmTangMr1/vVJPkvm6Lpl9tjlZzKFxccZjxs0g3k3gW71u4nwVz9L6UNeupEYhLJd4HeoVu9jwDlZpfOvrnX37ua1ROB6MlHHkkSAkJOxUMspXNmeY5s5q3tY7LP4KGQmFDyC5OU3WdXsLLHEbML+Cb47Cu6Frw/Pm9uOl9WTPRwnn/uEqOtYMrtapBrFsGRn2Juyli9KD68pZREreMctaIKCVbBJm4sepHY40f1a5s9iIYhmGLzVDfAcFlLocQNyPc0K/Dis3WN1xHPLFb/qFdxl4IRveQSRiNczC3OhnPGL5GXGlOqOxCAiP87pt3nQPxkhGp99sajbN2cRCc48YY00iqGMKRzJfHn0FfRUrnLo2vfj+qzRaIybEM8NOZulSfA20Bgl+NX5byJtnjOnzSFgb0OuFC2fuHybsFw6P1udHBh HrEPIz5N 4tm0Bla8GjaXNGGyFYq6EGBe6NgIrY7j72zboX41r+nlV8ySCACyq4MRUeVE0zzzY4lHjGJqYOnhrWEoZGPi0m5fnn2GJKxPM+Hk2BzOCH5Erhk5Ps4ll+PQmbFr8+xwik01c3w/yILIiqpgDvYZVBW/PGySYeptiIk9cq4vgPKrmR1Mnuzf820ko3yCjMIUuolyL64xEen4g87lyjq4llmxxC9CdRs5sEikyW+IBqvCcAuX40d+8b5RgR/0sfAKzjksP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/2025 2:34 AM, David Hildenbrand wrote: > On 30.05.25 20:09, Oleg Nesterov wrote: >> Well, let me say this again ;) I can't really comment, I don't understand >> this code enough. >> >> That said... >> >> On 05/30, David Hildenbrand wrote: >>> >>> I wonder if there might be a clean way to move the uprobe_mmap() out of >>> vma_complete(). >> >> Me too. >> >> Not only the uprobe_mmap() calls in vma_complete() doesn't look right >> "in general" (at least to me). >> >> To remind, vma_complete/uprobe_mmap/install_breakpoint is not even called >> in, say, this case when VMA grows and moves. See >> https://lore.kernel.org/all/20250526173845.GC4156@redhat.com/ >> I guess we don't really care, but still... >> >> >> But just in case... I agree with Lehui and Lorenzo in that we need a >> short >> term fix, and the last patch from Lehui seems to fix the immediate >> problem. > > Oh, there was a new patch yesterday. Too bad I wasn't CCed on that. > Oops...I just realized that you weren't included in the CC list. I had been using the send script which referencing the get_maintainer.pl list from the initial RFC, and I sincerely apologize for the oversight. I have already submitted three versions and would greatly appreciate your review. RFC v1： https://lore.kernel.org/all/20250521092503.3116340-1-pulehui@huaweicloud.com/ RFC v2: https://lore.kernel.org/all/20250527132351.2050820-1-pulehui@huaweicloud.com/ v1: https://lore.kernel.org/all/20250529155650.4017699-1-pulehui@huaweicloud.com/