Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap

[Pu Lehui <pulehui@huaweicloud.com>]

On 5/31/2025 2:34 AM, David Hildenbrand wrote:
> On 30.05.25 20:09, Oleg Nesterov wrote:
>> Well, let me say this again ;) I can't really comment, I don't understand
>> this code enough.
>>
>> That said...
>>
>> On 05/30, David Hildenbrand wrote:
>>>
>>> I wonder if there might be a clean way to move the uprobe_mmap() out of
>>> vma_complete().
>>
>> Me too.
>>
>> Not only the uprobe_mmap() calls in vma_complete() doesn't look right
>> "in general" (at least to me).
>>
>> To remind, vma_complete/uprobe_mmap/install_breakpoint is not even called
>> in, say, this case when VMA grows and moves. See
>> https://lore.kernel.org/all/20250526173845.GC4156@redhat.com/
>> I guess we don't really care, but still...
>>
>>
>> But just in case... I agree with Lehui and Lorenzo in that we need a 
>> short
>> term fix, and the last patch from Lehui seems to fix the immediate 
>> problem.
> 
> Oh, there was a new patch yesterday. Too bad I wasn't CCed on that.
> 
Oops...I just realized that you weren't included in the CC list. I had 
been using the send script which referencing the get_maintainer.pl list 
from the initial RFC, and I sincerely apologize for the oversight. I 
have already submitted three versions and would greatly appreciate your 
review.

RFC v1：
https://lore.kernel.org/all/20250521092503.3116340-1-pulehui@huaweicloud.com/

RFC v2:
https://lore.kernel.org/all/20250527132351.2050820-1-pulehui@huaweicloud.com/

v1:
https://lore.kernel.org/all/20250529155650.4017699-1-pulehui@huaweicloud.com/