From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDC9CEBF99 for ; Fri, 27 Sep 2024 11:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E704D6B00D2; Fri, 27 Sep 2024 07:17:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1EC66B00D3; Fri, 27 Sep 2024 07:17:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4BC16B00D4; Fri, 27 Sep 2024 07:17:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9FE116B00D2 for ; Fri, 27 Sep 2024 07:17:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 375CD1C62BF for ; Fri, 27 Sep 2024 11:17:33 +0000 (UTC) X-FDA: 82610267586.21.4C50BD9 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf03.hostedemail.com (Postfix) with ESMTP id F1E442000F for ; Fri, 27 Sep 2024 11:17:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727435788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zillNs+JcBR/Oelmxh2v0pjr2Rdeyi2qRK4QRHL1xto=; b=A56NPv3zbG5erPOEHLbHMZwok+N1leGITBECliBKKvvby7NSe/T2LE2GtqCpnhWI7u+WQu 7ZfSLuczowpoBeYB/YqRvc06SkvezBjuwbraXZxG0FfE3uRKe00WatGW+IAo/e1G//kHNc pyNDYbMzpkDxtO0oIgmMvgzUObdtUC4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727435788; a=rsa-sha256; cv=none; b=ZVMeOmkWk34ei7E4FlvcucS+E3pMXEUUWg3iqN4rWqW0elmEis4GuTCw6602ZIhakVxpla VoRMuj4Lulcjb+vblxk8BuyurOypWzLeRcwDLrdALw+wL6g42S7pxhr0lSfNNUsD8LTSxZ gq6QozZ6oLgF/2YHLol5Er2gPTkpD78= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XFSbM4jMPz6K6fS; Fri, 27 Sep 2024 19:16:47 +0800 (CST) Received: from frapeml100008.china.huawei.com (unknown [7.182.85.131]) by mail.maildlp.com (Postfix) with ESMTPS id C6CAA140DE5; Fri, 27 Sep 2024 19:17:25 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100008.china.huawei.com (7.182.85.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 27 Sep 2024 13:17:25 +0200 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Fri, 27 Sep 2024 13:17:25 +0200 From: Shiju Jose To: Fan Ni CC: "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "Jonathan Cameron" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "mike.malvestuto@intel.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "jgroves@micron.com" , "vsalve@micron.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH v12 02/17] EDAC: Add EDAC scrub control driver Thread-Topic: [PATCH v12 02/17] EDAC: Add EDAC scrub control driver Thread-Index: AQHbBCn4HKdgWv6WRUSg+JAQdJepo7JqpxUAgADtoXA= Date: Fri, 27 Sep 2024 11:17:25 +0000 Message-ID: <0a815781611a4e0480380a54875eaa65@huawei.com> References: <20240911090447.751-1-shiju.jose@huawei.com> <20240911090447.751-3-shiju.jose@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.146.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: F1E442000F X-Stat-Signature: dmxsk5nnqu44r1igowotf3f6smtef4bj X-HE-Tag: 1727435848-123716 X-HE-Meta: U2FsdGVkX1+WMrRbCNXBpG++f6iN3eSgNx5mQtDaxcMZA5tV29j4DEmqNa4GqtnMspxSKwhKrfmESGyIZmxA5L51GJ2+vaxFi7PhKtGjc2q2pwfHpH/0JY5R5kf9UrzNscBbXPSZDf9s6uPKF7yoaDYUBN1jkaJDtMuOHJ21WP3kyNhEOjVuzzOU+JgipRtelFqLwnTK9pyf2eSj/yR8ORvf4xMdysbiCxrGr2xv31UXTdSKhlaQb0V8PJENSNySKNU6XFWpsV/5wRBwQx5ReB+zTSvbT39RmQlnQGWk5jetziuuBbEKKufTaovS7MA+wvkywJeCI7hMI+bfp8J86QPDuUcn6k/CdAeLC5ikoeyLa9zxOOrJcvwuxLPNmFTxxcOr4RsEAc+1x2zCUiqTZI0sIfFYqXDqNZXHl/5AUNpLVrs4as0doOwmk3vix9STYzp78mnQQ9DbBcMdYIjxSAVPcvRLitS7kXU4oVtLq/u6x0bHB93t4DL964uQ6F9bPdtqKtYE8oSL1/PudGcc8IPmdq4SBh80zL/6Culhi1uAy4wiSkMHgI3WmmcmaNEYCFsOz0Y6nFc1AsjBrnDZXGKz3wbOLp7sUP7w9G4Y74RENEkO3DEAL6i1OQ47UmIMY/Ui29O0QwtCqRZ5G3LoYjHqhRRm9urcBSi+gxpbAoSNcv2MJLeZwsKChaYCINYCVlAU6Az8U26UrT92cJp/Hf8nLDdjicm+1m8pmvzISAU19tzFWOK66RX4dRThS7BJ19ZCGbLFAatNRLCRiItN/3I4TIbwWefj2xjG1VlS8gOfjZ8quV/q7VOcVs6bYkoViecKLOZALnOanMDKNkrDM4DOhGmEIT/nov9OiS2Jj2w7zhMmB8lbW2/dd53Rk8twglZ6QKwZpGn7Z9nzImkM2x9SlRnyTf+b56GG2UwqjRs02vnZ6gOdyaaHaetAlF0NanjAVijS1W9/q6lJBR1 Vv+lvByf xOYtT28zRpdlFYoMcyOGZIlkrdN0uS1Nnq+5kINYVctMyP3Jblfzg/sGEwOX0paoMqxcl/F8Xd2wIzP7qC8urYVIM94AGlVS89CPRQAxs4K7dN8C+7j5N9FDREIw/v+fZ1qfYd8Z3IlRXf+7T6vr/zZ9N7sn0uXMqDQB/Tt74D7trzS8d8eilFrjs7OVyBHv9eKn/Ilh4+p/woMTU5LgCsvj0mWCzqGxbbp2TlzTm19KDFmts+g0yv07gY5Z/DzuSbv+OzfVpNllzPKs3agyaJ+/l8jd8aL6y530esQuTmyRAcQ+X11uKISUuOMOYZv7HQPMeTY40KqBGbU0ZqO5yv4goCrxPbn4pMziqnOfq1rksuzZmftAPuSCeFh/5Mmw+o2X8GPN9KvuDq96eQKZbqBddVMTY+hER0oczGM8hqFP60o5t+F3oR66MF1jg/Q+TD5m7ITxn77JDtzYkbVe2edNppEC5JaJCiSFwfMvgWYKOZuUYO0qSE3TUB5phjc27/CPI5aBafThiuFjdEb6/IC10Lq+YIQw9M7BKplnc6bbL2FF/ygRERHJq1qRqlidH99Q780NWSSXgE9PgRGl6NAsipvJBA+6YG8qhVtItaGs32V/jzaUf6Bq6aN+PbpPkjC+C1pWdu5UmIrfh95XDsU11lhe/TaigtmNvQvgm/UPHgd9leVIjKGYlJ8ZfFyBRlvB0zR+aw1ehNaXFb60mcZqSib1qMcX6zYaCaCQFvhzhqYUCYl4GsK9Xq/uw14WvVV6DTQDDJPrFGdgnwdXN0W7jZ/ZaLH9UAuHzxEXCKY860ldJf2iamP3RXKTGtsxDQ415lirJh+eJUZZVnxcYdsNma9N4q+JWQz3FmPqUHSiaTFDUPmNlZ86eZJ+U8/qXflMTgHw7s9G1tj4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Fan Ni >Sent: 27 September 2024 00:05 >To: Shiju Jose >Cc: linux-edac@vger.kernel.org; linux-cxl@vger.kernel.org; linux- >acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; >bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; dan.j.williams@intel.com; dave@stgolabs.net; Jonathan >Cameron ; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com; >Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com; >Jon.Grimm@amd.com; dave.hansen@linux.intel.com; >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; >duenwen@google.com; mike.malvestuto@intel.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >wbs@os.amperecomputing.com; nifan.cxl@gmail.com; jgroves@micron.com; >vsalve@micron.com; tanxiaofei ; Zengtao (B) >; Roberto Sassu ; >kangkang.shen@futurewei.com; wanghuiqiang ; >Linuxarm >Subject: Re: [PATCH v12 02/17] EDAC: Add EDAC scrub control driver > >On Wed, Sep 11, 2024 at 10:04:31AM +0100, shiju.jose@huawei.com wrote: >> From: Shiju Jose >> >> Add generic EDAC scrub control driver supports configuring the memory >> scrubbers in the system. The device with scrub feature, get the scrub >> descriptor from the EDAC scrub and registers with the EDAC RAS feature >> driver, which adds the sysfs scrub control interface. The scrub >> control attributes for a scrub instance are available to userspace in >/sys/bus/edac/devices//scrub*/. >> >> Generic EDAC scrub driver and the common sysfs scrub interface >> promotes unambiguous access from the userspace irrespective of the >> underlying scrub devices. >> >> The sysfs scrub attribute nodes would be present only if the client >> driver has implemented the corresponding attribute callback function >> and pass in ops to the EDAC RAS feature driver during registration. >> >> Co-developed-by: Jonathan Cameron >> Signed-off-by: Jonathan Cameron >> Signed-off-by: Shiju Jose >> --- >> Documentation/ABI/testing/sysfs-edac-scrub | 69 ++++ >> drivers/edac/Makefile | 1 + >> drivers/edac/edac_device.c | 6 +- >> drivers/edac/edac_scrub.c | 377 +++++++++++++++++++++ >> include/linux/edac.h | 30 ++ >> 5 files changed, 482 insertions(+), 1 deletion(-) create mode 100644 >> Documentation/ABI/testing/sysfs-edac-scrub >> create mode 100755 drivers/edac/edac_scrub.c >> >> diff --git a/Documentation/ABI/testing/sysfs-edac-scrub >> b/Documentation/ABI/testing/sysfs-edac-scrub >> new file mode 100644 >> index 000000000000..f465cc91423f >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-edac-scrub >> @@ -0,0 +1,69 @@ >> +What: /sys/bus/edac/devices//scrub* > >Based on the code below, we can only have scrub0, scrub1, etc. >So should we use scrubX instead of scrub* here. > >The same for below. > Thanks . Changed, in other patches as well. >Fan > Thanks, Shiju >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + The sysfs EDAC bus devices //scrub* subdirectory >> + belongs to an instance of memory scrub control feature, >> + where directory corresponds to a device/memory >> + region registered with the EDAC scrub driver and thus >> + registered with the generic EDAC RAS driver. >> + The sysfs scrub attr nodes would be present only if the >> + client driver has implemented the corresponding attr >> + callback function and pass in ops to the EDAC RAS feature >> + driver during registration. >> + >> +What: /sys/bus/edac/devices/name>/scrub*/addr_range_base >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RW) The base of the address range of the memory region >> + to be scrubbed (on-demand scrubbing). >> + >> +What: /sys/bus/edac/devices/name>/scrub*/addr_range_size >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RW) The size of the address range of the memory region >> + to be scrubbed (on-demand scrubbing). >> + >> +What: /sys/bus/edac/devices/name>/scrub*/enable_background >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RW) Start/Stop background(patrol) scrubbing if supported. >> + >> +What: /sys/bus/edac/devices/name>/scrub*/enable_on_demand >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RW) Start/Stop on-demand scrubbing the memory region >> + if supported. >> + >> +What: /sys/bus/edac/devices/name>/scrub*/min_cycle_duration >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RO) Supported minimum scrub cycle duration in seconds >> + by the memory scrubber. >> + >> +What: /sys/bus/edac/devices/name>/scrub*/max_cycle_duration >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RO) Supported maximum scrub cycle duration in seconds >> + by the memory scrubber. >> + >> +What: /sys/bus/edac/devices/name>/scrub*/current_cycle_duration >> +Date: Oct 2024 >> +KernelVersion: 6.12 >> +Contact: linux-edac@vger.kernel.org >> +Description: >> + (RW) The current scrub cycle duration in seconds and must be >> + within the supported range by the memory scrubber. >> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile index >> 4edfb83ffbee..fbf0e39ec678 100644 >> --- a/drivers/edac/Makefile >> +++ b/drivers/edac/Makefile >> @@ -10,6 +10,7 @@ obj-$(CONFIG_EDAC) :=3D edac_core.o >> >> edac_core-y :=3D edac_mc.o edac_device.o edac_mc_sysfs.o >> edac_core-y +=3D edac_module.o edac_device_sysfs.o wq.o >> +edac_core-y +=3D edac_scrub.o >> >> edac_core-$(CONFIG_EDAC_DEBUG) +=3D debugfs.o >> >> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c >> index e4a5d010ea2d..6381896b6424 100644 >> --- a/drivers/edac/edac_device.c >> +++ b/drivers/edac/edac_device.c >> @@ -608,12 +608,16 @@ static int edac_dev_feat_init(struct device *paren= t, >> const struct edac_dev_feature *ras_feat, >> const struct attribute_group **attr_groups) { >> - int num; >> + int num, ret; >> >> switch (ras_feat->ft_type) { >> case RAS_FEAT_SCRUB: >> dev_data->scrub_ops =3D ras_feat->scrub_ops; >> dev_data->private =3D ras_feat->ctx; >> + ret =3D edac_scrub_get_desc(parent, attr_groups, >> + ras_feat->instance); >> + if (ret) >> + return ret; >> return 1; >> case RAS_FEAT_ECS: >> num =3D ras_feat->ecs_info.num_media_frus; >> diff --git a/drivers/edac/edac_scrub.c b/drivers/edac/edac_scrub.c new >> file mode 100755 index 000000000000..3f8f37629acf >> --- /dev/null >> +++ b/drivers/edac/edac_scrub.c >> @@ -0,0 +1,377 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Generic EDAC scrub driver supports controlling the memory >> + * scrubbers in the system and the common sysfs scrub interface >> + * promotes unambiguous access from the userspace. >> + * >> + * Copyright (c) 2024 HiSilicon Limited. >> + */ >> + >> +#define pr_fmt(fmt) "EDAC SCRUB: " fmt >> + >> +#include >> + >> +enum edac_scrub_attributes { >> + SCRUB_ADDR_RANGE_BASE, >> + SCRUB_ADDR_RANGE_SIZE, >> + SCRUB_ENABLE_BACKGROUND, >> + SCRUB_ENABLE_ON_DEMAND, >> + SCRUB_MIN_CYCLE_DURATION, >> + SCRUB_MAX_CYCLE_DURATION, >> + SCRUB_CURRENT_CYCLE_DURATION, >> + SCRUB_MAX_ATTRS >> +}; >> + >> +struct edac_scrub_dev_attr { >> + struct device_attribute dev_attr; >> + u8 instance; >> +}; >> + >> +struct edac_scrub_context { >> + char name[EDAC_FEAT_NAME_LEN]; >> + struct edac_scrub_dev_attr scrub_dev_attr[SCRUB_MAX_ATTRS]; >> + struct attribute *scrub_attrs[SCRUB_MAX_ATTRS + 1]; >> + struct attribute_group group; >> +}; >> + >> +#define to_scrub_dev_attr(_dev_attr) \ >> + container_of(_dev_attr, struct edac_scrub_dev_attr, dev_attr) >> + >> +static ssize_t addr_range_base_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u64 base, size; >> + int ret; >> + >> + ret =3D ops->read_range(ras_feat_dev->parent, ctx->scrub[inst].private= , >&base, &size); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "0x%llx\n", base); } >> + >> +static ssize_t addr_range_size_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u64 base, size; >> + int ret; >> + >> + ret =3D ops->read_range(ras_feat_dev->parent, ctx->scrub[inst].private= , >&base, &size); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "0x%llx\n", size); } >> + >> +static ssize_t addr_range_base_store(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + const char *buf, size_t len) { >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u64 base, size; >> + int ret; >> + >> + ret =3D ops->read_range(ras_feat_dev->parent, ctx->scrub[inst].private= , >&base, &size); >> + if (ret) >> + return ret; >> + >> + ret =3D kstrtou64(buf, 0, &base); >> + if (ret < 0) >> + return ret; >> + >> + ret =3D ops->write_range(ras_feat_dev->parent, ctx->scrub[inst].privat= e, >base, size); >> + if (ret) >> + return ret; >> + >> + return len; >> +} >> + >> +static ssize_t addr_range_size_store(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + const char *buf, >> + size_t len) >> +{ >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u64 base, size; >> + int ret; >> + >> + ret =3D ops->read_range(ras_feat_dev->parent, ctx->scrub[inst].private= , >&base, &size); >> + if (ret) >> + return ret; >> + >> + ret =3D kstrtou64(buf, 0, &size); >> + if (ret < 0) >> + return ret; >> + >> + ret =3D ops->write_range(ras_feat_dev->parent, ctx->scrub[inst].privat= e, >base, size); >> + if (ret) >> + return ret; >> + >> + return len; >> +} >> + >> +static ssize_t enable_background_store(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + const char *buf, size_t len) { >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + bool enable; >> + int ret; >> + >> + ret =3D kstrtobool(buf, &enable); >> + if (ret < 0) >> + return ret; >> + >> + ret =3D ops->set_enabled_bg(ras_feat_dev->parent, ctx- >>scrub[inst].private, enable); >> + if (ret) >> + return ret; >> + >> + return len; >> +} >> + >> +static ssize_t enable_background_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, char *buf) { >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + bool enable; >> + int ret; >> + >> + ret =3D ops->get_enabled_bg(ras_feat_dev->parent, ctx- >>scrub[inst].private, &enable); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "%d\n", enable); } >> + >> +static ssize_t enable_on_demand_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, char *buf) { >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + bool enable; >> + int ret; >> + >> + ret =3D ops->get_enabled_od(ras_feat_dev->parent, ctx- >>scrub[inst].private, &enable); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "%d\n", enable); } >> + >> +static ssize_t enable_on_demand_store(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + const char *buf, size_t len) { >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + bool enable; >> + int ret; >> + >> + ret =3D kstrtobool(buf, &enable); >> + if (ret < 0) >> + return ret; >> + >> + ret =3D ops->set_enabled_od(ras_feat_dev->parent, ctx- >>scrub[inst].private, enable); >> + if (ret) >> + return ret; >> + >> + return len; >> +} >> + >> +static ssize_t min_cycle_duration_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u32 val; >> + int ret; >> + >> + ret =3D ops->min_cycle_read(ras_feat_dev->parent, ctx- >>scrub[inst].private, &val); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "%u\n", val); } >> + >> +static ssize_t max_cycle_duration_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u32 val; >> + int ret; >> + >> + ret =3D ops->max_cycle_read(ras_feat_dev->parent, ctx- >>scrub[inst].private, &val); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "%u\n", val); } >> + >> +static ssize_t current_cycle_duration_show(struct device *ras_feat_dev, >> + struct device_attribute *attr, >> + char *buf) >> +{ >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + u32 val; >> + int ret; >> + >> + ret =3D ops->cycle_duration_read(ras_feat_dev->parent, ctx- >>scrub[inst].private, &val); >> + if (ret) >> + return ret; >> + >> + return sysfs_emit(buf, "%u\n", val); } >> + >> +static ssize_t current_cycle_duration_store(struct device *ras_feat_dev= , >> + struct device_attribute *attr, >> + const char *buf, size_t len) { >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(attr))- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + long val; >> + int ret; >> + >> + ret =3D kstrtol(buf, 0, &val); >> + if (ret < 0) >> + return ret; >> + >> + ret =3D ops->cycle_duration_write(ras_feat_dev->parent, ctx- >>scrub[inst].private, val); >> + if (ret) >> + return ret; >> + >> + return len; >> +} >> + >> +static umode_t scrub_attr_visible(struct kobject *kobj, >> + struct attribute *a, int attr_id) { >> + struct device *ras_feat_dev =3D kobj_to_dev(kobj); >> + struct device_attribute *dev_attr =3D >> + container_of(a, struct device_attribute, attr); >> + u8 inst =3D ((struct edac_scrub_dev_attr *)to_scrub_dev_attr(dev_attr)= )- >>instance; >> + struct edac_dev_feat_ctx *ctx =3D dev_get_drvdata(ras_feat_dev); >> + const struct edac_scrub_ops *ops =3D ctx->scrub[inst].scrub_ops; >> + >> + switch (attr_id) { >> + case SCRUB_ADDR_RANGE_BASE: >> + case SCRUB_ADDR_RANGE_SIZE: >> + if (ops->read_range && ops->write_range) >> + return a->mode; >> + if (ops->read_range) >> + return 0444; >> + return 0; >> + case SCRUB_ENABLE_BACKGROUND: >> + if (ops->get_enabled_bg && ops->set_enabled_bg) >> + return a->mode; >> + if (ops->get_enabled_bg) >> + return 0444; >> + return 0; >> + case SCRUB_ENABLE_ON_DEMAND: >> + if (ops->get_enabled_od && ops->set_enabled_od) >> + return a->mode; >> + if (ops->get_enabled_od) >> + return 0444; >> + return 0; >> + case SCRUB_MIN_CYCLE_DURATION: >> + return ops->min_cycle_read ? a->mode : 0; >> + case SCRUB_MAX_CYCLE_DURATION: >> + return ops->max_cycle_read ? a->mode : 0; >> + case SCRUB_CURRENT_CYCLE_DURATION: >> + if (ops->cycle_duration_read && ops->cycle_duration_write) >> + return a->mode; >> + if (ops->cycle_duration_read) >> + return 0444; >> + return 0; >> + default: >> + return 0; >> + } >> +} >> + >> +#define EDAC_SCRUB_ATTR_RO(_name, _instance) \ >> + ((struct edac_scrub_dev_attr) { .dev_attr =3D __ATTR_RO(_name), \ >> + .instance =3D _instance }) >> + >> +#define EDAC_SCRUB_ATTR_WO(_name, _instance) \ >> + ((struct edac_scrub_dev_attr) { .dev_attr =3D __ATTR_WO(_name), \ >> + .instance =3D _instance }) >> + >> +#define EDAC_SCRUB_ATTR_RW(_name, _instance) \ >> + ((struct edac_scrub_dev_attr) { .dev_attr =3D __ATTR_RW(_name), \ >> + .instance =3D _instance }) >> + >> +static int scrub_create_desc(struct device *scrub_dev, >> + const struct attribute_group **attr_groups, >> + u8 instance) >> +{ >> + struct edac_scrub_context *scrub_ctx; >> + struct attribute_group *group; >> + int i; >> + >> + scrub_ctx =3D devm_kzalloc(scrub_dev, sizeof(*scrub_ctx), GFP_KERNEL); >> + if (!scrub_ctx) >> + return -ENOMEM; >> + >> + group =3D &scrub_ctx->group; >> + scrub_ctx->scrub_dev_attr[0] =3D >EDAC_SCRUB_ATTR_RW(addr_range_base, instance); >> + scrub_ctx->scrub_dev_attr[1] =3D >EDAC_SCRUB_ATTR_RW(addr_range_size, instance); >> + scrub_ctx->scrub_dev_attr[2] =3D >EDAC_SCRUB_ATTR_RW(enable_background, instance); >> + scrub_ctx->scrub_dev_attr[3] =3D >EDAC_SCRUB_ATTR_RW(enable_on_demand, instance); >> + scrub_ctx->scrub_dev_attr[4] =3D >EDAC_SCRUB_ATTR_RO(min_cycle_duration, instance); >> + scrub_ctx->scrub_dev_attr[5] =3D >EDAC_SCRUB_ATTR_RO(max_cycle_duration, instance); >> + scrub_ctx->scrub_dev_attr[6] =3D >EDAC_SCRUB_ATTR_RW(current_cycle_duration, instance); >> + for (i =3D 0; i < SCRUB_MAX_ATTRS; i++) >> + scrub_ctx->scrub_attrs[i] =3D >> +&scrub_ctx->scrub_dev_attr[i].dev_attr.attr; >> + >> + sprintf(scrub_ctx->name, "%s%d", "scrub", instance); >> + group->name =3D scrub_ctx->name; >> + group->attrs =3D scrub_ctx->scrub_attrs; >> + group->is_visible =3D scrub_attr_visible; >> + >> + attr_groups[0] =3D group; >> + >> + return 0; >> +} >> + >> +/** >> + * edac_scrub_get_desc - get EDAC scrub descriptors >> + * @scrub_dev: client device, with scrub support >> + * @attr_groups: pointer to attrribute group container >> + * @instance: device's scrub instance number. >> + * >> + * Returns 0 on success, error otherwise. >> + */ >> +int edac_scrub_get_desc(struct device *scrub_dev, >> + const struct attribute_group **attr_groups, >> + u8 instance) >> +{ >> + if (!scrub_dev || !attr_groups) >> + return -EINVAL; >> + >> + return scrub_create_desc(scrub_dev, attr_groups, instance); } >> diff --git a/include/linux/edac.h b/include/linux/edac.h index >> b337254cf5b8..aae8262b9863 100644 >> --- a/include/linux/edac.h >> +++ b/include/linux/edac.h >> @@ -674,6 +674,36 @@ enum edac_dev_feat { >> RAS_FEAT_MAX >> }; >> >> +/** >> + * struct scrub_ops - scrub device operations (all elements optional) >> + * @read_range: read base and offset of scrubbing range. >> + * @write_range: set the base and offset of the scrubbing range. >> + * @get_enabled_bg: check if currently performing background scrub. >> + * @set_enabled_bg: start or stop a bg-scrub. >> + * @get_enabled_od: check if currently performing on-demand scrub. >> + * @set_enabled_od: start or stop an on-demand scrub. >> + * @min_cycle_read: minimum supported scrub cycle duration in seconds. >> + * @max_cycle_read: maximum supported scrub cycle duration in seconds. >> + * @cycle_duration_read: get the scrub cycle duration in seconds. >> + * @cycle_duration_write: set the scrub cycle duration in seconds. >> + */ >> +struct edac_scrub_ops { >> + int (*read_range)(struct device *dev, void *drv_data, u64 *base, u64 >*size); >> + int (*write_range)(struct device *dev, void *drv_data, u64 base, u64 >size); >> + int (*get_enabled_bg)(struct device *dev, void *drv_data, bool *enable= ); >> + int (*set_enabled_bg)(struct device *dev, void *drv_data, bool enable)= ; >> + int (*get_enabled_od)(struct device *dev, void *drv_data, bool *enable= ); >> + int (*set_enabled_od)(struct device *dev, void *drv_data, bool enable)= ; >> + int (*min_cycle_read)(struct device *dev, void *drv_data, u32 *min); >> + int (*max_cycle_read)(struct device *dev, void *drv_data, u32 *max); >> + int (*cycle_duration_read)(struct device *dev, void *drv_data, u32 >*cycle); >> + int (*cycle_duration_write)(struct device *dev, void *drv_data, u32 >> +cycle); }; >> + >> +int edac_scrub_get_desc(struct device *scrub_dev, >> + const struct attribute_group **attr_groups, >> + u8 instance); >> + >> struct edac_ecs_ex_info { >> u16 num_media_frus; >> }; >> -- >> 2.34.1 >> > >-- >Fan Ni