From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9676EC636D3 for ; Mon, 30 Jan 2023 19:24:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BAE76B0071; Mon, 30 Jan 2023 14:24:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26A7B6B0073; Mon, 30 Jan 2023 14:24:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 132796B0074; Mon, 30 Jan 2023 14:24:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 030C06B0071 for ; Mon, 30 Jan 2023 14:24:48 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C87DB1A07F3 for ; Mon, 30 Jan 2023 19:24:47 +0000 (UTC) X-FDA: 80412442614.16.1DC8161 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf22.hostedemail.com (Postfix) with ESMTP id E0E5BC0007 for ; Mon, 30 Jan 2023 19:24:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=acm.org (policy=none); spf=pass (imf22.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675106686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q0USauUwqY1SaOU2GvOVYD8aiTVQVkxSRI7nFSgwMtU=; b=4340+8Qm+n6wwmd78sw7l87E7xyfoZkY+Q58/TUlTUg3xMwSOxCPD8mD5xyAxw5+GyqkQg Ylk2PNmma1EUlamy+C+L+KlO+NjKr0qFRsgBxJwV2QzCEtSbNUHXF5B86Dtjnw5dSNCDT+ xb2itJdGbqvS0CnZMu5GN5aRDpkDkt4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=acm.org (policy=none); spf=pass (imf22.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675106686; a=rsa-sha256; cv=none; b=ERgKbjx6mP9Z9mfJ1S0GdzO7wtVi2vtZ/oxqoHInLFzez2dOnlaM+UnVPA6e8/4eZIZxRk odoFALd2VM3Eit9hl6lrc8ciOtzCRqe2N/gLidOO6/EvG999i9KOjhFVrGzYAj17SQTJgS tEuOhXdBFNdOvBooMys1Tj9IxrMcVHw= Received: by mail-pj1-f48.google.com with SMTP id cl23-20020a17090af69700b0022c745bfdc3so5534809pjb.3 for ; Mon, 30 Jan 2023 11:24:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q0USauUwqY1SaOU2GvOVYD8aiTVQVkxSRI7nFSgwMtU=; b=2GY0ZBs7PIObWV1GwAwqCWTXy+UhVogzBozw9o8zOsBrn4CxsfGbhtjZw7LzfCITJc I8IBZlL/7rSuzBMY2UykTaFvSf6fEx7gPSw9Xzdfe+sovOp1onRS7/ANUUh0dHfVIruL UjCtQFbz2jL3Qga0sZ4caaoCY2SnNsbu5ALY0rNChzJ6Yh5mPDbhG0gAqBW+Uvtgzm5G MdgpYGR6bWt4uQqogMbc5TdtMeQ6q/2ZhBzN4EKucJ2ork1db4m1wVjCENvYzuoHtJvx GWR9/iZt5C48TyqU1zNz6aZNSEYW/e2uMsgj6ucgr1AuqaluBggbD8ikT7hlXJ4b2QPX 3ieA== X-Gm-Message-State: AO0yUKU6cYTGlX2pcDPpoHPLrUAhQyfbckH+LZlZpvIDpjy1E9JoT+Ok z7MfKLjAZ21sM72i3l5efVQ= X-Google-Smtp-Source: AK7set/rGKHetFHi+kM9ZonjZUNA4n9BoD4xsf4KlNV/nZP1isOdo/PYXU7cRl9F9xNCOZ6lx4KGGg== X-Received: by 2002:a05:6a20:54a3:b0:be:a177:af43 with SMTP id i35-20020a056a2054a300b000bea177af43mr2872944pzk.24.1675106684718; Mon, 30 Jan 2023 11:24:44 -0800 (PST) Received: from ?IPV6:2620:15c:211:201:5016:3bcd:59fe:334b? ([2620:15c:211:201:5016:3bcd:59fe:334b]) by smtp.gmail.com with ESMTPSA id 69-20020a630248000000b0045ff216a0casm7117730pgc.3.2023.01.30.11.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 11:24:43 -0800 (PST) Message-ID: <0a7739db-13e2-efac-2c1a-872d7f2fa7aa@acm.org> Date: Mon, 30 Jan 2023 11:24:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Content-Language: en-US From: Bart Van Assche To: Christoph Hellwig , Jens Axboe Cc: Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> <2bab7050-dec7-3af8-b643-31b414b8c4b4@acm.org> In-Reply-To: <2bab7050-dec7-3af8-b643-31b414b8c4b4@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E0E5BC0007 X-Stat-Signature: tkg19cwxwxy6beunbfrwyka8uqiirfah X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675106685-63474 X-HE-Meta: U2FsdGVkX189+5eqoxsy5yv+4F0Tkf8qPW1Yb30WLS6o0H9Fd6Z4Luy5DW0uIaGCEQcX6llvxHNWSKiEL7U1pk0Tr5zKGZLy+6Sxe3ft6kKwrY4IhqkxtEBbJBox94M8oQZ4lktKtFxE9GTENL2xxmYaVjJOSvqG7eDBu0rgdp1KxCotNCW6xmJN0upFEFTNo5Y2iJVBeoq+bKXHwdgbTwPPFjkT9yvzbs1ZujJWBw7vIaS/NwKkQ09gi1tGG2yxteUNtf6nxaIVol7dMkJRvNShOprJU70F2LVftAlHH4kLhr/teFeWNZJK32TNwG1ph/oXZvaPaAXioEEsUHzlMHILGrv5x2Wyy3MVUZRZroX+z95T7O0p3H/BhcDDwR1UPGKCUhDJ+r+YwFcYrHDuPIvVq91SjASCDdnMSsKo7ztSZ1fSNj/hLH9Cb9THuFN++lAR8Tn95qCCXIr7zmuPn2VwGTvjMr0vuggk+8hoDuVPN1axnrY2MlhYw7f562i//ykENH9uCUlR0pKb4dZXaJ0JQptn41+W1PAsqJAiodj4F75AqfO5MDYzhrHxofS/l9FCxqohn3jpUXpWzXa33U802Nd4VUnTSpzl6uPJb0LwB8NiCyMRL7u6GwlEPiISjJyzQCognJ1wU+9R8w2IUqEzEGe7ryXPs5EAT6JlNUgepSFAmFNupQ4Hs3fCzccURXr5DH3ogDWAFoWNZss+B1PJ6Hx5d6DUlgPAeYdKjz7Gt4odctQLuwarsKE+GKpFBk32CmwJ3wJXQ9WMH7sIXYfNFBtZBYpFOtSrW/3UyQroSArdNgzeBFmEKfLyS8DN5xljIb0/VzaTCOANBvoNRYXAChCo1NGiCcrXXu3f34VKFhJnWQLGMaJFRc4Zndc6PbngQHw+V8mzMKCeM96sa2k2I1lJGlhjIKYSiOPkEMSGGPLwcCaIosi0UyaE+KeHFnOpKUfExH6+YVnyKhG 3Vf3BFUg mwzODoYhF/4wMshQxoop8vMGlGSnVHUmKo2U6tNUQV9/IlCD7gMPlzubbu9Au2242rQEba2GFR1ITPLlCnP26+9EQvzpirfN05CVhnpjUZ11/2nRMdlL1HyMxeRVrYZN0Yb9um0y/w92qhxwhDoHX6NdHC/4OI/YNPCXyiONsmgRfjOMTQExxzSQk2xsLNLE/hwuRzxkkndyVYKddef+7L6pYHp3c6XL9rQJ4GrUv9shKBymoMLCJrX+Vb0xyJd6wxRTt587sR0ZKCxEW06KmghmKJApioVEi+f/05DGBFiaKyyB/h4V8kap0w0gH94xgRVgwaVjwh4F+GKECN2EZuqeChlAyfqFsA62HE2kTpb8Gg42pCkBCFpCogNL+cZW12LPA8uHElLv6MA0gKg2OV7++jLywXN803J5rLi0x6tszv0Si+a9+0yXCf03RfGCmaqMJkMAq7HlnPr054MUDLlyh9OH2oqAn5PDY3Md9rO8HOemOnSAWZefgu+4++KHUmc2A0kLf24CORS/Scg4bxtkxvDNZ74eZhIaGNfGOqBDMKMg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/23 09:09, Bart Van Assche wrote: > On 1/30/23 01:21, Christoph Hellwig wrote: >> Add a helper to initialize a bvec based of a page pointer.  This will >> help >> removing various open code bvec initializations. > > Why do you want to remove the open-coded bvec initializations? What is > wrong with open-coding bvec initialization? This patch series modifies a > lot of code but does not improve code readability. Anyone who encounters > code that uses the new function bvec_set_page() has to look up the > definition of that function to figure out what it does. Please ignore the above question - I just noticed that this question has been answered in the cover letter. Bart.