From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85477C0218A for ; Sat, 1 Feb 2025 07:42:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD23B6B007B; Sat, 1 Feb 2025 02:42:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D83126B0082; Sat, 1 Feb 2025 02:42:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C72396B0083; Sat, 1 Feb 2025 02:42:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A36C26B007B for ; Sat, 1 Feb 2025 02:42:52 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 476241A158E for ; Sat, 1 Feb 2025 07:42:52 +0000 (UTC) X-FDA: 83070584184.07.A2EBE3C Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf24.hostedemail.com (Postfix) with ESMTP id 5706C180008 for ; Sat, 1 Feb 2025 07:42:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b="PjMpia/v"; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf24.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738395770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CLZpf6rLwx+y6XYMMSXn85igrf6sEjyPZMUtVYwyThE=; b=qo3pFGoTSUbBDHPB1KqnXqxOPEptXVq1F0IWCPuvSmvlOWEXjodnshgKRNbW6IsnSt1YAJ F/7J/QxcJuDq5eZBYqRQ8VB1VljTsu1QMggFH7XeQks+0AWaF1+Z+2ko2Px3diT+zrROu+ d+HCjzQpZnYFDWeBfZUliNRhaE1PkDc= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738395770; a=rsa-sha256; cv=pass; b=YBloXTyBBFl/IQzapbKu3INxyqNGhHPOUtEb8pCLRGp4KTT7WVCfpDuIf8o4bWzcVVA9JN sjZTb9W0tt7C9Bm/J3UGsozfW7iVfqAjkEgtVX6VqsRlsxHMDD7dBTGciK57i6lcWdVP+9 UbDSuM+NrATvEyWE7M3FQjwsSm6jB1U= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b="PjMpia/v"; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf24.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; a=rsa-sha256; t=1738395755; cv=none; d=zohomail.com; s=zohoarc; b=fnhtczJxfrullL1L0M2O5tVnX5aYmJoqPIqGaOEc2+ngT7LN3515fbaDT/OWFdIWk8drkrjQHjimE5i8LkTEURWZlrhyWCVe4mHob7c7lonao0HpS/V40HzE6xX8b94iHW0ePXFeH6P2io0TZ4wFixJPAUksA+CFE8hYi+ReaLc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738395755; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=CLZpf6rLwx+y6XYMMSXn85igrf6sEjyPZMUtVYwyThE=; b=TkW8wXB4zHB8iObuuCAUp5TgO44xn1rpkQNPMN0AJHt2H4Xk3JoUsetatO2QXPti1KcUZpZxw2mFFqxtUXsq7oINheiR4TIrfklrfcCho1M+bPZtiXUnuVrn2zZ0VX0ffG4juXQ5q+hG5qgEddxt/VpwtcMvqfYjF7lNthhgRIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1738395755; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=CLZpf6rLwx+y6XYMMSXn85igrf6sEjyPZMUtVYwyThE=; b=PjMpia/vELd4fiEUbx1qLHup05g6ekUMhmoUqu+HnTnZBvxnhpQzYfb8XM6U0+8D nWFLTDk5JWkjmufhgWBprHBR33ME6y9kjE60GksFLTHR3+o/rVu6zCyGen4IivWncl0 kWtUxNZWR3ID7JIwZiFRJDqGeb8m3MvpMfDI+cWs= Received: by mx.zohomail.com with SMTPS id 1738395751055390.58881136718696; Fri, 31 Jan 2025 23:42:31 -0800 (PST) Message-ID: <0a769233-8cdf-4bee-ba6a-3b69767b7d43@collabora.com> Date: Sat, 1 Feb 2025 12:43:03 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Andy Lutomirski , Will Drewry , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters To: Andrew Morton , Kees Cook References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> <202501090941.5289E7444B@keescook> <843bf743-4005-47bc-9e39-8ea49255b152@collabora.com> <202501090949.793D9A0@keescook> <20250109161246.f43a69773b5459e5200d3f45@linux-foundation.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20250109161246.f43a69773b5459e5200d3f45@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Stat-Signature: x146norz9znobym665qo3fznnxfmiaum X-Rspamd-Queue-Id: 5706C180008 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738395770-871882 X-HE-Meta: U2FsdGVkX1/ksteNmY/7fbjWGln1gsKvEaQEE+Vk551SQLkc0mD5r77s9pErR2eS8GuRKSBh3EBw7hR5TjODt869MldhteWvHQ1hKFouIJhqTOwI3dHUwZrQCf+TwmqZhSpqUw6RrfgU5aUc94L9Gxb1sim1xTSngy57RrWw+XaXI0s+QVwYcHJhGSq79eLITIWJj+l7Q/vqLfIcQiRUr06NK7dmKNvNr2lw/D0r10Z3+AWCPnofB7bul3vF2rXCOJ05Gua2XWYTIhcgrf+N3xvzSGW7ahXrwBeLAC1KquFloLfnfyyicDEXQoEa+ngg/sA2K5J83D/0qkF+9PKF1o2v/g3t6EMuK2laGZsTdC1BQtlc8eGfc+qxkaaWOesvIfafYYOgxdS8WgQAMVQkWiEQMVPGk7gW89E54Uz0wmBp2HjYOddtSGJ86Ft0jWIlgRg2Pm2yVeL/DNqJROY0BF3O6619HhtRgrJr/RSgtr44O9Qlq9J2ULtnEr4RbyZszSTv+TYLMfcRXqkCk1plPeHZeI9qvV6pMqYL+j/5iuA1IhjiJuY1LLgyiCqo91tlrCBuSdeODEy1EE0n96cJEtolbOQ+l8UqppvFDrM5u/5sc7uCHcvQtfTk4mjyE7jauOtlUY2P3Ho/RPTuD5FlsRqWlFGBuIqbvEsQt8ljsdkkLA/5HoXvsO/Op5D9xmQlKQGmQ/RGCgoxTH1F0hYqH9X69rtFN6zdrakqqUFROFcKvMwLm0RQiBYrSAlhgddRckkRp9SaSTDvTh9Ir3cOqgNaHENvcFqW2nd1qAUYU1QoO83Ef4HNUOxHIIkrD9QT4U7Vqu7NIhEIQ5L6NgUFGZCtN0Bo81sf7F/XRvdyelr5y2zvB3tcWPgATj7fBwhsz9KrlLfBKGkbyt4+pWo/zOZiw/DpvLtZnilxBCHOfVHHE9KmjnYnmhjjfvevzAtqOu+XaoKuyyTDU9wHBb1 OdXVN6P8 kzLFtzqR85NymMFuH9B6Mg43uEQO5g0H/msCfs0Dmf+EAdrlkaYOuI4Yc2zNFnCGz5uXEPO2NDyCR9N++giCYsteEF1blF5AzWwoCXYktWDa7BKT7/SF5CnHPRyjsNaXPvjuzwKCdWI5H1Sf+hXUC5MrZK/NCJDiNEx0mlt6owAxUHpCPQIcSs080LXMMf9UkgOkDe84M/dXrcN9+uZUuohfBaNyC5/lSZ0PhGZqoMwYtlYZAmxeXzf5pSb0ZhsDvDnjMwevH49fHJYlcM6SmAs64KlW7b+jNebHzTF/FSCymI4sAG4kXdXJSB6qvhNSm2Sd5DM2tq6ZF2BqHgllObmNxQ4b+jmDShqGhssJHLokDyEqCk8s7vj2WNntMEz3IPx/OQtDSEk+zeok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.116938, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/10/25 5:12 AM, Andrew Morton wrote: > On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook wrote: > >> On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: >>> For the all other case, why should we keep argv/argc and mark them unused >>> as well when they aren't being used? >> >> I'm fine either way, but my personal code style instinct is to keep the >> "standard" main declaration with argc/argv present. But it's mostly >> aesthetic. >> >> And if you think use of kselftest.h isn't universal, then perhaps we can >> avoid the macro, but it does seem nicer and more "normal" feeling for >> the rest of kernel development. >> > > Agreed. __attribute__((unused)) is a bit of a mouthful and isn't what > the kernel developer's eye expects to see. In the next version, I'll add a macro and use that. -- BR, Muhammad Usama Anjum