From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C458E7716D for ; Wed, 4 Dec 2024 09:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE3B56B0083; Wed, 4 Dec 2024 04:46:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D47D76B0085; Wed, 4 Dec 2024 04:46:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B71966B0088; Wed, 4 Dec 2024 04:46:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 925CC6B0083 for ; Wed, 4 Dec 2024 04:46:47 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 43F2CA0EEB for ; Wed, 4 Dec 2024 09:46:47 +0000 (UTC) X-FDA: 82856796582.27.E44DF1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 10B3F140003 for ; Wed, 4 Dec 2024 09:46:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UDtuXa8x; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733305598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YRAqhfi0rcfgVq/GFhN7dijeUq/tFTo66aJfQateYJw=; b=HW8Nda2gZ1RAfXZlTmkZj5RJ2aqWdSAAcJP39HG/tjUFv7d6R3rw/oM+DrL765FBfdhvug XDFvWajjvCNdSzp9/JwWkT/O6NThugX2hMrlCdClww5/9PVhNIUwD+gVYF4Sy9WMnYCkTU gj/h4N9oxHzTgmkc2iaiQOxsNyPpjj0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733305598; a=rsa-sha256; cv=none; b=FywAoi3gKzjkZOKkxeRfE0meOXw40Z0RPmCbp8w1Vm93EBorfYeAGgh8kM1DmbmfQFNyOM pDGax0d2UtGkFr8kE9gAIn/ulq9xYjgDqPMT048NL0o/UIHL4BGcdRnnjK6GCmR9SxCVn6 +jzJhus9CSRpYU1hkymDu0hcAYD+Wa8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UDtuXa8x; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733305604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YRAqhfi0rcfgVq/GFhN7dijeUq/tFTo66aJfQateYJw=; b=UDtuXa8xU7ZC3vHJagBJmYJkkaA3uKABELXBz3GmTOdVa6OF+C0gEopmJNNLFotY5d8AZL 18PhNAF9hiOIRQkDOpXbKXJSm5e63N595SdKwfgBEGIVNb5JcNvtnCJHbSM4/Q00wtc4N/ zDVzM6+XWk/rptXqp5QsNlZYTgFhMIg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-pkbYrVhUPGmBwfmab1Y2fA-1; Wed, 04 Dec 2024 04:46:40 -0500 X-MC-Unique: pkbYrVhUPGmBwfmab1Y2fA-1 X-Mimecast-MFC-AGG-ID: pkbYrVhUPGmBwfmab1Y2fA Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3860bc1d4f1so268429f8f.2 for ; Wed, 04 Dec 2024 01:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733305599; x=1733910399; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YRAqhfi0rcfgVq/GFhN7dijeUq/tFTo66aJfQateYJw=; b=gZHvpOjmrfPOfIcbNp7wXuirOCd25T4Gxdj9/9DLqbhf3AQCjdLfFsQmsxhWphPT+x JdAwbkFrV9DHH+1LW9oqM/J+ZEvAoyfnYN9LmLleS9LhzUdSQx7/uejne80McPwuxwmS qt1+cY0IZhxE9LzFk0M0rcch0DAYW5L5tCHXu/YJLGq6BqsN6sQPhIQdkeRMfz8jEdKb 5SHWqlX9jE6GNOGXi+lRBGipstMsTJDbw5qZ+iV075qWtyNgK798heFh6GiQsS1/L4zd seg9zdoaabOTltIO0a17E6i9bePFxzMfQcWXumMu0wPMJFWtiKvzyrr/AUhofNoDdAYK ykAQ== X-Forwarded-Encrypted: i=1; AJvYcCUe9vf71XCS/TLgUsE95xxv64il7V2VUXTn1AYDz61O/OusyHnEtr4nPSWbzHoWtbWpaZ6Kuq60fw==@kvack.org X-Gm-Message-State: AOJu0Yw35XqT4hbpx9SUntq772UdRIsRP6gencjl4s+SMYfrpniKU5wA 8KkmOfsFuOt9pNqPRkz7YyseWqfH1LGINnjUJvA7e/5Dja7/bjNJUuZHAH5rcuw0k40gh7QRsek BAniE+zV8RF2FJ3ETb3FR/SPAYHyPqJ8eH/56y8heKFbK6/mg X-Gm-Gg: ASbGncsT4gKnq94XPYOBbnp4Lw1MAGy+6hWXPICTXWLKXVSjCnJFucfXa/RTcZcP86m prAAgBQWCHTW+231DaLbKSBpLTZYzNYYpUfRFNjfduFLCK2t27Z1dfOw02fneUJI+9cHfVfihLa 5oXlk5fptKCcdvShe0iYPSFT1zJOOMnF0369G5CCwsltfO+CrEsnAHzM6AoNpJX0rntu70QZ/HC HRSaDIH/YXdbnCPp3ONS05OspKEf9ZoEzYUA774qZty9PqOitKx2tpyaz2HrE5kpJq2zbFzGgis Tk4Rohos47Tk0/WNVDnY4H0U6G6+zu5X1+OojWcKXZKsu1TPoLTD7PJg3/9f1iu0fFAvq5IxoQY Iew== X-Received: by 2002:a5d:64cb:0:b0:385:e43a:4ded with SMTP id ffacd0b85a97d-385fd42d1b4mr5226399f8f.57.1733305599647; Wed, 04 Dec 2024 01:46:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGj87FbNevjh4iVXX3pUKCZweRAnCBd4fI1DVIPcpNdBNX/OLFOmstYbmfV56A+UY56x6TjYQ== X-Received: by 2002:a5d:64cb:0:b0:385:e43a:4ded with SMTP id ffacd0b85a97d-385fd42d1b4mr5226383f8f.57.1733305599351; Wed, 04 Dec 2024 01:46:39 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:e100:38d6:8aa1:11b0:a20a? (p200300cbc70be10038d68aa111b0a20a.dip0.t-ipconnect.de. [2003:cb:c70b:e100:38d6:8aa1:11b0:a20a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a522sm17765557f8f.52.2024.12.04.01.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 01:46:38 -0800 (PST) Message-ID: <0a745263-c6a2-40db-bb40-4d6129e7e66f@redhat.com> Date: Wed, 4 Dec 2024 10:46:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v1] mm/memory_hotplug: move debug_pagealloc_map_pages() into online_pages_range() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton References: <20241203102050.223318-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Gsw-TWLA63_afYdMalsqJRiYHUD09FhFbiTc0lf3qUI_1733305600 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: f49rmyzwibpiik7sxdf5mmbwzfsf83bf X-Rspamd-Queue-Id: 10B3F140003 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733305593-948220 X-HE-Meta: U2FsdGVkX19c5jtA91mVvr0OpVtPa6AYvf3LGArL6Hr6h1eTnzwpHtfxMa6QiEGqK0rEiq02gT973x8OSHkxfBPSuEcB8hghFBRWYx3CdublXLUJH70rPlhxN2y1YANszSv/pdxbSjyQhihTtSLXQ5wNhxJjkifxM3s1omj85+HbxcJy/XT1CyAOHEjHuebvpmrCFnT/o55Wb4GRUEQt9Y9cSSLX/6WqqEeKxuuLRltGHZB4pUR76+MEhRblI24tzthEP8AirONurhIVvPeuULP/ckVfHeiRNGaeX6rFRa/LpBAGhGkLHwBZIG1D2sYYVQrYpvPQwdz7MUeKqXhLhccGPzd8vXsQsC4krUwXgrNlAO14VK+hpbOFx1v8PchPUyRZECG7WbBMWIrZ+HMQK/bGm9Ulv7Xg38zNZwfDE7jRu5JckpfWK+1dw6Rl1VVdTBjsIwmkNsnEqRMLTo3wDmxo7PLVoKnNwcHUD7EGzADpgHOYNsKtEcJt+Q8st7s4xZQ0/4YB/YwPuODQ7Drk68K7D8dL2jFYjyR8wM3+O0FMzqGsuIXNIz2rUYM2IKtKDOFaub4YPSI6zfDMqfA6UyggDJVFD/Yn5gW68fiBXCGs8n5sM39YkDw2/ffq3uo1jC4W5WS6Z/ZCO6bMqhvp9LxdAMGsxiuoxoLxXc8C6xVs3Vu3jx8TSMBnqh1C58mlfg9TXYexWeggaV46DS+wjWYwYS6Y2msoIxNxCJvw2vWuuNP8wqN6kJuxO2/ezKbU8Tfh4cii9TK61U3qZfAO84DgLJILB6YMXFBf82QimKfHkXcjlAABsiBUEZYALoum4yhCK6GOclKnDrjyJyweBYHIreBRPyQeS3c1XuvzZq/HGOJ19FpJT1bwljmiHjcrg6Tl5x1gQvHeXUz7Np0vaSNS1XhS5D8e3fiwuMZ4CxmUr2VQ+fPamt4QvHSQXTQ/7fcuNxAxVL3Fn6jfhl2 XjxFeiur czxDjo4tixj7pBxVqUpA1+fpscIASZ83nUX8vNKPynkQIk1ALaw62qKTuw9r1GEPacFlgjpYFGXL2aTnP1/RiYPqS797U/1EPrD8G0Y+azJvyj+TIiZvPUuzLqExhbqGvm32TO47xEl2c2ltPtSNvXruhBY89dJQOTrIFmySdlBOucNFJ/l1+VldBKK8Deg1jKIbqQ91p/48Ul8mu7RDQQk7r9PbotJ9pRjXlnfMgqDognfHXpu00oxlb330PhQocWX/4H1JzuZ8qWKYXFJye8bCFib6vxHnAFdLOJx/arrdvjxHx0JgcDHr3T4bCb0bX7r+Ni3KjMKL+0y/GRxEchsIq1XI+WXWBEBvTpjTlpUwf9VVCMLsZVv315UPcucw1D3M41JyJJ+lfdivkrAgnJHxQC3/s1QlCm8JitNOiO9f+XNXdCZ5oYu2EVU5ULkHRhwHcS93qHYW7LltdKXMGUP/8ZSmTTpVRUZQudVCB5hA396OoGBmlqc2pBzfM9LHe7/vtFa+swiB7Z/2ZQYD5WST2lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.12.24 16:28, Oscar Salvador wrote: > On Tue, Dec 03, 2024 at 11:20:50AM +0100, David Hildenbrand wrote: >> In the near future, we want to have a single way to handover PageOffline >> pages to the buddy, whereby they could have: >> >> (a) Never been exposed to the buddy before: kept PageOffline when onlining >> the memory block. >> (b) Been allocated from the buddy, for example using >> alloc_contig_range() to then be set PageOffline, >> >> Let's start by making generic_online_page() less special compared to > > This got me confused for a moment. I'd have said "making > __free_pages_core" less special? As that is where we were calling > debug_pagealloc_map_pages() if the context on the context. Well, yes, but it's really generic_online_page()->__free_pages_core() that triggers this exact code only. @Andrew, can you fix that up? s/generic_online_page()/generic_online_page()->__free_pages_core()/ > >> ordinary page freeing (e.g., free_contig_range()), and perform the >> debug_pagealloc_map_pages() call unconditionally, even when the online >> callback might decide to keep the pages offline. >> >> All pages are already initialized with PageOffline, so nobody touches >> them either way. >> >> Cc: Andrew Morton >> Cc: Oscar Salvador >> Signed-off-by: David Hildenbrand > > Acked-by: Oscar Salvador Thanks! -- Cheers, David / dhildenb