From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36573EE57CA for ; Wed, 11 Sep 2024 17:36:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A52D694007D; Wed, 11 Sep 2024 13:36:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02A7940066; Wed, 11 Sep 2024 13:36:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82EB594007D; Wed, 11 Sep 2024 13:36:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6120D940066 for ; Wed, 11 Sep 2024 13:36:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CFD8B160176 for ; Wed, 11 Sep 2024 17:36:25 +0000 (UTC) X-FDA: 82553161530.25.58EC514 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf25.hostedemail.com (Postfix) with ESMTP id 650B1A0011 for ; Wed, 11 Sep 2024 17:36:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=FwvE0o42; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Fv14+9p9; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf25.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726076066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JH+gvFAcILCSPEa3DPAWhAdAsl5arvXT5zTTVXo3uOY=; b=bEjTHYUdYV4+//yDUyhwqp1X44RRIhu0yIv0VRbKBLRVPZDXgTFMCwD881jvAAo34A3Z3M T99BK3fKi7Idby4VAiz9BOPzTUL8x6KVJTN/fk9bWt4TiFZboiZqr9mj0pOHBnayCh9UIK 6dhy+TqkngLZzEYYt4C/IfbSzXOhghs= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726076066; a=rsa-sha256; cv=pass; b=b4cEhw8Hgfax8encSRPDP2J457J8LPWoHIibIXFfIaj7mnWVbr/j6anV8QZjBth1VZ0KPk D9X5I/b8mlBrbzhMBPjsb51/vxrWFGjOKfA/jW2r1sHajRAcRoXZPHRnQpKmdEGSZZLq8W w3gfyjWdI0uoU0cAj4j7nnKjLjwWCTA= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=FwvE0o42; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Fv14+9p9; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf25.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48BCgBo6032140; Wed, 11 Sep 2024 17:36:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=JH+gvFAcILCSPEa 3DPAWhAdAsl5arvXT5zTTVXo3uOY=; b=FwvE0o420s35mzRtMAJ+uqr8h6Z+rIA XTBeD4zaJWECQzgrBPcSuDMzBzjPn2D23HDJKbG7PEF4PGWo0R4Yh2u/PNHR/5jq WmxR6EjR7BaOJ5LARUmZZf5zu1nioqXsXz5aIQq4DT+EClg2WU6llxeiEsCylqUm 9MLKsy/0xHrPJaQ/OEZtswSAGISfVGxaUQE5c1byw7+rNv61UxwA5otVhdD+x3Dr nvZhmxq24VoS6gpgnUvlAs0tSyefWnU7OCmzLBQMLql4YZilrUkloE7AdShv/Fpb wKXQ2eb3T6ylB9vBHimF2ywWhjifZ3+saNyCfdpb9v3HxZo24xlZUTA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41gde08wtd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Sep 2024 17:36:11 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 48BGRCue040803; Wed, 11 Sep 2024 17:36:10 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41gd9btahk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Sep 2024 17:36:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w9EsMzFlHvXpcDZSKtGwJpz0JZr+/u8d6LCNuF61gIYStD8C2MUtX3NV+D21Fz6wzaSqVf/3FJALy1kFh4ThOcfEpbZoKbZFOT2tWuV8tZ2Ehf+WO3SbaEk7OuJq0WSZvOGY7IRMTbtOzFAt8g5WBLs3hm0gum712aEwUyp8BrBLMPKfDwu1SXTIYsyynzGrKyYCGqWdRsIA2GmgNn48WxdmcpFAr6wRd8lfHuIHFDZxIwf6WZGXTuy4i4qWcHWYZq5C8rgUohiuUT9NUtMXNvzaK3o6qVGv/ipk8tcb/7SS30fJur4DLrD6ctwdbmtk3DUom82mf7Rk4tNVwsjzvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JH+gvFAcILCSPEa3DPAWhAdAsl5arvXT5zTTVXo3uOY=; b=bmfMaG+yIpmdwL5VqK5u6bXWAXRSW4PI+/MA93KRZ1uju9Xvzq2I2CsGxt82PVQuU204mIny4A31Ym4xMPbNmEagyuXz37EjqFhFSgFin1UKrqrrfBWy8Nqb3SZyDq89ujzVloJ1H0YNCJFZm1m8LsmQU5I+GAqPoCUOUlyGdmKKAuMS89dFmugthlbDogyA6WW2hqjbQ5FQic+arK5b/qCt+lCVAPLVyhjMaGX/VmpA5z+K1hcP9ILuSU48gugKj0LuatNEHR1P5DsLU1gyAAETPyorA8SuJy7PyYnqxRJIfZxknTfasxIQ+0rYPh549BFAbeXbeZkk77/EQ+aANQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JH+gvFAcILCSPEa3DPAWhAdAsl5arvXT5zTTVXo3uOY=; b=Fv14+9p9MdCSs1IHWPbrWf4up1kic+hl4WBBnctcOLPTtu7N2z/6yGQMxdUzs1UobxbGZgNnWaFhOF90YYNhOTmfUUxpGGG9x+tG/hKOBip3eS7AYWWGR6IoXfwWAGYRve/IIOF/P/PZLX4JiYjECnLwct1DhBRA+0bjyAl534U= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by DM6PR10MB4393.namprd10.prod.outlook.com (2603:10b6:5:223::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.17; Wed, 11 Sep 2024 17:36:07 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%5]) with mapi id 15.20.7962.016; Wed, 11 Sep 2024 17:36:07 +0000 Date: Wed, 11 Sep 2024 18:36:04 +0100 From: Lorenzo Stoakes To: Dan Carpenter Cc: Hans de Goede , Andrew Morton , Richard Narron , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Marcin Wojtas , Russell King , "David S . Miller" , Arnd Bergmann , Linus Torvalds , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH hotfix 6.11] minmax: reduce egregious min/max macro expansion Message-ID: <0a73fda5-e6b5-446c-832a-e6df8d3c0c90@lucifer.local> References: <20240911153457.1005227-1-lorenzo.stoakes@oracle.com> <181dec64-5906-4cdd-bb29-40bc7c02d63e@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0176.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::19) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|DM6PR10MB4393:EE_ X-MS-Office365-Filtering-Correlation-Id: 40f020de-7561-4927-dd06-08dcd28837cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PLsAFlpGbE/V7VDfGZoSj8tSoB8A6I+/lCwJh6t5aMjSLtD/It6pYrb7/JxD?= =?us-ascii?Q?maUgoAREfE2UkRZwE/oClcEn3eTy7D2Aq8wcjFZKtvZ2V88u5Yb0Ubz8zVVV?= =?us-ascii?Q?mXBllvGydqX/rJkVmSWbJIKq5NRc/W8CzUL+gaEExhp7Eu2ePRJLtjiVTFXl?= =?us-ascii?Q?qsaoFapw/wDfGUH6fsFdTg10t7AoLTjM4klbTkwXuNi0rNmvFMh9gDkqYWOt?= =?us-ascii?Q?YMt+VxoHvC+HRhRsdW4D/xKQMCVNB7rDwgLV5H9HJ6Qnw3Ll5VUopkz7BAhW?= =?us-ascii?Q?cO0rE9IJpdwDMgv+cJRzsfGMTBwoDgkPTazMcQ/F/ZGLSdsVxvYYqSX2pQRC?= =?us-ascii?Q?Ewph6RGbsF5kRxNyh6qHlUrBNM5rKQG3UG3/3KK40JmbXWtOT7w1kBjvHrav?= =?us-ascii?Q?Q5iYKRDl6n9YJFurj8aGFdJe5681srOScuURbJmuqOUimJDG4f7UKPqaIA81?= =?us-ascii?Q?RsJmId9SOS1Ww80xJeN2aaHLVc5sbbuHrYbmpbiW5UvYemLiW62uCA0MwfG0?= =?us-ascii?Q?lOyw7pTdzmvP7kW1E8NpcUbzz/b08hrDUjKDsBUHCX2fdeHUeihT/NceeCvv?= =?us-ascii?Q?wUsHV+MhmC4WnKud7DqSgcQk7INVhTAeTMXPe/J9BSB5GQwWGxj3qGWB/QGL?= =?us-ascii?Q?pAjOfAD3oAhqYkHT0r535xCV696LxHKe6jeY7VybS7VrYBXf7pgM2EJ6gI20?= =?us-ascii?Q?zju8nXgCknKyzefrSUgpAFjqgIZHJPNOaclzwPwacjsI5Yma0D3NF+uuQZGk?= =?us-ascii?Q?PZeS/kA27yWQjYgxp7Da8n3PfUJJk6bSu+MP1ciWx8iNVSgSG17zxcY8R8NZ?= =?us-ascii?Q?rg3SB4CywULY0U9fPZl0GscyZs3onmHbWKzklL1mhsGaZO5e0pUpnNqCYY7i?= =?us-ascii?Q?7rwh2wwHoTPWJlphizhOA4/qUUXnGdmWHfeSge1A64tiW1Zh4Xs4hMdlNwGC?= =?us-ascii?Q?7hJQZ5qvK2vJI+rubHMOpW+w/hgWoUksaTUYxLhcQcM33jig8O3VAxQJMCOO?= =?us-ascii?Q?nZvAt2utU+slQhLRkA5ShlM3ImSYS/wtsVSrYpOarpyeWNzvrkfw2ZGTniJ5?= =?us-ascii?Q?lN7SpJRjjmZCHO4vrteFMMi1SMKwhA3tHTfZCVpciWXfa18rVQ/ftA9EHE2O?= =?us-ascii?Q?NV5W4Jgkjjdq2e2UhEoYF2P/nAykPMFORaR0iUAfjtXrCFhubTnplB7KFxA7?= =?us-ascii?Q?Inl/kocIuMuTwR3pQXrSVgPnVXM7jna/Chgh05m9OzjMe+8qccZ6EtCEg+UI?= =?us-ascii?Q?52ApsB6zWfOK4+7C8W/OCAWa6TCFILE7ZmDujsJSu1MtgTfhzbbJjPdpr86l?= =?us-ascii?Q?0fZjGNF4xiolWXQSW3Mc49KeN9qTPVj1822SUidUThYXTl3/CMdxIyINwR+t?= =?us-ascii?Q?4+kuWKI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?htiMwbUJ2ni6Kwg71gh46PND+9u9I9WiuACM5h2Z6LWuIvXaj8IHkjxhPvVZ?= =?us-ascii?Q?/38DeWYcEMcy0ts4WVuJEXZPbLYxHSldBV1XaUJTtOIB1klKKez5oBezpG6i?= =?us-ascii?Q?KjByhswhSsW9HThccF9F/uQNtH7IJqsfKtVMZUXoe35VYt8KqRFqULErRvgM?= =?us-ascii?Q?1C5EALg0huYX5MuKpGu49LHOt9LySdTdoPlzh7Gfw+KjM/MYiOvY8TiNPrB/?= =?us-ascii?Q?5bJ/LbbICzbJsezDYzTxpOew0TfR2LBIn4vG6YbTinXNf8EK/l+ZqrF3oeVP?= =?us-ascii?Q?AWQhcxfQEcYA6T4f62JR5jcH2YizlZfdV5bayBR7RCHF52w4XgAWOShiHu9v?= =?us-ascii?Q?lQaLeItc+WT0Be6VFPcvndMNFNlwFVi1rpGOBunstQhs0XyoXPoq3pO1B1uH?= =?us-ascii?Q?KB+sTOy7p4ZmEPVpqzsA1YRUTd2Jel6JG7OEcGBmrO5a9iovtNy4DeplWwzr?= =?us-ascii?Q?KFmrcNhu3NmOi11afg46JMJ79zeO1Vj9vVBOiHFKe6/NAk4gAje0g2OcRC9R?= =?us-ascii?Q?ua0Je6aTpS7gQ1Rd7FJU73KrTAbk31WULmFix6Sdpg4T8U1MbYxRMYYarLER?= =?us-ascii?Q?tH6nkk4gF9hIJgiT2C39sDIoZhOF7PIpabkG8xQ/OwTaYlx8GkmKuY6EFPIT?= =?us-ascii?Q?gfhK12V1V5x53+sFKVTEhgU35l1wGc2ASPXzzJBu3ek6RYGGT1V/BVTsnKC+?= =?us-ascii?Q?uA+VG06O9qkxbPTEO0ZG7tywCmiM8BsHT241cOGIo4G4xtRp1+N0Ufd0JJ8B?= =?us-ascii?Q?Hez93UimN4l7IPKwwl1UxY3c0NNooE/iTH9jEtmNAUNQNOEKb2KuhLUIrXSU?= =?us-ascii?Q?BRJJHAcdJViQezT36DLgcyGn7ZehyZSGw+Uzso8BhDFMYqljHW5nZbmg4ulg?= =?us-ascii?Q?Xoj/ewtmeQxBE/v2a7Cf6IJKV7gNmOSWhmZ6dhHrBaepb2Y+EaIQakcZ3CjS?= =?us-ascii?Q?ADMKMiuJ6kyLfW9lHRCktf+P9E2niu8A5j2aGm2/peH1QYxJfo4WfvefuPV2?= =?us-ascii?Q?21sLAGFMSOXNNPi3Dc6YJ09+Y11zmLdieg8Gy8SB0Tk9m+IFd+JvOJ07ioJJ?= =?us-ascii?Q?pXf3SF27jE9bwm/aRaYJ1U58zLLVqHEEjz/nb8agV5Gd7TuddIyXpM7fU2xz?= =?us-ascii?Q?aAfh2kibEc2xzmbeKlfI6ytVXbwO+CKoCmMwTu2Lzcgr3EeHF9LUNdIXttxQ?= =?us-ascii?Q?q6E2UaMJKDbYKJvjopoYcvBaSRLpBlKIcnMXMpBR6GeXxa4iLbBJFOz2P5Gv?= =?us-ascii?Q?p87Alc3FvoFGFA3+RJabI1vvQ95y6oHdVcVHLXAbKkG1IUMmtZLrObMbmkFw?= =?us-ascii?Q?mSRd0Y1i7HwCnXwkEBW3oHRgC237ETPikqI3rsXqhZG20sbMkW/lQNIiPYoY?= =?us-ascii?Q?ab+N7ryEiVVF5aLWKiLiXzdA3DfrccPZOffIQLpkaJxIs2Xhyaapiy3WCUhU?= =?us-ascii?Q?+sM5IhM1ASjDrj6sdHu/M4B4Gt9SqnKELvDTIo7DIbQk8PS9vMH7UNCuB11T?= =?us-ascii?Q?GsYqlo5DKUd2wfN5XkjB1v57ccKefde4xy0f2eZR0caWrPvROXd/YpN2qo63?= =?us-ascii?Q?3hPJhrGo1LrjjB7S7QfAJeOyA7m/ltmSiseGp+gY84FOJeT1V2zV4H/wosK7?= =?us-ascii?Q?oQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4amNPDSk6J+/KW1N8htYOP5DucMICiGHOtf5sDQZ/gBp68+Ce/a8H/9WXt+hA40pKVum86+hb447Ock/3XxHdu5e4UPYqVQLqsqgCN2ECni4kgO6VKnfGfOyFUdLx8YhRcD0Y0LbZOPdeBEMVhUT+mFaiVBn6mIVAYuZ8CXIor+wItvnp9UViJX32YMiNJReHVusghO+tdy0WkZfHHPp3ocnDWcm/R6pSPGR/SRfDnOccqF2b+qLZ2gD2IJVpvvV5AbSgJ9i9DVLgdAv1HZxigb+HmxdSaULo+qSww/s6gwg1iFdFep0bEdVmMXy3hygsP/OvR4oep89+Q6RoOZSTDPwu+hw5lPtaWiaogMRhABLDQ0ZP18N8RA3rPORUtYeXs0iQs0iGhHGJyyRD9cAuZdmgcnyuAHE3jWZZpsr30A6m7/norSxdl0JAkL6EOupxdVoIzjf8d2t9JRAbGOgBMZM52EcWJ9rkKRykUuxPXvvGIcIb6ji69WAqg9jo+K16M0uIsYQqIiAP55cF6EQOhVNK7tk0xq8UD0sVw0P8HO7jesRWA7ZXb+UKsVH33gNyba0WEVOJcDO0teIPosJ3ydXjbj3qEk0R8XpopG3eQQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40f020de-7561-4927-dd06-08dcd28837cb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2024 17:36:07.5505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QFO5Q6/8B+NwehoTn8/f2vjejJwV6LWQHrgWRzCJYyBsyYdwY1MyL/FWADmG8slqivaguz2kXq8yaSdPgsphqFXWZ6RbD/9MapVQn3YePSw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4393 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-10_12,2024-09-09_02,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2408220000 definitions=main-2409110134 X-Proofpoint-ORIG-GUID: q2CZQd6XU8oAR-gHSXpFWQjOkjslgXiW X-Proofpoint-GUID: q2CZQd6XU8oAR-gHSXpFWQjOkjslgXiW X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 650B1A0011 X-Stat-Signature: nq5ie3d43cfs45f355nbeamom5e8r6cn X-Rspam-User: X-HE-Tag: 1726076182-89211 X-HE-Meta: U2FsdGVkX18SH7x3HOr1Ws56BpMAdRWc/fesfiOYmhNtdKr5uuFzbeuEpNA+Iy7rOGE59+O9GJEx1CtWHaAqHCYKOiilPYgVL3kg/cqSD2sqgvPEUDDzkxFhBJLSl09Asb+PW9AKo/sQlygbzwrJ7Y6T/bT6A3ZskTmoU19Q/6p5NAAYpSsmYcgLmzHLsLEHap4X9jqHZ713UYmbHiIx4zYBj2dKQaKtFy2HB+8K2ls/NQ1+GM1OlvTf/Gh6RL1pOXFbCH1M5nN6biAhjlrftpw9r2idhuUWz5VG9abcIcZHwwsobXsfg59NLxXuFoOjDulhanlLaqSVFBdtAsTttgLn0UbiW3te+7AvOSnGnvRssK5FIdhpuo4V7j1tATAifR5ActyHJDo+RJXEf7jLzOJSklZ08tvm5BRER4DIzN1YBBKMYy9uVy2V5wzrX9bD9trBh3u4yPKEr5SKZjREU2NVbOIcGoC4jZkqzfUuHUcwAkTKRwaJ3hqpQlx5cP+UuO5dxQnbQFq1pffviyPDQYD9UNL3f6opQlQJj6Vam7sL1ApLiJvcjHfhCTy9YexzIah6T2f0+5aXNUhrQ5pvWLpw4i/PCJFHTy7WYQUf5sf9tQPJ7mm5fuUiiIdWfoab7mfE/m7VfFoIitEPctkDwLFXbPWDIVJafFZy/6PKwIzSxmKMRKeOw7X3s9/LJ38qlesRCPMBLbwhAIQqEF7mNVI/kmyWgvqlomCMOFtCRgkeHwthPLBLFnyZ+RIGL7LrZ4MDAuFXbW6ngooR2BeDsEgKXuaihg0Ib0j/xWxuheLCbaoShmoYuzL7h7G4vdN5B5zi6O8Mo7nFRcJLn6jbLjwSBt/zUh+2LDlGTxf1inknfl2IjBq2j2tR2dGCMogwu8cyi9n974qZBVO9SMHsjCOhfxUHcTyo6RgxnQ5YYGpj1awhXou1Fdl22IocZgBI+l3lZ5YYeeXI12c4E6n EICfXWAp R+65KBECLuW7FaIjuttN1ymCdgQpZ12YPE2ZT31L7L7Wm1hARxT9mLArif0xtgNT+ZCu0GWSQKdO1YbcFuxqEusS1V3MZ1vylNODn712x1hLugljXQiYx7JrlyxifDxTIVADCBOlFJAyxnywI6t4UJqV2gnExhRbt+RMtrIIHH4GypThM0fC8DfHkPywglTEcCEWFCHVIBeBNkkL2e1OJJHt4BZ1WSzBAGkjM/jZ23dFU4tcf6th46F9fwVlsbar4pZzXwkUej+z5F5yVX7Sumpk5Ryv15Ue5uK3CVH+Eilq+NCBDoBKDGE9vlTA50notkV2SCJpdt19+AixKDdWu7uFmLzSvMFAJ7PO18vZq9osLogoXa9+ijZiD6oZCTIcv1b0LFBtgnOm4oHTIolabInfbKBjYHdYbhMORddiydjDKmiy67NXX4dkPJ3HVBCn+swZhlSZaz/AwC7xiT+gBACaAF7T9RxhymuoOY2oriya4cmwZNJcrYMGYwBlbOeyje6+vK4fZMZAyDRXHHe2wMjeFSR3ujv5ulRY7ipGiv+4IOEaljIenUG69HyKjMxZhrKtDJDv2X1o50dtAl5mL3xP+FfQ93PPyhB4YIM4Zo8YYnfnRxXZJvy46spPQinF9jaXoKBmcJSVyoACXU5fm4NBq8ybNeC5Ye8NfUZr7puUWXpwU2CwIH+OFHlNhXIUUQ8vYC28yii52nt5uN23TAq5T/3eGTpkmSi7E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 08:25:33PM GMT, Dan Carpenter wrote: > On Wed, Sep 11, 2024 at 06:24:54PM +0200, Hans de Goede wrote: > > Hi Lorenzo, > > > > On 9/11/24 5:34 PM, Lorenzo Stoakes wrote: > > > Avoid nested min()/max() which results in egregious macro expansion. > > > > > > This issue was introduced by commit 867046cc7027 ("minmax: relax check to > > > allow comparison between unsigned arguments and signed constants") [2]. > > > > > > Work has been done to address the issue of egregious min()/max() macro > > > expansion in commit 22f546873149 ("minmax: improve macro expansion and type > > > checking") and related, however it appears that some issues remain on more > > > tightly constrained systems. > > > > > > Adjust a few known-bad cases of deeply nested macros to avoid doing so to > > > mitigate this. Porting the patch first proposed in [1] to Linus's tree. > > > > > > Running an allmodconfig build using the methodology described in [2] we > > > observe a 35 MiB reduction in generated code. > > > > > > The difference is much more significant prior to recent minmax fixes which > > > were not backported. As per [1] prior these the reduction is more like 200 > > > MiB. > > > > > > This resolves an issue with slackware 15.0 32-bit compilation as reported > > > by Richard Narron. > > > > > > Presumably the min/max fixups would be difficult to backport, this patch > > > should be easier and fix's Richard's problem in 5.15. > > > > > > [0]:https://lore.kernel.org/all/b97faef60ad24922b530241c5d7c933c@AcuMS.aculab.com/ > > > [1]:https://lore.kernel.org/lkml/5882b96e-1287-4390-8174-3316d39038ef@lucifer.local/ > > > [2]:https://lore.kernel.org/linux-mm/36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local/ > > > > > > Reported-by: Richard Narron > > > Closes: https://lore.kernel.org/all/4a5321bd-b1f-1832-f0c-cea8694dc5aa@aaazen.com/ > > > Fixes: 867046cc7027 ("minmax: relax check to allow comparison between unsigned arguments and signed constants") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Lorenzo Stoakes > > > > Thank you for your patch. > > > > I must say that I'm not a fan of that this is patching 3 totally > > unrelated files here in a single patch. > > > > This is e.g. going to be a problem if we need to revert one of > > the changes because of regressions... > > These kinds of thing also complicates backporting to stable. The stable kernel > developers like whole, unmodified patches. So if we have to fix something in > sDIGIT_FITTING() then we'd want to pull this back instead of re-writing the fix > on top of the original define (unmodified patches). But now we have to backport > the chunk which changes mvpp2 as well (whole patches). Sure absolutely, as I said to Hans I did it all as one as I wanted to get this out quickly as a favour to Richard, but this was a mistake, very obviously it's much easier to have these separate. About to send out a v2 with this done. Cheers! > > regards, > dan carpenter >