From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E542C47422 for ; Mon, 29 Jan 2024 09:24:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 858EC6B0082; Mon, 29 Jan 2024 04:24:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 809EA6B008C; Mon, 29 Jan 2024 04:24:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D1306B0092; Mon, 29 Jan 2024 04:24:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 514B26B0082 for ; Mon, 29 Jan 2024 04:24:39 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E0791C12F5 for ; Mon, 29 Jan 2024 09:24:37 +0000 (UTC) X-FDA: 81731813394.12.757DB79 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 272D840008 for ; Mon, 29 Jan 2024 09:24:34 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706520275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4MCND0ajQC4teQRgemND8iZu+V9aTBWRa6Abnx1IORg=; b=gUcto7APBAeJ20Wlmgo2bTixBdogYC6XOFjT9GMY3UWqw08JowVywycNH5YHAgY02kwaAl StZWN7rbxwfrV390QEGRoTMt1lRXzbbgad7uV4qipZhC9Vr949WBOn7FLhQtGTNIsjEhQi VzCy5xo8qC3IhoLsNBd1vcABIisOSL0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706520275; a=rsa-sha256; cv=none; b=kzFeFhOjqQRyTrJZVNa92jwnXtdDomLX7k+MCtDqmI+uim795czkxxP23PLZqlNaxzSyAs H3H3zphxfQW1cDM+TUaKlCCCCG5EOMF9LrJ6iE5p440Pm0X5M90CHUEfhOHYzjqkVO9d6e J4BfvVizmF+h9o7YUzwtWXz8prKzdp4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 132871FB; Mon, 29 Jan 2024 01:25:18 -0800 (PST) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B6393F762; Mon, 29 Jan 2024 01:24:23 -0800 (PST) Message-ID: <0a71c87a-ae2c-4a61-8adb-3a51d6369b99@arm.com> Date: Mon, 29 Jan 2024 14:54:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLOC_SUCCESS/FAIL count the number of pages Content-Language: en-US To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-7-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: <20240125164256.4147-7-alexandru.elisei@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 272D840008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: aoyufp3jmcik71usnd1snyxxg5cq4s5q X-HE-Tag: 1706520274-211642 X-HE-Meta: U2FsdGVkX18pKPu+LJUoABxxqxIfSQUDQ+Sdr7l976vkapmfWoVs6RewxjPOdCmKKXbixdV0rE8FRzLQ4ovIUDyWTNTx9VL3c+ITSiy4qB42QfQQsH9Dwh21y59SfJ7obLn3kYaoCpEi/o9OHX5nkz9jtHZ2PjI1hdzlBwmFAVSGuCr7bLeljvqjEqhCX28MrJO/Cbxgx+W0MXbfHmmlyU8BWJJ7CzzpT984zEUOYGbVouWNUsTMDO+1YK9KJUjvNgZ9VVoIcq4nB3CGZUgRRRg5leclW3bE7W9bwBJ0tnnlDHKUvPxa6CDtPOy3i1L7PVjE8theVxexBDjucFG1NfH6eJ0mGd9Y7XHFYYL0vR+jkubXkFKBIqmYuxNKAx5NKjv4i6k2msjzOP8HED4W/QV3vr+MTHBXOcj+kfcZ0/Oeoma9IwhLayI3aA6ZMS5EOU7Srst5dUaxAdfwheXHLjrU1C3SUdkyKTb/vlTC8lpqQ3mol+NDLdmkqAtDkieOLLJRLiF0BvdKXUEtl0EnfYJkB9EfA+fTTZZmb6p2d0HlGe7bK/L7MB5gHizuItDB98zp42IGeSE8oMoZPrvKQMbU+m6H6DzTLod8HSxXMmoODKPZnYaa1jJpuDzA6NKk6lsKXUuVCb/4b4rTGi202Dcm+S8/s6S3iGEOXbZilHSjNs7J5f1z9nrx01lE8Lg6JFyYfOVJ82IYPATHewdZ8Br4FkjfIMo/AwYrWnmB5Mm0qOzt4OXGd8XMWRRn9Mg3RdEvBBI2utcOfJ+OSlN5C82b4RJT4YFPh8Ix37cNsD9Yay7iPlLMRg/BXtfGa/urdS2dUPze4dJvsSbsacfBQNWH0wPrLm8qmlQ4ty/YeFqoWvs3xaHExzSRhxoKwusxQfsvY2r8evSE+Bun1CsAoRFDc4ouNYMHAmWzNP1ywnMlhNEVrZK/FjPoce3+o42MheVwVdNh2y+UpHcVE/U CrndjP6t ahY0awzQekNfxX/JU/IGvBInn/XvQBkCpnI5zYxvmHjbH2ihmwFwUr5QKvrWyq8M3LxP+DNGl7lJZ/vwVWu7lYa37VB8G9nqYCky79XOR48Hw5t+MhHShtlBenS0/6UdOzWYnW4ZFXztVqa7keUD1qFGMqifGFzBL+9BhrA2hUftzN3RNuWpPdJnEN1v439miu0ADGzsfQqkfy/6pQ3bb7EUyNwG88HFcnGol5nOcumcuVv+FDkvhwEr1ce2TCFpGjO9Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/25/24 22:12, Alexandru Elisei wrote: > The CMA_ALLOC_SUCCESS, respectively CMA_ALLOC_FAIL, are increased by one > after each cma_alloc() function call. This is done even though cma_alloc() > can allocate an arbitrary number of CMA pages. When looking at > /proc/vmstat, the number of successful (or failed) cma_alloc() calls > doesn't tell much with regards to how many CMA pages were allocated via > cma_alloc() versus via the page allocator (regular allocation request or > PCP lists refill). > > This can also be rather confusing to a user who isn't familiar with the > code, since the unit of measurement for nr_free_cma is the number of pages, > but cma_alloc_success and cma_alloc_fail count the number of cma_alloc() > function calls. > > Let's make this consistent, and arguably more useful, by having > CMA_ALLOC_SUCCESS count the number of successfully allocated CMA pages, and > CMA_ALLOC_FAIL count the number of pages the cma_alloc() failed to > allocate. > > For users that wish to track the number of cma_alloc() calls, there are > tracepoints for that already implemented. > > Signed-off-by: Alexandru Elisei > --- > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index f49c95f8ee37..dbf7fe8cb1bd 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -517,10 +517,10 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > pr_debug("%s(): returned %p\n", __func__, page); > out: > if (page) { > - count_vm_event(CMA_ALLOC_SUCCESS); > + count_vm_events(CMA_ALLOC_SUCCESS, count); > cma_sysfs_account_success_pages(cma, count); > } else { > - count_vm_event(CMA_ALLOC_FAIL); > + count_vm_events(CMA_ALLOC_FAIL, count); > if (cma) > cma_sysfs_account_fail_pages(cma, count); > } Without getting into the merits of this patch - which is actually trying to do semantics change to /proc/vmstat, wondering how is this even related to this particular series ? If required this could be debated on it's on separately.