From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5271C25B76 for ; Wed, 5 Jun 2024 03:44:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691DC6B008A; Tue, 4 Jun 2024 23:44:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 641966B008C; Tue, 4 Jun 2024 23:44:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E1EF6B0092; Tue, 4 Jun 2024 23:44:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2B8D56B008A for ; Tue, 4 Jun 2024 23:44:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B4CF2A1A49 for ; Wed, 5 Jun 2024 03:44:31 +0000 (UTC) X-FDA: 82195442742.03.FE1E9C3 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf17.hostedemail.com (Postfix) with ESMTP id D33CE40007 for ; Wed, 5 Jun 2024 03:44:29 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dm0ixBmG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of seakeel@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717559069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SbD49E78cddouoifsf5mdpBCw/xwoRr3LLz54+H5tYg=; b=3tPR08ncsCYvakazIvGsUaxlWeqHlmb7zdF69ZJPpmIVZ+HkeUjQFTPQtkhZCSL9tYc1QW /+k31MCECXuf5YejCaVTg3BALKKYo8ksfiyRXPy2w7fo7/YGGN0z6V/0hE0EVvEp1IP4Oc J0ifg4jDCoICt1nFadw0+hwBhKUYGHg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dm0ixBmG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of seakeel@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717559069; a=rsa-sha256; cv=none; b=FN1v3nQXCgMWS8zhoi7v8bZwchGJkdDVtfJbAUQPCRBP0b2QJ6dzTw4r0tmVk/hNAc3b9G Oyng+M6LcaH7clfh2snElS9en9hmlY//rl8Xqihj6WD9nzOYUvVzyWT8s/Kbj6j6CYAMLa VYhl74TbX2eaZL/IsKd8KJDgubKmrCA= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2c21574d8ddso2809637a91.0 for ; Tue, 04 Jun 2024 20:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717559069; x=1718163869; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=SbD49E78cddouoifsf5mdpBCw/xwoRr3LLz54+H5tYg=; b=dm0ixBmGUGNxU9Yg2RDzJ9TW8/Og+r7UtaKJwoa9GemAPnKlbSsxo8VmDseYcnqSOL vdZoGgr0z8B0td9IcEawb6DdSn4lCDSCxAgQDmZ7USQpdEQ6IHWk9xMJh+6n14M6u7xq Ck7oj5yVKQgUD8DvuTPFz5Y4PtdMolBqedWO+Ac7Fp0WisUGxTB8CryWzMD2ztYSU3v5 AQrVQiPIP+bwIcJRDCOr2nsRH2D3ZOP1v0+xhoHGEFGIku7GlWsdPJy4/8TwYu/rTQiR oJcUy2bnoesfr5kUO7tu1qehH+Uptz9PgWN6Of0RV91YyFCeR7osTs6qVCdjuYa34SRe nygA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717559069; x=1718163869; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SbD49E78cddouoifsf5mdpBCw/xwoRr3LLz54+H5tYg=; b=RATGjJK55FFgArY8TowtLL3FdGSpQEVcXSpCk8mHn6Wax2jvbxw9rK7ZGWDWvZ7KMH dig+R+jdI2jCC6NOw6AeaMSABC9tiAoL/a0G/6j5EdcayIar/tpfNFEGF4WbhDh3DSTh hVLB11i4LjjzwDYoc+ST//xXA/7EA61E2hldzYSn4OPCmfMboV6IOVtQ46k6Kb/yp1VB vPlaQLFXwZEiJqz+om/q/dk/6oISAr9hPWxBoDyE67yZVEcIF+ptZL+tOc06CnBvkUj2 uCpHVka8l1Wwj6JkIVg429bMT2AxROZUdDQ4sgYCQVpLKU3C/PHkYOAMnHxm95myFi/w T/aA== X-Forwarded-Encrypted: i=1; AJvYcCWlU9oLeGY+empShBN1hY5yd85eoOOWa4fIyox/rDXmc9N3y24iV+QUcQFUsT2qi+Xlc3eAuQgibY/ANY4ozTRTgwU= X-Gm-Message-State: AOJu0YxfH96XT1sskGWW56wsUEpUbK5sH4QW67TvaIbzBfvujoEaC8xG aGUjtUWgTCEKfiMmHENlRtid1Kj8yd5E025xzTL05USRdyr9+Bwh X-Google-Smtp-Source: AGHT+IF6ouiokiVEyFL/FkVwCikSYFZ+WjrqZx3MbtO/OSdFIf0J9kZ/NtSEdTkFp9kIx9hLWh3+/A== X-Received: by 2002:a17:90a:fe04:b0:2c1:ea2e:20b2 with SMTP id 98e67ed59e1d1-2c27db57d16mr1342743a91.30.1717559068626; Tue, 04 Jun 2024 20:44:28 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c2806d1be2sm302326a91.55.2024.06.04.20.44.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 20:44:28 -0700 (PDT) Message-ID: <0a6603c4-ac05-460c-8bad-66813570b426@gmail.com> Date: Wed, 5 Jun 2024 11:44:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] mm/ksm: calc_checksum for folio To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-10-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D33CE40007 X-Stat-Signature: u7ugkjwhkj43fnz4wnpqhs81shuztfsw X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717559069-179643 X-HE-Meta: U2FsdGVkX18TQJMOowli2JRm1NOg9PMDDm2VWdar88GwWIG+Typ9Vm1i1ZqNgCoHBbrv/vlWs4TiOia1AevD1QsBcLefy4q5dnW3KLhE7YYW8RgjFT8EkHqVWSV6m27kFAI4dydAswdkRgvfCZG/kZNumxCWSwahJg4MQ+DS0oIqJVHQM4YtXgk7er7eSWbIMQcxX35C/CvVJ0VE+jXFKoivt5ZubwlUQ2CgC1YgQu7Yj1vgrx/bntxONp0REbVUy13BY3i48QDByJaOIjHD37Z0xhF8jVRWwkL4auU2Uo75BsGJ5BunZgpZcLM6tIeWvv1lNOH3wy18TrWXd9SgzYKJsRL7g1SOUeMwxSbcgxSw9Z6d8Q3okdIeOvIzC/MpbbDb9smd2eY1A7ksybdCxXvq0rXrouKundgKfFwEY1SXXxGmhhZs8GvuUqaT0mLfp6YYlmJgmhUDM5e/KFvujKC6HPKBZ1afotvSOpJK6a58evv8CgVVs13PFrGTuCJ7fWn2dnOrYuxWY6LnoiQVEfXyzCUtRwFxeUpad8foZ8fL/e36yLXD5NtmCHobqSNudPpeHTjGJDxYjVXhwi3XTCTV24WAXd5gRiXW1baU6P3tH7AQWoGSZ5USwob1/+fKTF25ta+qFg3ophn3HRky0+Zjmbuj71I8wD/8TTr3yFtYm0YSqo9dOAgs5TVRDvCBG+8JGIhrVnQQWoXq3shlUYL++RCvQ0blJfx7CLDCPl3Av5yXnTsA8oGbep8NVRJQSNkOTFu09DMz1Qj2HrbMeSsWeGZXM32Hm+I6V5+XgQzwwkV6W6usOSzTB6zmWF1D08EJNzCN7bnMB7QcWUYLuPMtAQPWzkPVTPyDd0CuFoNZok7lpBq08Zz120lOcPXZKwbu8K0KJDFT2Kn3SDjHYOXHBm6Lk+FOIZCnpFBlvilRLMhTqq6Ou3uqzjxLPankg8CzDL+4Y1wqcimCCDE d6me7LM0 JT3BehT4pA3utiEFTjc39WFMuOCQCJFqxbTsrBOEw9uZ7ZprR8NzkE5KECIQESkQx6biLw5xQfORFQu9IldvLzUntGqsa8fAigw65EJvp0ZrDI5ypirecHlDb4UcqauylC2UNqVjxBNZK0CZBdR9GaA0DxGW2lfQ4/0zE2hBvrjPXtClQC6rEvLKgEefhCEfbApfErcGjz+4GdPMusm+ZU7ao4O3VfUZLCBCfRu6d0t2MveqoTEO44+XwSkqoICUNWFx+xCRZlKACdQCt+5O8phEMwEABOXg3s6ltjGFAg+EG5O8Mt2T4clUGtn/HxLQiZ0PGP7fI1xZVNNV3BYq9wiTLaCJ1mnv3FlC1dVS9tTgpoZE2LR6vzn78aAF6ltra3mO/1MdJkt+P8Wn+Hr7lRlOcqjUy0PS4WPSAv4ZkvNDYL2gsaT9HLLirTdnbiJCHqp9+8KLJWHfjAT6hgAqJbQGXO/S6g2tgu7vCtexr7GLZhMo6pP1+jBSsD0gOeyHfC2cbgDx8YzSE8Gd0d/l/UF1LC5FCbHv+6M9R X-Bogosity: Ham, tests=bogofilter, spamicity=0.001316, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/24 9:18 PM, David Hildenbrand wrote: >> @@ -2369,7 +2371,7 @@ static void cmp_and_merge_page(struct page *page, struct ksm_rmap_item *rmap_ite >>        * don't want to insert it in the unstable tree, and we don't want >>        * to waste our time searching for something identical to it there. >>        */ >> -    checksum = calc_checksum(page); >> +    checksum = calc_checksum(folio); > > So for a large folio you suddenly checksum more than a single page? That's wrong. > > Or am I missing something? I am not sure if this change are good too, anyway, comparing the whole folio may have it advantages on efficiency, but more splitting do save more pages. Anyway, this change could be dropped. Thanks!