From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE5CC432BE for ; Wed, 25 Aug 2021 08:43:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6D506121E for ; Wed, 25 Aug 2021 08:43:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6D506121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 58A416B006C; Wed, 25 Aug 2021 04:43:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53A606B0071; Wed, 25 Aug 2021 04:43:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402018D0001; Wed, 25 Aug 2021 04:43:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 2458E6B006C for ; Wed, 25 Aug 2021 04:43:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BCE638249980 for ; Wed, 25 Aug 2021 08:43:21 +0000 (UTC) X-FDA: 78512963802.12.8882B1A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 3831E10000A5 for ; Wed, 25 Aug 2021 08:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629881000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbsXMyTovfUKWZOEFQO3h1qOrrlv91veJJTI8bsXjsw=; b=OeUwpkb2grkVyfwlWigCTz9EASnD1Rs+CjmPEBFaKA+DMG3QTCOM2xvMQehfjAGFZmAI47 JVI5qPFLKTEslLXk9Yn04g3nln+LOlfs32cz7OUIkB1ISkqebD//2JH5Kx5HnJXEJjkOWc 2KYNVSyws07IrosjUif5YBthfk9Aovs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-1IEp1l1yP5irk3miRAAkkg-1; Wed, 25 Aug 2021 04:43:17 -0400 X-MC-Unique: 1IEp1l1yP5irk3miRAAkkg-1 Received: by mail-wm1-f69.google.com with SMTP id m33-20020a05600c3b2100b002e87a0542efso1043427wms.2 for ; Wed, 25 Aug 2021 01:43:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=CbsXMyTovfUKWZOEFQO3h1qOrrlv91veJJTI8bsXjsw=; b=qIDBdE6DcHs2sJNLc1J9SHo6EOwRcVo0fXzkgJRq9OkGL0lMEN6aJjV/NLSzhBZC4a cAMO3eJhdjv4t9BUuS9KY2vyZR/LdgNaTNHrjubQ8K1XtRIkK/XwskQ6+5C/yCxWJN/r V835BEAaU//fhfS/VCmwPuz59XU+gXhxoQcqx92mmWtgt8xhFtH9R0O2RD1tRd4+Vr0P tZVQfG30BJxu0owAkbfMZXzUpaN32Xkq63kPhuGMcO1QhIPAG6V7dHIJq1nVkGG7Njef FFaOpTCdpF/c9eqKkAy08b5BW6xk02dmtxNrZDHbfRrP5dVIIbZ9mzaRs0kW43ztwDvq kMnQ== X-Gm-Message-State: AOAM5323DQ1kyR+OX8QF9jVcJZ/zEvEhnYtHGUx+o74OILJZ8f4ObW2v SWyCciytaM3N1LnRt7yHrvzJyWlU0cUYK8671H+BiY+oatTpV2LjtDmE3e7H4Xz0XdOfzC42Utz I+UE7tUT758A= X-Received: by 2002:adf:c44b:: with SMTP id a11mr23568464wrg.416.1629880996014; Wed, 25 Aug 2021 01:43:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUyD1KLk0iI2jPyHl9GDFe6jSrc1gBZb/3vUsGD54fVrtirIG5zJq0Teb+VGu/hRxrzQ1gSg== X-Received: by 2002:adf:c44b:: with SMTP id a11mr23568447wrg.416.1629880995860; Wed, 25 Aug 2021 01:43:15 -0700 (PDT) Received: from [192.168.3.132] (p4ff23d6b.dip0.t-ipconnect.de. [79.242.61.107]) by smtp.gmail.com with ESMTPSA id k18sm4619837wmi.25.2021.08.25.01.43.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 01:43:15 -0700 (PDT) Subject: Re: [RFC PATCH 3/4] mm/page_alloc: introduce __GFP_PTE_MAPPED flag to allocate pte-mapped pages To: Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Andy Lutomirski , Dave Hansen , Ira Weiny , Kees Cook , Mike Rapoport , Peter Zijlstra , Rick Edgecombe , Vlastimil Babka , x86@kernel.org, linux-kernel@vger.kernel.org References: <20210823132513.15836-1-rppt@kernel.org> <20210823132513.15836-4-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <0a6341d6-c5be-ade3-9fb9-66cc8ebe1619@redhat.com> Date: Wed, 25 Aug 2021 10:43:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210823132513.15836-4-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OeUwpkb2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3831E10000A5 X-Stat-Signature: 94pqpre68o1h5xr57nfy39qpcwhcaiac X-HE-Tag: 1629881001-856334 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.08.21 15:25, Mike Rapoport wrote: > From: Mike Rapoport > > When __GFP_PTE_MAPPED flag is passed to an allocation request of order 0, > the allocated page will be mapped at PTE level in the direct map. > > To reduce the direct map fragmentation, maintain a cache of 4K pages that > are already mapped at PTE level in the direct map. Whenever the cache > should be replenished, try to allocate 2M page and split it to 4K pages > to localize shutter of the direct map. If the allocation of 2M page fails, > fallback to a single page allocation at expense of the direct map > fragmentation. > > The cache registers a shrinker that releases free pages from the cache to > the page allocator. > > The __GFP_PTE_MAPPED and caching of 4K pages are enabled only if an > architecture selects ARCH_WANTS_PTE_MAPPED_CACHE in its Kconfig. > > [ > cache management are mostly copied from > https://lore.kernel.org/lkml/20210505003032.489164-4-rick.p.edgecombe@intel.com/ > ] > > Signed-off-by: Mike Rapoport > --- > arch/Kconfig | 8 + > arch/x86/Kconfig | 1 + > include/linux/gfp.h | 11 +- > include/linux/mm.h | 2 + > include/linux/pageblock-flags.h | 26 ++++ > init/main.c | 1 + > mm/internal.h | 3 +- > mm/page_alloc.c | 261 +++++++++++++++++++++++++++++++- > 8 files changed, 309 insertions(+), 4 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 129df498a8e1..2db95331201b 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -243,6 +243,14 @@ config ARCH_HAS_SET_MEMORY > config ARCH_HAS_SET_DIRECT_MAP > bool [...] > +static int __pte_mapped_cache_init(struct pte_mapped_cache *cache) > +{ > + int err; > + > + err = list_lru_init(&cache->lru); > + if (err) > + return err; > + > + cache->shrinker.count_objects = pte_mapped_cache_shrink_count; > + cache->shrinker.scan_objects = pte_mapped_cache_shrink_scan; > + cache->shrinker.seeks = DEFAULT_SEEKS; > + cache->shrinker.flags = SHRINKER_NUMA_AWARE; > + > + err = register_shrinker(&cache->shrinker); > + if (err) > + goto err_list_lru_destroy; With a shrinker in place, it really does somewhat feel like this should be a cache outside of the buddy. Or at least moved outside of page_alloc.c with a clean interface to work with the buddy. But I only had a quick glimpse over this patch. -- Thanks, David / dhildenb