From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCED2C4332F for ; Wed, 13 Dec 2023 11:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D516B0423; Wed, 13 Dec 2023 06:37:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FC5B6B0424; Wed, 13 Dec 2023 06:37:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DFD6B0425; Wed, 13 Dec 2023 06:37:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 26F486B0423 for ; Wed, 13 Dec 2023 06:37:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E22D6C014D for ; Wed, 13 Dec 2023 11:37:53 +0000 (UTC) X-FDA: 81561595626.20.2C66BAE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B0D3F1C001B for ; Wed, 13 Dec 2023 11:37:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MUGkp6Rh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702467471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C0J7HgLnLHbD3dQ9Y4XJMMCD7yXP1FeN7YSEarA2fBw=; b=eo2CZzbXboAV3H5OzUksYGTRj8WOgX5fE5MgM0JI+eMKKG9Lrrz3TEFgepCSFQgjBoHkOl KSUGEqbIp2oUoRxE0ahIA/sZ2wWz7/h8B48zRets40EU8AAqsVHKHmmTVuXq4itHd10QXv ZZ+gI5naUbg1PaXXD8ZHwNNGltemrac= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MUGkp6Rh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702467471; a=rsa-sha256; cv=none; b=UsR4v8ShANk+YCcLYFdfHVreqQ2IfaEHtOOmGnUp8KebZGzAdnthdpT+zFchntRdJFBSZw DE4x7UB4xBHSyhcdc0NhNMScVw3bWv36pNpr8lhOrxqKjMWg/zLlb5MmKHsSe2vYSgKRIE 0KOq6XJKXl2xNzCV/NIsrT3xZyAAmVM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702467471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=C0J7HgLnLHbD3dQ9Y4XJMMCD7yXP1FeN7YSEarA2fBw=; b=MUGkp6Rhq4chaL0aJs85wNExDs+eLANFshGvLwOLWY5H6V8bQh5qnXSLC008bEzne3Tdxn +UZiY5J6c8omDXCi2imdRHu4xoyXsJk8sQe9l0JA45gnGzpiCuJu9Z5rwl2VOBsgqPayFw shnI0Z/RqQLN/WQUcamZAf/Y8sUZ+Wk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-JdiEkpK8Nj-DFh5E8_RHsw-1; Wed, 13 Dec 2023 06:37:49 -0500 X-MC-Unique: JdiEkpK8Nj-DFh5E8_RHsw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-33335c6d495so5227154f8f.2 for ; Wed, 13 Dec 2023 03:37:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702467468; x=1703072268; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C0J7HgLnLHbD3dQ9Y4XJMMCD7yXP1FeN7YSEarA2fBw=; b=gOmI47J2Re3RE6MxOSbVUX6mIZkldEglARrFwrbXQSSKHvfO2WoqPQU/CM8H3ElQAA POFTxQIlBD2DZwVQ3pdxC2mLXXR4kWH0p5q33adz07PhoQE+Aso2BSiyXRy0c2h+a/3r 6kzZnCP34yPqUG9HGpHCEipkuTCw93TItAr2Tn4AG/SVNDdglILOAox26ygwsxeX+00g Entrfi7e+NfH07cQpbCg7mpUXShnIrG3kkWGOSWTv2Gaqe1cpRKehE2SydMQdvh9kDVg Ce6MkuqdcehxEHUa/ZlTqg+PZ8aSg2lLul98gdKArkeOQ+iGTWoYrKc7i9RpPfGj7gMQ plqA== X-Gm-Message-State: AOJu0YwB8jgSrz1V3h47SXt7wujjp968dKZhgBDFTyoYOX3lWOOvQ/l2 LsI75NFJetV7uHWsvrWL5Ngbtsfw0Y8HEn4d5qUjSMEHWTcKmRBOQQzrjl13J6DOADDFhtmcePA j7c6+rPO/xDQ= X-Received: by 2002:adf:cf0d:0:b0:336:bb6:8994 with SMTP id o13-20020adfcf0d000000b003360bb68994mr3406171wrj.39.1702467468485; Wed, 13 Dec 2023 03:37:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFr5PR1aDLFhPXUOH2kQVblSJFukKRSYc6Hkis9duwKDu7ebJND9nxHFim6stNhVujn+KvPUQ== X-Received: by 2002:adf:cf0d:0:b0:336:bb6:8994 with SMTP id o13-20020adfcf0d000000b003360bb68994mr3406160wrj.39.1702467468053; Wed, 13 Dec 2023 03:37:48 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6e00:7e5:5f4d:f300:5d52? (p200300cbc7096e0007e55f4df3005d52.dip0.t-ipconnect.de. [2003:cb:c709:6e00:7e5:5f4d:f300:5d52]) by smtp.gmail.com with ESMTPSA id q9-20020a05600000c900b0033330846e76sm13149482wrx.86.2023.12.13.03.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 03:37:47 -0800 (PST) Message-ID: <0a573adb-b0d3-4108-ba17-6498bb3ee274@redhat.com> Date: Wed, 13 Dec 2023 12:37:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: ksm: Remove unnecessary try_to_freeze() To: Kevin Hao , linux-mm@kvack.org Cc: Andrea Arcangeli , Andrew Morton , "Rafael J. Wysocki" , Pavel Machek References: <20231213090906.1070985-1-haokexin@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231213090906.1070985-1-haokexin@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B0D3F1C001B X-Stat-Signature: cysxkpfxk5kxm3yzn9ewg3m9sut3z5h5 X-HE-Tag: 1702467471-875825 X-HE-Meta: U2FsdGVkX1+CjhjDuAAE7RRgGyA2YHaWZpbDnOk8RnUP5QPG1qRbAbGBD/qu6OgTuRRwwdeJSTY7XhR3c4hNHvWUk+ev071VZC/G61ouBNxfwBVNrJtnQ/NVGUEdOytGBJq9LxAZO4YbjIGLd3qOyZrFOndw+ww1Zr7ViBOsEvsaBxeYsHv0IoDPlzGP52k0wAX9UA4HVMW7NHZdAISipM7413N1PKYK5p5l+SEfUplniATKGJkwp9XM2yxA+1uKnLQKGzdkjPOYRGK/9q0lYh6kRUAhx3yI4SSshLC1IsCnFhUW3HJshzYVq+YrnOzKJPTJ+YqipP5oV4wDvF9xCMwPStSJSEs8l4sey8dTQ3e28wuPejXGX/tUiAbd81uAKfkd2EukKeJFqFwMlzf9wvP41Z1kRV7RjvjeqoRJqTXyk8b/KeBUV3wfxnYR1QMajkW1pDycL33psF8hXuwpcxwwLAbmWdFA4tSWpUCq7oqbAifvVXEiQn798UbtGW9skycgoQ00fN/wwMaA3ecwr3P3mJNbBxyy+f/sRUvssyqQivcNhf0fPP6HoH9LvgDt3b3PtwA7ZyGCYo/vNJQTMq3DpCOvTgeAB8BSJ4xqvB8fi/bU7k2pRuEnfcIxxvu2QuBFG9oihqmnIF4hxuGoHzx9bVAeiIZuuSwBdyw0AEY0gWUn1JSHV4FvnY2MPe184i+cuCZHHLuyMRDnRhasslik/4ObnIVFSdblYR8t4j0cOV6tQW3EBcvYfOt6zJgkpkno5cUL477LGBS1ICiQfNabnxV6RXZyE34Bbi0G4/5jbcpQ59txH+xWHR2/NBPwLHv9r4tVZvwf/kmsRvdvLn7G1jNbTVF3ExVjtyR52J8dva5YjToBiv3UHvUv73p1vwpcuLtB1yrP+stUPiLxjPa4fBBCC2nUiOIdEgzveW/wEGaSx7J5KDMd7Z4WaYXrC4J0qv5JX8hF9v9PocV +9A8VG6s tZwPlezhMJ4pjaysw6iR/Eaahc/XOAzXHrMJoLZ6nKdViCt77+bodOCWo4fWMU77RI7LLzE9vvm6Jy99i+LfpPsGH31GxGUi4ndYTHdypsmYqo63JpajYi/GQ3PBskxLwJfT/M8au1mMIzDp3l/rgQe2jAa8+fNaZyCcaPJzhK6wj5uMqrX7QbhP/qlToSM4SJkpQn+04RqoQ/L9mNPWtoJGc9DioBMIAgmvDCspzpyddWs2TL8jRtsXKkrNIST14X7QFm512hZ1x3T9coceOiKXuRsACF2CCe4ssKUNowmJ5JfKjjn6v5JC3hrooPhQe2ZZuD0PjaVmu+ot8JG93kmY0TWXUQm7qha4rsI6WcWWf0cMW9NOW0BwrbhW7FkYpYYFPJ+icJK3dAW8qUhU32JkfMIcj7Q3R4+bJv5Km2L+QJAVIuQkJ5FJRrK2UkA9h1yTyiKc93ZwRqrNdV75pIZKtqkTvo9HxXVtErY86I+tObHXI15niqPAMv3DTrhiolk4qDKitm3uWJ0QF+syBX4qBbCTzH7DMFQIizA2aarQotsMTYJ/Z/yaMqrQJaHl/GJg7FYL6Gj/p9PplB3g6WuuiyHrKfuNqXIW4yrsH1KLfvL+6r/OtDb0fwqtSrwjgN3F7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.12.23 10:09, Kevin Hao wrote: > A freezable kernel thread can enter frozen state during freezing by > either calling try_to_freeze() or using wait_event_freezable() and its > variants. However, there is no need to use both methods simultaneously. > > Signed-off-by: Kevin Hao > Cc: Andrea Arcangeli > Cc: Andrew Morton > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > --- > mm/ksm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 16532fa85a46..e2ce850c2739 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -2604,11 +2604,9 @@ static int ksm_scan_thread(void *nothing) > ksm_do_scan(ksm_thread_pages_to_scan); > mutex_unlock(&ksm_thread_mutex); > > - try_to_freeze(); > - > if (ksmd_should_run()) { > sleep_ms = READ_ONCE(ksm_thread_sleep_millisecs); > - wait_event_interruptible_timeout(ksm_iter_wait, > + wait_event_freezable_timeout(ksm_iter_wait, > sleep_ms != READ_ONCE(ksm_thread_sleep_millisecs), > msecs_to_jiffies(sleep_ms)); > } else { I'm not an expert on task freezing, but staring at Documentation/power/freezing-of-tasks.txt "freezable kernel threads need to call it explicitly in suitable places or use the wait_event_freezable() or wait_event_freezable_timeout() macros (defined in include/linux/freezer.h) that combine interruptible sleep with checking if the task is to be frozen and calling try_to_freeze()." So this cleanup makes sense to me. Acked-by: David Hildenbrand -- Cheers, David / dhildenb