From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3927DC11D13 for ; Thu, 20 Feb 2020 16:52:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB44320722 for ; Thu, 20 Feb 2020 16:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dNg0IiRn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB44320722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EA2A6B0073; Thu, 20 Feb 2020 11:52:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BFE66B007B; Thu, 20 Feb 2020 11:52:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D60E6B007D; Thu, 20 Feb 2020 11:52:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 640566B0073 for ; Thu, 20 Feb 2020 11:52:40 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 09DBD8248D52 for ; Thu, 20 Feb 2020 16:52:40 +0000 (UTC) X-FDA: 76511099280.24.force45_516c0243d9f2a X-HE-Tag: force45_516c0243d9f2a X-Filterd-Recvd-Size: 6076 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 16:52:39 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id p7so4159806qkh.10 for ; Thu, 20 Feb 2020 08:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I8J4e+RKsO0vBs9ulW2qejTzM3UP4IUucx45iZgHGDk=; b=dNg0IiRn+Gk9q6KF+hcyLl60wq0erTW0EXJiWVJ6o7dlHxQ/E0J0TEw5dFNUcTKu6e becjiDbCVRRn2+wyS6bnxSDyuVvWnC9V6xOfbWHnYmoD4PKhjTlaDzO/qZIcvObgzOog 3LlvWuPv6L0ZcZd3Gqc9Ta57OzRhgW+XI3KbpDT/uiekeqDgK1OLt8r6BHQsUfpW17Sb MOaGL2lrRUYXhWErY2Hdimj/tnrFkcz9B9QEqZrvjeSN0BiR/Yp3ZZ+akBkuZ7LmThrG uJuD9QxOo+NHbUOf5HWYe8qAAkmZnc4v84NIm4DSush/HbfARDvIR6r2yuqD8yFP7HX9 oyMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I8J4e+RKsO0vBs9ulW2qejTzM3UP4IUucx45iZgHGDk=; b=uGsdJG026xMgOKO231hdVv3QcJ5fxVTGtV+72Udd8Xz0v03L5EtTIo9tNkr0Npdntp zbqwC6Cr9GJWlRj2p9T7tt385dHC7pbGXzkYpVX56hD65pWOPdLucS8sgDTeKymHnrjL Haph1kgmIAt58zv4A4XNy4ohz3pBNwpv6No4FH+4rnfrlwEBdFwWF1eO2nRTOlq9GuQ1 UUyOLbGH04vapZ/xpU4lxJp77u//uf1PjpxTCzsYMQPGuq56Hum/SRbMfyfY/9PWIIlt v1b+t4wsr2+3+lyRNruxA5AiXYLHtEsP/TmBRK1Wwp3bhsEkRFmQagMDPQ79aZL2+5vL sw8A== X-Gm-Message-State: APjAAAUgAZEx6qm3C4QINNE2x2XH2XMNRFtKdWF6DBzTTHMWu51u6QID T7p22dYqckj/OTaF0YPWCDk= X-Google-Smtp-Source: APXvYqwuXQgzUa7PIPUi2PPZnRvaq1VkmjKxS8nsMsEuTd0zTGjx5hX6n+BdmU44K9ufjVnvYUNujw== X-Received: by 2002:a37:e55:: with SMTP id 82mr29857378qko.370.1582217558779; Thu, 20 Feb 2020 08:52:38 -0800 (PST) Received: from dschatzberg-fedora-PC0Y6AEN.thefacebook.com ([2620:10d:c091:500::3:edb0]) by smtp.gmail.com with ESMTPSA id t55sm43567qte.24.2020.02.20.08.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 08:52:38 -0800 (PST) From: Dan Schatzberg To: Cc: Dan Schatzberg , Jens Axboe , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Chris Down , Yang Shi , Thomas Gleixner , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list), cgroups@vger.kernel.org (open list:CONTROL GROUP (CGROUP)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: [PATCH v3 2/3] mm: Charge active memcg when no mm is set Date: Thu, 20 Feb 2020 11:51:52 -0500 Message-Id: <0a27b6fcbd1f7af104d7f4cf0adc6a31e0e7dd19.1582216294.git.schatzberg.dan@gmail.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: memalloc_use_memcg() worked for kernel allocations but was silently ignored for user pages. This patch establishes a precedence order for who gets charged: 1. If there is a memcg associated with the page already, that memcg is charged. This happens during swapin. 2. If an explicit mm is passed, mm->memcg is charged. This happens during page faults, which can be triggered in remote VMs (eg gup). 3. Otherwise consult the current process context. If it has configured a current->active_memcg, use that. Otherwise, current->mm->memcg. Previously, if a NULL mm was passed to mem_cgroup_try_charge (case 3) it would always charge the root cgroup. Now it looks up the current active_memcg first (falling back to charging the root cgroup if not set). Signed-off-by: Dan Schatzberg Acked-by: Johannes Weiner Acked-by: Tejun Heo --- mm/memcontrol.c | 11 ++++++++--- mm/shmem.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6f6dc8712e39..b174aff4f069 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6317,7 +6317,8 @@ enum mem_cgroup_protection mem_cgroup_protected(str= uct mem_cgroup *root, * @compound: charge the page as compound or small page * * Try to charge @page to the memcg that @mm belongs to, reclaiming - * pages according to @gfp_mask if necessary. + * pages according to @gfp_mask if necessary. If @mm is NULL, try to + * charge to the active memcg. * * Returns 0 on success, with *@memcgp pointing to the charged memcg. * Otherwise, an error code is returned. @@ -6361,8 +6362,12 @@ int mem_cgroup_try_charge(struct page *page, struc= t mm_struct *mm, } } =20 - if (!memcg) - memcg =3D get_mem_cgroup_from_mm(mm); + if (!memcg) { + if (!mm) + memcg =3D get_mem_cgroup_from_current(); + else + memcg =3D get_mem_cgroup_from_mm(mm); + } =20 ret =3D try_charge(memcg, gfp_mask, nr_pages); =20 diff --git a/mm/shmem.c b/mm/shmem.c index c8f7540ef048..7c7f5acf89d6 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1766,7 +1766,7 @@ static int shmem_getpage_gfp(struct inode *inode, p= goff_t index, } =20 sbinfo =3D SHMEM_SB(inode->i_sb); - charge_mm =3D vma ? vma->vm_mm : current->mm; + charge_mm =3D vma ? vma->vm_mm : NULL; =20 page =3D find_lock_entry(mapping, index); if (xa_is_value(page)) { --=20 2.17.1